Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I715374b531da2850434b2436633b6042ecb9ebe0
|
|
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
|
|
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
|
|
Change-Id: I514e183571e4ac109f59c4bdfccdc553c36c26ee
|
|
Change-Id: I874fc4d677abb2646bffb4331a220f3812443b66
|
|
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
|
|
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
|
|
Change-Id: I745b320dd5f44d54371d8a0b961c49793e3e0ad6
|
|
Change-Id: Idff46e5642034cf751d557de9a49c02a7abf27bb
|
|
...that might depend on macro arguments and not really be redundant
Change-Id: If19de3835a4972add58965ea7c0936fad7ef6957
|
|
Genius suggestion from Tor Lillqvist, write a clang plugin that finds
methods that can be static.
Change-Id: Ie6684cc95d088e8750b300a028b49f763da00345
|
|
Change-Id: I876736d18db6676629c283fccd65e1b6fb2bb2be
|
|
as sberg points out, it needs a massive blacklist, which is going
to be a pain to maintain. Until I can think of a way to make this
more resilient, move it where it can't bother people.
Change-Id: I64fc498146a3cb4ea9c1e37150c4ef50023b7bd5
|
|
Change-Id: I66ffc0c3a73d45e9d4b54f46092a65913b753d26
|
|
Change-Id: Ieedf89bebb59e783dfe13ef2d5ae7ba3347cdc62
|
|
Change-Id: I484e1206d1f17305d21f7e750b8aca9d1c8d809b
|
|
Change-Id: Iea1cd468528d00ffa07e13b2063ca5fce5cc4fae
|
|
Change-Id: Ie9b7a0c41fc4dbd2560ceff6bae9ab85357f518b
|
|
so that we find dialog that have been instantiated but not actually
executed
Change-Id: Ia308e832780627c0a8de71a9d64dabcb3b861a9c
|
|
The problem being that any lib later loaded via osl_loadModule (e.g.,
libgcc3_uno.so) would not bind to the same global (RTTI-related) symbols as
libsofficeapp.so and its dependencies (so, e.g., -fsanitize=function would
erroneously assume that bridges/source/cpp_uno/shared/component.cxx's
uno_initEnvironment is called with a different, non-matching uno_Environment
type).
Change-Id: I08b0cbc1f9eb74641eb617c46587a0a528a56c31
|
|
Change-Id: I3fd9d6447adfa365a823ca6e87f0939670bcb39b
|
|
Change-Id: I88ab4c51ff59312127681d3087d22b9c79192b94
|
|
Change-Id: I45eabbe9d1a4e3f85f16c2869c4031fc06f5ef31
|
|
...inspired by <http://www.viva64.com/en/b/0308/#ID0EE4BI>'s V639 finding.
Change-Id: I3b49f00dd4a593ed0b94d81398fa89ff64f6c79b
|
|
Change-Id: I5b41039bf63a4c2f313fe7a57c0f6934dcb0752d
|
|
Change-Id: I24d0b7531feba32f86f761daf18170397cfe5d2f
|
|
Change-Id: Ia09e2e7b3e40bd04da64b52fe29258017b90b156
|
|
...to special member function declarations that were left undefined. Helps
compilers do a better job at identifiying unused class members. This plugin
uses heuristics and whitelists do identify applicable declarations, but is not
appropriate for "unattended" use so is placed into store/.
The following commits contain the results of running this plugin, per module:
* Declarations of undefined special member functions are mmarked
SAL_DELETED_FUNCTION (aka "= delete", which is deemed superior to deriving the
class from boost::noncopyable, cf. Howard Hinnant's reply to
<http://stackoverflow.com/questions/7823990/what-are-the-advantages-of-boostnoncopyable>.
* Any redundant "explicit" or SAL_DLLPRIVATE markers are removed from the
deleted definitions.
* Some redundant declarations of undefined default ctors are simply removed;
smelled like clueless cargo-cult to have them declared at all.
* Some declarations of undefined operator == etc. are left in (and marked
SAL_DELETED_FUNCTION) for now, to be on the safe side, though they are likely
clueless cargo-cult, too.
* Most "static-only" classes are replaced with namespaces (and some where that
would be non-trivial due to private members are marked TODO for later).
* Newly identified unused class members are removed.
Change-Id: Ibeaae4fd579d7a0971a2c2a654a2263acd13414a
|
|
...even if it is known to be dangerous
Change-Id: Ied96284e33b966bf072d0961054479ec7f891dea
|
|
Change-Id: I08f17dd9cc092206083ff41bbbc178e0322e86d0
|
|
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
|
|
we don't need to run them on an ongoing basis, and the current code
does not compile with older versions of clang.
Change-Id: I07ccacf7ff7b00e8e2453fff91a3f487dd5abed9
|
|
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
|
|
Change-Id: Id7a596344c21e9265e35188c477e60ce510bcc6e
|
|
Change-Id: Iaa46849742c215798722d03d9ee59bb39d8033f7
|
|
Change-Id: Ifdbcbcc51c29dc14b2a3b4c845481b45300313d6
|
|
Change-Id: Id5dd1ee1a29c4e1c7cb2b58419d6ccb1f032bffe
|
|
Change-Id: Ie74be926c1e071fa9b311920b1cf1d4dd5bbd30d
|
|
Change-Id: I8a4483a6425f51fea0eae5c809c6c41ef56388a2
|
|
Change-Id: I7c41b90c9af045fd452ee62ed0c5d9b261236855
|
|
Change-Id: I0ad9681a8b31d78cefce5b66040415154a1c7a99
|
|
Change-Id: I1300d1d696878c1b646decc2841f13d489d3cadc
|
|
Change-Id: Ib09f2b794ce7a1e650275750a67c6c8ad5d7c808
|
|
Change-Id: I467d032296607d22e850c95e56c452fe7e62cebe
|
|
(for non-Windows--only code, as MSVC would complain about such cases anyway)
Change-Id: Id6daf61b79bd31529bdaeb7c6df4f354731ae7d7
|
|
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.
However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.
Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
|
|
...some paths trough clang::Expr::isIntegerConstantExpr (esp. if
non-CPlusPlus11) assert the assumption that the given expr is not
value-dependent, so it appears to be a prereq
Change-Id: Ibc5fe472ea3f91b31c8cb7f06c4b7c7f4d6831a3
|
|
Change-Id: Ie425af19019126b6a15ac03f52e32d186a46db35
|
|
...where SAL_OVERRIDE is not available
Change-Id: I49d447ba90516f4f744c21302607bff97ad3c4d5
|
|
...the worst kind of all
Change-Id: I6b98a324735a79ed9060003b491acce733f74f06
|