summaryrefslogtreecommitdiff
path: root/compilerplugins/clang
AgeCommit message (Collapse)AuthorFilesLines
2 daysClarify no loplugin:overridevirtual with templated base classStephan Bergmann1-0/+44
Change-Id: I4128b43f2a928fa5465991cc92b2d62e54e2cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117662 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2 daysAdapt compilerplugins to llvm::sys::fs::OF_None renameStephan Bergmann2-1/+8
...from F_None, which happened with <https://github.com/llvm/llvm-project/commit/1f67a3cba9b09636c56e2109d8a35ae96dc15782> "[FileSystem] Split up the OpenFlags enumeration" towards LLVM 7, originally leaving the alternative F_None spelling in for compatibility, but which was finally removed now with <https://github.com/llvm/llvm-project/commit/3302af9d4c39642bebe64dd60a3aa162fefc44b2> "Support: Remove F_{None,Text,Append} compatibility synonyms, NFC". Change-Id: Iea1192b5ee351c13ea5d6701887f3aba62133c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117609 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
5 daysloplugin:finalclassesNoel Grandin2-3/+3
improve the plugin to detect more cases. I only apply the new final changes to classes in /include here. Which reveals that RoadmapWizard::getPageController( TabPage* _pCurrentPage ) will always return nullptr Also needed to sprinkle some SAL_DLLPUBLIC_TEMPLATE around to workaround Visual Studio linking problems. Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysAdapt o3tl::temporary to C++23 P2266R1Stephan Bergmann2-0/+29
With the recent implemenation of <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" in Clang 13 trunk as <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f> "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build started to fail with > In file included from sal/rtl/random.cxx:25: > include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double' > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ > sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here > return std::modf(random, &o3tl::temporary(double())); > ^ etc. (And fixing that by adding the recommended static_cast then triggered a false loplugin:redundantcast warning.) Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
7 dayssplit NotifyingLayout outCaolán McNamara1-2/+1
Change-Id: Ib706331f9e6b3749559a0b78f1a07d442a674829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
7 daysgtk4: restore double-decker notebooksCaolán McNamara1-0/+2
add a 'NotifyingLayout' to find out when the size of a widget changes now that size-allocate has been removed Change-Id: Iae55b7fafd2fd26c62afaedd777ae40e84fbb964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
8 daysMove enable_if from dummy template parameter to return typeStephan Bergmann1-6/+0
...and drop the no-longer necessary loplugin:implicitboolconversion exclusion (which had been necessary to avoid > [CXX] vcl/source/window/dockingarea.cxx > In file included from vcl/source/window/dockingarea.cxx:26: > In file included from vcl/inc/svdata.hxx:26: > include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion] > template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false> > ^~~~~ etc.) Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
10 daysAdapt compilerplugins to LLVM 13 APSInt::toString changeStephan Bergmann9-12/+26
<https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29> "[ADT] Remove APInt/APSInt toString() std::string variants". TODO: While most uses of compat::toString should be harmless performance-wise, as they are either in error reporting code or in plugins that are not run by default, some calls like the one in compilerplugins/clang/staticconstfield.cxx might benefit from moving them away from using std::string. Change-Id: Icfac7d6d4a0a4a4edeb5c8bdcdbc13b73e20a5e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
13 daysloplugin:unusedmethods improve filteringNoel Grandin1-4/+15
Change-Id: I75771dbcecd58259bffdd2ddb0df631205aa8d93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10Adapt compilerplugins to Clang VK_RValue -> VK_PRValue renameStephan Bergmann2-4/+11
<https://github.com/llvm/llvm-project/commit/aef5d8fdc7d0d348125d5ecf4a13be5888eb1654> "[clang] NFC: Rename rvalue to prvalue" Change-Id: I237e8a491465500e35637f8dae400402bcd9411d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116983 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-04loplugin:virtualdeadNoel Grandin3-114/+77
Change-Id: Ic2e18f9088e7427f0679dab27f0d3acb6f2bb240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03-Wunused-but-set-{parameter,variable} in CompilerTest_compilerplugins_clangStephan Bergmann22-0/+46
...new with Clang trunk 13. As a rule of thumb, this change adds explicit cast-to-void silencing in those .cxx that already contained other such silencing casts and adds wholesale #pragma clang diagnostic ignored in all others. Change-Id: I1884496ee1aa81aaf3c8b3533534a4b69b185e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116660 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-01drop unused Widget::set_secondaryCaolán McNamara1-2/+0
Change-Id: I63e69ca9daa8a452eee28333d8639d1db093e826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31gtk4: enable cut and paste into other applicationsCaolán McNamara1-0/+2
Change-Id: I9924a9af10532254dc368e274e4a20c6706e4239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse1-4/+0
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-31tdf#142467: Update comments with GCC bug IDStephan Bergmann1-1/+1
Change-Id: I71052f8db941733ab4e4b1b36cbf1fcb28eac9d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116420 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-27gtk4: continue to provide Paintable via cairo surfaceCaolán McNamara1-0/+2
instead of squeezing through a GdkTexture and losing hidpi surfaces Change-Id: I1ee75ff804d1d769273e2f80335bfdf528ae8039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116267 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#47065 Add new file open UI options and implement a new threadMatt K1-0/+4
Add new UI options when opening a locked or non-writeable document to allow the user to be notified when such a document becomes editable . If the user selects "Notify", then that document is added to a list of open documents to be checked by a thread every 60 seconds for read/write access and whether lock file is available/obtainable. If access is allowed for a document, then show UI dialog to the user asking to Reload that document. If Reload is selected by the user then that document is reloaded with read/write access. The checking thread is spawned only once no matter how many "Notify" documents there are. The thread is spawned if not already running when a new "Notify" document is opened, and it terminates when all "Notify" documents have been closed or the application terminates. Also update badstatics clang plugin to ignore new global variables introduced. Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-26tdf#142467 crash on calling 'getInfoHelper' in final classCaolán McNamara1-0/+2
IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when CandleStickChartType is final for unknown reasons. I see this with gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem. #1 0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549 #2 0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219 Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19Adapt loplugin:noexcept to system macro BEGIN_COM_MAP (clang-cl)Stephan Bergmann1-20/+21
...to silence warnings like > In file included from C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.cxx:27: > C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.h(57,1): error: Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept] > BEGIN_COM_MAP(SOComWindowPeer) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/atlmfc/include\atlcom.h(2204,130): note: expanded from macro 'BEGIN_COM_MAP' > static HRESULT WINAPI _Cache(_In_ void* pv, _In_ REFIID iid, _COM_Outptr_result_maybenull_ void** ppvObject, _In_ DWORD_PTR dw) throw()\ > ^~~~~~~ Change-Id: Iee2619e000963a419b757235d86d7f87944ed46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115748 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-18loplugin:unusedfieldsNoel Grandin1-8/+46
Change-Id: Ib574403a7f7f8b11c6263c9c19ec6b65c8374ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18loplugin:unusedmethodsNoel Grandin1-1/+2
Change-Id: I8191f4a9eb25b12242354813303fb7d30489d2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18loplugin:unnecessaryvirtualNoel Grandin2-22/+20
Change-Id: I1c6c4741680d5b49c4e1445d0f4ca7a01fd7e192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-17sc_ucalc: move formula tests to their own moduleXisco Fauli1-6/+0
in order to split sc_ucalc monster into smaller modules Now, we can change CppunitTest_sc_ucalc.mk to use the template - Enable testExternalRefUnresolved on Linux/Mac - Remove testFormulaHashAndTag. it was disabled in f4dc8a869ac49f19c20fc5fa606448e9103726bd < the idea behind the test can't work right now > Change-Id: I864341442ccd321c8ef4f7147db4512bcc7a6b21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115595 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-17split OutputDevice from WindowNoel Grandin1-5/+7
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-16sc_ucalc: move conditional format tests to their own moduleXisco Fauli1-12/+0
in order to split sc_ucalc monster into smaller modules While at it, remove testCopyPasteSkipEmptyConditionalFormatting it was added already disabled in 5915d38e84c7a7861c169bea18c63824bcfdc470 <add disabled test for conditional formatting with skip empty cells> and it fails if it's enabled Change-Id: I6222849b38ab288b24432dc00698d72f5bcc5c2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115677 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-14Improve loplugin:stringviewStephan Bergmann2-19/+17
Issue the "instead of O[U]String, pass [u16]string_view" diagnostic also for operator call arguments. (The "rather than copy, pass subView()" diagnostic is already part of handleSubExprThatCouldBeView, so no need to repeat it explicitly for operator call arguments.) (And many call sites don't even require an explicit [u16]string_view, esp. with the recent ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads". Just some test code in sal/qa/ that explicitly tests the O[U]String functionality had to be excluded.) Change-Id: I8d55ba5a7fa16a563f5ffe43d245125c88c793bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115589 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-14sc_ucalc: move shared formula tests to their own moduleXisco Fauli1-2/+0
in order to split sc_ucalc monster into smaller modules Change-Id: I399daeb57dd5fba7077fef6584b0a3772df84d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115559 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-14Improve loplugin:stringview diagnostic outputStephan Bergmann2-20/+40
Say what the O[U]String is constructed from (to make it easier to decide on an optimal rephrase of the whole surrounding expression), and find more cases that could use O[U]StringChar. Change-Id: I64a3851544498c26ca3f46f5df7f593d2fdcb0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-12Guard against isCXX11ConstantExpr on dependent expressionStephan Bergmann1-2/+4
> Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), function isCXX11ConstantExpr, file ~/llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 15540. ...as would have hit with a preliminary version of ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads" Change-Id: I652063b4eebd076973eaa57219df91cd1fbef312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-11loplugin:implicitboolconversion workaroundNoel Grandin1-0/+6
after commit eb6819e74a66750235d3a4a894479faeee8146e2 Date: Sat May 1 22:13:37 2021 +0900 change usage of boost::hash_combine to o3tl::hash_combine Change-Id: Idc70726f7e762b49111e6505ba3f978370d7cf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115399 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2021-05-10rename to remove the gtk3 prefixCaolán McNamara3-4/+3
Change-Id: I219798ed42aff11d09fd45c26ca1a018c2d22c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115239 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06loplugin:unusedmethodsNoel Grandin1-9/+49
plugin code needed some updating because it was interacting badly with PCH code in pluginhandler::ignoreLocation Change-Id: I228f94a4e285747bd1d5b8536010f8617118cafa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-05loplugin:unnecessaryvirtualNoel Grandin1-29/+21
Change-Id: Iedb9586fcf34dc172b93f0a246b1c1e1c9033376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:stringadd improvement for appending numbersNoel Grandin1-12/+4
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:unnecessaryparen small improvementNoel Grandin2-1/+10
when calling a function, and passing only one arg, but the function has defaulted args, we were ignoring this case. Change-Id: I86517f18e30531127664088ddc09ef96dbd8bdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03throw() -> noexcept, part 3/3: New loplugin:noexceptStephan Bergmann2-0/+98
Change-Id: I3ce3fab3e8047be14e003f1f3096b4e2745534e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115026 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27loplugin:moveoptNoel Grandin2-0/+214
An attempt that did not find anything convincing enough to finish it up and make it permanently active. So just leave it in /store for now. Change-Id: I1750e177655a4a510da100f880ba81bf762be277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin3-1/+63
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27More aggressive Clang 13 trunk -Werror,-Wdeprecated-copy[-with-dtor]Stephan Bergmann1-0/+1
...since <https://github.com/llvm/llvm-project/commit/abf3ca61e3235681f26d0f527b8e2763dd4c0c62> "[Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)" Change-Id: I43ae8a620915ad211a1f21ecf89b6955b7d2faaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114674 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-21loplugin:stringadd replace OUStringLiteral temporaries with OUString::ConcatNoel Grandin2-8/+16
Change-Id: I656f06a74d9f0180ae460264563d6a935c7d2c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-20drop unused get_hscroll_heightCaolán McNamara1-2/+0
Change-Id: Ibf4dffd01c3a6b3f352b2951552e58d476d0d204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-17loplugin:constantparamNoel Grandin4-850/+854
Change-Id: I1d518bef47c838d03d8526a6a8fffd36d2ee68d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin2-2/+64
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14loplugin:unusedmethodsNoel Grandin1-143/+125
Change-Id: I9c1c6f27e35a66d8e3623c3ebb1618dceda60e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13loplugin:singlevalfieldsNoel Grandin2-237/+243
Change-Id: I429e2e947f426ad16e22d3b99d48714aba96417d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12convert few more clang plugins to sharedLuboš Luňák5-11/+42
Change-Id: If8ee55d36f1fd2b2dee8c0a1596dee0c7d05eb6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113886 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-09remove vcl/waitobj.hxxCaolán McNamara1-1/+0
create vcl/locktoplevels.hxx for the utility to set all toplevel windows modally locked Change-Id: I964484d238852e830e1e5c0b86b3bebb3b41a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09do not #error in clangplugins with --disable-pchLuboš Luňák1-7/+7
I missed that -building-pch-with-obj is checked by configure (and used) only if PCHs are used. So remove the error checking and hope that it gets checked whenever somebody does changes related to the flag. Change-Id: Ibdf991169f023dae48dad0dd2929215fb048d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113841 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-09make clang plugin check code in headers only once if in PCHLuboš Luňák1-0/+13
When using Clang PCHs, we know for certain that the content of a PCH will be used once by the PCH's dedicated source file. So it is not necessary to let clang plugin check locations coming from a PCH every time, but just once when compiling that dedicated source. For starmath's parse.cxx this reduces compilation time 0.94s->0.4s (0.1s when not using plugins at all), for sc's document.cxx it is 5.9s->5.0s (4.0s without plugins). For reference, without PCHs the numbers are (with/without plugins) 2.1s/1.9s for parse.cxx and 11.2s/10.3s for document.cxx. Change-Id: Ie39787e65d7951187941dcff4899d053da63cbdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113817 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>