summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)AuthorFilesLines
2017-06-20create comphelper::RefCountedMutexNoel Grandin1-0/+5
and merge the two existing implementations of the idea - SotMutexHolder from package and RefCountedMutex from connectivity Change-Id: I87f09f359ac798cf934381a2c75225dab71dd43e Reviewed-on: https://gerrit.libreoffice.org/38972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-20loplugin:oncevar in codemaker..connectivityNoel Grandin5-11/+5
Change-Id: Ia479d9d3d459a699dfc5c1148d01c35e8bc973bd Reviewed-on: https://gerrit.libreoffice.org/39000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-15comphelper: add a profiling APILászló Németh2-0/+106
Using the guard style ProfileZone aZone("foo"). Test macro: Sub TimeLog toolkit = createUnoService("com.sun.star.awt.Toolkit") toolkit.startRecording() toolkit.processEventsToIdle() toolkit.stopRecording() a = toolkit.getRecordingAndClear() s = "" For Each i in a s = s + i + ", " Next i Print s End Sub Change-Id: Iceaf9143d0387c87e7936dc67eecbbf71ee8d74a Reviewed-on: https://gerrit.libreoffice.org/38786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-15Missing includeStephan Bergmann1-0/+1
Change-Id: I3345d989dc279f080d26c60888daa67154b3c0e9
2017-06-15use more SAL_N_ELEMENTS part 3Noel Grandin1-2/+2
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13use local statics for getUnoTunnelImplementationIdJochen Nitschke1-5/+3
replace uses of double checked locking pattern and rtl::Static Change-Id: I479d9d94f652b4fb4c67388405823a5f4e2b6ed4 Reviewed-on: https://gerrit.libreoffice.org/38690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12Setting Buffered(threaded)Stream as default:Mohammed Abdul Azeem1-18/+2
Also cleaning up bUseBufferedStream parameter. Change-Id: Ibf9c9fcefbdcd229ffaa1d3b169ff87f00e91ceb Reviewed-on: https://gerrit.libreoffice.org/38661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-12Remove VCLExternalSolarLock and IMutex.Arnaud Versini4-41/+11
Next step is to remove OContextEntryGuard. Change-Id: I9460fb67fba6f3bfb3c809b730c33f38d225a64e Reviewed-on: https://gerrit.libreoffice.org/38411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12pass comphelper::PropertySetInfo around using rtl::ReferenceNoel Grandin1-14/+6
and remove some manual ref counting Change-Id: Ib78122fbbf914e87e0aef1f8fffe3952639e5b22 Reviewed-on: https://gerrit.libreoffice.org/38607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-11allow build without tls and ssljan Iversen1-0/+5
support for using --disable-openssl AND --without-tls (needed if you want to avoid including crypto code). Change-Id: I77650e9db679ddf1690560eda069d8645acacfc4 Reviewed-on: https://gerrit.libreoffice.org/38604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@libreoffice.org>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin1-2/+2
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31Remove some unnecessary scaffolding around SAL_WARN callsStephan Bergmann1-1/+0
Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
2017-05-30teach redundantcast plugin about functional castsNoel Grandin2-3/+3
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin3-30/+19
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-27tdf#36541 Wrong syntax highlighting in BASIC IDEtagezi1-18/+18
-- and // are not comments in Basic Change-Id: I6cd16f2d19eec280ead7d59a6162cd03ac267474 Reviewed-on: https://gerrit.libreoffice.org/38074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-05-20cleanup unused css/script/ includesJochen Nitschke1-1/+0
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: comphelperStephan Bergmann1-12/+12
Change-Id: Icb7d43c95ee5d53fdf6b1cdb92953df8488d1ef1
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M3-3/+3
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-12remove unused uno::Reference varsNoel Grandin1-2/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke12-12/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-29add test for MD5 hashingMarkus Mohrhard1-0/+12
Change-Id: If13f6d800b857cc6d581ef7800beb0f25b3f5a37 Reviewed-on: https://gerrit.libreoffice.org/36793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-29add MD5 hashing to generic digest classMarkus Mohrhard1-0/+6
Change-Id: If3abc80f8511d9c7bf0d5197ce28ef4cf60a6b45 Reviewed-on: https://gerrit.libreoffice.org/36792 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-28loplugin:cppunitassertequals: comphelperStephan Bergmann1-1/+2
Change-Id: Ice8310b60d8bd2930bc00110f88f77565d33341b
2017-04-27tdf#39468 cleanup source code commentsdennisroczek1-2/+1
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27remove ResourceBasedEventLogger in favor of its base EventLoggerCaolán McNamara1-13/+0
because there are no resources in use anymore Change-Id: I37e4a100aabbf6214533738da3e528ed2f434eae
2017-04-27drop writeonly unused structCaolán McNamara1-15/+0
Change-Id: I6a7d58899991109264d86059a16b4a3a540f1491
2017-04-27the only use of this argument is sdbcl which is a deleted resource fileCaolán McNamara1-6/+2
Change-Id: I31c140dcab9a291c4ede62e56d296a224dcd47c8
2017-04-27comphelper: fix loplugin:unreffun warningMiklos Vajna1-1/+0
Change-Id: Ie3d398568dbb4e237b8d03349c0286f2776e7cdd
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara1-66/+0
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2-0/+2
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-23simplify ChainableProperySet and MasterPropertySetNoel Grandin2-90/+6
bunch of methods that do nothing Change-Id: If7806018721bb101825d3489ca8e7fe70e175af4 Reviewed-on: https://gerrit.libreoffice.org/36778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-22fix --with-tls=openssl buildCaolán McNamara1-1/+1
Change-Id: I10bab565a5a152755fbc38268559657b4ec539b2
2017-04-21add test for generic digest classMarkus Mohrhard2-0/+81
Change-Id: Ibe3f033ebec5f832eee7420013c7083ab224e65e Reviewed-on: https://gerrit.libreoffice.org/36791 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-21add generic digest classMarkus Mohrhard2-0/+159
Change-Id: Ic5d2d8fbb0bb4edc4c966e185be81f6ca673950e Reviewed-on: https://gerrit.libreoffice.org/36790 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky6-6/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin2-11/+11
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19clang-tidy readability-simplify-boolean-expr in accessibility..cuiNoel Grandin2-23/+5
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-14update cppunit to 1.14.0Markus Mohrhard1-5/+0
Change-Id: I95fa42f4ef0580734b605df859c1660b29adb8b2 Reviewed-on: https://gerrit.libreoffice.org/36499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-12[API-CHANGE] drop css.comp.logging.SimpleLogRingCaolán McNamara4-226/+0
Change-Id: I2f61a8ec24a28a917b458673df6ed45ac1f93e72 Reviewed-on: https://gerrit.libreoffice.org/36447 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-07try and silence coverity#1403659 Data race conditionCaolán McNamara1-0/+1
Change-Id: Ibe8629b9f61230b41840351a3486050e6ad9eb8c
2017-04-06split closeOutput upCaolán McNamara1-4/+10
Change-Id: Id6408fa804e1049ceab012ec0220d8e6f8d8e555
2017-04-05loplugin:constantparam part2Noel Grandin1-2/+2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31This only wants to check for Windows in general?Stephan Bergmann1-1/+1
Change-Id: I0578e046b8d97b076ca638912740d548453a9a04 Reviewed-on: https://gerrit.libreoffice.org/35916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30remove type decorations on char literalsJochen Nitschke1-2/+2
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-29tdf#39468 Translate German commentsJens Carl1-5/+3
Translate German comments and terms Change-Id: Ic80dd218bfae5a3523e12cda77b911a4413b8dc6 Reviewed-on: https://gerrit.libreoffice.org/35819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-29sw: plain-text ASCII export: filter out all CH_TXT_ATR_*Michael Stahl2-0/+58
These control characters are Writer implementation details and should not be available via public interfaces. This filter is also used by SwXTextRange::getString(). Change-Id: If656ee3d451dbefe2f7a905e8b63a44cdb787809
2017-03-25Fix typosAndrea Gelmini1-1/+1
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: https://gerrit.libreoffice.org/35617 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin1-1/+1
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22comphelper::ThreadPool: guard against concurrent shutdown/pushTaskMichael Stahl1-7/+9
To join a thread, the mutex must be released - another thread in pushTask() could add a new thread to maWorkers at that point, which must of course not be deleted. Avoid the problem by transferring ownership of the to-be-deleted threads to the calling thread. (regression from bdaa13a87744e424d3c210fc7f3f9e4f199d8279) Change-Id: I9d4fcfe4cb46a336586b5663934a12d47b2d8ccb