summaryrefslogtreecommitdiff
path: root/comphelper/source/container
AgeCommit message (Collapse)AuthorFilesLines
2017-07-13use more OUString::operator== comphelper..cuiNoel Grandin1-1/+1
Change-Id: Ib5f3037249152be2b66acf347d1a0c236dc7adfa Reviewed-on: https://gerrit.libreoffice.org/39888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-12strip some linefeeds from the end of debug outputNoel Grandin1-3/+3
Change-Id: I2821969d86b7f8cee53404e6a0acfbebbe53b3ac Reviewed-on: https://gerrit.libreoffice.org/39824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: comphelperStephan Bergmann1-1/+0
Change-Id: I28752323d31320141a537c0e108c911cef09c10a
2017-06-20loplugin:oncevar in codemaker..connectivityNoel Grandin1-2/+1
Change-Id: Ia479d9d3d459a699dfc5c1148d01c35e8bc973bd Reviewed-on: https://gerrit.libreoffice.org/39000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin1-2/+2
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke1-1/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin1-10/+10
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin1-1/+1
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19ofz: segv on nullptrCaolán McNamara1-6/+5
Change-Id: I5ec64411b101972ddd150a782b845d4f790ea873
2017-02-15Drop :: prefix from std in c*/Tor Lillqvist2-8/+8
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann1-3/+1
Change-Id: I143ec0287421675fb13a03e8cf3c7054a17be37f Reviewed-on: https://gerrit.libreoffice.org/34271 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-06Add missing #includesStephan Bergmann3-0/+6
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-03makeAny->Any in canvas..configmgrNoel Grandin1-6/+6
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e Reviewed-on: https://gerrit.libreoffice.org/33869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin1-7/+5
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann6-159/+80
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-20use rtl::Reference in OContainerListenerNoel Grandin1-18/+5
instead of manual acquire/release Change-Id: I83e6229029e662073e2e01e98f4846fb0a0ed643
2016-12-23tdf#70998 Change word "Graphic(s)" to "Image(s)"Huzaifa Iftikhar1-1/+1
There was an error in the previous patch inside the file embeddedobjectcontainer.cxx This is fixed in this patch. Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0 Reviewed-on: https://gerrit.libreoffice.org/32353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin1-1/+1
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12comphelper: cleanup class NameContainer.Arnaud Versini1-7/+2
Remove useless class NameContainerImpl. Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c Reviewed-on: https://gerrit.libreoffice.org/31830 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-28loplugin:unnecessaryoverride (dtors) in comphelperStephan Bergmann3-15/+0
Change-Id: I13ebc4efa7f8bd0d3732ed65e397c710ae65d14e
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-2/+2
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:dllprivateStephan Bergmann1-2/+1
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-5/+5
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist1-1/+0
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-08-16new loplugin to check for static OUStringsNoel Grandin1-1/+1
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith1-2/+1
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin1-1/+1
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-1/+1
Change-Id: I11d6467a35fb9e32cc0608549bd323b1f6683b9f
2016-06-24loplugin:singlevalfields in comphelperNoel Grandin1-6/+4
Change-Id: I22711d226a266dc00c32beff54398a55c4c9691a Reviewed-on: https://gerrit.libreoffice.org/26599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-20Clean up uses of Any::getValue() in comphelperStephan Bergmann1-2/+3
Change-Id: I433cca20fb29c6b6ede934edcb2e200f15b060f2
2016-06-03tdf#89329: use unique_ptr for pImpl in embeddedobjectcontainerXisco Fauli1-4/+3
Change-Id: I679555e2eb51e2b9660bb035a08d8da8b1687cab Reviewed-on: https://gerrit.libreoffice.org/25747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26loplugin:unusedmethodsNoel Grandin1-29/+0
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda Reviewed-on: https://gerrit.libreoffice.org/25431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-6/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin2-6/+2
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-29Iteration must not start at the endSeraphime Kirkovski1-1/+1
Change-Id: I2aebcc909aa9222fc1881e57bbc844025a154e84 Reviewed-on: https://gerrit.libreoffice.org/24497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann3-11/+11
Change-Id: Idb7e5ff0c73bbc2c462b92cd96444eb5d2d4194b
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in comphelperNoel Grandin1-1/+1
Change-Id: Iff26c89ea6079e0f12691dbc04bb36f02b85c305 Reviewed-on: https://gerrit.libreoffice.org/23920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-08tdf#94306 replace boost::noncopyable in c...Jochen Nitschke1-3/+5
comphelper, connectivity and cppcanvas. Replace with C++11 delete copy-constructur and copy-assignment. Removed unused boost/noncopyable.hpp includes from some source files in cppcanvas. Change-Id: I90780820e21fbfd291ac10c266e7d16616e3a81b Reviewed-on: https://gerrit.libreoffice.org/23905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-05loplugin:constantparam in comphelperNoel Grandin1-75/+41
Change-Id: I81e6af1ee869caa3b40d2d00604e8e22517d92d7 Reviewed-on: https://gerrit.libreoffice.org/23808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke1-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10Avoid reserved identifiersStephan Bergmann1-9/+9
Change-Id: Iaf015fdcf9818655243e138c6c655c5f86511ac3
2016-03-03loplugin:unuseddefaultparams comphelperNoel Grandin1-2/+2
Change-Id: I78280a13fc0d82fc87041b5dad0c3f2f7d462652 Reviewed-on: https://gerrit.libreoffice.org/22853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-24convert ComponentMethodGuard::MethodType to scoped enumNoel Grandin1-1/+1
Change-Id: I1f1b4981c70c2b8ff8087a85f0af28b816b4654a
2016-02-09Remove excess newlinesChris Sherlock2-3/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-31tdf#74608 comphelper: Constructor feature for NamedPropertyValuesContainerkripton1-27/+6
Change-Id: I63390eca5c887bfd84846655cef6339ba9785e24 Reviewed-on: https://gerrit.libreoffice.org/21888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-01-30tdf#74608 comphelper: Constructor feature for IndexedPropertyValuesContainerkripton1-28/+6
Change-Id: I0e9ea9e4c750918b33040dad2279fe55facd4cab Reviewed-on: https://gerrit.libreoffice.org/21858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin1-0/+307
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-13tdf#97108: SwDocShell of clipboard document has no base URLMichael Stahl1-1/+2
... which triggers this assert; have to downgrade it to SAL_INFO. The startsWith("0x") check is obsolete anyway since commit 0f02bc189b6e89ca2e62d4bd6a2f407a9fd4ec3b. Change-Id: If47bc4496852ff85ba1bbeb4205ffc16be0782de
2016-01-09crashtesting: fdo85994-1.doc assert on reexport to docCaolán McNamara1-5/+11
try setting DefaultParentBaseURL based on the parent BaseURL for objects created this way Change-Id: I1a660ff6e4874321e0308d556c7ce0e10a2605fe