summaryrefslogtreecommitdiff
path: root/codemaker
AgeCommit message (Collapse)AuthorFilesLines
2014-07-26coverity#1019323 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I3d8b598e86339fdd51af48e62393550821b6278d
2014-07-25coverity#1219788 Unchecked dynamic_castCaolán McNamara1-0/+3
Change-Id: I1bedfb601320bc27adc0d0d72fcb8b3c5dfe73ff
2014-07-01New loplugin:stringconcatStephan Bergmann1-4/+3
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-24new compilerplugin returnbyrefNoel Grandin2-7/+7
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin2-8/+1
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin1-4/+0
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05various: remove SAL_THROW macroNoel Grandin1-17/+17
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-26coverity#1019311 Unchecked return valueCaolán McNamara1-4/+4
Change-Id: I682ca0b62e6eb0d02113218de97d1440089b782c
2014-05-26coverity#1019326 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: Ib3f0776048ca3dbb8a7efa4d9240f4ee9d6ac9dd
2014-05-26coverity#1019329 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: Ic340559c9ab9b74f4f932c90e08f2530c08e8d08
2014-05-26coverity#1019330 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I9c7893f7c9af2b42dcc50f2d1463ec497bb85e30
2014-05-23improve parameter flow in cpputype.cxxNoel Grandin1-10/+8
after commit c5d47c327a57df55 "add default value for Context param in uno::Exception constructors" Change-Id: Ib429b58c559ecd48764a8df2f49d5470057c2c63
2014-05-23add default value for Context param in uno::Exception constructorsNoel Grandin1-7/+24
and all it's subtypes, which is almost never used, so this allows us to simplify lots of call sites. Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
2014-05-23Combine unoidl::loadProvider and unoidl::Manager::addProviderStephan Bergmann1-3/+1
Change-Id: I1240656cc2a4d713c838eb80fa90ce3485aad614
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin2-3/+3
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-11coverity#1213117 Unchecked dynamic_castCaolán McNamara1-0/+3
Change-Id: I6f55030ea7bebce99537c7cdd5156c83c38a765a
2014-04-28prefer makefile-gmake-modeTakeshi Abe3-3/+3
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-04-14Reduce the amount of strings in the release builds.Jan Holesovsky1-23/+22
I guess even in the debug builds these strings do not add much info, but... Change-Id: I5cf765539a821513b5ce77c5484071d181459881
2014-04-04codemaker: sal_Bool->boolNoel Grandin4-6/+6
Change-Id: I0a0691df58455b712eb27695f4cce15fd3494b65
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann2-2/+2
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann3-50/+50
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-17codemaker,editeng: prefer passing OUString by referenceNoel Grandin2-11/+11
Change-Id: If3e2dd3905cc33f1e7fc9fbfbb9f2bb49a756a34
2014-02-27Remove visual noise from codemakerAlexander Wilms1-2/+2
Change-Id: I098c636ed8794c858317fdbefa9ffa1c6d81c320 Reviewed-on: https://gerrit.libreoffice.org/8241 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17codemaker: sal_Bool -> boolStephan Bergmann6-36/+36
Change-Id: I2cacac2aa7e48b3b9d8d060137d5c6d6f1d06b3f
2014-02-01coverity#707676 : Uninitialized scalar fieldNorbert Thiebaud1-2/+5
Change-Id: I546c3f497dc98c88a0d678622c20cced387a4ab2
2014-01-31Remove UNOIDL "array" and "union" vaporware remnantsStephan Bergmann1-2/+0
...and deprecate what cannot be removed for compatibility. Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-28copy&paste typoMatúš Kukan1-1/+1
Change-Id: I528a6a747e88fe2a4b4abfd9372daddf4e8aa502
2014-01-28Support direct ctor calls for singletons too.Matúš Kukan1-3/+31
Change-Id: I6db797c950b8222b3ad95faff86adf5e7b41ff4b
2014-01-28coverity#440030 Logically dead codeCaolán McNamara1-14/+1
Change-Id: I77428c6cf1f79dcc0e2c5e1d52f9b4b8c88130e3
2014-01-28coverity#440029 Logically dead codeCaolán McNamara1-16/+1
Change-Id: Id071c8658b473b9d393a32e1da2c2474bb7361d3
2014-01-27coverity#1019407 Uninitialized scalar fieldCaolán McNamara1-1/+2
Change-Id: Icaa2062b00e0a68486bcbbc4a26b4089016bf2c8
2014-01-27coverity#1019406 Uninitialized scalar fieldCaolán McNamara1-1/+2
Change-Id: I9f5d48c5c5c0f76aa3386cfedcaf43ced162e4b0
2014-01-27codemaker: Allow compiler to share these generated strings.Jan Holesovsky1-6/+10
There is really no need to see tons of component context fails to supply service <something long> of type <something else long>: and component context fails to supply service <something long> of type <something else long> in the binary ;-) - let's split the strings to parts that the linker can share easily. Change-Id: I07f149a587c05985045028c3b6530c6efd081ff5
2014-01-23Do not acquire again in direct constructor function calls.Matúš Kukan1-2/+2
Missing in c2c530da69152ff9192b9726aa95961803ce9b29 "Introduce static inline cppu::acquire(), and make use of that." Change-Id: I4a856eeaff1fce3f429c62c1897fe3898371d1ec
2014-01-20Minimize the constructor functions to a bare minimum.Jan Holesovsky1-2/+2
Most of the constructors are supposed to be only a call of new TheInstance(arguments) or an equivalent; so let's just change the constructor caller accordingly, to accept unacquired new instance. If there are exceptions that need to do more heavy lifting, they do not have to use the constructor feature, or there can be a wrapper for the real implementation, doing the additional work in their (C++) constructor. Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
2014-01-20Fix declaration for ctor functions in generated headers.Matúš Kukan1-3/+5
Change-Id: I329ff80da68c629d7a82921253c4412563743b34
2014-01-18Initialize also implementations created directly by generated function.Matúš Kukan1-4/+15
This was forgotten in commit bdeb57c23973f3ef79020847b2fe39f312cf3c0b. Change-Id: Idd339222e3c464abc2524f78f16c8fe0a02dcd5b
2014-01-10Be explicit when using bool as integral valueStephan Bergmann1-1/+1
Change-Id: I22ee35d8c26ac119b35ba6c85c06199539b0c9d7
2014-01-10codemaker: fix^2 invalid string index accessStephan Bergmann1-5/+2
...originally the past-the-end checks in destination where always true, and thus happend to work as intended for empty destionation, but 614e04019a672cdd61b86699d99250d80f169f95 broke that, so calling cppumaker w/o -O was broken now. Change-Id: I8d41dfe8d4c12e4a73a9782d4d5e7c9fa4d9df81
2014-01-08sal_textenc is a runtime dep of cppumakerDavid Tardon1-1/+0
Change-Id: I9fd91ee8c15479e9956daa5c85a09f141ef6cc3f
2013-12-30Add sal_textenc dependency to cppumakerIsamu Mogi1-0/+1
In Japanese localized Windows, cppumaker requires sal_textenclo.dll but that rule isn't written in .mk. It causes build failure. Change-Id: Icab74493a4a3b445144bb9d969b79636dbd17162 Reviewed-on: https://gerrit.libreoffice.org/7134 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2013-12-19...and support direct calls of non-default ctors, tooStephan Bergmann1-3/+26
Change-Id: I507a5664e642c75f6e9e9fe0c95c97ea76a8e5b3
2013-12-19WIP: Direct service ctor calls at least on Android/iOSStephan Bergmann1-3/+28
Change-Id: I8a1907bc4b8f2134efb15d38a0fb5176b4384317
2013-12-17if there is one typo, its guaranteed to duplicated somewhereCaolán McNamara1-1/+1
Change-Id: Ia81069afa47fa5790b973247c68bead7de87d718
2013-11-07codemaker: fix invalid string index accessMichael Stahl1-2/+3
Change-Id: Icca819484e751864d146a893fe78e8ef2c36363b
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-4/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-9/+2
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-20cppumaker: Allow UNO interface functions to throw std::exceptionStephan Bergmann3-5/+15
...so that exceptions like std::bad_alloc need not be treated in C++ implementations of UNO interfaces to not cause std::unexpected. Of course, this requires implementations to be adapted and actually mention std::exception in their exception specifications. Change-Id: Ie7f91e7ca47d8a81e3d0ba817e65d83c7823af75
2013-10-20Some more cppumaker "css" clean-upStephan Bergmann1-3/+3
...hopefully, all generated headers that use css (indirectly) include sal/types.h Change-Id: Iaa40fa014d54b57b395eafda8b4f35ca395d55b0
2013-10-20fdo#70285 cleanup generated C++ codeNoel Grandin2-106/+95
Change-Id: Ic43628de53c5139ef43bb48723fb1e0788af1cd1 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>