summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2019-12-19Fix typoAndrea Gelmini1-2/+2
Change-Id: If7c72942e008d8197dd2e1a2216421925518bc56 Reviewed-on: https://gerrit.libreoffice.org/85483 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18tdf#128995: Special case for single variable regression...Deena Francis2-36/+111
like in LINEST implementation in Calc. Use a straightforward regression solver in this case, so that it is easier to handle the numerical error in the intercept term using ::rtl::math::approxSub(). Change-Id: I627c0c48e377cac5385a85050c4f472ee963f3d6 Reviewed-on: https://gerrit.libreoffice.org/85222 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-12-18sal_Char->char in canvas..codemakerNoel Grandin5-6/+6
Change-Id: Iaf46b42a17bc00da0f86daeafea7b5346c4a6360 Reviewed-on: https://gerrit.libreoffice.org/85372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-16chart2: clear listener parents in disposeAshod Nakashian3-1/+14
Change-Id: Icdab125589ab0f55255f683a1ea39e036de661b1 Reviewed-on: https://gerrit.libreoffice.org/84997 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-16tdf#129173 tdf#129175 Fix number format of data labelsBalazs Varga7-48/+17
Show the real value (cell value) of datapoints instead of the recalculated value in case of Percent Stacked Area chart. Also fix: tdf#95425 Do not reset number format of data labels when open dialog of 'Format data series' and close dialog. Note: Inherits the data series/point label format from the cell format and not the axis format, if we set the 'link to source data' option to true. Change-Id: I04e9968034a67c6bc6b92941df61d945b4292d79 Reviewed-on: https://gerrit.libreoffice.org/84819 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-13tdf#129056: No need for catastropheMuhammet Kara1-1/+12
We can continue working without hurting others in case of an invalid reference. Putting in a warning so that it doesn't become a black hole which silences errors. Change-Id: I6d75edeba227a4293b0ae16217811e49ae336a6b Reviewed-on: https://gerrit.libreoffice.org/85111 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-12-13loplugin:expandablemethodsNoel Grandin4-22/+3
Change-Id: I333d91ea5ce78c82e9bb107f934614efc7bfb8f7 Reviewed-on: https://gerrit.libreoffice.org/85078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12Unit test clean-up for testAxisTitlePositionDOCXBalazs Varga1-4/+5
Related commit: 9ff954d5f780cae5df6942e97b713cfc19449145 (tdf#127908 tdf#128193 Chart OOXML: Fix Custom Y axis title position) Change-Id: I5b239e8cc5d2e497e7ecd6443b9e2f3001c3c231 Reviewed-on: https://gerrit.libreoffice.org/84991 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12tdf#34517 Bring forward/backward in chart series switchedKelemen Gábor1-1/+2
Turns out bringing a data series forward means its index is increased while bringing backwards means decreasing it. Since the bool MOVE_SERIES_FORWARD is defined as true in ControllerCommandDispatch.cxx the condition here meant that bringing forward decreased the index and MOVE_SERIES_BACKWARD as false meant that bringing backward increased the index. Now the commands do the expected series order change. Change-Id: Ib49b301eacc227439b8fb3b0dc3513e59cbdc484 Reviewed-on: https://gerrit.libreoffice.org/84608 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-12tdf#121991 Chart OOXML import: fix deleted legend entriesTünde Tóth2-0/+15
The legend showed deleted legend entries too. Change-Id: I1e205cdfc4262c73d2bb189237d6bc316781931d Reviewed-on: https://gerrit.libreoffice.org/84516 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-12-07Check secondary Y axis exists before retrieving value for "Show" prop (chart2)Julien Nabet1-2/+2
Change-Id: I7d2a69635de6625e09dd71a33553261898e30420 Reviewed-on: https://gerrit.libreoffice.org/84685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-07Fix typosAndrea Gelmini1-1/+1
Change-Id: Ibaaf738abdb4abcb9edb66ea35b6ebabdbe02507 Reviewed-on: https://gerrit.libreoffice.org/84681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-07PageStyle and WritingMode may be absent (chart2)Julien Nabet1-3/+11
Create a brand new odb file (embedded hsqldb) Create a report with design, just insert a chart It'll error-log first because of missing "PageStyle" property once this one fixed, it'll error-log with missing "WritingMode" property Remark: the chart will be created But let's avoid these error-logs Change-Id: I04bb4d87e8e97fb3ff7c4e5dc7f81897afca64ec Reviewed-on: https://gerrit.libreoffice.org/84675 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I14e60ed9cc095ff26a60f505701c08cea68b9ff2 Reviewed-on: https://gerrit.libreoffice.org/84475 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-04drop dbgutil SdrItemBrowser FloatingWindowCaolán McNamara1-1/+0
Change-Id: I7a4ca90ea23271e7b6f60d7e47e4513978d3222d Reviewed-on: https://gerrit.libreoffice.org/84356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04remove some unnecessary includes and update pchesCaolán McNamara1-2/+7
Change-Id: Ieee11f2ea3c5c18a84316a8b7c39a261afd720ed Reviewed-on: https://gerrit.libreoffice.org/84308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-04some std::set->o3tl::sorted_vectorNoel Grandin4-8/+8
which is much better cache-wise Change-Id: Iacec0df48f043bcdd761ed30c1b1513850a00152 Reviewed-on: https://gerrit.libreoffice.org/84311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-03remove some useless comment linesNoel Grandin2-2/+0
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-02tdf#129054 Chart OOXML Import: Fix size of Pie ChartBalazs Varga3-1/+14
Do not shift (set to false ShiftedCategoryPosition) the category axis for Pie chart with complex category. Change-Id: I3b1d99899a2daf9fd7a596c88531797aa5084734 Reviewed-on: https://gerrit.libreoffice.org/83871 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-01Introduce o3tl::optional as an alias for std::optionalStephan Bergmann4-7/+7
...with a boost::optional fallback for Xcode < 10 (as std::optional is only available starting with Xcode 10 according to <https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite all code to use o3tl::optional instead of boost::optional. One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per fed7c3deb3f4ec81f78967c2d7f3c4554398cb9d "Slience bogus -Werror=maybe-uninitialized" should no longer be necessary (and whose check happened to no longer trigger for GCC 10 trunk, even though that compiler would still emit bogus -Wmaybe-uninitialized for uses of boost::optional under --enable-optimized, which made me ponder whether this switch from boost::optional to std::optional would be a useful thing to do; I keep that configure.ac check for now, though, and will only remove it in a follow up commit). Another longer-term benefit is that the code is now already in good shape for an eventual switch to std::optional (a switch we would have done anyway once we no longer need to support Xcode < 10). Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses boost::property_tree::ptree::get_child_optional returning boost::optional, so let it keep using boost::optional for now. After a number of preceding commits have paved the way for this change, this commit is completely mechanical, done with > git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g' (before committing include/o3tl/optional.hxx, and relying on some GNU features). It excludes some files where mention of boost::optional et al should apparently not be changed (and the sub-repo directory stubs). It turned out that all uses of boost::none across the code base were in combination with boost::optional, so had all to be rewritten as o3tl::nullopt. Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b Reviewed-on: https://gerrit.libreoffice.org/84128 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Rewrite uses of boost::optionalStephan Bergmann4-5/+5
...to only use functions that are also available for std::optional (in preparation for changing from boost::optional to std::optional): * uses of get are replaced with operator * or operator -> * uses of is_initialized are replaced with operator bool * uses of reset with an argument are replace with operator = (All of the replacements are also available for boost::optional "since forever", so this change should not break builds against old --with-system-boost. An alternative replacement for is_initialized would have been has_value, but that is only available since Boost 1.68.) Change-Id: I532687b6a5ee37dab28befb8e0eb05c22cbecf0f Reviewed-on: https://gerrit.libreoffice.org/84124 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-30Removed executable permission on fileAndrea Gelmini1-0/+0
Change-Id: I32f116281f37d22d63d44f5da1010ee3ca6bd9c0 Reviewed-on: https://gerrit.libreoffice.org/84095 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-29tdf#123206 Import/Export chart custom label textTamas Bunth2-0/+16
OOX import supports custom label texts in chart diagrams (produced by e.g. double clicking on a data label, and write custom text), but - since embedded objects are exported and imported to odf right after migration - it is not displayed in case of a Writer document. In order to make it work, we have to support custom label text in the odf structure. This commit only allows the import/export of pure text, it should be improved to store and load formatted string. A new XML token is added, which currently refers to an attribute of the chart:data-point tag. If we want to store formatted string, something more clever has to be done. Change-Id: I80c4a3a0dbcf59f1dc732d795fb716da318411cb Reviewed-on: https://gerrit.libreoffice.org/80156 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-11-27tdf#115630 tdf#88922 Chart: fix custom legend position and sizeBalazs Varga2-19/+18
Do not need to set the "AnchorPosition" value, when we move the legend object. It is enough to set only the "Expansion" as custom, so we keep the previously set "AnchorPosition" value and we can use the lcl_calculatePositionAndRemainingSpace function to calculate the remaining space of the inner chart area. Change-Id: I7b577bc6acf2de9b6755329b92603ea5ba631d57 Reviewed-on: https://gerrit.libreoffice.org/83399 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-24lok: Chart context menu: Disable menu items which are not available.Tamás Zolnai3-1/+17
Change-Id: Id7487c581759389e66ca513381d6706f3ae49980 Reviewed-on: https://gerrit.libreoffice.org/83605 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24lok: Chart context menu: Replace tunneled context menu with JS context menu.Tamás Zolnai1-18/+20
Change-Id: I36db90887bff86036093ce0732db6fc6c76e79f6 Reviewed-on: https://gerrit.libreoffice.org/83604 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-22make some classes module-privateNoel Grandin1-1/+1
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann27-15/+215
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-21tdf#123774 OOXML chart export: keep digits of percentages of data points Balazs Varga4-0/+16
by exporting PercentageNumberFormat, checking the "Label" format directly and taking the respective number format based on that. Note: also fix the "LinkNumberFormatToSource" property. If we create a pie chart with data labels and set the "Show value as number" or "Show value as percentage" and check on/off "Source format", this move is not set the property in the XPropertySet. Because of this, it fixes also the export of correct value of "link-data-style-to-source" property into ODS files. But this patch doesn't fix the export of old ODS files to OOXML, because they contain wrong (always true) "link-data-style-to-source" value. Change-Id: I4098a245dec5bf35cde20c9ccb79aca726230118 Reviewed-on: https://gerrit.libreoffice.org/82703 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-21tdf#42949 tdf#119699 Fix IWYU warnings in chart2/Gabor Kelemen57-185/+255
* Recheck after recent refactorings and improvements in f-u-i * Drop now unused TabPageIds.h * The problem noticed in bug #119699 now seems to be gone too so drop those lines from the blacklist. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15 Reviewed-on: https://gerrit.libreoffice.org/83182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-20loplugin:unusedmethodsNoel Grandin2-17/+0
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18tdf#127777 fix "CrossBetween" for not imported combined chartBalazs Varga1-1/+4
Set the ShiftedCategoryPosition for true in case of combined chart. See also commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f 'tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts Change-Id: I52fdcdc52e75ac15c85e04c2982b25cc180d7815 Reviewed-on: https://gerrit.libreoffice.org/82617 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann1-0/+4
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16cid#1453998 Wrapper object use after freeCaolán McNamara1-3/+4
Change-Id: I1dc733e72ba63db1eaa20113a7599ea7580eef31 Reviewed-on: https://gerrit.libreoffice.org/82988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-16ChartTypePanel: Remove unused varsMuhammet Kara1-6/+0
Change-Id: I6a19fa269efaf008345b48341d1c501e1c7e7d17 Reviewed-on: https://gerrit.libreoffice.org/82244 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82812 Tested-by: Jenkins
2019-11-16Rename getCurrentParamter() as getCurrentParameter()Muhammet Kara2-6/+6
Change-Id: I0116b4526fea377130b1d1e101d30b3107af3c81 Reviewed-on: https://gerrit.libreoffice.org/82243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82811 Tested-by: Jenkins
2019-11-16Remove unused var m_xChartTypeLabelMuhammet Kara2-2/+0
Change-Id: I3de7eb4e438021f9522e581c60a84fb7fcc168c7 Reviewed-on: https://gerrit.libreoffice.org/82242 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82810 Tested-by: Jenkins
2019-11-16Add SplineResourceGroup to ChartTypePanelMuhammet Kara2-9/+11
Change-Id: I229eb1cc4963c04968ed9ac32b65847dbfd602c3 Reviewed-on: https://gerrit.libreoffice.org/82807 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-16Add more resource groups to ChartTypePanelMuhammet Kara2-30/+35
Change-Id: I64c1d8b418f9abb537b4f23c3b31aa0e48bd3faa Reviewed-on: https://gerrit.libreoffice.org/82119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82801 Tested-by: Jenkins
2019-11-15chart2: Weld ChartTypePanelMuhammet Kara4-288/+277
Change-Id: I8ed178ffe0d880b362f98b9754bce40b20942bd7 Reviewed-on: https://gerrit.libreoffice.org/82768 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-15-Werror,-Wunused-private-fieldStephan Bergmann1-3/+0
Change-Id: I0e9e7be9ba7dfc2f8c6d4e17aa6c08aa1d97db45 Reviewed-on: https://gerrit.libreoffice.org/82755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15make some classes module-privateNoel Grandin9-17/+17
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5 Reviewed-on: https://gerrit.libreoffice.org/82116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-14Add ChartTypePanel to the ChartDeckMuhammet Kara6-0/+1063
Consists of the first part of the implementation. Pushing to be able to see/use/tinker with it on the online/mobile side. Will be completed with follow-up patches. Change-Id: If49be54418c3b4c5ccc92fc7ee3e414847904162 Reviewed-on: https://gerrit.libreoffice.org/80799 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82663 Tested-by: Jenkins
2019-11-14Move SplinePropertiesDialog & SteppedPropertiesDialog to reuseMuhammet Kara6-134/+205
Change-Id: I2937c617bed0d000734784301421237f282014e9 ecefe02a664e6a6852cf132d615c20e56e580e92 Reviewed-on: https://gerrit.libreoffice.org/82124 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82648 Tested-by: Jenkins
2019-11-13tdf#128733 Chart import: fix secondary X axisBalazs Varga3-0/+18
shiftedcategoryposition value. When inserting secondary axes it applies the ShiftedCategoryPosition of the main axis. Regression from the commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: Ia043fe2873f633cbd5f7db206cf9d1b0d2f8c34c Reviewed-on: https://gerrit.libreoffice.org/82511 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13chart2: Separate definition from declaration for ChartResourceGroupsMuhammet Kara3-421/+457
Change-Id: I861eaf0e519c428debc28436ea41724fdf493359 Reviewed-on: https://gerrit.libreoffice.org/81634 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82463 Tested-by: Jenkins
2019-11-13tdf#128732 Chart OOXML import: fix rounding error of color transparencyBalazs Varga2-0/+27
Change-Id: I52efb541d62a9536c2eb5f99453dc2cb594e6fe4 Reviewed-on: https://gerrit.libreoffice.org/82500 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13tdf#128619 Chart OOXML export: fix gradient positionBalazs Varga2-0/+14
Export the gradient border value as gradient stop position of the first color at LINEAR GradientStyle. Change-Id: I1a2b986a004fecbf68050c6bf95be549684fea70 Reviewed-on: https://gerrit.libreoffice.org/82446 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-13chart2: Separate ChartResourceGroups to reuseMuhammet Kara5-570/+610
Change-Id: I0ca2ea9cd520013250faaba0e17e713da1e6fca3 Reviewed-on: https://gerrit.libreoffice.org/81581 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82462 Tested-by: Jenkins
2019-11-12tdf#128627 tdf#128634 Fix OOXML import of CrossBetweenBalazs Varga3-0/+34
Set default 'midCat' value during the import, for Radar charts, because MSO created them with default 'midCat', but exported a 'between' value. Set default 'between' value during the import, for 3D Bar and Stock charts, because sometimes the OOXML file can contain a wrong CrossBetween value, but MSO import them with default values. tdf#128627 regression from commit: 830e539547c463b932ce643517f880789185032d (tdf#127393 OOXML chart import: fix X axis position setting "CrossBetween") tdf#128634 regression from commit: 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: Ie9763197b79c3a661e66043da7b89b4f0f00ba33 Reviewed-on: https://gerrit.libreoffice.org/82211 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-05 05:16:13 +0000