summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2018-12-03Fix JunitTest_chart2_unoapi failing DBG_TESTSOLARMUTEX on WindowsMike Kaganski1-1/+2
The failing call stack: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 61 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61) ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187 at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(187) ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420 at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(420) ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444 at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(444) vcllo.dll!ImplDbgTestSolarMutex() Line 46 at c:\lo\src\core\vcl\source\app\dbggui.cxx(46) tllo.dll!DbgTestSolarMutex() Line 78 at c:\lo\src\core\tools\source\debug\debug.cxx(78) vcllo.dll!OpenGLSalBitmap::Create(const Size & rSize, unsigned short nBits, const BitmapPalette & rBitmapPalette) Line 164 at c:\lo\src\core\vcl\opengl\salbmp.cxx(164) vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, unsigned short nBitCount, const BitmapPalette * pPal) Line 108 at c:\lo\src\core\vcl\source\bitmap\bitmap.cxx(108) vcllo.dll!o3tl::make_unique<Bitmap,Size &,unsigned short &>(Size & <args_0>, unsigned short & <args_1>) Line 29 at c:\lo\src\core\include\o3tl\make_unique.hxx(29) vcllo.dll!vcl::PNGReaderImpl::ImplReadHeader(const Size & rPreviewSizeHint) Line 665 at c:\lo\src\core\vcl\source\gdi\pngread.cxx(665) vcllo.dll!vcl::PNGReaderImpl::GetBitmapEx(const Size & rPreviewSizeHint) Line 342 at c:\lo\src\core\vcl\source\gdi\pngread.cxx(342) vcllo.dll!vcl::PNGReader::Read(const Size & i_rPreviewSizeHint) Line 1732 at c:\lo\src\core\vcl\source\gdi\pngread.cxx(1732) vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, unsigned short * pDeterminedFormat, GraphicFilterImportFlags nImportFlags, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> * pFilterData, const WmfExternal * pExtHeader) Line 1813 at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1813) vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat, unsigned short * pDeterminedFormat, GraphicFilterImportFlags nImportFlags, const WmfExternal * pExtHeader) Line 1281 at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1281) vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 2509 at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2509) vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance, ConvertData & data) Line 2481 at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2481) sofficeapp.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop * __formal, ConvertData & rData) Line 1752 at c:\lo\src\core\desktop\source\app\app.cxx(1752) sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void * instance, ConvertData & data) Line 1749 at c:\lo\src\core\desktop\source\app\app.cxx(1749) vcllo.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic, ConvertDataFormat nFormat) Line 44 at c:\lo\src\core\vcl\source\gdi\cvtgrf.cxx(44) chartcorelo.dll!chart::ChartModel::impl_loadGraphics(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & xStorage) Line 621 at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(621) chartcorelo.dll!chart::ChartModel::impl_load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rMediaDescriptor, const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & xStorage) Line 576 at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(576) chartcorelo.dll!chart::ChartModel::load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rMediaDescriptor) Line 543 at c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(543) chartcontrollerlo.dll!chart::ChartFrameLoader::load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rMediaDescriptor, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) Line 170 at c:\lo\src\core\chart2\source\controller\main\chartframeloader.cxx(170) fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1149 at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(1149) fwklo.dll!framework::LoadEnv::startLoading() Line 383 at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(383) fwklo.dll!framework::LoadEnv::loadComponentFromURL(const com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> & xLoader, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & xContext, const rtl::OUString & sURL, const rtl::OUString & sTarget, long nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArgs) Line 170 at c:\lo\src\core\framework\source\loadenv\loadenv.cxx(170) fwklo.dll!framework::Desktop::loadComponentFromURL(const rtl::OUString & sURL, const rtl::OUString & sTargetFrameName, long nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 619 at c:\lo\src\core\framework\source\services\desktop.cxx(619) mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214 at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(214) mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 429 at c:\lo\src\core\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(429) binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny> > * outArguments) Line 239 at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(239) binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79 at c:\lo\src\core\binaryurp\source\incomingrequest.cxx(79) binaryurplo.dll!request(void * pThreadSpecificData) Line 83 at c:\lo\src\core\binaryurp\source\reader.cxx(83) cppu3.dll!cppu_threadpool::JobQueue::enter(__int64 nDisposeId, bool bReturnWhenNoJob) Line 108 at c:\lo\src\core\cppu\source\threadpool\jobqueue.cxx(108) cppu3.dll!cppu_threadpool::ORequestThread::run() Line 170 at c:\lo\src\core\cppu\source\threadpool\thread.cxx(170) cppu3.dll!threadFunc(void * param) Line 186 at c:\lo\src\core\include\osl\thread.hxx(186) sal3.dll!oslWorkerWrapperFunction(void * pData) Line 58 at c:\lo\src\core\sal\osl\w32\thread.cxx(58) ucrtbased.dll!invoke_thread_procedure(unsigned int(*)(void *) procedure, void * const context) Line 92 at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(92) ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void * __ptr64)>(void * const parameter) Line 115 at minkernel\crts\ucrt\src\appcrt\startup\thread.cpp(115) kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Change-Id: Ia22ebb2361192c30549b0f01ac0b709295e1dbdc Reviewed-on: https://gerrit.libreoffice.org/63700 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01tdf#121744 XLSX Export Combinated Chart (Column and Line)Jozsef Szakacs2-0/+15
Each of the Column and Line Chart creates it's own x and y Axes. So now the LineChart Exporter Method uses the same Axes as the BarChart. Thanks for the help: - Balazs Varga - Adam Kovacs Change-Id: Ie763cf831c2ce63ef204d1fdcbff634e7ca8fad5 Reviewed-on: https://gerrit.libreoffice.org/64146 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-30remove unused enum DataSourceDialogPagesNoel Grandin1-6/+0
Change-Id: If990d5f8cb2eca7fa6ffd21f2f8db17ba4385df6 Reviewed-on: https://gerrit.libreoffice.org/64319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29related tdf#42915, pass NaN through date transformationMarkus Mohrhard1-0/+3
Many places in chart2 use NaN to mean no available value. Not propagating NaN through the helper disables all this functionality. Change-Id: I37f966007b5b7cc16778c5c6903710fbd144631b Reviewed-on: https://gerrit.libreoffice.org/64266 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#42915, NaN in a date axis can destroy the whole chartMarkus Mohrhard2-0/+12
The NaN value forces the scaling of the axis to be based on years and introduces gaps in the rendering. Change-Id: I78219be289d76edb53b5672209e1c031ab62def9 Reviewed-on: https://gerrit.libreoffice.org/64267 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#42949 Fix IWYU warnings in include/vcl/[i-m]*Gabor Kelemen8-0/+11
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91 Reviewed-on: https://gerrit.libreoffice.org/64141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-29add test for tdf#105236Markus Mohrhard2-0/+14
Change-Id: I5464504ae9ee411221c2cb2ff6f27b7b7e131326 Reviewed-on: https://gerrit.libreoffice.org/64201 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-27weld DataSourceDialogCaolán McNamara10-349/+461
Change-Id: I4d3eb8aa354043d3ff57b4996db7b28ad25e0262 Reviewed-on: https://gerrit.libreoffice.org/64072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27improve chart type dialog treeview widthCaolán McNamara1-0/+1
Change-Id: I41a053f63db6bced24dd6586e2c347d286339c29 Reviewed-on: https://gerrit.libreoffice.org/64071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27Refactor calc non-linear ViewToDevice transformArmin Le Grand2-6/+14
This change solves the non-linear World-To-View trans- formation that calc uses due to it's screen rendering as good as currently possible (AFAIK). Calcv view is layouted on pixel base (due to better homogen distances and full pixel lines between cells), but this leads to having a non-linear transformation between discrete units (pixels, view) and model coordinates (World). In principle, each cell has it's own (so called) ViewTransformation -> the position on screen depends on the mappings of all cells top/left from it. This is obvioulsly non-linear and can sometimes be seen by producing 'offset' errors when many cells (small and thin) are shown in low zoom stages. No better solution for this comes to mind easily. The extremes are - on the one hand AntiAliasing the whole calc edit view and accept 'unsharp/AAed' lines - on the other hand what we have now. Maybe a future solution could find a mapping that gets close to linear mapping for the full view. On the long run this state is hard to keep correct. Even with this extended solution the mapping of SdrObjects spawning mutiple cells is assumed 'linear' in that area - which is in reality currently not the case (!) Note: This is only true for the screen visualization, print and/or PDF export do not do that pixel-based layouting. Note2: This mechanism is general in DrawingLayer (look for '.*GridOffset.*'. If it is deactivated by providing no offsets, the result is the unchanged, linear mapping. First step: Add interfaces to get a possible GridOffset at ViewObjectContact. There it belongs, we have a view- dependent offset per object and view. Add mechanisms to create on-demand and reach back to the view (aka calc's derivation of it). Second step: Implement the on-demand creation, adapt to use it in ViewObjectContact::getPrimitive2DSequence, add stuff to reset on zoom change, disable temporarily old mechanism -> paint already works. Need to adapt the places from old mechanism where the GridOffset was used, but no longer the geometry creations. Third step: Isolated and disabled old mechanism (by already removing SetGridOffset). Marked all places that possibly need change with '//Z' tag. Main work now will be to adapt in the SdrView implementations in svx to know about having a SdrObject-dependent ViewTransformation at all (currently not known, was hard-coded at some places from the old code, ViewTransformation set as MapMode at a target OutputDevice, not member at SdrView at all...). Fourth step: Adapt the Handles and OverlayObjects to use an evtl. existing GridOffset. The mechanism is that the SdrHdl(s) can be seen as 'Model-Objects', these get converted to OverlayObjects in the ::CreateB2dIAObject() implementations, for all SdrMarkView and SdrPageView, so this is the place where the ObjectContact is known (the SdrPageWindow *is* a ObjectContact) and the view- dependent GridOffset can be calculated per SdrObject. I modified OverlayObject to be able to work with a set Offset that embeds the created visualization using this additionally. Handles get now correctly set and have a working HitTest (due to that already using the primitives). Some inter- action stuff already working, some will need more adaption. We simply have no concept for this stuff... Refactored to not get dependencies to SdrObject in ObjectContact. Fifth Step: Make HitTest work by adding the View-And- Object dependent GridOffset in the View when HitTest is triggered. This is in SdrMarkView::CheckSingleSdrObjectHit where pObj->GetCurrentBoundRect() is used that gets the view-independent form. To make HitTest work, add a possible GridOffset. Since this will be necessary more often in SdrView hierarchy, added a tooling method (getPossibleGridOffsetForSdrObject) at that level after checking that at that level will be reachable at all potential spots. Inside that method the correct ObjectContact will be identified and the object-specific offset requested there. Sixth Step: Adaptions and started some cleanups. Still some adaptions needed: - After creation of new object, need to relocate from used GridOffset setting to WorldCoordinates - Interactions, e.g. start with dragging handles or full object/points Seventh Step: React on EndCreateObj. Here, the created SdrObject is in model coordinates and needs to be adapted to evtl. GridOffset. This is 'tricky' due to calculating the possible offset based on new coordinates 'close' to the target position, but may be in the wrong cell. Nonetheless this is the best we can do here. Last (hopefully) missing are now all interaction viszualizations. They already work and are applied correctly, but wrong visualized. Have taken the time to unify adding OverlayObjects for selection visualization to OverlayManager, see handleNewOverlayObject. This does all needed when adding OverlayObjects in one place where the GridOffset can also be handled. It makles things more safe - not possible to forget one of the three steps for others. Eighth Step: Do the same unification for creating the OverlayGeometry, also rename methods to make usage more clear. We now have SdrHdl::insertNewlyCreatedOverlayObjectForSdrHdl SdrDragMethod::insertNewlyCreatedOverlayObjectForSdrDragMethod which can do the needed GridOffset changes centralized. Needed to get a ObjectContact for this at SdrDragMethod, so adapted ::CreateOverlayGeometry implementations accordingly. Missing is now the implementation in insertNewlyCreatedOverlayObjectForSdrDragMethod to add the GridOffset - if used. This has no SdrObject at this time, so we will need a fallback to do the same using a Range (Rectangle). The stuff doing this for SdrObject already has a fallback and is based on using the Rectangle from the SdrObject anyways, so this will be possible. Ninth Step: Cleanup of old stuff (no more //Z), adapted some usages of OverlayObject creations to use getViewIndependentPrimitive2DContainer instead of the view dependent parts so that offset applied to drag-overlays is correct and not already added. Adapted insertNewlyCreatedOverlayObjectForSdrDragMethod to use calculateGridOffsetForB2DRange. Use now that instead of SdrObject-based approach in calc - is more generic. Getting closer, but still not complete - there is an error with dragging the grepped handle somehow - the offset for drag is somehow wrong. Tenth Step: Corrected that offset error. Of course at interaction start and progress (move) the coordinates are in GrifOffset coordinates and need to be corrected to Model coordinates. Done that at ::BegDragObj and ::MovDragObj, works well. Of course there are exceptions for the crop-handles, so needed to add setting the correct parameters at SdrHdl when these got created, then all works as expected. The strategy is to *not* change the model data itself in any way, instead do all changes/adaptions in the view-only code. This has minimal impact and is needed due to having a 1:n relationship between model and views anyways. There are two directions: All visualizations are adapted to take the GridOffset into account (SdrObjects, overlay, handles, InteractionObjects, ...). In the other direction input like MousePosition is in principle in calc EditView in 'GridOffset'-coordinates and needs to be mapped back before usage. Change-Id: I2ecdd409def96a7248a26a65a22e59eb962880a0 Reviewed-on: https://gerrit.libreoffice.org/64057 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-27add test for tdf#108027Markus Mohrhard2-0/+15
Change-Id: I1048d86bf11b4fdd4a5c90f6e98276893b8ffbf4 Reviewed-on: https://gerrit.libreoffice.org/64078 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-26Fix typoAndrea Gelmini1-1/+1
Change-Id: I339e1d956ed6f3017453237f0b8ad540d7d4ad20 Reviewed-on: https://gerrit.libreoffice.org/64068 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-26weld DataSourceTabPageCaolán McNamara7-481/+424
Change-Id: I99b7c2ec397829c2f7ceb7ec18ae24195b9781e2 Reviewed-on: https://gerrit.libreoffice.org/61800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26tdf#42949 Fix IWYU warnings in chart2/source/view/*cxxGabor Kelemen43-146/+12
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9ee3318c79d3b59f272a2a5f89c38b26afa05974 Reviewed-on: https://gerrit.libreoffice.org/63775 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26drop some unnecessary includesCaolán McNamara1-5/+0
Change-Id: I4a45110e69fc76ff5b12e014586a0684c3737dfe Reviewed-on: https://gerrit.libreoffice.org/64000 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26Put text label outside of the pie if..Tamas Bunth1-1/+12
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: https://gerrit.libreoffice.org/64015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-23improve function local staticsNoel Grandin1-42/+39
simplify the initialisaion and make them thread-safe i.e. initialise them using the runtime's local static locking. Thanks to mike kaganski for pointing out the nice lambda approach that makes this feasible. Change-Id: I76391189a6d0a3d7eed2d0d88d28dfa6541eaff7 Reviewed-on: https://gerrit.libreoffice.org/63645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23Related: tdf#118764 last of the GtkRadioButtons with can-focus FalseCaolán McNamara1-5/+5
Change-Id: I1346478fb8bbb1720ecc6cf7c88407be3b126bf1 Reviewed-on: https://gerrit.libreoffice.org/63867 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkCheckButtons with can-focus FalseCaolán McNamara5-11/+11
Change-Id: I81d3e03a0ccea3851b01d39b2e972b13ef4f6359 Reviewed-on: https://gerrit.libreoffice.org/63869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkButtons with can-focus FalseCaolán McNamara1-4/+4
Change-Id: I8001d8c6c950e74df0f909e1cebfb3d1e52a84a4 Reviewed-on: https://gerrit.libreoffice.org/63846 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22--enable-dbgutil --disable-assert-always-abort fixesStephan Bergmann3-3/+3
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across; plus some related loplugin:staticmethods fixes Change-Id: If6998c302cfbabfcad626d9c68d94d3368548a41 Reviewed-on: https://gerrit.libreoffice.org/63808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-21weld SwCondCollPageCaolán McNamara3-6/+6
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21loplugin:redundantfcast improvementsNoel Grandin7-14/+14
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21add test for tdf108022Markus Mohrhard2-0/+14
Change-Id: I00868938738e30afc2b212c01ed36d5223401ceb Reviewed-on: https://gerrit.libreoffice.org/63683 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-19weld TreeViewCaolán McNamara3-16/+31
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen6-0/+6
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-19add test for tdf#104579Markus Mohrhard2-0/+16
Change-Id: I62112a2aa0eac6aaa78fdadabfc4439f2a66e6df Reviewed-on: https://gerrit.libreoffice.org/63542 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-18tdf#102186, add test for deleted data labelsMarkus Mohrhard2-0/+31
Change-Id: Ie4849b62f96cf6829aa845997bbc9647d94f4dbb Reviewed-on: https://gerrit.libreoffice.org/63514 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-18tdf#94231 OOXML Import: Fix disappeared Hatch Background ColorBalazs Varga2-0/+20
With adding the PROP_FillBackground property to spnCommonPropIds and spnFilledPropIds the hatch background color imported correctly, an will not disappear. Change-Id: I56745179236d2912a2d5c8585098e54acc4e3062 Reviewed-on: https://gerrit.libreoffice.org/63069 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-17Adapt to C++2a char_tStephan Bergmann1-1/+1
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16loplugin:buriedassign in sd..writerfilterNoel Grandin1-1/+1
Change-Id: I954c12d9e1c493be6ac8c7b15076077b5bff5b74 Reviewed-on: https://gerrit.libreoffice.org/62811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16tdf#114179: Custom size and position of the chart wallJozsef Szakacs3-0/+46
By Xlsx files, rChartSize is using the Values that it gets from getChartSize(), this is the same Size as rPageSize. By Docx files rChartSize was a negative number everytime, so the calcAbsRectangle Method gave back a 'false' Value because of this. The rPageSize shows at every Debugging, Width = 16000, and Height = 9000 for Docx files, and beacause rChartSize was equal to rPageSize by Xlsx, I tried rChartSize with this Fixed Size. Change-Id: Ia29fa3401475c33c1b5e3dde9c3cb030a02cceb4 Reviewed-on: https://gerrit.libreoffice.org/62991 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-16Resolves: tdf#121246 crash in chart dialogsCaolán McNamara6-589/+475
Change-Id: I3bc720e44f5ea15749e6bc0f0fada3a17a783e23 Reviewed-on: https://gerrit.libreoffice.org/63463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-16loplugin:staticmethods improvementNoel Grandin2-2/+2
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755 Reviewed-on: https://gerrit.libreoffice.org/63434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-15Resolves: tdf#121341 weld TrendlineTabPageCaolán McNamara5-260/+228
Change-Id: I8ecc1901388986bd6a3822e8d0055e48d873586c Reviewed-on: https://gerrit.libreoffice.org/63387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-14move fmtfieldCaolán McNamara4-4/+4
Change-Id: Ic3f4388ea2ca92d9e97d4a9e066eea07c7de79e5 Reviewed-on: https://gerrit.libreoffice.org/63363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-13loplugin singlevalfields improvementNoel Grandin2-6/+3
checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski1-1/+1
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11cppCheck redundantAssignment variable bUseCustomLabelZdibák Zoltán1-2/+1
Change-Id: Ic900d5116fd1cf5a90526078c6e4802f09589aa7 Reviewed-on: https://gerrit.libreoffice.org/63253 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-11cppCheck redundantAssignmentZdibák Zoltán1-5/+2
Change-Id: Ib9203fa65d7b9825b0a7181dcfc0f522bc575541 Reviewed-on: https://gerrit.libreoffice.org/63242 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai1-1/+1
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski3-24/+8
Change-Id: I0b3c407331bfa1fa0c5003250d327d4f26de3643 Reviewed-on: https://gerrit.libreoffice.org/63235 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-09tdf#42949 Fix IWYU warnings in chart2/source/controller/dialogs/*hxxGabor Kelemen35-81/+111
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie6fb9f03f36d71e7b07ef70238d969db65121c8f Reviewed-on: https://gerrit.libreoffice.org/61506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-11-09Simplify and fix Java UNO API test makefilesJan-Marek Glogowski1-18/+1
Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski3-21/+21
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-08loplugin:constantparamNoel Grandin1-13/+13
Change-Id: I593ccc2fb43321caf3ff64d0c348b1bac742ad18 Reviewed-on: https://gerrit.libreoffice.org/63025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-07move SvTreeListBox to vclCaolán McNamara5-6/+6
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-07tdf#121205: Convert <a:br> to newline chars in chart titleVasily Melenchuk2-0/+16
Change-Id: I43d14025c48878c5bc035d492623f4fc52426e5e Reviewed-on: https://gerrit.libreoffice.org/62752 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-06loplugin:collapseif in accessibility..cuiNoel Grandin2-10/+4
Change-Id: I1437b493f3289b4ac97d061bd71973580571e792 Reviewed-on: https://gerrit.libreoffice.org/62933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-05Removed executable permission on xlsx and odt fileAndrea Gelmini1-0/+0
Change-Id: I59d9864e4fbf84ed98764db03b2f24703c7c9352 Reviewed-on: https://gerrit.libreoffice.org/62903 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 23:42:38 +0000