path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2018-12-03tdf#42915, NaN in a date axis can destroy the whole chartMarkus Mohrhard3-0/+15
The NaN value forces the scaling of the axis to be based on years and introduces gaps in the rendering. Change-Id: I78219be289d76edb53b5672209e1c031ab62def9 Reviewed-on: Tested-by: Jenkins Reviewed-by: Markus Mohrhard <> related tdf#42915, pass NaN through date transformation Many places in chart2 use NaN to mean no available value. Not propagating NaN through the helper disables all this functionality. Change-Id: I37f966007b5b7cc16778c5c6903710fbd144631b Reviewed-on: Tested-by: Jenkins Reviewed-by: Markus Mohrhard <> Reviewed-on: (cherry picked from commit 55c5382591305a872b961d54571e3c823728ccb2) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-11-27Put text label outside of the pie if..Tamas Bunth1-1/+12
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: Tested-by: Jenkins Reviewed-by: Tamás Bunth <> (cherry picked from commit 3339c730f8c9a6088a2e8b335185f1bf0b232216) Reviewed-on: Reviewed-by: Andras Timar <>
2018-11-08tdf#121205: Convert <a:br> to newline chars in chart titleVasily Melenchuk2-0/+16
Change-Id: I43d14025c48878c5bc035d492623f4fc52426e5e Reviewed-on: Tested-by: Jenkins Reviewed-by: Katarina Behrens <> (cherry picked from commit 57d4cd80dcaf01fe4897d79d89e906d355410243) Reviewed-on: Reviewed-by: Thorsten Behrens <>
2018-11-05tdf#108104 OOXML Import: Fix Hatch fill in ChartsBalazs Varga2-0/+24
Sets an explicit fill hatch, or creates a named fill hatch and stored in a global container. With this patch the SUPPORTED MS Office hatch styles by LibreOffice, or the custom LibreOffice hatches will be appeared correctly instead of the previous display as horizontal lines in LibreOffice. (The background color of the hatch styles are not imported correcty, but that is another BUG.) Change-Id: Ifda9dc805dd08f58db10b35f40d7f511a8614f77 Reviewed-on: Tested-by: Jenkins Reviewed-by: Miklos Vajna <> Reviewed-on: Reviewed-by: Andras Timar <>
2018-10-17Resolves: tdf#115182 default Chart percentage format is integerEike Rathke5-50/+54
Regression from commit 0f4b3cb7d3d68906de316a64dcec281da2a641bd CommitDate: Mon Aug 10 17:12:45 2015 +0200 The chart2/qa/extras/xshape/data/reference/tdf90839-?.xml reference files were created with the then wrong default of two decimals so need to be adapted. For chart2/qa/extras/xshape/data/reference/tdf90839-1.xml this meant to regenerate because of the changed positions and sizes of labels. Change-Id: Ib0c2c862af9399ab2af5178d01510aa5e4fff97c Reviewed-on: Tested-by: Jenkins Reviewed-by: Eike Rathke <> (cherry picked from commit 9672d034b9e760f24ac9a6652ab45dee15ee260a) Reviewed-on: Reviewed-by: Andras Timar <>
2018-10-11tdf#120387 get lock to use ImpEditView::CutCopyJan-Marek Glogowski1-38/+23
ImpEditView::CutCopy releases the SolarMutex to handle clipboard access. So lock the SolarMutex when accessing this function through OutlinerView::Copy(). Now all paths effectively need the SolarMutex, so remove all the intermediate locking. I guess the explicit release for the test isn't needed. Change-Id: Ib2a69a520bbf0ef7ba4ccb893c6489b292207f2a Reviewed-on: Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <> (cherry picked from commit c11ee0f7b0e4e7bf4d1e2e5bb4309f24b917ce79) Reviewed-on: Tested-by: Xisco Faulí <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-10-04tdf#120015, don't crash without major tick marksMarkus Mohrhard1-0/+4
Change-Id: Icac79eb1c0c47388f96d37d2921c81fb6c848607 Reviewed-on: Tested-by: Jenkins Reviewed-by: Markus Mohrhard <> (cherry picked from commit 217cb86dd06f0c539d6181d9b7fd0d71c4edd628) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-09-25tdf#119922, sanitize the point count when extrapolate is usedMarkus Mohrhard1-0/+2
Change-Id: Iec5e591f51ab13efa4b014b82df213e91eb5b793 Reviewed-on: Tested-by: Jenkins Reviewed-by: Markus Mohrhard <> (cherry picked from commit e206a3b40083729fd57502f33e49fa30e54ac8e6) Reviewed-on: Reviewed-by: Noel Grandin <>
2018-09-17SOSAW080: Derive SdrObjGroup from SdrObjListArmin Le Grand4-11/+8
Also simplify parent/child relationships, get rid of double data (SdrPage/Parent infos in SdrObjects, also in SdrObjList). This is all not needed - when a SdrObject is inserted to a SdrPage, get SdrPage by traveling over parents (no double info, member as soon as inserted, ...). More cleanups/reworks included, will need some more cleanups, too. Stabilizing: SetRectsDirty/DefaultStyleSheet Had to correct the SetRectsDirty stuff for 3D due to going down the hierarchy while the 2D implementation goes the other direction -> endless loops. Added special handling for 3D stuff for now (will be chnaged again when SnapRect is no longer needed at SdrObject level). Also had to adapt how the DefaultStyleSheet is set at incarnated SdrObjects - better: their properties. Since we now always have a SdrModel, it is possible to correctly initialize with the correct default StyleSheet from that SdrModel. This needs to be done after ForceDefaultAttributes and in a way that again deletes Items that are set in the StyleSheet. This leads to an error in CppunitTest_sd_import_tests where I checked tdf100491 - it is okay and thus I change the control instance of the imported, XML-dumped file. The less hard attributes, the better for Styles in general. Cleanup of comments for last two commits Corrected SvxShape::getParent() Needed to get the direct parent, so test for SdrObject first (to get SdrObjGroup/E3DScene), for SdrPage second Fixed CppunitTest_sc_subsequent_export_test Several problems arose. The used SdrCaptionObj was Cloned, but the clone not inserted to a SdrPage. This leads to not being able to access a UNO API imlementation of the SdrPage (SvxPage) on lower levels. It worked before due to SdrObject having a SdrPage* additionally to being added to a SdrPage - this is exactly the main cleanup this change does. Looked for why it is cloned, could see no reasons. The SdrCaptionObj exists during all im/export, not difference to other SdrObjects (that do not get cloned). It is not changed in any way. It *might* be to suppress a crash that happened due to UNO API Service emfio/emfio not being available in the UnitTest scenario. Interestingly it did not crash with the cloned SdrCaptionObj, but the Graphic exported was probably wrong. Fixed by no longer Cloning the SdrCaptionObj and adding emfio/emfio UNO API Service. d139f821a5b39535a3e7b9c6261df7e18f8ae8ac 910e7f4bc628a715fda7545dffaf3369d5e76ea0 ca1de01b723051e09ac37d7ec7bba978beea41c5 3a76da1471dfe75e69847f64a6a3519ad21c8c9c Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Armin Le Grand <> Reviewed-on: Tested-by: Jenkins
2018-09-14tdf#108028 OOXML: Fix line breaking of chart titleBalazs Varga1-0/+1
With adding the "TextMaximumFrameWidth" property to the chart title's textbox property, it breaks chart titles longer then the chart width, as in OOXML reference implementation. LibreOffice previously distorted the text and squeezed the chart. This patch will fix it. Change-Id: Ic086d25b49e9c5cf9c6f2c79f141592749adc7d8 Reviewed-on: Tested-by: Jenkins Tested-by: László Németh <> Reviewed-by: László Németh <> (cherry picked from commit 063e92004b65411dbee7fc12ab00c78aa9c69a86) Reviewed-on: Reviewed-by: Xisco Faulí <>
2018-08-23tdf#94502 Fix overlap export of Stacked Bar Chart to *.xlsxBalazs Varga2-0/+23
Export the Overlap value with 100% for stacked charts, because the default overlap value of the Bar/Column chart is 0% and LibreOffice do nothing with the overlap value in Stacked Chart case, unlike the MS Office. Change-Id: If4e20b88c2b1180f68a8d2b610c407d674a8498b Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Jenkins (cherry picked from commit 17c2b0af97f73b9103be982b15d7111b3980e027) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-08-23Resolves: tdf#98558 oom under windows with certain chartsCaolán McNamara1-1/+14
keep the performance fix of i#66963 but clip it to a value larger than appears in that document, but massively smaller than what is necessary for this document Change-Id: I162c03a13ce11e348db8168fed212dfea216c7a4 Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Jenkins
2018-08-14Resolves: tdf#117069 crash double clicking in certain chartCaolán McNamara1-0/+3
Change-Id: I4506a3517eff7f73cf793195e9d605d450b84fda Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Jenkins
2018-08-10tdf#96469 Export Data Point properties in Charts on DOCX/XLSXBalazs Varga3-0/+40
If the color or other property of a datapoint in the chart deviates from the dataseries property, this patch will write it into a separate dPt tag and fixing the lost properies during OOXML export. Change-Id: I3d975675ac3691fcafe76de16e46851561eb2807 Reviewed-on: Reviewed-by: Bartosz Kosiorek <> Tested-by: Jenkins
2018-08-03forcepoint#60 FPECaolán McNamara1-0/+2
Change-Id: I7de20dce834d4c41531487d79071db47e9260e73 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
2018-08-02tdf#119029: also export rotation for data seriesMike Kaganski2-0/+14
Change-Id: I6a9895145e0c54d35bf404f209721a0c718e4446 Reviewed-on: Tested-by: Jenkins Reviewed-by: Mike Kaganski <> (cherry picked from commit 8f90492812d1edac6c91e83b84f3512877dcd552) Reviewed-on: Reviewed-by: Andras Timar <>
2018-07-31tdf#108078 OOXML Export Chart shapes area fill propertiesBalazs Varga10-0/+102
Verified with color, gradient, bitmap for: Chart Title in DOCX, XLSX and PPTX. Also verified with gradient, bitmap for Chart Legend, Plot Area, Dataseries and Background in DOCX, XLSX and PPTX. Change-Id: I15d29f3ca2d75f45f612766b635d50a29d8551ae Reviewed-on: Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <> (cherry picked from commit 051399740e41c6495ed362e78c63e0868bcd180c) Reviewed-on: Reviewed-by: Balazs Varga <>
2018-07-10tdf#118314 menubar: remove ShowImeStatusWindow in menubarsandreas kainz1-2/+0
Function isn't available any more. codebase has to be cleanded up Change-Id: I42597cde5b5d2472f670552f49776775d5bf391e Reviewed-on: Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <>
2018-07-04tdf#115945 oox export: data label writeRunPropertiesJustin Luth1-0/+1
DataLabel font was always returning to the default - black. Change-Id: I6c72a8daa699394b36f69fc54e0ba042f0255c18 Reviewed-on: Tested-by: Jenkins Reviewed-by: Justin Luth <> Reviewed-by: Szymon Kłos <> (cherry picked from commit ae2fd281e046b2199ef44777b84518cd3abb2952) Reviewed-on: Reviewed-by: Christian Lohmaier <>
2018-06-21move SvColorDialog to welded argumentsCaolán McNamara1-2/+2
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: Tested-by: Jenkins Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-06-15menubar: sync chart2 menubarandreas kainz1-12/+4
Change-Id: Iadc905916c0b6437eec8cc19ce838719c16a44d0 Reviewed-on: Reviewed-by: Heiko Tietze <> Tested-by: Jenkins (cherry picked from commit 46c3083943f7dc8bf9529ca498d37593bad81a31) Reviewed-on:
2018-05-31tdf#117864 TransferableHelper::GetSystemClipboard requires a focus windowCaolán McNamara2-1/+6
Change-Id: Ibd9b9218cf12e80db1fc9a70bdbab38d3df950f7 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-29weld SvxTransformTabDialogCaolán McNamara2-2/+3
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-23toolbar:id is not valid attribute of toolbar:toolbarChristian Lohmaier8-8/+8
according to framework/dtd/toolbar.dtd – and having the same ID everywhere also is kinda pointless.. Change-Id: Ia7768be2f951886e39e24d78fc6d69b4f3c84235 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Christian Lohmaier <>
2018-05-22lok: charts context menu was misplaced + wrong LogicToLogic conversionMarco Cecchetti1-0/+14
Chart context menu was misplaced since the context menu expects a position related to the document window not to the chart window. Moreover map mode is not enabled for chart window, that leads to use the LogicToLogic routine which unfortunately provides a wrong pixel to twips conversion. In fact we gets a 20 twips per pixel conversion since LogicToLogic uses a fixed 72 dpi value, instead of a correctly computed output device real dpi or at least the most commonly used 96 dpi value. Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <> Reviewed-on: Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Marco Cecchetti <>
2018-05-22loplugin:unusedfields in avmedia..comphelperNoel Grandin19-63/+9
Change-Id: I74f125103b67c506d9bb67537e4c4cd3f8f871da Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-05-21weld SchAxisDlgCaolán McNamara7-76/+74
Change-Id: I18441b4fc06b69caf12dc73e5042ad2b609a7cc5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-21weld SplinePropertiesDialogCaolán McNamara2-67/+49
Change-Id: I1df0f2bce86da698205c5b36217f935e0e971de5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-16tdf#117596 set the size for Asian and Complex char height tooTomaž Vajngerl1-0/+2
Change-Id: I703fc4d1cf34747d924a7fa44913a4bfe9bff67b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2018-05-14loplugin:redundantfcastStephan Bergmann1-1/+1
Change-Id: I412eb9530e4b10281c505c07f0c18a4220e2cba9
2018-05-14tdf#113688: Pattern fill can be set from sidebar nowKatarina Behrens1-4/+27
Change-Id: I877dd2610aadd1b0118cdb6928a8473af1dc4c73 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <>
2018-05-08tdf#116977 secured ::Clone methodsArmin Le Grand2-2/+4
Renamed SdrPage::Clone -> SdrPage::CloneSdrPage Renamed SdrObject::Clone -> SdrObject::CloneSdrObject Giving SdrModel is no longer an option, but a must (as reference). This makes future changes more safe by force usage to think about it. Also equals the constructors which already require a target SdrModel. Done the same for ::CloneSdrPage. Change-Id: I06f0129e15140bd8693db27a445037d7e2f7f652 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Armin Le Grand <>
2018-05-04Removed executable permission on data filesAndrea Gelmini1-0/+0
chmod -x for doc, xlsx, png, hxx, cxx, xls, ppt, hpp Change-Id: I52aed261e318cfd765e9adb3ed8edd226c8a59d8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Thorsten Behrens <>
2018-05-03weld SvxTextTabDialogCaolán McNamara1-1/+1
Change-Id: I2a48230d38fbc3c7d3e1e3b3ad43d4b17f48ed16 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-05-03[API CHANGE] revert SymbolBitmapURL impl, add SymbolBitmap propertyTomaž Vajngerl2-1/+52
This adds back the implementation for setting the SymbolBitmapURL property (getting returns an empty string) and adds SymbolBitmap property to the UNO API (LineDiagram.idl). SymbolBitmapURL property was already deprecated, but we still need to add the SymbolBitmap for compatibility. [ Miklos Vajna: updated qadevOOo tests to handle the new write-only properties. ] Change-Id: Id00d78299b7fd5ba9d78c36c5f03a10d9e61c60a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2018-05-03loplugin:useuniqueptr in SdrDragMethodNoel Grandin1-1/+1
Change-Id: I73411368b55d53e83f45e0347663036f1f72c066 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-05-02Fix typosAndrea Gelmini1-1/+1
Change-Id: I56bd1a7ac204f4302261e46d0b8c5dd62c4b6df9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Bartosz Kosiorek <>
2018-04-26[API CHANGE] deprecate XGraphicObjectResolverTomaž Vajngerl3-31/+33
XGraphicObjectResolver was used to get the GraphicObject URL from an storage (package) URL. This isn't possible anymore in LO 6.1 since creating GraphicObject from uniqueID was removed for its lifecycle issues. XGraphicObjectResolver is now deprecated and when the "resolveGraphicObjectURL" is called, it throws a RuntimeExeption. In places where XGraphicObjectResolver was used, we now use the XGraphicStorageHandler as the alternative. Both share a common implementation so previously we could cast one to the other at any time. Now only XGraphicStorageHandler is used. GraphicObjectResolver was removed and replaced by the alternative GraphicStorageHandler for instance creation - where needed. Change-Id: I5d3f759c6f95b7dbe2d93688d99c8aa4899ffa84 Reviewed-on: Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <>
2018-04-25SvTabListBox::SetTabs, pass count explicitNoel Grandin1-2/+2
passing count as first element in array, dodgy. Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463
2018-04-24Revert "work around clang-cl ABI bug PR25641"Stephan Bergmann1-3/+0
This reverts commit 81ce629c9e8a4fc26ded9d49157e3f3263991e03, now that <> "clang-cl: vtordisp thunks not emitted for functions with class template specializations in their signatures" is fixed.
2018-04-22place an intermediate class as parent for SfxTabPagesCaolán McNamara22-36/+36
so a SfxTabPage can be parented by a vcl::Window or a welded native notebook tabpage. That ways the same SfxTabPage can be used at the same time in both a native dialog or a vcl dialog. The impl can be changed to the weld api, and when hosted in a native dialog the vcl impl of that will be instantiated, while native otherwise. e.g. print options appearing in print options dialog and general options. This allows incremental changeover. Change-Id: I6f1fed1e8d0898b01853bb878757bad41cbf9bba Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-04-17loplugin:constparamsNoel Grandin1-1/+1
Change-Id: I3d1b88dbd0ff73fddc08d52f50e0efb42daab89b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-16Take care of E3DObjListArmin Le Grand1-1/+1
E3DObjList is not needed, remove. Remove memeber from E3DObject, derive E3DScene directly from SdrObjList, some cleanups in SdrObject, too Change-Id: Ifa4620a800c14faf21f8b80fd4dc1d39f71be804 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Armin Le Grand <>
2018-04-15remove some unused comphelper includesJochen Nitschke26-15/+11
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Jochen Nitschke <>
2018-04-14look for check buttons without underlinesCaolán McNamara7-0/+27
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-04-14look for radio buttons without underlinesCaolán McNamara5-0/+9
Change-Id: I0ed97515a03a5633628a492ec7797fc3ade8a3d8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-04-13Remove XGraphicProvider imports where they aren't neededTomaž Vajngerl1-2/+0
Change-Id: Ie4da74e7d58d49aa870a70c4279cbab22f0f7746 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2018-04-11new loplugin:unusedvariablemoreNoel Grandin1-2/+0
collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-04-09tdf#104658: Fix jumping bitmap-filled chart barsKatarina Behrens1-1/+6
Coincidentally this also resolves almost identical issues in chart wall (tdf#114132) Change-Id: Ib566110639d00aa46463ee592861ce3e15c64f50 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Katarina Behrens <>
2018-04-09use more DBG_UNHANDLED_EXCEPTIONNoel Grandin111-627/+736
so we get nice logs of the exception dynamic type for UNO exceptions. Change-Id: Ic0b10dc14d354a2c9a0591b3a51d2f1640d54bdb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>