summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2016-10-25Avoid further crash with empty Chart documentStephan Bergmann1-0/+3
following up on 8b5f8c26f007c8e67bc46b1b09340cae660d0b8b "Avoid crash with empty Chart document", when you then close the Writer doc (discarding the changes), it crashes in a chart::sidebar::ChartSidebarModifyListener::disposing call whose mpParent (that was a ChartElementsPanel) is already destroyed. The problem is that the ChartElementsPanel ctor creates an mxListener pointing to this, then calls Initialize, which calls xBroadcaster->addModifyListener(mxListener) and then, during updateData, throws a RuntimeException when xDiagram is null in getChartType, causing the ChartElementsPanel object to immediately be destroyed, but the listener still registered. This apparently needs fixing independently of the immediate problem. (The immediate problem is a regression introduced with d7748842e96536daeb0c638c6f8d01d99b9a3e08 "hide grid and axes options in chart elements if not supported, tdf#94297".) Change-Id: I2fe4f2a59600664f6210456c65e033f9453f4cc9 (cherry picked from commit 429e4dc671f03e0c4d50e8f8aa055f4aaca761da) Reviewed-on: https://gerrit.libreoffice.org/30147 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-25Avoid crash with empty Chart documentStephan Bergmann1-0/+3
In a fresh Writer document, "Insert - Object - OLE Object... - Create new - LibreOffice 5.3 Chart - OK", then left-clicking into the empty Chart are, caused an unhandled (or rather, handled by desktop's FatalError) RuntimeException since 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320". (cherry picked from commit 8b5f8c26f007c8e67bc46b1b09340cae660d0b8b plus c5feb9ad79c9c830ca824e29277ff41c5cc24e7d "Minor improvement of previous commit") Change-Id: I7ff53a84e4b06b20409d09e6010bac80e5a7c4b2 Reviewed-on: https://gerrit.libreoffice.org/30139 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara3-4/+4
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-19tdf#94004 Wrap Power trendline equationLaurent Balland-Poirier2-14/+37
Wrap equation trendline if it is longer than chart width Continue https://gerrit.libreoffice.org/18397/ Change-Id: If805f712a29c412a01209533842f9a6c797cbaf1 Reviewed-on: https://gerrit.libreoffice.org/25418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit e420a335f783bb4d2ee9d74d56f91e16d189566f) Reviewed-on: https://gerrit.libreoffice.org/26119 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-06-19tdf#94004 Wrap Logarithmic trendline equationLaurent Balland-Poirier1-23/+49
Wrap equation trendline if it is longer than chart width Continue https://gerrit.libreoffice.org/18397/ Change-Id: Iee374e5db56178a9e87b0f462c3e7deb5e913ab8 Reviewed-on: https://gerrit.libreoffice.org/25416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 4d636391e3e588779c88c566ac7df5fd1990afea) Reviewed-on: https://gerrit.libreoffice.org/26118 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-06-19tdf#94004 Wrap Exponential trendline equationLaurent Balland-Poirier2-19/+52
Wrap equation trendline if it is longer than chart width Continue https://gerrit.libreoffice.org/18397/ Change-Id: I3938aaeec6c56582ecfe50dbfc54ec711f1b963d Reviewed-on: https://gerrit.libreoffice.org/25393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit 9a9c778d81e8ae54dcc42290241a5fc72be29bf2) Reviewed-on: https://gerrit.libreoffice.org/26117 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-06-07only init the OpenGL context if we need itMarkus Mohrhard2-1/+5
Reviewed-on: https://gerrit.libreoffice.org/26023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 78b100ec9cb0db2f7b33ece5ad3287a67a37246f) we also need to set initialized falg for deferred initialization Change-Id: Ia88a1720d204b9933f1476bd703b99180e45abde Reviewed-on: https://gerrit.libreoffice.org/26031 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-27Typo fixTor Lillqvist1-1/+1
Change-Id: Ibf279e723c11a4a5f62ce082938e723a46e40f6d Reviewed-on: https://gerrit.libreoffice.org/25540 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-25Fix typosAndrea Gelmini1-2/+2
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22tdf#94004 Trendline: wrap equation to fit in chart areaLaurent Balland-Poirier16-109/+248
If equation is too long compared to chart width: equation is wrapped and if equation has General format, the number of digits is reduced In this patch, only polynomial equation is treated. If this approach is ok, I will extend to other regression curves. Conflicts: chart2/source/view/charttypes/VSeriesPlotter.cxx Change-Id: I1bfd897881d752655faec6df034c0dde7f78c51b Reviewed-on: https://gerrit.libreoffice.org/18397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-18convert TAB to scoped enumNoel Grandin1-2/+3
and rename the SID constant to something more meaningful Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676 Reviewed-on: https://gerrit.libreoffice.org/24986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin8-179/+2
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin1-1/+1
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17avoid assertDavid Tardon1-2/+7
Change-Id: I60ea0f29226d12e98ed88716d092d7f9f7df184f
2016-05-16stop right away if there are no pointsDavid Tardon1-0/+2
Change-Id: I099db29c066392f53935f78f62c122f7176aaea2
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-16parseExport only needs to export filesMarkus Mohrhard2-2/+10
This saves about 50% of the chart2export test time as we no longer import files that we will never need. Change-Id: I7ddbae9e8b3194d10e2c25b59cfdd2fa5d345b9d Reviewed-on: https://gerrit.libreoffice.org/25023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara1-0/+1
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-13tdf#35957 check for preconditions earlierDavid Tardon1-2/+7
This cuts the number of calls of chart::VSeriesPlotter::calculateYMinAndMaxForCategory from ~10 billion to 1760 and load time from a minute to a second... Change-Id: I8ec07d82aa0e915659ce4cbdf6cd1bdd381d6245
2016-05-10Missing break in switchStephan Bergmann1-0/+1
First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM falling through to the default break case. Then 14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines, tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE, OBJECTTYPE_DATA_AVERAGE_LINE block in between. Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann2-1/+3
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin1-1/+1
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-08tdf#92768 Support hiding title objectsFeyza Yavuz3-3/+52
Change-Id: I879fc3d81a8fe8ca2f928305f5dc7fd9ebcfd294 Reviewed-on: https://gerrit.libreoffice.org/24564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-04-Werror=maybe-uninitializedThorsten Behrens1-1/+1
Change-Id: Id516aa921d13ff5c0085fb9cf76fefd56acb31ad
2016-05-04use Any constructor instead of temporariesNoel Grandin3-12/+4
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-30Fix typosAndrea Gelmini1-2/+2
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30tdf#92768 Support hiding title objectsFeyza Yavuz1-0/+10
Change-Id: I34723ab353fbced5eb339fb0afbcb0677b3eadd4 Reviewed-on: https://gerrit.libreoffice.org/24517 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin13-34/+34
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27-Werror,-WvarargsStephan Bergmann1-3/+2
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just drop the variadic overload and use the one taking a WizardPath (i.e., a vector) Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-27tdf#99518 Use correct decimal separatorLaurent Balland-Poirier1-6/+21
Change-Id: I39169e7c7344fcfd594a0e0d2ab0a762cc3d5829 Reviewed-on: https://gerrit.libreoffice.org/23961 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann4-24/+24
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
2016-04-25the container document commands std::set can be staticNoel Grandin2-7/+6
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
2016-04-25no need to copy the list of available commands on every callNoel Grandin2-3/+4
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25Kill comphelper::MakeMapStephan Bergmann29-524/+465
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823 Reviewed-on: https://gerrit.libreoffice.org/24344 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25Kill comphelper::MakeSetStephan Bergmann2-62/+60
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3 Reviewed-on: https://gerrit.libreoffice.org/24343 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-24C++11: disable ctors instead of not implementing them (chart2)Jochen Nitschke7-18/+7
replace the old declare and don't implement pattern with C++11 delete keyword Change-Id: I10b14cece4ecaddc5f96ee098b5fa36a8782a0fc Reviewed-on: https://gerrit.libreoffice.org/24340 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24Kill comphelper::MakeVectorStephan Bergmann1-19/+12
Change-Id: I6525f9189b25f007d3ffd190b37c73552a900de2 Reviewed-on: https://gerrit.libreoffice.org/24341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-22Fix typosAndrea Gelmini1-1/+1
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin11-119/+97
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-21new plugin stylepoliceNoel Grandin9-74/+74
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann41-120/+120
Change-Id: I1230a1785c61b8ef5dab97176e7c06600ac95a5b
2016-04-20Remove redundant comparison against sal_FalseStephan Bergmann1-2/+2
Change-Id: I6e5e5d730a8e7e3efc50472db08d0ed258ffbb3a
2016-04-18Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I207203433b6300dda662c2c0b5c1d9e167c1c4c6
2016-04-18cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Iee9d28c9630a144e4da8e46e58f01a4be99aa961
2016-04-18clean-up: unused using declarations and includesJochen Nitschke47-65/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar9-49/+17
Removed OSL_DEBUG_LEVEL > 1 conditionals to reduce the problem of multiple debug levels Change-Id: I453f74198e08308c3891e923ebaee58a276e34ad Reviewed-on: https://gerrit.libreoffice.org/22616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-14loplugin:passstuffbyref in chart2Noel Grandin30-58/+57
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
2016-04-12Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I8590b2c145a536872d692afcaa50279c99b3f974
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 21:43:14 +0000