summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2018-03-22tdf#116163 import testSzymon Kłos1-0/+97
Change-Id: Ie4fd1142e1111e4968941a639a265d169aaa6413 Reviewed-on: https://gerrit.libreoffice.org/50814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50926 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-22tdf#116163: Limit label height in chart if neededSzymon Kłos12-4/+76
Change-Id: Ia84fd0c3b76886bc6124dc3b59035465aa31b020 Reviewed-on: https://gerrit.libreoffice.org/50700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50913 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115859 Export number format for chart seriesSzymon Kłos2-0/+12
Change-Id: I65d30c6b92a530eadbd6fabe87fa8bd3416fee20 Reviewed-on: https://gerrit.libreoffice.org/50392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-27tdf#114173 Preserve size of chart legend during xlsx exportBartosz Kosiorek1-0/+15
This is a combination of 2 commits. tdf#114173 Preserve size of chart legend during xlsx export During export chart into .xlsx file, the information about size of legend was not saved. Example of proper size: <c:w val="0.41459448854442293"/> <c:h val="0.23161616722845749"/> another issue was hardcoded "layoutTarget" which was always "inner": <c:layoutTarget val="inner"/> also properties regarding default text style was not preserved: <c:txPr> <a:bodyPr/> <a:lstStyle/> <a:p> <a:pPr> <a:defRPr sz="900" b="0" i="0" u="none" strike="noStrike" kern="1200" baseline="0"> <a:solidFill> <a:schemeClr val="tx1"> <a:lumMod val="65000"/> <a:lumOff val="35000"/> </a:schemeClr> </a:solidFill> </a:defRPr> </a:pPr> <a:endParaRPr lang="pl-PL"/> </a:p> </c:txPr> With this patch all these issues was resolved, and in case of layoutTarget "outer", the field is not availble at all, according to specification. Change-Id: I2c9b7a112bdd911542b5273e660222d7fefa2d88 Reviewed-on: https://gerrit.libreoffice.org/47358 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 84392651d2731cce91c3b2e144bed4ac07e4ddf1) crashtesting: multiple export failures since... commit 84392651d2731cce91c3b2e144bed4ac07e4ddf1 Date: Wed Jan 3 23:27:16 2018 +0100 tdf#114173 Preserve size of chart legend during xlsx export Change-Id: Iebc936a0f490d6b707dfee0343732753f56728e7 Reviewed-on: https://gerrit.libreoffice.org/48147 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fa68bed11c180ebb0d45fb7779d538098b2921ff) Reviewed-on: https://gerrit.libreoffice.org/48153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/48726
2018-01-07tdf#108031 Area chart labels not rotatedJochen Nitschke2-24/+23
This fixes recognition of x-axis or y-axis when the coordinate system is rotated (3D-view). So the labels are rotated correctly. Change-Id: Iaacfec943f3885c58e99a55585714a79f1d0d9d5 Reviewed-on: https://gerrit.libreoffice.org/38355 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> (cherry picked from commit 38bf5f69663f64434a3a0a74e02c1a23f876b677) Reviewed-on: https://gerrit.libreoffice.org/47016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-03prevent crash when trying to edit broken chart documentsMarkus Mohrhard1-0/+6
Change-Id: Ie5fb706011ca600b42e5e2d3770e919b56347edd Reviewed-on: https://gerrit.libreoffice.org/46938 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1d2eb0b64339a771152bb17831c83373830e5c38) Reviewed-on: https://gerrit.libreoffice.org/47005 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-11-09Fix chart dump test recent failures on MACTamás Zolnai1-1/+1
Change-Id: I066ecea1e32cec10696dab3a3e4fac78894088a2 Reviewed-on: https://gerrit.libreoffice.org/42420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 3c1f44c91091205512098bb4f1d56333c20a1f8b) Reviewed-on: https://gerrit.libreoffice.org/44543 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-15tdf#112006: the result is different using getFirstSeriesXisco Fauli1-6/+18
Restore the old code and use c++11 for-statement Change-Id: If85793d03fc9f022a938bcd365c605a7ddac2720 Reviewed-on: https://gerrit.libreoffice.org/42031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 493d10b828ec475f63d399a98ba9b55b9766ee25) Reviewed-on: https://gerrit.libreoffice.org/42045 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-28tdf#62363: When pie chart sector is too small do "Outside" placementDennis Francis1-2/+10
...of its label when "Best fit" label placement setting is used. Change-Id: Id201d922505de0e134286f4772abe282bb0722bc Reviewed-on: https://gerrit.libreoffice.org/41572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 8c8edfabdee656ac5a9a0b1106f90baf315f1dd4) Reviewed-on: https://gerrit.libreoffice.org/41621
2017-08-10bug fix: tdf#111173Marco Cecchetti1-4/+7
Mostly based on patch by Julien Nabet: http://bugs.documentfoundation.org/attachment.cgi?id=135107 Thanks Julien! Change-Id: I02440be7dfa5881e5bf63710a9d3c4f261d00533 Reviewed-on: https://gerrit.libreoffice.org/40877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 05c3791710397346aae0b2a9cca1792567941d62) Reviewed-on: https://gerrit.libreoffice.org/40898 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-09tdf#109858: Override default point label placement setting...Dennis Francis2-0/+15
with series label placement setting if available while importing xlsx chart. Adds unit test in chart2import.cxx that asserts one of the point label setting in the bugzilla xlsx document. Change-Id: I8bc04fd569f94a19633666ffdc51b61ac719e8a9 Reviewed-on: https://gerrit.libreoffice.org/40860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk> (cherry picked from commit 70944a849dc59fa686e3f316a3983dbc8a47017f) Reviewed-on: https://gerrit.libreoffice.org/40861 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-08Resolves: tdf#111087 change names from bmp to pngCaolán McNamara1-1/+1
they are really png in icon-themese and while some fallback code will find the png if they get included in the final zips the zip builder won't include them if the name doesn't match Change-Id: I0f08685403f8e4a92b7661edcbb8b14af1034fea Reviewed-on: https://gerrit.libreoffice.org/40729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-07tdf#109523: Do not forget to remove the chart model from...Dennis Francis1-0/+7
data-provider's listener set when the chart model is getting disposed. Change-Id: Iafbe1426cdb42059cbb4e2955a257a09aa42ec8e Reviewed-on: https://gerrit.libreoffice.org/40663 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9561e0f392de3b99d8a0374486d4c0575b23180b) Reviewed-on: https://gerrit.libreoffice.org/40705 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-08-02tdf#90352: set/handle LinkNumberFormatToSource property in xls...Dennis Francis2-0/+61
Import/Export filter respectively for axis numbers. For ods and xlsx this was already getting set/handled correctly. Also add unit test to assert LinkNumberFormatToSource property and number format for import and export-import roundtrip. Change-Id: Id029ac7d0233ca490a6a00609e9cea8fdafee70f Reviewed-on: https://gerrit.libreoffice.org/40577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit d8e731adb8608aab17385e02f4441ed3122efa40) Reviewed-on: https://gerrit.libreoffice.org/40664
2017-07-27tdf#90510 : Override default point label placement setting...Dennis Francis2-0/+16
with global label placement setting if available while importing xls chart. Added unit test in chart2import.cxx that asserts one of the point label setting in the bugzilla xls document. Change-Id: Id331f56c05873554b22920e02805909c50fb8619 Reviewed-on: https://gerrit.libreoffice.org/40402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 2a4d015ff896dc9e8d2219982da54c51a42482b8) Reviewed-on: https://gerrit.libreoffice.org/40495
2017-07-23tdf#103984 : For bubble charts append data column...Dennis Francis3-1/+24
for "values-size" role too, after parsing in InternalDataProvider::createDataSequenceFromArray(). Without this, embedded bubble charts in documents(MSO) other than spreadsheets will be empty when imported. Also adds docx import chart2-unit-test in chart2import.cxx Change-Id: I63168074b30090a8b7cf977eb5af443f6b9ac240 Reviewed-on: https://gerrit.libreoffice.org/40258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 0bdbd099bb52ae687196e06561e03c5c4d9c90eb) Reviewed-on: https://gerrit.libreoffice.org/40336
2017-07-12tdf#108986 : no arrow for "Data" button on pivot chartDennis Francis7-2/+62
Also changed the fill color of "Data" button to a lighter shade to distiguish it from other buttons, for both row and column fields. Added matching testcase in chart2dump.cxx Change-Id: I2ae5da6c3552372f606da41055f1e0663b6f0802 Reviewed-on: https://gerrit.libreoffice.org/39687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c86be45d343635f2e137b8ea710d87e1a612101d) Reviewed-on: https://gerrit.libreoffice.org/39854 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-12tdf#108921 : Enforce a minimum legend size for pivot charts...Dennis Francis1-6/+14
...proportional to the chart size. This lets a default pivot chart maintain its current size even when there are no data points which may result from a pivot field filter operation. Tried to add a test, but could not with a reasonable amount of effort. Some observations I made when tried to create a unit test: 1. If a new chart is created using uno api fresh from a pivot table, no legend is created irrespective of whether there is data or not. 2. Pivot charts with zero data points work fine with this patch, but on round trip the chart needs to be explicitly refreshed by clicking one of the pivot table's field selectors to make the chart show axis/labels etc. Change-Id: I010ca9093ce94dc216ba06e9d7aedaa412e59401 Reviewed-on: https://gerrit.libreoffice.org/39620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 18909d45977a897cbd921d76d1dde4bf3a466271) Reviewed-on: https://gerrit.libreoffice.org/39799 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-06tdf#108923 : Use display string for generating chart labelsDennis Francis1-15/+97
Use display string for generating chart labels in PivotTableDataProvider::collectPivotTableData as chart2 does not seem to use number format for labels although it does for the data. Added unit test PivotChartTest::testPivotChartWithDateRowField() for this fix. Change-Id: I668d4c9d7cf8bbb7e4213cce7a6e7cd4d7d07cbe Reviewed-on: https://gerrit.libreoffice.org/39548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5eeed755a2eadbadd7a2e0c06216258af028a96e) Reviewed-on: https://gerrit.libreoffice.org/39654 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-06-21only some languages put a space between number and %Caolán McNamara1-4/+4
Change-Id: Ifdd2f2c02738fc9e9b3fd4cbf97b211b29856df1 Reviewed-on: https://gerrit.libreoffice.org/38870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit e89e3ca2a6ab1773a7221eac11cb60812c002005) Reviewed-on: https://gerrit.libreoffice.org/39020 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-06-12Fix typo in queryAggregationStephan Bergmann1-1/+1
...that caused UBSan failure in UITest_calc_demo: > framework/source/services/desktop.cxx:406:47: runtime error: member call on address 0x611000887c80 which does not point to an object of type 'com::sun::star::lang::XServiceInfo' > 0x611000887c40: note: object is base class subobject at offset 64 within object of type 'chart::CreationWizardUnoDlg' > 1a 06 80 29 70 23 e8 c8 5a 7f 00 00 50 87 f0 00 40 60 00 00 48 24 e8 c8 5a 7f 00 00 02 00 00 00 > ^ > #0 0x7f5d62c1413b in framework::Desktop::addTerminateListener(com::sun::star::uno::Reference<com::sun::star::frame::XTerminateListener> const&) framework/source/services/desktop.cxx:406:47 > #1 0x7f5ac78f9337 in chart::CreationWizardUnoDlg::CreationWizardUnoDlg(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:52:15 > #2 0x7f5ac7906cdd in com_sun_star_comp_chart2_WizardDialog_get_implementation chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:368:30 > #3 0x7f5df087ff37 in std::_Function_handler<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:1716:9 > #4 0x7f5df0757dab in std::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:2127:14 > #5 0x7f5df06f69f1 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) cppuhelper/source/servicemanager.cxx:667:13 > #6 0x7f5df07134f2 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) cppuhelper/source/servicemanager.cxx:998:17 > #7 0x7f5df0715d7a in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) cppuhelper/source/servicemanager.cxx > #8 0x7f5d47aca8ca in FuInsertChart::FuInsertChart(ScTabViewShell*, vcl::Window*, ScDrawView*, SdrModel*, SfxRequest&) sc/source/ui/drawfunc/fuins2.cxx:650:27 > #9 0x7f5d49da003c in ScTabViewShell::ExecDrawIns(SfxRequest&) sc/source/ui/view/tabvwshb.cxx:344:13 > #10 0x7f5d49ce50ed in SfxStubScTabViewShellExecDrawIns(SfxShell*, SfxRequest&) workdir/SdiTarget/sc/sdi/scslots.hxx:1407:1 > #11 0x7f5de463ea6d in SfxShell::CallExec(void (*)(SfxShell*, SfxRequest&), SfxRequest&) include/sfx2/shell.hxx:211:35 > #12 0x7f5de4600cbe in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:377:20 > #13 0x7f5de4621593 in SfxDispatcher::PostMsgHandler(SfxRequest*) sfx2/source/control/dispatch.cxx:1156:17 > #14 0x7f5de460487a in SfxDispatcher::LinkStubPostMsgHandler(void*, SfxRequest*) sfx2/source/control/dispatch.cxx:1136:1 > #15 0x7f5de5f18eda in Link<SfxRequest*, void>::Call(SfxRequest*) const include/tools/link.hxx:84:45 > #16 0x7f5de5f189d2 in SfxHintPoster::DoEvent_Impl(void*) sfx2/source/notify/hintpost.cxx:44:12 > #17 0x7f5de5f18861 in SfxHintPoster::LinkStubDoEvent_Impl(void*, void*) sfx2/source/notify/hintpost.cxx:42:1 > #18 0x7f5dbc3bb9fa in Link<void*, void>::Call(void*) const include/tools/link.hxx:84:45 > #19 0x7f5dbc3a5bdf in ImplHandleUserEvent(ImplSVEvent*) vcl/source/window/winproc.cxx:1946:30 > #20 0x7f5dbc39103c in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) vcl/source/window/winproc.cxx:2495:13 > #21 0x7f5dbf2f016f in SalFrame::CallCallback(SalEvent, void const*) const vcl/inc/salframe.hxx:276:33 > #22 0x7f5dbf350db2 in SvpSalInstance::DoYield(bool, bool, unsigned long) vcl/headless/svpinst.cxx:345:31 > #23 0x7f5dbe714b69 in ImplYield(bool, bool, unsigned long) vcl/source/app/svapp.cxx:494:29 > #24 0x7f5dbe6efb53 in Application::Yield() vcl/source/app/svapp.cxx:558:5 > #25 0x7f5dbe6ef896 in Application::Execute() vcl/source/app/svapp.cxx:458:9 > #26 0x7f5dfab81984 in desktop::Desktop::DoExecute() desktop/source/app/app.cxx:1354:5 > #27 0x7f5dfab89eb6 in desktop::Desktop::Main() desktop/source/app/app.cxx:1698:17 > #28 0x7f5dbe76c6ab in ImplSVMain() vcl/source/app/svmain.cxx:192:35 > #29 0x7f5dbe779bf1 in SVMain() vcl/source/app/svmain.cxx:230:16 > #30 0x7f5dfadb8659 in soffice_main desktop/source/app/sofficemain.cxx:166:12 > #31 0x50fa39 in sal_main desktop/source/app/main.c:48:15 > #32 0x50f9e3 in main desktop/source/app/main.c:47:1 > #33 0x7f5df9322400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #34 0x419f79 in _start (instdir/program/soffice.bin+0x419f79) Change-Id: I0a798c6d77b7349077ea44dfe112024abb2567f0 (cherry picked from commit 89214e05e0c2f92fbe68e6c4f4a9035a94cff282) Reviewed-on: https://gerrit.libreoffice.org/38611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-02Add custom HID to the 'From Data Table' optionGabor Kelemen2-1/+3
On the X/Y Error Bars window a custom text is set for a radiobutton if the chart has its own data table. The difference is explained in the help, let's display the correct description in the extended help. Change-Id: Idaa6038818bc4f87ea490a457e7c96ff741f1f77 Reviewed-on: https://gerrit.libreoffice.org/38240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4d0f4fefeb128cf7d61ebfceb8fb2befd3e98904) Reviewed-on: https://gerrit.libreoffice.org/38349 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-21make string translation loading more uniformCaolán McNamara7-19/+14
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2155e04d6343638ca9815d394cbc4f78c2b17c3a) drop toString Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5 (cherry picked from commit 8b1101023f01b2c7478a014b5ead73ada4fd4861) pNameResId is unused Change-Id: Ic1fe6abc7066517187695266c4d1a0888b41ffe7 (cherry picked from commit c2667d7ff558a1b7bf83e694909465f00d1a16f6) Reviewed-on: https://gerrit.libreoffice.org/37843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19tdf#107862 test case with outline mode and subtotalsTomaž Vajngerl1-0/+206
Change-Id: Icfccdb3689a642a96e1666c499728f4ab8106578 Reviewed-on: https://gerrit.libreoffice.org/37741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 54ad4ef4f1d50bb4e4ce08b3600157471af2f565) Reviewed-on: https://gerrit.libreoffice.org/37807 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-18can drop SCH_RESSTR nowCaolán McNamara27-268/+266
Change-Id: Ic9e82098101cb184faec6b3f7fe4c821f5df3278
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin2-98/+1
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M1-1/+1
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-12remove unused uno::Reference varsNoel Grandin12-31/+11
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11tdf#107103 fixes for the legend in a pivot chartTomaž Vajngerl4-28/+71
- Solves issue described in the bug where the legend calculation was not correct if using custom legend placing and the buttons were added to the legend (like in a pivot chart). - Place the legend buttons horizontally if the legend is placed at the top or bottom (wide legend expansion), so the space is used more efficiently. - Fix automatic placing of the legend when we have buttons at the bottom of the chart so that we don't cover them with the legend. - It can happen that the button click is triggered when we resize the legend, so make sure we trigger only when mouse-down and mouse-up are on button. Change-Id: I6a60e7885f7a2ddd6424b1cdfc22e8b046c89dd4 Reviewed-on: https://gerrit.libreoffice.org/37518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin1-1/+1
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin1-2/+1
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09loplugin:constantparamNoel Grandin2-5/+3
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2 Reviewed-on: https://gerrit.libreoffice.org/37390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07break circular includeJochen Nitschke1-0/+1
of include/vcl/window.hxx and include/vcl/vclevent.hxx Change-Id: Iacb3cc942693a732de5899af26e08e0977a83102 Reviewed-on: https://gerrit.libreoffice.org/37338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-07revert OSL_ASSERT changesChris Sherlock58-138/+138
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert chart2 view source from OSL_ASSERT to assertChris Sherlock4-11/+11
Change-Id: I1f4e5b0e90778697f9acf77f34206eb6dabebd71
2017-05-07tdf#43157: convert chart2 model source from OSL_ASSERT to assertChris Sherlock15-29/+29
Change-Id: Id426cf71bfa63a202979e6bd3fa230cabeeb4dcc
2017-05-07tdf#43157: convert chart2 controller source from OSL_ASSERT to assertChris Sherlock26-65/+65
Change-Id: I184c2c0ed74b6a94eb2366c35daf9ed386fbc36f
2017-05-07tdf#43157: convert chart2 tools source from OSL_ASSERT to assertChris Sherlock13-33/+33
Change-Id: Ib55bb437ff7228d12fa2b6c37fb71242f3a136b4
2017-05-05loplugin:checkunusedparams in svtoolsNoel Grandin1-1/+1
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7 Reviewed-on: https://gerrit.libreoffice.org/37201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03remove empty commentsNoel Grandin38-107/+1
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01tdf#107145 display applied filters for page field in pivot chartTomaž Vajngerl1-3/+8
Add field output description which shows the description of the filtered output, which can be either "- all -" when nothing is filtered, "- multiple -" when multiple values are outputted or the specific value - the only value remaining. Change-Id: I8fca6050dabba9878e9f3a31e4be7a03e3b87467 Reviewed-on: https://gerrit.libreoffice.org/37125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-01tdf#107074 uncommenting createLabels for the axis fixes the issueTomaž Vajngerl1-1/+1
Quick fix for this bug seems to be to call createLabels again after creating shapes. The code to position axis label seems to be quite messy it would be better to greatly refactor the code if we want to do any enhancement to this code in the future. Change-Id: I2bc2c3d503944002c538d2d2a5119102c927f3b7 Reviewed-on: https://gerrit.libreoffice.org/37122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-29tdf#107097 invoke internal DP and correctly handle "range" namesTomaž Vajngerl2-1/+5
When we copy/paste a pivot chart to another (new) document, we "send" a chart data as ODC to the other document. In the new document we can't use the pivot table (as there is none in this document) so we read-in the table data from the document to the internal data provider. The problem was that we didn't match the (fake) range names from the pivot table correctly in the internal data provider and the data wasn't populated. This commit fixes that and changes the fake range names to something that is easy to parse and matches the names in internal data provider. Change-Id: I9872160cca68abd91738a25bf9b3b27bc77ce38d Reviewed-on: https://gerrit.libreoffice.org/37086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-28loplugin:salunicodeliteral: chart2Stephan Bergmann2-2/+2
Change-Id: I8531b2466298a18c06a4c2a690af6bc998cc802f
2017-04-28commit: loplugin:checkunusedparams in chart2Noel Grandin38-110/+98
Change-Id: Ia1f42e74365ca1dace93babc132ad67fd09fc99d Reviewed-on: https://gerrit.libreoffice.org/37064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27remove svx bitmaps from .src filesCaolán McNamara2-6/+10
Change-Id: Ie3795870484648e62dea483f9976af31cd1be167 Reviewed-on: https://gerrit.libreoffice.org/37006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock2-2/+2
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26Resolves: tdf#107372 set opengl context when using opengl functionsCaolán McNamara1-1/+9
even if they are teardown ones Change-Id: Ie222d3ffb2b555c0013d7346552d3fc76ec87d9b Reviewed-on: https://gerrit.libreoffice.org/36948 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25remove chart2 bitmaps from .src filesCaolán McNamara11-906/+279
Change-Id: I8ae690b510e69df65e7383e38f054580b8a5ab9d
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-11 20:16:28 +0000