summaryrefslogtreecommitdiff
path: root/chart2/source/view/main/ChartView.cxx
AgeCommit message (Collapse)AuthorFilesLines
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen1-0/+1
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-19loplugin:flatten in chart2Noel Grandin1-199/+202
Change-Id: Iadc4da6515a7d82e7a92b33d74d589b61fa2c64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92480 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09tdf#95425 follow-up: enable "Source format" checkbox of data labelBalazs Varga1-31/+3
settings after file opening, if its value is true in the opened ODF or OOXML document, instead of always showing disabled state. Testing notes: double click on a data label during chart editing of unit test document testAreaChartNumberFormat.docx of commit e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) to see the Data Labels for Data Series... window. On the page "Data Labels...", click on the Number format... button to see the enabled checkbox "Source format" (that was disabled previously). Change-Id: I2845e6f462db273f21c47bb286bed56046f8cf21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91038 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-27tdf#129095 Chart view: fix missing inner chart areaBalazs Varga1-17/+21
If the inner chart area has RelativeSize, always create the plot area with that setting. Regression from commit: 739ed2c29f49ea5e83bcd1352b2644c2e2d09f7b (tdf#115630 tdf#88922 Chart: fix custom legend position and size) Change-Id: I9265843c5d0d148c6a392e440b5d3b0c4ccf0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90708 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-24Revert "tdf#95425 follow-up: enable "Source format" checkbox of data label"Stephan Bergmann1-5/+27
This reverts commit 9bf40c635c41c6b3b072b7c61fea67a20ba4342b. Reason for revert: This apparently causes builds to hang. Witness all the six failed Jenkins builds for <https://gerrit.libreoffice.org/c/core/+/90079> as well as <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/29218/> and following. Change-Id: I441e04cba0f1234cdc200a9aa714b166bda4ab89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90950 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2020-03-24tdf#95425 follow-up: enable "Source format" checkbox of data labelBalazs Varga1-27/+5
settings after file opening, if its value is true in the opened ODF or OOXML document, instead of always showing disabled state. Testing notes: double click on a data label during chart editing to see the Data Labels for Data Series... window. On the page "Data Labels...", click on the Number format... button to see the checkbox "Source format". Change-Id: Idb837d9492ad7e83b9020167c47ed52499c070a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90079 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-23Related tdf#130681: use "Standard" page style if nothing else foundJulien Nabet1-0/+2
Opening docx from https://bugs.documentfoundation.org/attachment.cgi?id=157891 I noticed this log: warn:chart2:151346:151346:chart2/source/view/main/ChartView.cxx:1406:DBG_UNHANDLED_EXCEPTION in void chart::{anonymous}::lcl_setDefaultWritingMode(const std::shared_ptr<chart::DrawModelWrapper>&, chart::ChartModel&) exception: com.sun.star.container.NoSuchElementException bt: 0 0x00007fffd652d857 in chart::(anonymous namespace)::lcl_setDefaultWritingMode(std::shared_ptr<chart::DrawModelWrapper> const&, chart::ChartModel&) (pDrawModelWrapper=std::shared_ptr<chart::DrawModelWrapper> (use count 1, weak count 0) = {...}, rModel=...) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1386 1 0x00007fffd6533d3f in chart::ChartView::createShapes() (this=0x55555b750050) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2461 2 0x00007fffd65340d6 in chart::ChartView::impl_updateView(bool) (this=0x55555b750050, bCheckLockedCtrler=true) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2530 3 0x00007fffd652fc7c in chart::ChartView::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis>, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x55555b750050, xAxis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rExplicitScale=..., rExplicitIncrement=...) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1703 4 0x00007fffd5e00ce9 in chart::wrapper::Chart2ModelContact::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis> const&, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x55555b74b330, xAxis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rOutExplicitScale=..., rOutExplicitIncrement=...) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx:141 5 0x00007fffd5e6203d in chart::wrapper::WrappedScaleProperty::getPropertyValue(chart::wrapper::WrappedScaleProperty::tScaleProperty, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x55555b8214d0, eScaleProperty=chart::wrapper::WrappedScaleProperty::SCALE_PROP_MAX, xInnerPropertySet=uno::Reference to (chart::Axis *) 0x55555b88feb0) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:365 6 0x00007fffd5e61256 in chart::wrapper::WrappedScaleProperty::getPropertyValue(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x55555b8214d0, xInnerPropertySet=uno::Reference to (chart::Axis *) 0x55555b88feb0) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:134 7 0x00007fffd6785913 in chart::WrappedProperty::getPropertyState(com::sun::star::uno::Reference<com::sun::star::beans::XPropertyState> const&) const (this=0x55555b8214d0, xInnerPropertyState=uno::Reference to (chart::Axis *) 0x55555b88ff10) at /home/julien/lo/libreoffice/chart2/source/tools/WrappedProperty.cxx:105 8 0x00007fffd678721a in chart::WrappedPropertySet::getPropertyState(rtl::OUString const&) (this=0x55555b818aa0, rPropertyName="Max") at /home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:285 9 0x00007fffd67874ae in chart::WrappedPropertySet::getPropertyStates(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x55555b818aa0, rNameSeq=uno::Sequence of length 82 = {...}) at /home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:315 10 0x00007fffed317df6 in (anonymous namespace)::FilterPropertiesInfo_Impl::FillPropertyStateArray(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> >&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, rtl::Reference<XMLPropertySetMapper> const&, bool) (this=0x55555b822090, rPropStates=std::__debug::vector of length 0, capacity 0, rPropSet= uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, rPropMapper=rtl::Reference to 0x55555b7b80d0, bDefault=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:349 11 0x00007fffed319411 in SvXMLExportPropertyMapper::Filter_(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, bool, bool) const (this=0x55555b79d560, xPropSet=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, bDefault=false, bEnableFoFontFamily=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:616 12 0x00007fffed318e9a in SvXMLExportPropertyMapper::Filter(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, bool) const (this=0x55555b79d560, rPropSet=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, bEnableFoFontFamily=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:546 13 0x00007fffecfcc301 in SchXMLExportHelper_Impl::exportAxis(xmloff::token::XMLTokenEnum, xmloff::token::XMLTokenEnum, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XAxis> const&, rtl::OUString const&, bool, bool, bool, bool) (this=0x55555b833a80, eDimension=xmloff::token::XML_X, eAxisName=xmloff::token::XML_PRIMARY_X, rAxisProps=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, rChart2Axis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rCategoriesRange="", bHasTitle=false, bHasMajorGrid=false, bHasMinorGrid=false, bExportContent=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:2260 14 0x00007fffecfcd203 in SchXMLExportHelper_Impl::exportAxes(com::sun::star::uno::Reference<com::sun::star::chart::XDiagram> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XDiagram> const&, bool) (this=0x55555b833a80, xDiagram=uno::Reference to (chart::wrapper::DiagramWrapper *) 0x55555b8be9b8, xNewDiagram=uno::Reference to (chart::Diagram *) 0x55555b883ad8, bExportContent=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:2401 15 0x00007fffecfca651 in SchXMLExportHelper_Impl::exportPlotArea(com::sun::star::uno::Reference<com::sun::star::chart::XDiagram> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XDiagram> const&, com::sun::star::awt::Size const&, bool, bool) (this=0x55555b833a80, xDiagram=uno::Reference to (chart::wrapper::DiagramWrapper *) 0x55555b8be9b8, xNewDiagram=uno::Reference to (chart::Diagram *) 0x55555b883ad8, rPageSize=..., bExportContent=false, bIncludeTable=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1925 16 0x00007fffecfc6ebc in SchXMLExportHelper_Impl::parseDocument(com::sun::star::uno::Reference<com::sun::star::chart::XChartDocument> const&, bool, bool) (this=0x55555b833a80, rChartDoc= uno::Reference to (chart::wrapper::ChartDocumentWrapper *) 0x55555b74b208, bExportContent=false, bIncludeTable=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1415 17 0x00007fffecfc50ce in SchXMLExportHelper_Impl::collectAutoStyles(com::sun::star::uno::Reference<com::sun::star::chart::XChartDocument> const&) (this=0x55555b833a80, rChartDoc=uno::Reference to (chart::wrapper::ChartDocumentWrapper *) 0x55555b74b208) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1050 18 0x00007fffecfd5207 in SchXMLExport::collectAutoStyles() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3556 19 0x00007fffecfd530d in SchXMLExport::ExportAutoStyles_() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3568 20 0x00007fffed0c407d in SvXMLExport::ImplExportAutoStyles() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:1152 21 0x00007fffed0c527f in SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum) (this=0x55555b7b4a00, eClass=xmloff::token::XML_CHART) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:1404 22 0x00007fffecfd502f in SchXMLExport::exportDoc(xmloff::token::XMLTokenEnum) (this=0x55555b7b4a00, eClass=xmloff::token::XML_CHART) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3534 23 0x00007fffed0c20d9 in SvXMLExport::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x55555b7b4a00, aDescriptor=uno::Sequence of length 6 = {...}) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:811 Change-Id: I21a6b54f3340b0423a0b12f39a620f71d96ff565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88763 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-24loplugin:makeshared in chart2..comphelperNoel Grandin1-2/+2
Change-Id: Ia25f5de3167fd554d463ce6111e8c5b0e7842907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14clang-tidy modernize-concat-nested-namespace in chart2Noel Grandin1-1/+1
Change-Id: I320234b60963d80f6870a9ce1fead8e29de437aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: Ib2314f23efe953398ed0a5e88305842c812e18bb Reviewed-on: https://gerrit.libreoffice.org/85708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-16tdf#129173 tdf#129175 Fix number format of data labelsBalazs Varga1-19/+9
Show the real value (cell value) of datapoints instead of the recalculated value in case of Percent Stacked Area chart. Also fix: tdf#95425 Do not reset number format of data labels when open dialog of 'Format data series' and close dialog. Note: Inherits the data series/point label format from the cell format and not the axis format, if we set the 'link to source data' option to true. Change-Id: I04e9968034a67c6bc6b92941df61d945b4292d79 Reviewed-on: https://gerrit.libreoffice.org/84819 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-07Check secondary Y axis exists before retrieving value for "Show" prop (chart2)Julien Nabet1-2/+2
Change-Id: I7d2a69635de6625e09dd71a33553261898e30420 Reviewed-on: https://gerrit.libreoffice.org/84685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-07PageStyle and WritingMode may be absent (chart2)Julien Nabet1-3/+11
Create a brand new odb file (embedded hsqldb) Create a report with design, just insert a chart It'll error-log first because of missing "PageStyle" property once this one fixed, it'll error-log with missing "WritingMode" property Remark: the chart will be created But let's avoid these error-logs Change-Id: I04bb4d87e8e97fb3ff7c4e5dc7f81897afca64ec Reviewed-on: https://gerrit.libreoffice.org/84675 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-02tdf#129054 Chart OOXML Import: Fix size of Pie ChartBalazs Varga1-1/+2
Do not shift (set to false ShiftedCategoryPosition) the category axis for Pie chart with complex category. Change-Id: I3b1d99899a2daf9fd7a596c88531797aa5084734 Reviewed-on: https://gerrit.libreoffice.org/83871 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-21tdf#42949 tdf#119699 Fix IWYU warnings in chart2/Gabor Kelemen1-1/+0
* Recheck after recent refactorings and improvements in f-u-i * Drop now unused TabPageIds.h * The problem noticed in bug #119699 now seems to be gone too so drop those lines from the blacklist. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I44f26c7370f5328c8f67ac61cd8f0cdb29077f15 Reviewed-on: https://gerrit.libreoffice.org/83182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin1-2/+0
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15move HAVE_FEATURE_DESKTOP/OPENCL to their dedicated headersLuboš Luňák1-1/+1
HAVE_FEATURE_OPENCL is included by a common Calc header and HAVE_FEATURE_DESKTOP is included by a common Writer header, causing pretty much their full rebuilds if any feature changes. Change-Id: If29bf78bd4fd70b37981e0826a577777fd255c89 Reviewed-on: https://gerrit.libreoffice.org/80776 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-07tdf#127777 OOXML chart export: fix "CrossBetween" for not imported chartsBalazs Varga1-12/+5
Newly created or ODF charts were still exported incorrectly, because ShiftedCategoryPosition was stored in the view code. Now it is removed to the model using ChartTypeTemplate::adaptScales. See also commit 6027ec08fd5df2e09e34ff61b3777ad2cc8304b3 'tdf#127777 OOXML chart export: fix X axis position setting "CrossBetween"' Change-Id: I7cd69e311833bf9f24f3a600ee7c6312285a7738 Reviewed-on: https://gerrit.libreoffice.org/80160 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-26add property name when throwing css::uno::UnknownPropertyExceptionNoel Grandin1-2/+2
Change-Id: I17f06c9415b9d43b6d8896360e07216c2856367a Reviewed-on: https://gerrit.libreoffice.org/79627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-23tdf#127393 OOXML chart import: fix X axis position setting "CrossBetween"Balazs Varga1-5/+7
Set ShiftedCategoryPosition according to OOXML value CrossBetween. Change-Id: I6445c94507de83f84b08fd3380cbbf03886b5aa3 Reviewed-on: https://gerrit.libreoffice.org/79142 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-23tdf#39593 use getUnoTunnelImplementationArkadiy Illarionov1-12/+5
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd Reviewed-on: https://gerrit.libreoffice.org/79350 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-06tdf#39593 use isUnoTunnelIdArkadiy Illarionov1-2/+1
Adapt getUnoTunnelId methods where required: rename or make public. Change-Id: I0fd2120bf9f0ff1aa690329a65ff64a154c89315 Reviewed-on: https://gerrit.libreoffice.org/78680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-19loplugin:constvars in chart2..connectivityNoel Grandin1-6/+6
Change-Id: I35d450b022af870df4e57714363892554a4ae917 Reviewed-on: https://gerrit.libreoffice.org/77722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in basic..cuiNoel Grandin1-2/+4
Change-Id: I15d825de3201808d188b461415f78a4d81b64127 Reviewed-on: https://gerrit.libreoffice.org/77494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-10Fix typosAndrea Gelmini1-1/+1
Information is always singular Change-Id: I55275d7c2fd76c3ec0ae4a98aa952777feb90460 Reviewed-on: https://gerrit.libreoffice.org/75645 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): chart2Stephan Bergmann1-1/+1
Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915 Reviewed-on: https://gerrit.libreoffice.org/76692 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin1-3/+3
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-20tdf#39593 Remove chart::ExplicitValueProvider::getExplicitValueProviderArkadiy Illarionov1-15/+1
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I8a457dc2aa701957f463b31bd6cc112337999aad Reviewed-on: https://gerrit.libreoffice.org/74377 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov1-2/+2
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-14loplugin:logexceptionnicely in chart2Noel Grandin1-8/+8
Change-Id: Ib7933723e5506578bbc85cc431d54d1ed8466376 Reviewed-on: https://gerrit.libreoffice.org/74019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-10Use hasElements to check Sequence emptiness in chart2..connectivityArkadiy Illarionov1-3/+3
Similar to clang-tidy readability-container-size-empty Change-Id: I41824e8a4ef38d6a35a0ac4421cffcbcd17308e1 Reviewed-on: https://gerrit.libreoffice.org/71802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-29tdf#122765: Legend interferes with pie chart after pptx import, second partTamás Zolnai1-2/+2
Revert of: 2903c5f59d257b6ab94f32df64513f2edf94fb0b Reverting this commit does not lead to the original bug to come back, so we can revert it without a problem. Change-Id: I244a6b9451c47e1094db8a77c71b6696e0c464cc Reviewed-on: https://gerrit.libreoffice.org/73139 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-26tdf#124796 Fix chart primary Y axis scalingBalazs Varga1-2/+16
Re-scale the primary Y axis if the secondary axis is deleted and the dataseries still attached to the secondary axis. Change-Id: I6e7958766d23a74569ce8529ddf1bdafa89f1870 Reviewed-on: https://gerrit.libreoffice.org/71302 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-04-23tdf#113266 slow opening XLS with 45 MB drawingNoel Grandin1-2/+2
Some hot-spots around dynamic_cast of SdrHint, so avoid that by creating special SfxHintId::ThisIsAnSdrHint The most common CPU hot-spot was in SvxShape::Notify, the other changes are just for consistency. Also remove some dead code in ScShapeChildren, the Notify method was doing nothing useful. Change-Id: I696db1fcafc09bb10bf23ac673de292746141491 Reviewed-on: https://gerrit.libreoffice.org/71108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski1-2/+2
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11new loplugin writeonlyvarsNoel Grandin1-2/+0
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26tdf#42949 Fix IWYU warnings in chart2/source/view/*cxxGabor Kelemen1-21/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9ee3318c79d3b59f272a2a5f89c38b26afa05974 Reviewed-on: https://gerrit.libreoffice.org/63775 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-21loplugin:redundantfcast improvementsNoel Grandin1-1/+1
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16loplugin:staticmethods improvementNoel Grandin1-1/+1
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755 Reviewed-on: https://gerrit.libreoffice.org/63434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-3/+3
Change-Id: I856345576ff5c10a41509a97ad4539272bd55568 Reviewed-on: https://gerrit.libreoffice.org/62803 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-23clang-tidy performance-unnecessary-copy-init in canvas..cuiNoel Grandin1-1/+1
Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4 Reviewed-on: https://gerrit.libreoffice.org/62214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann1-2/+2
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17New loplugin:externalStephan Bergmann1-1/+1
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-14Fix race in chart::ChartViewStephan Bergmann1-5/+5
...that recently started to hit quite often during JunitTest_chart2_unoapi, when the main thread is painting windows and calls ChartView::createShapes (which calls impl_deleteCoordinateSystems, which clears m_aVCooSysList) while an URP thread executes chart::WrappedPropertySet::getPropertyValue and calls ChartView::getExplicitValuesForAxis (which calls findInCooSysList, which iterates over m_aVCooSysList), all apparently without locking access to m_aVCooSysList. (See e.g. the below backtraces from <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/14432/console>, where both threads operate on chart::ChartView instance 0x2633140.) I assume this issue has always been there, and has only been made noticeable with recent 3e62ac3e9ef2f6759d8faca2c012dba51c314ba5 "loplugin:useuniqueptr in VCoordinateSystem", which changed the implementation of impl_deleteCoordianteSystems from O(1) swap-and-clear to plain O(n) clear of m_aVCooSysList, which extends the time span in which the thread executing findInCooSysList can find an inconsistent m_aVCooSysList (and see in the below backtrace how much code is apparently executed during the destruction of m_aVCooSysList's VCartesianCoordinateSystem elements). And indeed, <https://bz.apache.org/ooo/show_bug.cgi?id=109770> "ChartView::getExplicitValuesForAxis accessing destroyed VCoordinateSystem" found apparently the same issue already in 2010, and the swap-and-clear was introduced as a means to address the race in 590a1a5225623eb922e63b02b62e711d153e9d55 "chart43: #i109770# ChartView::getExplicitValuesForAxis accessing destroyed VCoordinateSystem". (So the "//#i109770#" comment should have been removed from impl_deleteCoordinateSystem already when 3e62ac3e9ef2f6759d8faca2c012dba51c314ba5 dropped the swap; catching up on that now.) For a proper fix, there appears to be no constitent existing locking scheme for ChartView (appart from a few scatter SolarMutexGuards). Lets be bold and see whether it works to put the whole bodies of (at least, for now) createShapes and getExpliticValuesForAxis under SolarMutexGuards. (Which means the SolarMutexGuard in createShapes2D can go, as it is exclusively called from createShapes.) > Thread 2 (Thread 0x2ae81cbd2840 (LWP 10147)): > #0 0x00002ae81dee4f9a in __gnu_debug::_Safe_iterator_base::_M_attach(__gnu_debug::_Safe_sequence_base*, bool) () at /lib64/libstdc++.so.6 > #1 0x00002ae822e0a685 in __gnu_debug::_Safe_iterator_base::_Safe_iterator_base(__gnu_debug::_Safe_sequence_base const*, bool) (this=0x7ffedb73c598, __seq=0x2acc2f0, __constant=false) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/debug/safe_base.h:89 > #2 0x00002ae822f75c6a in __gnu_debug::_Safe_iterator<std::__cxx1998::_Deque_iterator<SfxBroadcaster*, SfxBroadcaster*&, SfxBroadcaster**>, std::__debug::deque<SfxBroadcaster*, std::allocator<SfxBroadcaster*> > >::_Safe_iterator(std::__cxx1998::_Deque_iterator<SfxBroadcaster*, SfxBroadcaster*&, SfxBroadcaster**> const&, std::__debug::deque<SfxBroadcaster*, std::allocator<SfxBroadcaster*> > const*) (this=0x7ffedb73c598, __i=, __seq=0x2acc2a0) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/debug/safe_iterator.h:152 [...] > #44 0x00002ae846166609 in chart::VCartesianCoordinateSystem::~VCartesianCoordinateSystem() (this=0x28c2b60) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/axes/VCartesianCoordinateSystem.cxx:64 > #45 0x00002ae8461767af in std::default_delete<chart::VCoordinateSystem>::operator()(chart::VCoordinateSystem*) const (this=0x28e4190, __ptr=0x28c2b60) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:67 > #46 0x00002ae8461737d3 in std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >::~unique_ptr() (this=0x28e4190) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/unique_ptr.h:184 > #47 0x00002ae84626e295 in std::_Destroy<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > >(std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*) (__pointer=0x28e4190) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_construct.h:93 > #48 0x00002ae84626e25f in std::_Destroy_aux<false>::__destroy<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*>(std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*, std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*) (__first=0x28e4190, __last=0x28e4198) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_construct.h:103 > #49 0x00002ae84626e1bd in std::_Destroy<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*>(std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*, std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*) (__first=0x28e4190, __last=0x28e4198) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_construct.h:126 > #50 0x00002ae84626dce1 in std::_Destroy<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*, std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > >(std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*, std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*, std::allocator<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > >&) (__first=0x28e4190, __last=0x28e4198) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_construct.h:151 > #51 0x00002ae846273bf3 in std::__cxx1998::vector<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >, std::allocator<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > > >::_M_erase_at_end(std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >*) (this=0x2633240, __pos=0x28e4190) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1352 > #52 0x00002ae846273b94 in std::__cxx1998::vector<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >, std::allocator<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > > >::clear() (this=0x2633240) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1126 > #53 0x00002ae846251d8c in std::__debug::vector<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> >, std::allocator<std::unique_ptr<chart::VCoordinateSystem, std::default_delete<chart::VCoordinateSystem> > > >::clear() (this=0x2633240) at /usr/lib/gcc/x86_64-redhat-linux/4.8.5/../../../../include/c++/4.8.5/debug/vector:563 > #54 0x00002ae84623749c in chart::ChartView::impl_deleteCoordinateSystems() (this=0x2633140) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/main/ChartView.cxx:1136 > #55 0x00002ae846240346 in chart::ChartView::createShapes() (this=0x2633140) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/main/ChartView.cxx:2484 > #56 0x00002ae84623d8f6 in chart::ChartView::impl_updateView(bool) (this=0x2633140, bCheckLockedCtrler=true) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/main/ChartView.cxx:2563 > #57 0x00002ae846243eae in chart::ChartView::update() (this=0x2633140) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/main/ChartView.cxx:2720 > #58 0x00002ae845bafef5 in chart::ChartController::execute_Paint(OutputDevice&, tools::Rectangle const&) (this=0x2a60ac0, rRenderContext=..., rRect=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/main/ChartController_Window.cxx:479 > #59 0x00002ae845bceb26 in chart::ChartWindow::Paint(OutputDevice&, tools::Rectangle const&) (this=0x2928e60, rRenderContext=..., rRect=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/main/ChartWindow.cxx:100 [...] > #71 0x00002ae8280ee03c in Scheduler::ProcessTaskScheduling() () at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/app/scheduler.cxx:451 > #72 0x00002ae8280ed1ed in Scheduler::CallbackTaskScheduling() () at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/app/scheduler.cxx:270 > #73 0x00002ae828302716 in SalTimer::CallCallback() (this=0x20db780) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/inc/saltimer.hxx:55 > #74 0x00002ae828300b84 in SvpSalInstance::CheckTimeout(bool) (this=0x12640d0, bExecuteTimers=true) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/headless/svpinst.cxx:206 > #75 0x00002ae828301a61 in SvpSalInstance::DoYield(bool, bool) (this=0x12640d0, bWait=true, bHandleAllCurrentEvents=false) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/headless/svpinst.cxx:418 > #76 0x00002ae82811fbd1 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/source/app/svapp.cxx:471 [...] > Thread 1 (Thread 0x2ae842779700 (LWP 13177)): > #0 0x00002ae8461307dc in com::sun::star::uno::Reference<com::sun::star::chart2::XScaling>::set(com::sun::star::chart2::XScaling*) (this=0x2ae842776bb8, pInterface=0x9999999999999999) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/com/sun/star/uno/Reference.hxx:234 > #1 0x00002ae84612f8a0 in com::sun::star::uno::Reference<com::sun::star::chart2::XScaling>::operator=(com::sun::star::uno::Reference<com::sun::star::chart2::XScaling> const&) (this=0x2ae842776bb8, rRef=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/include/com/sun/star/uno/Reference.hxx:349 > #2 0x00002ae846140bea in chart::ExplicitScaleData::operator=(chart::ExplicitScaleData const&) (this=0x2ae842776b98) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/inc/chartview/ExplicitScaleValues.hxx:37 > #3 0x00002ae846171ad2 in chart::VCoordinateSystem::getExplicitScale(int, int) const (this=0x28c2b60, nDimensionIndex=1, nAxisIndex=0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/axes/VCoordinateSystem.cxx:272 > #4 0x00002ae84623d475 in chart::ChartView::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis>, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x2633140, xAxis=..., rExplicitScale=..., rExplicitIncrement=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/view/main/ChartView.cxx:1735 > #5 0x00002ae845954d69 in chart::wrapper::Chart2ModelContact::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis> const&, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x26b6920, xAxis=..., rOutExplicitScale=..., rOutExplicitIncrement=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx:143 > #6 0x00002ae8459d1d20 in chart::wrapper::WrappedScaleProperty::getPropertyValue(chart::wrapper::WrappedScaleProperty::tScaleProperty, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x2b68480, eScaleProperty=chart::wrapper::WrappedScaleProperty::SCALE_PROP_STEPMAIN, xInnerPropertySet=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:389 > #7 0x00002ae8459d114b in chart::wrapper::WrappedScaleProperty::setPropertyValue(chart::wrapper::WrappedScaleProperty::tScaleProperty, com::sun::star::uno::Any const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x2b68480, eScaleProperty=chart::wrapper::WrappedScaleProperty::SCALE_PROP_AUTO_STEPMAIN, rOuterValue=..., xInnerPropertySet=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:234 > #8 0x00002ae8459d0893 in chart::wrapper::WrappedScaleProperty::setPropertyValue(com::sun::star::uno::Any const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x2b68480, rOuterValue=..., xInnerPropertySet=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:130 > #9 0x00002ae846523605 in chart::WrappedPropertySet::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x2b64cc0, rPropertyName=..., rValue=...) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/chart2/source/tools/WrappedPropertySet.cxx:89 > #10 0x00002ae841d97854 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0x2b64cf8, nVtableIndex=4, pRegisterReturn=0x0, pReturnTypeRef=0x127fb10, bSimpleReturn=true, pStack=0x2ae8427777d0, nStack=0, pGPR=0x2ae842777ae0, pFPR=0x2ae842777aa0) at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77 [...] Change-Id: Id0236bf04bff9f06f8fc5ee9e2db295216a54c16 Reviewed-on: https://gerrit.libreoffice.org/60474 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-06loplugin:simplifyconstruct in canvas..cuiNoel Grandin1-4/+4
Change-Id: I02eba1df117a9d0df42bcac13c3251cb4fa6da14 Reviewed-on: https://gerrit.libreoffice.org/60074 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06loplugin:useuniqueptr in VCoordinateSystemNoel Grandin1-45/+36
Change-Id: I369d6755d3de2dd885214115559150256298852d Reviewed-on: https://gerrit.libreoffice.org/60051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-06tdf#42949 Fix IWYU warnings in chart2/source/view/{axes,charttypes,main}/*hxxGabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I33d3ac3edbda5e2a9958373123565e28210b55c8 Reviewed-on: https://gerrit.libreoffice.org/59956 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-11loplugin:mergeclasses AbstractShapeFactory into ShapeFactoryNoel Grandin1-13/+12
Change-Id: I9cc607bcc84a14ffdbe22bdbe1a038f5b22b719a Reviewed-on: https://gerrit.libreoffice.org/58871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08tdf#42949 Fix IWYU warnings in chart2/source/inc/[d-l]*hxxGabor Kelemen1-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Try harder to use fw declarations, and a few newly analyzed files Change-Id: I50299e9115ced60468c7bc5e63013addbaec48c0 Reviewed-on: https://gerrit.libreoffice.org/58618 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 09:12:12 +0000