path: root/chart2/qa/extras
AgeCommit message (Collapse)AuthorFilesLines
2018-08-23tdf#94502 Fix overlap export of Stacked Bar Chart to *.xlsxBalazs Varga2-0/+23
Export the Overlap value with 100% for stacked charts, because the default overlap value of the Bar/Column chart is 0% and LibreOffice do nothing with the overlap value in Stacked Chart case, unlike the MS Office. Change-Id: If4e20b88c2b1180f68a8d2b610c407d674a8498b Reviewed-on: Reviewed-by: Markus Mohrhard <> Tested-by: Jenkins (cherry picked from commit 17c2b0af97f73b9103be982b15d7111b3980e027) Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-08-10tdf#96469 Export Data Point properties in Charts on DOCX/XLSXBalazs Varga3-0/+40
If the color or other property of a datapoint in the chart deviates from the dataseries property, this patch will write it into a separate dPt tag and fixing the lost properies during OOXML export. Change-Id: I3d975675ac3691fcafe76de16e46851561eb2807 Reviewed-on: Reviewed-by: Bartosz Kosiorek <> Tested-by: Jenkins
2018-08-02tdf#119029: also export rotation for data seriesMike Kaganski2-0/+14
Change-Id: I6a9895145e0c54d35bf404f209721a0c718e4446 Reviewed-on: Tested-by: Jenkins Reviewed-by: Mike Kaganski <> (cherry picked from commit 8f90492812d1edac6c91e83b84f3512877dcd552) Reviewed-on: Reviewed-by: Andras Timar <>
2018-07-31tdf#108078 OOXML Export Chart shapes area fill propertiesBalazs Varga10-0/+102
Verified with color, gradient, bitmap for: Chart Title in DOCX, XLSX and PPTX. Also verified with gradient, bitmap for Chart Legend, Plot Area, Dataseries and Background in DOCX, XLSX and PPTX. Change-Id: I15d29f3ca2d75f45f612766b635d50a29d8551ae Reviewed-on: Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <> (cherry picked from commit 051399740e41c6495ed362e78c63e0868bcd180c) Reviewed-on: Reviewed-by: Balazs Varga <>
2018-07-04tdf#115945 oox export: data label writeRunPropertiesJustin Luth1-0/+1
DataLabel font was always returning to the default - black. Change-Id: I6c72a8daa699394b36f69fc54e0ba042f0255c18 Reviewed-on: Tested-by: Jenkins Reviewed-by: Justin Luth <> Reviewed-by: Szymon Kłos <> (cherry picked from commit ae2fd281e046b2199ef44777b84518cd3abb2952) Reviewed-on: Reviewed-by: Christian Lohmaier <>
2018-05-04Removed executable permission on data filesAndrea Gelmini1-0/+0
chmod -x for doc, xlsx, png, hxx, cxx, xls, ppt, hpp Change-Id: I52aed261e318cfd765e9adb3ed8edd226c8a59d8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Thorsten Behrens <>
2018-03-08loplugin:constantparam in canvas..comphelperNoel Grandin1-24/+20
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2018-03-07tdf#116163 import testSzymon Kłos1-0/+99
Change-Id: Ie4fd1142e1111e4968941a639a265d169aaa6413 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Szymon Kłos <>
2018-03-04tdf#116163: Limit label height in chart if neededSzymon Kłos2-0/+11
Change-Id: Ia84fd0c3b76886bc6124dc3b59035465aa31b020 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Szymon Kłos <>
2018-02-28tdf#115859 Export number format for chart seriesSzymon Kłos2-0/+12
Change-Id: I65d30c6b92a530eadbd6fabe87fa8bd3416fee20 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Andras Timar <>
2018-01-29tdf#114821 export complex data labels in chartsSzymon Kłos1-0/+159
Change-Id: I9b0893dfde4efc10bb05e6e17b7128b016efeb71 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Szymon Kłos <>
2018-01-29tdf#114821 import complex data labels in bar chartSzymon Kłos3-0/+154
* import static text & fields: VALUE, SERIESNAME, COLUMNNAME * text is formatted * DataPointCustomLabelField with field type (DataPointCustomLabelFieldType) was introduced. * text can have many portions & multiple lines * unit tests for import data labels with formatting Not implemented: CELLREF field support which needs importing some additional data from extLst Shows custom text as a label for data points. Change-Id: Iba8fd508eb16356b05586b93d7b8da32240d2b91 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Szymon Kłos <>
2018-01-12More loplugin:cstylecast: chart2Stephan Bergmann3-10/+10
auto-rewrite with <> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I745557506326b2b0ce66d0058ebf85e5ed2a0952
2018-01-09tdf#114173 Preserve size of chart legend during xlsx exportBartosz Kosiorek1-0/+15
During export chart into .xlsx file, the information about size of legend was not saved. Example of proper size: <c:w val="0.41459448854442293"/> <c:h val="0.23161616722845749"/> another issue was hardcoded "layoutTarget" which was always "inner": <c:layoutTarget val="inner"/> also properties regarding default text style was not preserved: <c:txPr> <a:bodyPr/> <a:lstStyle/> <a:p> <a:pPr> <a:defRPr sz="900" b="0" i="0" u="none" strike="noStrike" kern="1200" baseline="0"> <a:solidFill> <a:schemeClr val="tx1"> <a:lumMod val="65000"/> <a:lumOff val="35000"/> </a:schemeClr> </a:solidFill> </a:defRPr> </a:pPr> <a:endParaRPr lang="pl-PL"/> </a:p> </c:txPr> With this patch all these issues was resolved, and in case of layoutTarget "outer", the field is not availble at all, according to specification. Change-Id: I2c9b7a112bdd911542b5273e660222d7fefa2d88 Reviewed-on: Reviewed-by: Mike Kaganski <> Tested-by: Mike Kaganski <>
2018-01-02loplugin:passstuffbyref improved return in sd,variousNoel Grandin1-1/+1
Change-Id: I4b6ea89ae2072f4389a696ea3c96d8f7a5731e7a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-12-29add test for tdf#114182Markus Mohrhard2-0/+11
Change-Id: I08dd556814257e64cd0629bcfb2193f939d994e5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-12-20tdf#105517: overwrite existing scheme colors in vectorAron Budea2-0/+30
Theme overrides stopped working once ClrScheme::maClrScheme was changed to vector, and colors were always appended to it. Regression from f3121049828596b369e3ea844355d61666e49795. Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-10-27loplugin:includeform: chart2 (Windows)Stephan Bergmann1-1/+1
Change-Id: Ie3e8e174f3fa51331988481ec16d2d1a52bb9ece
2017-10-23loplugin:includeform: chart2Stephan Bergmann1-1/+1
Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
2017-10-23chmod 0755 -> 0644 for some source filesStephan Bergmann1-0/+0
Change-Id: Ibe5b5e03374419c2c23cd6559ab213d2dc2fcc66
2017-10-05ChartDumpTest: Disable checks which seems to fail because of font differencesTamás Zolnai16-1082/+25
Change-Id: Icc45a7533510eaf4506be87819ac9f1e7d4bf9e2 Reviewed-on: Reviewed-by: Tamás Zolnai <> Tested-by: Tamás Zolnai <>
2017-09-18Fix chart dump test recent failures on MACTamás Zolnai1-1/+1
Change-Id: I066ecea1e32cec10696dab3a3e4fac78894088a2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Zolnai <>
2017-08-24Consistently use OUString in test::DirectoriesStephan Bergmann1-4/+4
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2017-08-08unit test for tdf#111173Marco Cecchetti2-0/+10
Change-Id: I9b9a1f3c38c1402c436fd6815916be3dabf71447 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Marco Cecchetti <>
2017-08-08tdf#109858: Override default point label placement setting...Dennis Francis2-0/+15
with series label placement setting if available while importing xlsx chart. Adds unit test in chart2import.cxx that asserts one of the point label setting in the bugzilla xlsx document. Change-Id: I8bc04fd569f94a19633666ffdc51b61ac719e8a9 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Dennis Francis <>
2017-08-02tdf#90352: set/handle LinkNumberFormatToSource property in xls...Dennis Francis2-0/+61
Import/Export filter respectively for axis numbers. For ods and xlsx this was already getting set/handled correctly. Also add unit test to assert LinkNumberFormatToSource property and number format for import and export-import roundtrip. Change-Id: Id029ac7d0233ca490a6a00609e9cea8fdafee70f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-07-31loplugin:oncevarNoel Grandin2-3/+3
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-07-27tdf#90510 : Override default point label placement setting...Dennis Francis2-0/+16
with global label placement setting if available while importing xls chart. Added unit test in chart2import.cxx that asserts one of the point label setting in the bugzilla xls document. Change-Id: Id331f56c05873554b22920e02805909c50fb8619 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-07-23tdf#103984 : For bubble charts append data column...Dennis Francis2-0/+23
for "values-size" role too, after parsing in InternalDataProvider::createDataSequenceFromArray(). Without this, embedded bubble charts in documents(MSO) other than spreadsheets will be empty when imported. Also adds docx import chart2-unit-test in chart2import.cxx Change-Id: I63168074b30090a8b7cf977eb5af443f6b9ac240 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-07-10tdf#108986 : no arrow for "Data" button on pivot chartDennis Francis3-0/+46
Also changed the fill color of "Data" button to a lighter shade to distiguish it from other buttons, for both row and column fields. Added matching testcase in chart2dump.cxx Change-Id: I2ae5da6c3552372f606da41055f1e0663b6f0802 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-07-07remove nullptr checks on STL search result iteratorsJochen Nitschke1-1/+0
results are in the range of first_iterator to last_iterator. If one of those is nullptr the algorithm would fail anyway. This removes some impossible checks in sw/source/core/unocore/unochart.cxx: SwChartDataProvider::detectArguments. A sorted range still holds the same values and has the same length as the original range. Replacing raw pointers eases reading this code. Change-Id: If96bd11e9167488346a57e9e08507ac42338d3cd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-07-06tdf#108923 : Use display string for generating chart labelsDennis Francis1-15/+97
Use display string for generating chart labels in PivotTableDataProvider::collectPivotTableData as chart2 does not seem to use number format for labels although it does for the data. Added unit test PivotChartTest::testPivotChartWithDateRowField() for this fix. Change-Id: I668d4c9d7cf8bbb7e4213cce7a6e7cd4d7d07cbe Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-06-20loplugin:oncevar chart2Noel Grandin2-23/+19
Change-Id: I2dd0939db440b5357225395e88680dd0b0fdbf43 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-06-09use comphelper::InitPropertySequence in more placesNoel Grandin1-4/+2
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin1-3/+3
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-05-18tdf#107862 test case with outline mode and subtotalsTomaž Vajngerl1-0/+206
Change-Id: Icfccdb3689a642a96e1666c499728f4ab8106578 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-04-24coverity#1405475 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: If4709eb169196893378ceb7c2dc9c645d4a640a3
2017-04-24tdf#107147 ignore subtotals and grandtotals when gathering labelsTomaž Vajngerl1-3/+3
When gathering the labels and categories for the pivot chart, ignore subtotals and grandtotals so they don't end up in the chart. Change-Id: I45e80a59531d6a048a22016132e9bef280bb325c Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-04-24preserve "Total" label on round-trip, remove code duplicationTomaž Vajngerl1-2/+2
Change-Id: Ic4e682f2193291798a3ebbf5a7f3f435d40a0645 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-04-19pivotcharts: test pivot table fieldsTomaž Vajngerl1-4/+130
Change-Id: I384bf36a79adccdccdecb836b122958ce925c376 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-04-19pivotcharts tests: setup pivot table from scratchTomaž Vajngerl1-0/+271
This changes tests so that we fill example data and create a new pivot table from scratch, and create a new pivot chart using that pivot table. This enables that we test different cases without an example document which creates a pivot table for us. In addition add two test cases: - pivot table with one column field and one data field - pivot table with one row field and one data field (disabled, as it currently crashes) Change-Id: I8397a598857953e0b2d7da8dd91d7709a3495b71 Reviewed-on: Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <>
2017-04-14update cppunit to 1.14.0Markus Mohrhard2-35/+0
Change-Id: I95fa42f4ef0580734b605df859c1660b29adb8b2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2017-04-10pivotcharts: ignore subtotals, grand totals in pivot table dataTomaž Vajngerl1-10/+45
Change-Id: I08cdd28aaae536fa8306446168dcdb977897dfcd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tomaž Vajngerl <>
2017-04-06Call CPPUNIT_ASSERT directly (also avoids -Werror,-Wformat with clang-cl)Stephan Bergmann1-28/+16
Change-Id: I78a1d59e6814ad7f3e39fd720871189ccb0e22d1
2017-04-04tdf#83257 [API-CHANGE] Pivot chart implementationTomaž Vajngerl4-2/+373
This is a squashed commit of the pivot chart implementation. Some of the changes: - Add pivot chart specific (pivot table) data provider which provides the data from a pivot table to the associated chart. - When inserting a chart and the cursor is in a pivot table, in that case insert a pivot chart - Modify the pivot chart when the pivot table changes - Collect and set the number format for the values - isDataFromSpreadsheet check for the creation wizard - In ChartView (and VLegend) check if the data provider is a pivot chart data provider and get the pivot table field names to create the buttons on the UI. - Adds the functionallity to show a filter pop-up (from calc) when clicking on row / column / page field buttons. - Remove (X)PopupRequest as we won't need it. - Add ODF import/export for pivot charts: + Added loext:data-pilot-source attribute on chart:chart which is the internal name of the pivot table with which the pivot chart is associated with. If the element is present, then the it means the chart is a pivot chart, else it is a normal chart + Added service to create pivot chart data provider through UNO + Add new methods to XPivotChartDataProvider to create value and label data sequences separately from the data source, which is needed for pivot chart import + When importing defer setting the data provider until a later time when we know if we are creating a chart od a pivot chart - Pivot chart ODF round-trip test - Add table pivot chart supplier API: This adds the XTablePivotChartSupplier and related interfaces so we can access, create, delete pivot charts from UNO in a sheet document. With this we now distinguish between normal charts and pivot charts. This was mainly needed because we can't extend the "published" interfaces of TableChartSupplier. - Added an extensive test, which uses the API to create a new pivot chart when there was none, and checks that the pivot chart updates when the pivot table updates. Change-Id: Ia9ed96fd6b1d342e61c2f7f9fa33a5e03dda21af Reviewed-on: Reviewed-by: Tomaž Vajngerl <> Tested-by: Tomaž Vajngerl <>
2017-03-31use actual UNO enums in chart2Noel Grandin2-0/+35
Change-Id: I05d4eed55f5deba4b1802389d1ba94582d30550f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-03-25Fix typosAndrea Gelmini2-1/+1
To re-integrate the fixes in revert commit ab92c84dfe600f320f37b6126cab11385a6fbdd1 we have also to update the binary ods, to avoid break of "make check". Change-Id: Ic044d43c6c3c3d9fc3e003c282fac4ba888a0115 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Julien Nabet <>
2017-03-25Fix typosAndrea Gelmini1-2/+2
Change-Id: If92860597a44ee79b513d255ce3f21112485a97e Reviewed-on: Reviewed-by: Julien Nabet <> Tested-by: Julien Nabet <>
2017-03-16Revert "ChartDumpTest: Use local EPS for Mac only"Tamás Zolnai1-12/+0
This reverts commit 4f786274be8f9b01b34ad0772bcf718d5259bdc0.
2017-03-15ChartDumpTest: Use local EPS for Mac onlyTamás Zolnai1-0/+12
On linux it was not a problem. On Windows there were some random failures, but that might be fixed by using Liberation Mono font. Change-Id: Iae2684b302b3380c3a63b1fa80b1d0585454ed56 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Zolnai <>