summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2014-01-24coverity#736909 Allocation too small for typeCaolán McNamara1-1/+1
Change-Id: I330ebdfd94d0c30b40e180e307d7543c09fd334b
2014-01-24coverity#736908 Allocation too small for typeCaolán McNamara1-1/+1
Change-Id: Ic41c5071957f5e95322971f8ec3ef864edecdb20
2014-01-24coverity#706117 Allocation too small for typeCaolán McNamara1-2/+2
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
2014-01-22remove SvStream::operator<< methodsNoel Grandin5-13/+13
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22convert more SvStream::operator<< callsNoel Grandin1-1/+1
.. to more explicit SvStream::Write* calls This was done using another run of the clang rewriter, and then a lot of hand tweaking to fix all the places where the rewriter did not play nice with various macros. Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18 Reviewed-on: https://gerrit.libreoffice.org/7494 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22Add some unit-tests for Mid vb function (includes fdo#73771)Julien Nabet4-0/+60
Change-Id: Ib5ee18207897cbe16a818096769cdb055dc9dad7 Reviewed-on: https://gerrit.libreoffice.org/7583 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2014-01-21bool improvementsStephan Bergmann1-1/+1
Change-Id: I64288207adb083e006b4acc5e7f26d647236a443
2014-01-21Resolves: fdo#73771 Non-standard behaviour for Function MidJulien Nabet1-1/+2
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2 Reviewed-on: https://gerrit.libreoffice.org/7539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-19how should I fix this memory leak??Markus Mohrhard1-1/+0
2014-01-19CID#706118: possibly invalid castMarkus Mohrhard1-1/+3
2014-01-17Whatever those "true" arguments to SotStorage ctor may once have meantStephan Bergmann1-2/+2
...is lost to history, but they are effectively equivalent to pssing default SorageMode nStorageMode = 0 today, as the only thing that is done with that nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx) is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED (0x44). Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17fdo#73698 check for empty aOutAndras Timar1-1/+1
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6 Reviewed-on: https://gerrit.libreoffice.org/7474 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-16Environment variables can contain >127 charactersAndras Timar1-1/+1
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin1-1/+1
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-14bool improvementsStephan Bergmann3-6/+6
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin11-100/+100
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-06Resolves: #i123817# prepare codebase for updating to boost 1.55Herbert Dürr3-4/+4
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153) Conflicts: basic/source/comp/parser.cxx basic/source/comp/token.cxx dbaccess/source/ui/dlg/generalpage.cxx sc/source/ui/unoobj/chart2uno.cxx vcl/quartz/salbmp.cxx Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2013-12-20typo fixesAndras Timar1-1/+1
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann1-2/+2
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann1-1/+1
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-11sbxbase.hxx is private to basicTor Lillqvist3-2/+54
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
2013-12-11sbstdobj.hxx is private to basicTor Lillqvist4-3/+139
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
2013-12-11sbprop.hxx is private to basicTor Lillqvist2-1/+69
Change-Id: I1d7a28652ee7743b6823d78e1565338a324f0a6a
2013-12-11sbobjmod.hxx is private to basicTor Lillqvist6-5/+109
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
2013-12-11basic/global.hxx is private to basicTor Lillqvist3-2/+28
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
2013-12-08Drop duplicate #includeTakeshi Abe2-3/+0
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-02Resolves: #i74854# fix buttons in MsgBox with info iconHerbert Dürr1-1/+1
Patch by: hanya.runo@gmail.com Found by: ooo@catcons.co.uk Tested by: hdu@apache.org (cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c) Conflicts: basic/source/runtime/methods.cxx vcl/inc/vcl/msgbox.hxx Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-2/+2
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann1-1/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+1
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-34/+24
Change-Id: I32e4a80e99885c561a30e8f059c9b9a24c4bd3c7
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-10/+1
Change-Id: I4e47b5194992d3847a689284d7600be92a4ead26
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin2-7/+7
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11basic: include <> for external includesNorbert Thiebaud24-75/+75
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann1-1/+0
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-1/+1
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11remove unnecessary use of OUString constructor in BASIC moduleNoel Grandin8-38/+38
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
2013-11-01add limits.h for rhel-6 buildCaolán McNamara1-1/+2
Change-Id: I9d355be54eb4072044ad660296375fca8d0fa831
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-1/+1
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28fixincludeguards.sh: basicThomas Arnhold36-76/+76
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
2013-10-28windows: warning 4355 is disabled globally in com_MSC_defs.mkThomas Arnhold1-5/+0
So there is no need to do this locally, too. Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-23clean up places accessing the NULL at the of an OUStringNoel Grandin2-9/+13
There were only a couple of real bugs fixed, but we're a little bit safer now. This also fixes the assert and the comment in OUString::operator[] about this. Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist7-9/+9
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara1-1/+1
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-21fdo#68849 add some header guardsThomas Arnhold2-0/+10
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f Reviewed-on: https://gerrit.libreoffice.org/6364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-17The getSupportedServiceNames implementations will already take careStephan Bergmann1-1/+0
Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
2013-10-17fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza1-12/+2
to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-15clean up SbiScanner::NextSym() a little, fdo#70319 follow-upEike Rathke2-51/+74
Number recognition was suboptimal and didn't properly resync scan positions after having detected an error. Change-Id: I278fdaaf17ed40560785deaaad0e3412a249d90a
2013-10-15Defer OUString -> OString conversionStephan Bergmann3-20/+15
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon. Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
2013-10-14work around crappy SbiScanner::NextSym(), fdo#70319Eike Rathke1-1/+3
just to make test not fail that was wrong anyway Change-Id: Ibbb8214b64be0e9a82e2bde406abdcfd2e84c734