summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann2-4/+4
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09deref of nullCaolán McNamara1-2/+2
regression from commit f17a4694b07856292804c23b80ce92967d401bb8 Author: Arnaud Versini <arnaud.versini@gmail.com> Date: Sat Feb 13 20:17:41 2016 +0100 BASIC : use std::unique_ptr for storing SbiExprList Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec Reviewed-on: https://gerrit.libreoffice.org/22345 because they have been moved into the container at this point Change-Id: If21e0321ffdce66aa9629637d0ff8c16efbbd25e
2016-03-09loplugin:constantparam in basicNoel Grandin1-2/+2
Change-Id: I5b49406535c1ec95e47fe237a23184a499b875e5
2016-03-08tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo4-12/+28
Replaced boost::noncopyable with plain C++11 deleted copy ctors in /basic/* files. Change-Id: I9c0eb0a51ec5cb25c88c72b55f42864e73006e6b Reviewed-on: https://gerrit.libreoffice.org/22969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-08Remove ancient StarPortal leftoversStephan Bergmann4-160/+0
No UNO bridge has a "user" token in its description anyway, so needsSecurityRestrictions always returned false. Change-Id: Ibc3aa25212a2e8b245c13578fa29582be42791e6
2016-03-07basic: tdf#87530 if a new password is set, must set mbLoadedSource flagMichael Stahl1-0/+10
... so that the library is stored (and encrypted), and not copied unencrypted from source storage. Change-Id: I9546087ec6f07007aa1ec377d2e959f2bae99a38
2016-03-07basic: tdf#87530 don't copy storage that doesn't existMichael Stahl1-2/+15
If the Basic library is newly created it may not have been stored to the document storage yet. (regression from 5246fa262450f686674850c53df666422f441c86) Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8
2016-03-07tdf84938 Replaced Sb_Attr_ defined constants with enum class in runtime.hxxSteven Guo3-24/+31
Replaced the #define Sb_Attr_* constants with SbAttributes enum class in runtime.hxx and adjusted uses in methods.cxx. Change-Id: Ic7f6f6452849ffc9675ffd697ffc130276082318 Reviewed-on: https://gerrit.libreoffice.org/22948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin2-8/+4
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:unuseddefaultparams in basicNoel Grandin9-42/+28
Change-Id: I286efdac6af47a859693fccc71b445915f76945c
2016-03-02tdf#84938 Change average enum for scoped enumbaltasarq2-23/+25
This is a [partial] patch for tdf#84938, involving the substitution of an average enum for a scoped one. Change-Id: I4b3a19914d30a14dec2640355ba392b943e1ddd7 Reviewed-on: https://gerrit.libreoffice.org/22808 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26tdf#84938 Eliminate B_xxx defines in filefmt.hxx for FileOffset scoped enum.baltasarq2-40/+44
Second step: Make SbiOpenRecord() accept a FileOffset as second parameter This is a [partial] patch The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants B_xxx that were located in filefmt.hxx and were changed for a FileOffset enum class. Obviously some other files where the type is used must be changed too. Change-Id: I7406bdc8e780ee89802ab6823f9c91c4c9b765c0 Reviewed-on: https://gerrit.libreoffice.org/22697 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25coverity#1231668 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: I4c83b1290484dabc9d40f970a3a86de5d6dc3928
2016-02-25change to SearchOptions2Eike Rathke1-4/+5
Change-Id: I07a72492f1cdc566109bf8e9247368558f420abe
2016-02-24simply the SbxRes stuff, inheriting from OUString is ickyNoel Grandin7-33/+23
Change-Id: Ie9794ea164d587ad87ee13d360cb3abc18166051
2016-02-24Removing #defines for String_XXX in sbxres.hxxbaltasarq7-42/+44
This is a [partial] patch for BUG #84938: https://bugs.documentfoundation.org/show_bug.cgi?id=84938 The objective is to substitute all apparitions of #defined constants for enum class. The victim here is the series of constants STRING_xxx that were located in sbres.hxx and were changed for a StringId enum class. Obviously some other files where the type is used must be changed too. Change-Id: I31fa684eb5eb3508d2025c9a319d5b245cc177af Reviewed-on: https://gerrit.libreoffice.org/22655 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22Actually, why passive voice?Tor Lillqvist1-1/+1
Change-Id: Ib8723c7ef1f74b7cfb4efa8e13e34953bff7d0da
2016-02-22Fix mis-translated German commentTor Lillqvist1-1/+1
Change-Id: I9c2dbccdc789b58c583e033a8d5627e0a95a95f9
2016-02-22loplugin:commaoperator in basic/Noel Grandin14-42/+156
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
2016-02-22BASIC : Add tools::make_ref and simplify SvRef usageArnaud Versini6-73/+53
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8 Reviewed-on: https://gerrit.libreoffice.org/22587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22WaE vs2015 truncation of literal on static_castNorbert Thiebaud1-0/+7
Change-Id: I63a89c50c653145ea49aa34e4e4dd554da66598f Reviewed-on: https://gerrit.libreoffice.org/22597 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin8-12/+12
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#40517 Unit test for question marks in number formatLaurent Balland-Poirier1-0/+4
Unit test for https://gerrit.libreoffice.org/21021/ Add unit test for Engineering format Add unit test for optional sign in exponent Change-Id: I958ccdcc68a4e496cbd4bdc74d0650c133f3a3f7 Reviewed-on: https://gerrit.libreoffice.org/21824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17BASIC : use std::unique_ptr for storing SbiExprListArnaud Versini5-49/+37
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec Reviewed-on: https://gerrit.libreoffice.org/22345 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16tdf#39440: reduce scope of local variablesArnold Dumas1-4/+1
Change-Id: I6ba411d2e07240821518281996d543f71acf3259 Reviewed-on: https://gerrit.libreoffice.org/22378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin2-7/+7
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-15cppcheck: unreadVariableCaolán McNamara1-22/+20
Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce
2016-02-15fix indentCaolán McNamara1-7/+7
Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077
2016-02-12tdf#95857 Sort out German plurals ...danielt9983-8/+8
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-09Remove excess newlinesChris Sherlock26-117/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08BASIC : Use std::unique_ptr in SbiExpression and SbiExpListArnaud Versini3-41/+30
Change-Id: I6f09615d19560673319e103af36c40c94ea77f12 Reviewed-on: https://gerrit.libreoffice.org/22186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-08sequence->vector in basicNoel Grandin3-7/+6
Change-Id: Ic42f7218bda81effe870d950f666ba7653d60c66 Reviewed-on: https://gerrit.libreoffice.org/22177 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08sequence->vector in basicNoel Grandin2-20/+17
Change-Id: Ic1b72a6c5e9df5d0fa65626ec1d8eda6a2d2feec Reviewed-on: https://gerrit.libreoffice.org/22176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin4-16/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08BASIC : Use vector in SbiExprList to avoid any dependenciesArnaud Versini3-76/+19
Change-Id: I1ae88ae9c4276452a00aadaaadebf582e639b15a Reviewed-on: https://gerrit.libreoffice.org/22174 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05basic: Merge macro snippet testsMatúš Kukan13-375/+217
Change-Id: Ia2d8944227c6be8b5ae7b42f7d566ac150d522b9
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke1-1/+1
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04loplugin:fpcomparison in basic/Noel Grandin2-2/+2
Change-Id: I76ffac6a0f0b1525c85d1995277d3ca22ef268e1 Reviewed-on: https://gerrit.libreoffice.org/21869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin1-3/+3
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-27BASIC: SbiExpression::IsIntConstant has side effects.Arnaud Versini3-5/+5
Also renames IsIntConstant to ConvertToIntConstIfPossible. Change-Id: Ib4b465ac0d890762547fb2d83c26ad6be6ee75e8 Reviewed-on: https://gerrit.libreoffice.org/21746 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin2-5/+5
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-24BASIC : Remove class SbiDimList and SbiParametersArnaud Versini4-81/+55
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af Reviewed-on: https://gerrit.libreoffice.org/21734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2016-01-24BASIC : Remove SbiExprList::pParserArnaud Versini3-17/+13
Change-Id: Ib9386d97ddb12f148cf76dc71aa8c41003286f50 Reviewed-on: https://gerrit.libreoffice.org/21534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16BASIC : Remove useless virtual function overrideArnaud Versini2-7/+0
Change-Id: I0f8e480bf73256e7f1284e11983cc70c0426172c Reviewed-on: https://gerrit.libreoffice.org/21513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16BASIC : Remove useless methods in StarBasicArnaud Versini2-20/+10
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d Reviewed-on: https://gerrit.libreoffice.org/21498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15basic: coverity#1348466 checked returnMichael Stahl1-5/+10
Kind of unnecessary but let's hope it shuts up coverity. Change-Id: I4903c9df788ce5fb9648c5fd68627ff21362828f
2016-01-13-Werror=misleading-indentation (GCC 6)Stephan Bergmann1-1/+2
Change-Id: Ia633b859df94ede325469ec8a20e7383d2a178d4
2016-01-12loplugin:loopvartoosmallNoel Grandin1-1/+1
Change-Id: Ifa813b91b153004aa0fba42cdc209f4c4fd9578f
2016-01-12loplugin:unusedmethods unused return value in include/basicNoel Grandin6-37/+26
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0 Reviewed-on: https://gerrit.libreoffice.org/21360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 07:32:15 +0000