summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza5-0/+5
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22Revert "Simplify ImplRepository::impl_getLocationForModel return type"Stephan Bergmann1-4/+4
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus, cf. the comment in ImplRepository::getDocumentBasicManager about recursive calls.
2014-08-22Remove BasicManagerCleanerStephan Bergmann1-18/+4
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22Simplify ImplRepository::impl_getLocationForModel return typeStephan Bergmann1-4/+4
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22Remove trivial typedef, to make code more obviousStephan Bergmann1-9/+8
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-21coverity#1202729 - ensure we have exactly a one dimensional array.Michael Meeks1-0/+1
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
2014-08-18drop unnecessary shl.hxx includesCaolán McNamara2-2/+0
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-17coverity#1231668 Unchecked return valueCaolán McNamara2-3/+3
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
2014-08-13update_pchThomas Arnhold1-1/+2
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-11-Werror,-Wundefined-bool-conversionStephan Bergmann4-9/+9
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-01typo: more then -> more thanTakeshi Abe1-1/+1
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-29basic: -Werror=sign-compareMichael Stahl1-1/+3
Change-Id: I7c776faa74a61b0d263c3b446972da9461b3d4f6
2014-07-29fdo#46037: remove unused comphelper/configurationhelper.hxxAlexandre Vicenzi1-1/+0
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa Reviewed-on: https://gerrit.libreoffice.org/10603 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29convert linked list to std::vector in SbxDimArrayNoel Grandin1-61/+40
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23 Reviewed-on: https://gerrit.libreoffice.org/10298 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-24fdo#52076 remove empty library instead of writing it out emptyLionel Elie Mamane1-1/+5
Change-Id: Id4fd8c4f34e8ed07044eb428049731c4b9b694ca Reviewed-on: https://gerrit.libreoffice.org/10507 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-24Drop unused #includesTakeshi Abe2-7/+0
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
2014-07-18Drop an unused functionTakeshi Abe2-21/+0
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
2014-07-17fdo#75757: remove inheritance to std::vectorTakeshi Abe2-33/+21
... which was introduced at 2110397670695991b3a5cd28a15ba0ffd2a3a611. Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c Reviewed-on: https://gerrit.libreoffice.org/10363 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert4-4/+4
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16Avoid possible memory leaks in case of exceptionsTakeshi Abe3-15/+15
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
2014-07-11new loplugin: externalandnotdefinedNoel Grandin7-27/+51
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-06DBG_ASSERT->assert when followed by dereferenceCaolán McNamara1-2/+2
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8
2014-07-03coverity#706241 Uncaught exceptionCaolán McNamara2-9/+31
we've already checked to see if the element exists, so we know that its not there. Change-Id: I538c0d48a883d478e4c748d222b21958d083c049
2014-07-01coverity#706240 Uncaught exceptionCaolán McNamara1-11/+17
Change-Id: Ie31f5e1ff74ff8b9f35d7ce08e1f02a780375890
2014-07-01coverity#735397 dead codeNorbert Thiebaud1-5/+1
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
2014-07-01clang scan-build: various warningsCaolán McNamara1-2/+2
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann2-3/+0
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-26clang: Dead initializationCaolán McNamara1-2/+1
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26clang: Returning null referenceCaolán McNamara1-3/+5
Change-Id: I2cfc14e73696a027283dfa5eef98f784505dc5a3
2014-06-26clang: Uninitialized argument valueCaolán McNamara1-6/+4
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-25Remove this weird inheritance from smart-pointer-wrapped class.Kohei Yoshida1-114/+122
SbxVarEntry is now its own class. Change-Id: I5c5ce1990fa83930acced1d507f5b0de60bf221e
2014-06-25Use boost::optional to store alias name.Kohei Yoshida2-32/+23
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
2014-06-25pData -> mpVarEntries.Kohei Yoshida1-43/+43
pData is a nightmare with grepping as it's too generic of a name. Change-Id: I01b3f1b503f21ee13c97733fa66804874a2cddc4
2014-06-25Remove this class that only derives from std::vector and not much else.Kohei Yoshida1-24/+12
Change-Id: Ibc584f4148cec49a9ac34a240cc2fa3e87daf443
2014-06-25fixes for up-casting to Reference<XInterface>Noel Grandin3-7/+8
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-19basic: silence expected SAL_WARN outputMiklos Vajna2-3/+3
These were HACK() and DbgOut() messages previously, none of these ended up on stderr. It seems that they are more or less harmless, so as long as nobody fixes them, silence them, so more useful warnings are not hidden when one does e.g. xray on a drawinglayer shape. Change-Id: I7343d93d2916d9978852418aca725d027eb09128
2014-06-17coverity#1210096 Uncaught exceptionCaolán McNamara1-5/+11
Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0
2014-06-17coverity#1210098 Uncaught exceptionCaolán McNamara1-5/+12
Change-Id: I531891fa1cce10a331dd651ee9ce52d1f8d0c169
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin5-21/+1
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann10-31/+31
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
2014-06-13coverity#1213486 Uncaught exceptionCaolán McNamara1-10/+18
Change-Id: Ia4d919d88bf22168aa770ad35fd8360b0b155efe
2014-06-10iprevent violation of exception specMarkus Mohrhard1-1/+6
Change-Id: I1f638ae3a2e88e0cadaab0046ef087fe77e16b06
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin7-25/+2
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-04Do not both _use_library_objects and _use_libraries sbStephan Bergmann1-1/+0
Change-Id: I11f667104a0ca7279542fab53ad754d4de8c807d
2014-06-04Avoid static BasicDLL (that would be destroyed after DeInitVCL now)Stephan Bergmann1-7/+2
Change-Id: Id8968a7746815ecce79b6eb1ce971b74e770efa4
2014-06-04DeInitVCL at end of testsStephan Bergmann4-0/+4
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04WaE: warning C4101: 'ex' : unreferenced local variableThomas Arnhold1-1/+1
Change-Id: Ib8b71b50fe52a7cc4e261626549ac3e067851797
2014-06-02basic: typoThomas Arnhold1-1/+1
Change-Id: I10c9e480a94a966dac4f6c17fc69fa8892c56955
2014-06-02Fix memory leak for BASIC sub (as well as void function)Stephan Bergmann1-2/+8
d88593af59d9126cdbcd6c0a5b06fb9c673dc6f9 "INTEGRATION: CWS ab34: #i73457# Prevent sub from beeing set as param 0 for return type void" to fix i#73457 "Memory Leak in all Basic type void Method calls" had made the PutDirect call dependent on != SbxVOID only (which would cover void functions) but not also on != SbxEMPTY (which would apparently be required to also cover subs, as seen with CppunitTest_basic_vba run under lsan). Either this was an oversight with the original fix, or subs have meanwhile changed from GetType() == SbxVOID to SbxEMPTY? Change-Id: I3e5dbf79bfd5eea3cfec8ed3fa984d13167aa501
2014-05-31Avoid possible memory leaks in case of exceptionsTakeshi Abe4-28/+16
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf