summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2013-06-14blind ( windows ) fix re. uno::Refererence vs rtl::Reference foobar fdo#65545Noel Power1-1/+1
Change-Id: I81b877e8e1b6945c2f1265947ad915ed1070800a (cherry picked from commit c32dd08cfbaefb0d0a75a303b182e68d073ee262)
2013-06-03SfxLibraryContainer::storeLibraries_Impl: make saving basic macros work againMiklos Vajna1-0/+2
Regression from cbd1a89676f39135ed2e9c47d20475b2053289b9, that commit accidentally not only removed the #if 0 block, but also two other braces -- because of this, in case bStorage was false, nothing was saved. The effect of this was that if the user edited some macro in the basic IDE, then saved the macro, it was shown as saved, but in fact that didn't happen. Change-Id: I20f8358dddfb226976be72f95dcad64de88d83c3 (cherry picked from commit 06138c2a5575b45109dc609453300aa74df22800)
2013-05-29Improve DialogProvider service ctorStephan Bergmann1-22/+22
...recently introduced with c75a46fbd0ba4daf857fcd7d70badeed5aae8e28 "fdo#46808, use DialogProvider service constructor." The general theme of this additional ctor appears to be more about "Scripting" than "Listener," and the DialogLib argument is actually expected to be of XNameContainer type. Change-Id: Iea7d906d9b2ffc3b3ee5b2cbfaf7c58191037c9b (cherry picked from commit 69e697deefc9bebefa2daac4ae4b8cde5ae742f1)
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann3-10/+38
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998 (cherry picked from commit e36f83d81c462e1a5959b160886e481a8d449494)
2013-05-21fdo#46808, Convert awt::XUnoControlDialog to new styleNoel Grandin1-1/+1
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin2-37/+9
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-20fix wildcard handling regression( for basic functions like Dir ) fdo#64536Noel Power1-1/+1
Tweak another fallout from String->OUString Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist4-7/+7
2013-05-15fdo#46808, Use service constructorsNoel Grandin1-43/+4
Change-Id: I34a41cde5d40e14803859116648c8da9f50c4b07
2013-05-14fdo#46808, use DialogProvider service constructorNoel Grandin1-15/+8
Change-Id: I1652be5cefd00892426cf8559cadc9605ad8d439
2013-05-14fdo#46808, Convert script::InvocationAdapterFactory to new styleNoel Grandin1-38/+26
Change-Id: I2fe24c863f4c43471f46032ed15fcd5b98863fc1
2013-05-14fdo#46808, use XComponentContext in SfxLibraryContainerNoel Grandin4-35/+33
Change-Id: I6f66fc69a40e2cd2ef2372e0413ff95b6202c5c5
2013-05-14fdo#46808, replace XMultiServiceFactory with XComponentContext is SfxLibraryNoel Grandin6-23/+23
Change-Id: I150d86b4ae4004e7c39ec6a3ed7fba31029f8ab1
2013-05-09fix VBA mode MkDir when passed folder is not a full pathNoel Power1-0/+22
Change-Id: I7fd804999f1b96e6aab112445edcd9dcf7753c24
2013-05-09remove #if 0 block ( from af34774d260a68fc02cd78ba90dd8d4afaf1a2a4 )Noel Power1-45/+15
I left in that block in the mentioned commit above for mostly because I preferred a more obvious hack/change to cherry-pick to 4.0 The more I think about this ( despite the still imho problematic setting of the modify state ) I think always writing from memory to the storage is the right thing to do Change-Id: I13c82b9d6b55120482c65fb7a5bfadb2396c347c
2013-05-08hopefully this fixed the strange autorecovery related dataloss fdo#42899Noel Power1-0/+14
also this is a fix for bnc#817477 Disabling the optimisation of copying the library container storage to target storage for the moment ( hopefully after some rework it might make some sense to re-enable this code ) The problem here is there is a tragic flaw in the api implementation. In the implementation the library in-memory model state reflects that the library model has been saved to storage but not the library container storage as you ( or at least I ) would expect but actually any storage. So to illustrate the problem, during autorecovery when the basic library containers are stored to the autorecovery file the library pImplLib->implIsModified() is set to false, any subsequent save attempt will think the library is not modified and will attempt to the librarycontainer storage to the target one. However, in this case the source (library container) storage has never been updated with the changes from memory. Can't we simply only update the 'implIsModified' state only if the library container's own storage and the storage to store to are the same ? Sounds like a good idea, unfortunately this is not possible due to the way that sfx spaghetti code uses temporary storages for even own copies and also because it sets the new root storage for the library container after the library copy happens. ( some stuff in dbaccess appears to depend on this as well ) AFAICT for any document save/saveas etc. operation the librarycontainer's own storage and the storage we save to are *always* different. So for the moment it seems best to *always* write the storage from the in-memory model. Change-Id: Ia24e7a6119558497d901370dbc0986101bde4de9
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks3-3/+3
2013-04-26fix windows buildThomas Arnhold2-0/+6
Change-Id: Id5d51292c0ee9c6bf62a2ceac6a80cbfd3e09605
2013-04-26some more namespace cleanupThomas Arnhold6-9/+9
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-24Combine fairly pointlessly split source code for SbiRuntime into one fileTor Lillqvist6-3538/+3443
Insert basic/source/runtime/step[012].cxx into basic/source/runtime/runtime.cxx. Follow-up to https://gerrit.libreoffice.org/#/c/3373/ . In many cases the sources for some class have been split up into several source files, typically suffixed with a number 0, 1, 2 etc. Presumably this has been done because some compiler years ago was not capable of compiling all the source for that class at one time, or some other no longer relevant reason. It would be nice to get rid of this convention, so that clever compilers have a better chance of noticing unused private fields in a class, for instance. Just combining the source files in question into one source file and removing the old source files from git leads to a discontinuity in version control history. But the consensus seems to be that this is not such a big deal. I picked these sources just because they happened to be the first ones I came across when looking for files called *0.cxx. Change-Id: Ia7e8ece9a4374721bbcce6b0e2aba5721436faae
2013-04-24gbuild: drop empty use_packages callsDavid Tardon1-3/+0
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: https://gerrit.libreoffice.org/3503 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon2-6/+0
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23execute move of global headersBjoern Michaelsen28-3493/+0
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2-42/+10
2013-04-20fdo#63154: Change Min/Max/Abs for std::min/max/absMarcos Paulo de Souza1-1/+1
Now all these usages were removed from LO. Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Reviewed-on: https://gerrit.libreoffice.org/3326 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-18get rid of some Germanism (and some Windowsism)Eike Rathke2-13/+13
Change-Id: I2ca1b34ff688a7d4fcf6c84c02035eda3ab0dee8
2013-04-18Revert "svformatter already accept OUString input", fdo#63306Eike Rathke1-3/+5
This reverts commit c5e5699c80cfb32a164696a2c5144b5ccb0a91a9. And adapts to OUString. Conflicts: basic/source/runtime/runtime.cxx Change-Id: Icd7c1e1e57162eefb1f3631aa5509fd3a09c9b08
2013-04-18date/time IDL datatypes incompatible changeLionel Elie Mamane1-1/+1
- nanosecond precision - signed (allowed negative) year Also: assorted improvements / bugfixes in date/time handling code. Some factorisation of copy/pasted code. Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-17-Werror=unused-macros (MinGW, GradientStyle_RECT)Stephan Bergmann1-1/+0
...hopefully unnecessary today anyway? Change-Id: Ib3c621f46311c90d159fe0f08655c01d25024d7d
2013-04-12Get rid of SHL_SBCTor Lillqvist3-13/+9
GetAppData(SHL_SBC) was used only locally in the sb library so no need for it. Just use a static pointer field. Change-Id: I37c8429b6c9e521a00c52bb622f78bdc4afe345c
2013-04-12basic: SbCompare_UString_PropertyValue_Impl MSVC workaroundMichael Stahl1-0/+6
MSVC 2008 with _DEBUG calls this with parameters in wrong order so needs another overload to make it happy. Change-Id: I906483ecf5325d7aa742e3d93afb151501374abb
2013-04-10Introduce characters utilities in rtl/character.hxxArnaud Versini1-25/+6
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with slight modifications to sal/inc/rtl/character.hxx: * Replaced "#pragma once" with explicit include guard for now. * Missing includes. * Cosmetic clean-up. Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
2013-04-07remove needless forward rtl::OUString declarationsLuboš Luňák1-1/+0
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák33-146/+146
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-05new module i18nlangtagEike Rathke10-10/+10
Moved portions from module i18npool, all of former i18nisolang1 library that now is i18nlangtag. Included are languagetag, isolang and mslangid. This i18nlangtag code is now even used by module comphelper, so disentangling i18npool and making this an own module was needed to not create circular module dependencies. Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
2013-04-03fdo#58807 bring Beep() for basic backThomas Arnhold1-0/+2
The functionality was removed by fdo#48549. This partially reverts 0f6101cfef4c2e45d9f1f1b3a61ef94799e4526b 0bdf6fc7c71c4c49e6d6f83d56ac953272ad16d5 85cb9084533605657aca0394afe4516058a8e4ef I changed the behavior to always beep, because only the basic macro function is using Beep(). Looks like the Beep macro function didn't even work correctly before the removal, because the default was to not beep for most platforms. So I set the volume from disable (0) to 50% for XBell(). Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a Reviewed-on: https://gerrit.libreoffice.org/3124 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-04-01remove boilerplate commentsThomas Arnhold1-2/+0
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01Use local utility functions instead of SbxSimpleCharClassArnaud Versini1-32/+26
Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef Reviewed-on: https://gerrit.libreoffice.org/3132 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-03-30fix loplugin warningsPeter Foley1-0/+2
Change-Id: I17593ac6e495213a1ef99d4d5525a6e38aee0bc7
2013-03-29ResMgr with LanguageTagEike Rathke2-4/+2
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-28Bypass extension scanning unless HAVE_FEATURE_EXTENSIONSTor Lillqvist1-0/+4
Change-Id: I6ada96fc5cea895b967387c10814a7003e1e492b
2013-03-27-Wunused-macrosStephan Bergmann5-19/+1
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-25sal_Bool to boolTakeshi Abe1-3/+3
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
2013-03-24basic: Remove non working AboutStarBasicThomas Arnhold3-10/+0
The content of this function was commented out since the first import. So as it does nothing remove it. Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482 Reviewed-on: https://gerrit.libreoffice.org/2899 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-23coverity#704205/704206/704207 Logically dead codeJulien Nabet1-3/+3
Change-Id: Ic2cbd96f393a21cf2c6634d3c5e5a4c5a5b486ef
2013-03-22in Val() check status after stringToDouble()Eike Rathke1-3/+14
instead of calling checkArithmeticOverflow() Change-Id: I2e3307ee054db77bab0a106d886823dba9e56ea8
2013-03-21added unit test for 10e308 math overflowEike Rathke1-0/+11
Change-Id: I492d991545239539d21fb59de3eccdd1ab56a9af
2013-03-21SbiScanner::NextSym: check status after rtl_math_uStringToDouble()Eike Rathke1-2/+5
For example, 10e308 is overflow, not 0 ... Change-Id: Ib7d622865bfb73581732bda45c76e078ee7d05d0
2013-03-21another variation of the localised Cdbl testNoel Power1-0/+14
Change-Id: Icf6dd7428cb88f1891c6d816a24a4126ea2cc135
2013-03-20tweak basic_coverage test to support locale specific testingNoel Power3-2/+57
in basic some function results are influenced by locale, now in the basic_coverage directory you can have sub dirs ( named by the proper locale e.g. de-DE etc. ) and any macros found there will be run in the desired locale Change-Id: I625ee58d37493f83a15a62214bde6708e8fa75f7
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-04 23:13:13 +0000