summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2013-05-20fix wildcard handling regression( for basic functions like Dir ) fdo#64536Noel Power1-1/+1
Tweak another fallout from String->OUString Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd (cherry picked from commit 175509176433cf5df2d98718e1a6f9cf5bbe9658) Reviewed-on: https://gerrit.libreoffice.org/3975 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-13hopefully this fixed the strange autorecovery related dataloss fdo#42899Noel Power1-0/+14
also this is a fix for bnc#817477 Disabling the optimisation of copying the library container storage to target storage for the moment ( hopefully after some rework it might make some sense to re-enable this code ) The problem here is there is a tragic flaw in the api implementation. In the implementation the library in-memory model state reflects that the library model has been saved to storage but not the library container storage as you ( or at least I ) would expect but actually any storage. So to illustrate the problem, during autorecovery when the basic library containers are stored to the autorecovery file the library pImplLib->implIsModified() is set to false, any subsequent save attempt will think the library is not modified and will attempt to the librarycontainer storage to the target one. However, in this case the source (library container) storage has never been updated with the changes from memory. Can't we simply only update the 'implIsModified' state only if the library container's own storage and the storage to store to are the same ? Sounds like a good idea, unfortunately this is not possible due to the way that sfx spaghetti code uses temporary storages for even own copies and also because it sets the new root storage for the library container after the library copy happens. ( some stuff in dbaccess appears to depend on this as well ) AFAICT for any document save/saveas etc. operation the librarycontainer's own storage and the storage we save to are *always* different. So for the moment it seems best to *always* write the storage from the in-memory model. Change-Id: Ia24e7a6119558497d901370dbc0986101bde4de9 Reviewed-on: https://gerrit.libreoffice.org/3832 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-19Revert "svformatter already accept OUString input", fdo#63306Eike Rathke1-3/+5
This reverts commit c5e5699c80cfb32a164696a2c5144b5ccb0a91a9. And adapts to OUString. Conflicts: basic/source/runtime/runtime.cxx Change-Id: Icd7c1e1e57162eefb1f3631aa5509fd3a09c9b08 (cherry picked from commit 1ef2cce787df3d254a78ebdb469fb06668f350f4) Reviewed-on: https://gerrit.libreoffice.org/3468 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-16follow on fix for fdo#62090 ensure out of range startpos is handledNoel Power1-2/+6
Change-Id: Ic1f57480a36415998748faeea3b606a47d277181 (cherry picked from commit 0054b438013ef412c2df3b7ebe93dd1935ec07af) Reviewed-on: https://gerrit.libreoffice.org/3409 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-04-16fix for fdo#62090 Mid function regressionJulien Nabet1-1/+1
Change-Id: Ia6a73d6a44a34345b512922037d01b8b40ac24a8 (cherry picked from commit 14d452d0c2874f47f0b6ac1cd1c725195d5d69a9) Reviewed-on: https://gerrit.libreoffice.org/3408 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-04-04fdo#58807 bring Beep() for basic backThomas Arnhold1-0/+2
The functionality was removed by fdo#48549. This partially reverts 0f6101cfef4c2e45d9f1f1b3a61ef94799e4526b 0bdf6fc7c71c4c49e6d6f83d56ac953272ad16d5 85cb9084533605657aca0394afe4516058a8e4ef I changed the behavior to always beep, because only the basic macro function is using Beep(). Looks like the Beep macro function didn't even work correctly before the removal, because the default was to not beep for most platforms. So I set the volume from disable (0) to 50% for XBell(). Reviewed-on: https://gerrit.libreoffice.org/3124 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com> (cherry picked from commit 47664d3f2e12649d324b031ca6ffd5589fe3d197) Conflicts: vcl/inc/headless/svpframe.hxx Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a Reviewed-on: https://gerrit.libreoffice.org/3185 Tested-by: Thomas Arnhold <thomas@arnhold.org> Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-03-20resolved rhbz#919020 Basic CDbl() and CSng() scan localized numberEike Rathke1-78/+117
Code wrongly replaced decimal separator with '.' and used atof() to scan the number string which itself may be localized on *iX systems but not on Windows. Hence on *iX the numbers may had been truncated where on Windows they were not. Additionally made this work with Unicode separators if defined for the locale, removed the awkward conversion to ASCII byte string and eliminated use of toupper() and isdigit() calls. Also eliminated a possible buffer overflow. (cherry picked from commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d) Conflicts: basic/source/sbx/sbxscan.cxx replace decimal separator at correct position, rhbz#919020 (cherry picked from commit e96c7a60c88bc1e3008ebdeafd59327933d6707f) Change-Id: I35d82e8f267ecb925783bf6f2de044a29c08f688 Reviewed-on: https://gerrit.libreoffice.org/2859 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-19WaE: Werror=shadowCaolán McNamara1-7/+7
Change-Id: I7f1bddbed85076f1c909d0d9f4ecdd1cda6f1880 (cherry picked from commit 4158ae52fb4a0d1141637593c47aed3bb5378e7e) Reviewed-on: https://gerrit.libreoffice.org/2861 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-03-15unittest and test data for bnc#809017Noel Power2-3/+28
Change-Id: I3ccae692db44bb3ce41b371f0b511a9db7181bf4 Reviewed-on: https://gerrit.libreoffice.org/2759 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-15detect follow-on default member of default member object bnc#809017Noel Power2-0/+29
Change-Id: I366c049fc342240081957b81d2f28bfcf8d4e331 Reviewed-on: https://gerrit.libreoffice.org/2758 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-15Rehash basic unit test frameworkNoel Power19-233/+1629
Create new Macro helper class to help invoking macros for unittests Change-Id: Icc3cbfc3eae6ade037960497e7fe2addf1912897 (cherry picked from commit a9fc6ee7dc640f016728bf524d684696a376e989) use "doUnitTest" as the method to search for, tweak error reporting Change-Id: I0c0f4ce1304b561bf94af5444c83d8920062568b (cherry picked from commit 49417b0b68e8c9743bd6f664a5f8b4a0f3c19723) adapt existing tests to use MacroSnipper helper class Change-Id: I50980d9510b82277a5da04cc4f6c1d3ec8e7c756 (cherry picked from commit 8534787f95dfbfff24167b2160cfe07a1b70bcc6) Nested_Struct should really inherit from test::BootstrapFixture Change-Id: I06255940f41c32493187d1ec847f7238fef4e9f8 (cherry picked from commit 20f12a1d7ad5f9694f901a85e1fa22f46c3953a2) finally remove no long needed BasicTestBase Change-Id: Ic1522b0c3a292af061f5777e06e796dd82884fbf (cherry picked from commit fea9b3a99a24366b4dea22ed1b79f34046f7f521) Add some stand alone vba specific tests ( mostly vba only functions ) Change-Id: I137e93a8af67b7eec4c51348caf3d0d03dbbce73 (cherry picked from commit 76c3184813c97224cfd1e114ec13796e1da040d5) fix String->OUString foobar Change-Id: Ia924e6e8f3cfa25b131185713699d64e9d339357 (cherry picked from commit f202b21770b9d36522ff811868b911d0f1c852a6) doh! sReturnStrg is OUStringBuffer, no need to assign Change-Id: I490d20e8b494b4f59277b1cc92c73beb65a05813 (cherry picked from commit a9813b9ab307591a4c8a06fd01a4ef82126cfb18) fix WAE mbError unused Change-Id: I03bae6808008dcb0b53b1e816f3fe84739036773 (cherry picked from commit 4596120336b575d94d305c4139054afd95d2f740) remove duplicate file loading from basic_coverage ( now in MacroSnippet ) Change-Id: I1b19fec59419575fcf09d79986b6bac73ea51c9a (cherry picked from commit 46bab17e6d48c2279f4698d46f01db5404b0ba6f) unit tests and data for bnc#805071 Change-Id: I36fefa280ee922cbade676c951b753e632c9d8bb (cherry picked from commit 0f7798d86226d8e93fbd624283cd3558c7dd63fe) remove some rtl:: and RTL_CONSTASCII_USTRINGPARAM foo Change-Id: I68e2891999f306865d00b33fdfef3bc539a34e93 (cherry picked from commit 54d70501380f818fc928557590ed70e6f5a925f7) basic: make the makefile a bit nicer Change-Id: Ib606c0a9c84b35f4ab4b10dd7dc4dd82e85fcb71 (cherry picked from commit 954611cdea0ae4b0dab4f241e580c4f61792dc8b) Windows oleautobridge depends on ATL Change-Id: I94b43b03f742da7c6c8cf2e6a60ed305c1395fa7 (cherry picked from commit b0bcadf62a631b6cce5a5188f8018f266e1b99ee) Reviewed-on: https://gerrit.libreoffice.org/2757 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-15bnc#805071 fix object assigment problems when default members presentNoel Power1-11/+32
Change-Id: I6f7dfd369a36aff06f15b9a3affadb9d19787a9c (cherry picked from commit d06f4577b52df5f390809850f26663e2e62d0ff1) Reviewed-on: https://gerrit.libreoffice.org/2756 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-13Fix Set/Let mixup ( from String -> OUString rework ) fdo#60752Noel Power1-1/+1
Change-Id: I56f3e8b54d80f4575937f8515e8a8d9318353b8d (cherry picked from commit 9dcfc56c7cd76de237f45cf46448c14cfbb2f45c) Reviewed-on: https://gerrit.libreoffice.org/2705 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-18fix basic access to nested uno structures fdo#60117Noel Power2-8/+250
Although basic might appear to correctly change nested struct elements fdo#60117 shows that basic can be fooled ( and even the watch(ed) variable in the debugger shows the expected values ). The problem stems from the fact that the uno object held by basic isn't infact modified when changed via the introspection uno service. Additionally pimp the existing tests to check the actual uno struct to see if the changes made are *really* reflected in the object also includes commit:0ee3d79b98af3c249f47c77a0298a80f01300be5 blind wae fix for CPPUNIT_ASSERT_EQUAL Change-Id: Iff007e17df87148ea81e69d3567c8cf9857fdcaa Reviewed-on: https://gerrit.libreoffice.org/2099 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-07fix for fdo#60065Noel Power2-0/+25
squash errors trying to gain object for rhs ( where no object yet exists ( Change-Id: I81548d1c6a32f0445dc18e31c84c3df85163ed45 Reviewed-on: https://gerrit.libreoffice.org/2003 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-01-07fdo#53521 Crash when running BASIC's "shell()" with a non-existent programChristopher Copits1-1/+5
The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not. Therefore, a segmentation fault would result, as a random memory address would be freed. This patch checks whether osl_executeProcess was successful. If it was, then it frees the handle; if it wasn't successful, the memory is not freed. Change-Id: Ic3af07be06e7af7730a3bcb1680c659a88b66af3 Reviewed-on: https://gerrit.libreoffice.org/1530 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit dbfc8777bf73872d1b96f956b9e778d9099d52b3)
2012-12-29fdo#58222 The BASIC HEX Command now returns uppercase hexadecimal charactersChristopher Copits1-1/+3
Instead of returning lowercase characters with BASIC's HEX command, uppercase characters are now returned. Digits from 0-9 are not affected. This change utilizes on OUString's toAsciiUpperCase() method. Change-Id: Id6ea93a7635c1913c8592bf5519bdd7391f4e3bc Reviewed-on: https://gerrit.libreoffice.org/1428 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-12-20fix crash for fdo#58306 by avoiding literal assignNoel Power1-1/+1
OUStringBuffer doesn't handler append ( if it had been previously assigned to "" literal ) Change-Id: Ief4379490a4873fbee4117db5833111943b86334
2012-11-30c++ API: use css alias in generated headers, adds global css declThorsten Behrens1-2/+0
This changes all generated API headers (.hpp and .hdl) to use a namespace alias 'css' instead of the pointlessly long com::sun::star Makes the change in cppumaker & associated tools, adds a global namespace alias definition in sal/types.h, and removes a kiloton of local, now pointless-to-harmful versions of that alias from all over the code. Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-28fdo#46808, Adapt reflection::ProxyFactory UNO service to new styleNoel Grandin1-6/+2
The service is deprecated, but we still have a handful of in-tree users, and converting it lets me thread XComponentContext through a bunch of classes. Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-25German comment translationsMarkus Maier2-2/+2
Change-Id: I0d169b7cd0f47b6986063d0cc0b6697b1d575e6a
2012-11-23some i18n wrappers with LanguageTagEike Rathke2-4/+4
Change-Id: I2ceaa3159e8669c2c569fa8559c1e061dcad399d
2012-11-22AllSettings with LanguageTagEike Rathke12-18/+21
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22convert users of XDocumentInfo to XDocumentPropertiesMichael Stahl1-1/+2
Change-Id: I10f395f90d554d0ec26fe9f2654ae839e21c7ee5
2012-11-20Merge branch 'feature/killsdf'Andras Timar1-1/+1
Conflicts: desktop/prj/build.lst helpcontent2 l10ntools/Executable_gsicheck.mk l10ntools/Executable_uiex.mk regexp/inc/regexp/reclass.hxx solenv/gbuild/AllLangResTarget.mk Change-Id: I398f0cd9e7daefa8d2e04fd977d5bc2e9708169b
2012-11-19Bin the HACK() sillynessTor Lillqvist1-3/+3
Change-Id: Ieeebc4098404fa006d66bb8b656172a4348b1dc1
2012-11-18PutEntry familly of functions use consistent pairing OUString/sal_Int32Norbert Thiebaud3-5/+5
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18basic: fix OUString copy overrun in Mid()Norbert Thiebaud1-1/+12
Change-Id: I91cdd3a52917b89ab2a452e0eeb7a9e00dc35e8b Reported-by: vmiklos@suse.cz
2012-11-15fdo#46808, use service constructor for ucb::SimpleFileAccessNoel Grandin8-78/+65
I upgraded the service to return XSimpleFileAccess3, since it already implemented that interface, and it's backwards compatible. Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-14Clean upStephan Bergmann1-38/+25
Also, avoid global static data in sb lib, so that gengal.bin now also works well on Mac OS X, cf. 12fa9ece663f24eff44197befe546a92e6c90724 "Avoid global static data." Change-Id: I23f2a7abc0c06a752ded1c1c64619b3aab009190
2012-11-14Report errors for invalid DateAdd/Diff/Part Add parameter valuesStephan Bergmann1-3/+3
...so that e.g., DateAdd("x", 1, "1/31/2004") (where "x" is not in the list of valid values for the Add parameter, "yyyy", "q", "m", etc.) leads to a Basic runtime error rather than going into a seemingly endless while(nNewMonth>nTargetMonth) loop at the end of RTLFUNC(DateAdd) (basic/source/runtime/methods.cxx). Change-Id: I15c3bdb62723ffddf36ff2396ffb294369d93ff8
2012-11-11Merge branch 'master' into feature/killsdfAndras Timar96-4671/+7502
Conflicts: Repository.mk RepositoryFixes.mk connectivity/prj/build.lst extensions/prj/build.lst filter/prj/build.lst fpicker/prj/build.lst l10ntools/StaticLibrary_transex.mk saxon/build.xml shell/prj/build.lst solenv/gbuild/AllLangResTarget.mk solenv/gbuild/Configuration.mk solenv/gbuild/UI.mk ucb/source/ucp/webdav/webdavcontent.cxx
2012-11-08fix more warning C4804 unsafe use of type boolMichael Stahl1-1/+1
... from commit bbf1bcd9ad9cc0368aef4a4de41e9538f6ad91b0 Change-Id: Ic8e52f6848e09a274133f2d8fd1c4044cae4b039
2012-11-07BasicScriptListener_Impl::firing_impl: actually this is the defaultMiklos Vajna1-1/+1
Change-Id: I0fdb522a1119da4a75094db86217449e9d940d19
2012-11-07basic: fix String -> OUString conversion in BasicScriptListener_ImplMiklos Vajna1-1/+1
Regression from commit ac476e78848ad02fd399633acbe9cb72e40d1235, the second parameter of OUString::copy() is not the end position, but the length. In practice this makes xray usable again. Change-Id: I9f345648c851b61e2e3c581bc605af7df4c12c87
2012-11-07basic: adapt dllmgr-x64.cxx to OUString changesMichael Stahl1-3/+3
Change-Id: I9e5ff5be1f001a9f55953fd516fb5ef7fe94bf44
2012-11-07Fix String -> OUString falloutTor Lillqvist1-3/+3
Change-Id: I038848aed0c64c39ca93da89b4a78bd3a1f6d7d0
2012-11-07basic: String -> OUStringNorbert Thiebaud67-2975/+3529
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-05fdo#46808, Adapt i18n::Transliteration UNO service to new styleNoel Grandin2-5/+5
Simply make the service implement XExtendedTransliteration, since all of the implementatins already do that. Change-Id: If03bf56a8d33931ad0230743a4603e2ae9b104ac
2012-11-04Fix .Len -> getLengthJulien Nabet1-1/+1
Change-Id: Ibe3e97a6fa59098b9234e4aae04118abc4e37eea
2012-11-03basic add a generic unit test fixtureNorbert Thiebaud5-0/+310
basic_coverage is a generic unit test that scan qa/basic_coverage/* each file there is supposed to be a well formed Basic script that define as least a Function doUnitTest as Integer that return 1 if OK, 0 if not OK Change-Id: I6c3cfac1e7ce4748f46c04344102a0eff69b6a49
2012-11-03basic: preliminary cosmetic clean-upNorbert Thiebaud43-1049/+2593
parsing 1000s of line of code is hard enough without having to fight with weird indentation and irregular formatting. So as the review progress, in order to follow the code, cosmetic changes were made... In order to minimize the task of the reviewers and allow them to concentrate on what matter, an effort is made to collect these cosmetic changes into this separate commit. Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
2012-11-03basic: OUStringification of ddectrlNorbert Thiebaud5-44/+81
Change-Id: I2af40d7c8117aff8ce62a8ea0eec579664f8bdeb
2012-11-03basic migration to OUStringNorbert Thiebaud4-71/+180
Change-Id: I1f9403174b3779801d91ba20d846191ed9a09eed
2012-11-03basic: convert StepPAD to OUStringNorbert Thiebaud1-3/+7
Change-Id: I19d05f455767c973a47d0233b3af20af1ac3a20a
2012-11-03simplify and use OUString for StepLOADNCNorbert Thiebaud1-8/+4
Change-Id: I92c86f672cc79506c2c7c56bb3402b4436f71c98
2012-11-03basic: use OUString in DimAsNewRecoverItemNorbert Thiebaud1-5/+5
Change-Id: Icfecff549161c3c429524549b65752671792a94f
2012-11-03basic: unnecessary round-trip via StringNorbert Thiebaud1-1/+1
Change-Id: I691a59b8ab9e6352a9257dac35b8e378e6ef9666
2012-11-03basic: avoid String<>OUString issue by by-passing them completelyNorbert Thiebaud1-2/+20
Change-Id: If741661f1151950a2180fa5c6504957b44a7e998
2012-11-03basic: clean-up String from eventatt.cxxNorbert Thiebaud1-38/+55
Change-Id: I78f39310dbb0a024af4268f503a6150451f12778
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 08:05:45 +0000