Age | Commit message (Collapse) | Author | Files | Lines |
|
Also create a Clang compiler plugin to detect such cases.
Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752
Reviewed-on: https://gerrit.libreoffice.org/4001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I40d2e2ddd92186a2ba22ebfbdda8367391e8d355
|
|
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
|
|
Tweak another fallout from String->OUString
Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd
|
|
|
|
Change-Id: I34a41cde5d40e14803859116648c8da9f50c4b07
|
|
Change-Id: I1652be5cefd00892426cf8559cadc9605ad8d439
|
|
Change-Id: I2fe24c863f4c43471f46032ed15fcd5b98863fc1
|
|
Change-Id: I6f66fc69a40e2cd2ef2372e0413ff95b6202c5c5
|
|
Change-Id: I150d86b4ae4004e7c39ec6a3ed7fba31029f8ab1
|
|
Change-Id: I7fd804999f1b96e6aab112445edcd9dcf7753c24
|
|
I left in that block in the mentioned commit above for mostly because
I preferred a more obvious hack/change to cherry-pick to 4.0
The more I think about this ( despite the still imho problematic setting
of the modify state ) I think always writing from memory to the storage
is the right thing to do
Change-Id: I13c82b9d6b55120482c65fb7a5bfadb2396c347c
|
|
also this is a fix for bnc#817477
Disabling the optimisation of copying the library container storage
to target storage for the moment ( hopefully after some rework
it might make some sense to re-enable this code ) The problem here is
there is a tragic flaw in the api implementation. In the implementation
the library in-memory model state reflects that the library model
has been saved to storage but not the library container storage
as you ( or at least I ) would expect but actually any storage.
So to illustrate the problem, during autorecovery when the
basic library containers are stored to the autorecovery file the
library pImplLib->implIsModified() is set to false, any subsequent save
attempt will think the library is not modified and will attempt
to the librarycontainer storage to the target one. However, in this case the
source (library container) storage has never been updated with the changes
from memory.
Can't we simply only update the 'implIsModified' state only if the library
container's own storage and the storage to store to are the same ?
Sounds like a good idea, unfortunately this is not possible due to the way
that sfx spaghetti code uses temporary storages for even own copies and
also because it sets the new root storage for the library container
after the library copy happens. ( some stuff in dbaccess appears to
depend on this as well )
AFAICT for any document save/saveas etc. operation the librarycontainer's
own storage and the storage we save to are *always* different.
So for the moment it seems best to *always* write the storage from the
in-memory model.
Change-Id: Ia24e7a6119558497d901370dbc0986101bde4de9
|
|
|
|
Change-Id: Id5d51292c0ee9c6bf62a2ceac6a80cbfd3e09605
|
|
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
|
|
Insert basic/source/runtime/step[012].cxx into
basic/source/runtime/runtime.cxx.
Follow-up to https://gerrit.libreoffice.org/#/c/3373/ .
In many cases the sources for some class have been split up into several
source files, typically suffixed with a number 0, 1, 2 etc. Presumably this
has been done because some compiler years ago was not capable of compiling all
the source for that class at one time, or some other no longer relevant
reason.
It would be nice to get rid of this convention, so that clever compilers have
a better chance of noticing unused private fields in a class, for
instance. Just combining the source files in question into one source file and
removing the old source files from git leads to a discontinuity in version
control history. But the consensus seems to be that this is not such a big
deal.
I picked these sources just because they happened to be the first ones I came
across when looking for files called *0.cxx.
Change-Id: Ia7e8ece9a4374721bbcce6b0e2aba5721436faae
|
|
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f
Reviewed-on: https://gerrit.libreoffice.org/3503
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac
Reviewed-on: https://gerrit.libreoffice.org/3502
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
|
|
|
|
Now all these usages were removed from LO.
Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I2ca1b34ff688a7d4fcf6c84c02035eda3ab0dee8
|
|
This reverts commit c5e5699c80cfb32a164696a2c5144b5ccb0a91a9.
And adapts to OUString.
Conflicts:
basic/source/runtime/runtime.cxx
Change-Id: Icd7c1e1e57162eefb1f3631aa5509fd3a09c9b08
|
|
- nanosecond precision
- signed (allowed negative) year
Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.
Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
|
|
...hopefully unnecessary today anyway?
Change-Id: Ib3c621f46311c90d159fe0f08655c01d25024d7d
|
|
GetAppData(SHL_SBC) was used only locally in the sb library so no need for
it. Just use a static pointer field.
Change-Id: I37c8429b6c9e521a00c52bb622f78bdc4afe345c
|
|
MSVC 2008 with _DEBUG calls this with parameters in wrong order so needs
another overload to make it happy.
Change-Id: I906483ecf5325d7aa742e3d93afb151501374abb
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with slight modifications
to sal/inc/rtl/character.hxx:
* Replaced "#pragma once" with explicit include guard for now.
* Missing includes.
* Cosmetic clean-up.
Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
|
|
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
|
|
The functionality was removed by fdo#48549.
This partially reverts
0f6101cfef4c2e45d9f1f1b3a61ef94799e4526b
0bdf6fc7c71c4c49e6d6f83d56ac953272ad16d5
85cb9084533605657aca0394afe4516058a8e4ef
I changed the behavior to always beep, because only the basic macro
function is using Beep(). Looks like the Beep macro function didn't
even work correctly before the removal, because the default was to
not beep for most platforms. So I set the volume from disable (0)
to 50% for XBell().
Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a
Reviewed-on: https://gerrit.libreoffice.org/3124
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
|
|
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
|
|
Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef
Reviewed-on: https://gerrit.libreoffice.org/3132
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I17593ac6e495213a1ef99d4d5525a6e38aee0bc7
|
|
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
|
|
Change-Id: I6ada96fc5cea895b967387c10814a7003e1e492b
|
|
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
|
|
Change-Id: Ibc63340b3ae431c7cdac78893dbdd1989ebe5ff9
|
|
The content of this function was commented out since the first import. So as it does nothing remove it.
Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482
Reviewed-on: https://gerrit.libreoffice.org/2899
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Change-Id: Ic2cbd96f393a21cf2c6634d3c5e5a4c5a5b486ef
|
|
instead of calling checkArithmeticOverflow()
Change-Id: I2e3307ee054db77bab0a106d886823dba9e56ea8
|
|
Change-Id: I492d991545239539d21fb59de3eccdd1ab56a9af
|
|
For example, 10e308 is overflow, not 0 ...
Change-Id: Ib7d622865bfb73581732bda45c76e078ee7d05d0
|
|
Change-Id: Icf6dd7428cb88f1891c6d816a24a4126ea2cc135
|
|
in basic some function results are influenced by locale, now
in the basic_coverage directory you can have sub dirs ( named
by the proper locale e.g. de-DE etc. ) and any macros found
there will be run in the desired locale
Change-Id: I625ee58d37493f83a15a62214bde6708e8fa75f7
|
|
Change-Id: I97a652e6a1286726fe21ae580f6dbf5536f9d52d
|
|
Code wrongly replaced decimal separator with '.' and used atof() to scan
the number string which itself may be localized on *iX systems but not
on Windows. Hence on *iX the numbers may had been truncated where on
Windows they were not.
Additionally made this work with Unicode separators if defined for the
locale, removed the awkward conversion to ASCII byte string and
eliminated use of toupper() and isdigit() calls. Also eliminated a
possible buffer overflow.
Change-Id: Ic3f791601c321ef1386fe51a5244d3dacac3d908
|
|
Change-Id: I6ff724052660d73b583fb1e44265a60a6fa4379f
|