summaryrefslogtreecommitdiff
path: root/basic/qa
AgeCommit message (Collapse)AuthorFilesLines
2016-10-28Bypass VBATest::testMiscOLEStuff() in a 64-bit Windows build for nowTor Lillqvist1-2/+4
It fails when Excel is installed, for some reason: Basic error: Type: com.sun.star.uno.RuntimeException Message: [automation bridge] unexpected exception in IUnknownWrapper_Impl::invoke ! Message : [automation bridge]: [Microsoft][ODBC Driver Manager] Data source name not found and no default driver specified macro result for ole_ObjAssignNoDflt.vb macro returned: C:/cygwin64/home/Tor/lo/64bit-debug/basic/qa/cppunit/test_vba.cxx:155:`anonymous namespace'::VBATest::testMiscOLEStuff assertion failed - Expression: pReturn->GetOUString() == "OK" - Result not as expected Note that this test returns early if Excel is not installed, so it is effectively not performed anyway even in 32-bit builds on most (any?) Jenkins and tinderbox machines. Change-Id: I0a0b6f27219dec116369fae1bb7c95b3e9597e77 Reviewed-on: https://gerrit.libreoffice.org/30329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-07tdf#99696 fix build error for 64bit Windows in unit tests using ADODBTomofumi Yagi1-2/+22
This patch fixes the problem that the build for x64 fails in basic module on 64bit Windows installed 32bit Excel Application. New code checks the existance of ODBC driver for excel insted of the existance of Excel application(at this time the bitness of ODBC driver for excel would match that of building LibreOffice). What we need is probably not Excel Application but ODBC drivers for proper bitness. Change-Id: I62285eb2351f2022754fc34cb2d54db1bd9e8142 Reviewed-on: https://gerrit.libreoffice.org/25301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d2a44e62704f185a0acecbb6320b92a4df3063b9) Reviewed-on: https://gerrit.libreoffice.org/25981
2016-05-23Convert SbxClassType to scoped enumNoel Grandin1-1/+1
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove needless typedef from basic/qa/cppunit/basic_coverage.cxxRyan McCoskrie1-6/+5
Change-Id: Iba1c48d58daa618107ad84240d613f675d447aad Reviewed-on: https://gerrit.libreoffice.org/24175 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann2-4/+4
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin1-1/+1
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17tdf#40517 Unit test for question marks in number formatLaurent Balland-Poirier1-0/+4
Unit test for https://gerrit.libreoffice.org/21021/ Add unit test for Engineering format Add unit test for optional sign in exponent Change-Id: I958ccdcc68a4e496cbd4bdc74d0650c133f3a3f7 Reviewed-on: https://gerrit.libreoffice.org/21824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin1-2/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05basic: Merge macro snippet testsMatúš Kukan6-113/+146
Change-Id: Ia2d8944227c6be8b5ae7b42f7d566ac150d522b9
2016-01-04Use CPPUNIT_ASSERT_DOUBLES_EQUALStephan Bergmann1-42/+42
...except when checking for infinity Change-Id: If6e3b8965169cc615fa5d76422e1925866714936
2016-01-04loplugin:cstylecastStephan Bergmann1-40/+40
Change-Id: I5ecd63d79e8be77879d3789c45079929696abe03
2016-01-04tdf#96136 replace CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUALDipangar Niranjar1-428/+428
Change-Id: Ib45af8a56ac3adc428c530908cf1bbd95e9cc64c Reviewed-on: https://gerrit.libreoffice.org/21065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-11-30Get order of expected/actual args to CPPUNIT_ASSERT_EQUAL rightStephan Bergmann1-6/+6
Change-Id: I0fa26417630991c6d07b5412fb579f9c222d09a6
2015-11-29generate better unit test assert messageMarkus Mohrhard1-13/+13
Change-Id: Ibba7f18fefb4f2851472a6ae0b41447237a6b97f Reviewed-on: https://gerrit.libreoffice.org/20270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-11-25loplugin:unusedfields variousNoel Grandin1-7/+0
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann2-5/+5
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann1-2/+2
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni1-3/+3
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin1-4/+2
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-07-24loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20com::sun::star->css in basicNoel Grandin1-2/+2
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212 Reviewed-on: https://gerrit.libreoffice.org/17206 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15loplugin:unusedmethods basicNoel Grandin1-5/+0
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1 Reviewed-on: https://gerrit.libreoffice.org/17044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-1/+1
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-05-19basic: used typed LINKsNoel Grandin1-4/+4
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
2015-05-18missing semiCaolán McNamara1-1/+1
Change-Id: I3253f09d10cbe733fdf6387d90ab04d65ba9328e
2015-05-18cppunit: noExplicitConstructorCaolán McNamara1-4/+5
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
2015-04-30Gradually typed LinkStephan Bergmann1-1/+1
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-3/+3
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann1-1/+1
Change-Id: I6dd7c7fbaf0d4b22abba0a7b1f5e37f0a46d0747
2015-03-26WaE: this method is empty and should be removedTor Lillqvist1-0/+3
Change-Id: Ia5ec3890a4e57c460dab58fcd690530ebf836140
2015-03-23remove trailing blanks rubbishEike Rathke8-188/+188
Change-Id: I97cee7ea1d63375b73f0d4003022e9f09ad38e5f
2015-03-23more engineering notation format tests, tdf#30716Eike Rathke1-2/+42
Change-Id: Iefb035af9258c21e4fcc7f9b997f40ec318ed1ff
2015-03-23tdf#30716 Engineering notationLaurent Balland-Poirier1-2/+2
Implement engineering notation: fomat ##0.00E+00 for instance Saved in ODF thanks to https://gerrit.libreoffice.org/14875/ Change-Id: I1e401183a95ce05481a9af52e49bbcfe08cd1a20 Reviewed-on: https://gerrit.libreoffice.org/14886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-23Related fdo#87834: add 2 unit testsJulien Nabet2-0/+30
Change-Id: I4735b15c9535dc17665629510fdafe3dd4086e0b Reviewed-on: https://gerrit.libreoffice.org/13708 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19Fix typo comments Resouce->ResourceAndrea Gelmini1-1/+1
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2 Reviewed-on: https://gerrit.libreoffice.org/13985 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-11Related: #i94895# revert the part of revision 1650261Tsutomu Uchino1-1/+1
replaced string should be starting with the start postion if specified (cherry picked from commit 68c6265584fb6cb0469098507dd287e6e1127324) Conflicts: basic/source/runtime/methods.cxx Change-Id: Ib729facfa78ffddebc258440324f05d037fae46f
2015-01-09Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara1-1/+1
and adjust the basic test-case, which is surely wrong The syntax for REPLACE is: // Replace(expression, find, replace[, start[, count[, compare]]]) surely in the case of a start of 3 the preceeding chars should be returned unchanged in the result, not stripped off as before this change. This reverts commit 869402a58720b45e7227438b2e56e5a9532c0000. Change-Id: Ie710e4de9e7e35c84abe2770142a963532820af4
2014-12-30Rename "Mid" unit tests to distinguish cases with 2 and 3 argsJulien Nabet4-0/+0
Change-Id: Ie9241d0a28dc3871c9242123c9f000100e1a2fa1
2014-12-18basic: Use appropriate OUString functions on string constantsStephan Bergmann1-30/+30
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
2014-12-05fdo#38835 strip out OUString globalsNoel Grandin1-6/+6
Change-Id: I8bc386ffa88e31988bdc778a845403bec0772799
2014-10-23basic: move SbxAppData to a BasicDLL memberMichael Stahl1-1/+1
... so it is deleted by ~SfxApplication. Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
2014-09-19vba - disable Currency test / invocation on master.Michael Meeks2-3/+5
We're missing an effective SbxCURRENCY conversion here. Change-Id: Id6530ed3a93623b31089304f3451d9693ab4f3af
2014-09-19vba: add a different variant of the same compatibility function.Michael Meeks2-1/+106
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
2014-09-19vba: initial impl. of compatibility methods.Michael Meeks4-7/+94
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
2014-06-04Avoid static BasicDLL (that would be destroyed after DeInitVCL now)Stephan Bergmann1-7/+2
Change-Id: Id8968a7746815ecce79b6eb1ce971b74e770efa4
2014-05-13basic: update descriptions and add some more testsThomas Arnhold1-6/+20
Change-Id: Ice829c70482171bbfc22719e4b9e30c5ac058f5e
2014-05-13basic: Add CDec unit testThomas Arnhold2-0/+73
Change-Id: I9152f00239e5d407f9b33016caadb6a01770fed3
2014-05-02coverity#1209779 & coverity#1209780 Resource leakChris Sherlock1-0/+2
Have the testBasics() function clean up after itself - delete p2 and p4 at the end of the function. Change-Id: Ib0c732e1962da94fde0e0da307f610dd36f49eda
2014-04-17remove executable bitAndras Timar1-0/+0
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681