path: root/basic/inc
AgeCommit message (Collapse)AuthorFilesLines
2018-03-20drop unnecessary includesCaolán McNamara1-1/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2018-01-02RID_* can be extern global variablesNoel Grandin1-1/+1
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-11-10loplugin:finalclasses in basic,basegfxNoel Grandin1-7/+3
Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-10-23loplugin:includeform: basicStephan Bergmann1-1/+1
Change-Id: I6fbba5c4619eec7ae03fed65a18974faa0f190af
2017-10-10basic: consistently use "" and <> in include directivesMike Kaganski1-1/+1
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski1-9/+9
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <>
2017-08-25no need to use ERRCODE_RES_MASK hereNoel Grandin1-128/+128
the relevant usage sites already call GetRest() before comparing Change-Id: I5e8ce3a3c2b6972810aa527356f6350c61b8bd63 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara1-27/+0
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2017-08-01loplugin:checkunusedparamsNoel Grandin1-6/+6
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-07-21migrate to boost::gettextCaolán McNamara4-15/+174
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-20loplugin:constparams in basicNoel Grandin1-3/+3
Change-Id: Idf55f63f2d56be4997a8cdc6afc5690eacac9a60 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-07-02loplugin:casttovoid: basicStephan Bergmann1-3/+3
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
2017-06-15replace SbxError typedef with ErrCodeNoel Grandin1-1/+1
part of a larger patch to convert ErrCode to strong_int Change-Id: Ia56e5d6d8c4217d6f258e2113d20ce737977892f Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2017-05-02loplugin:checkunusedparams in basctl and basicNoel Grandin1-9/+9
Change-Id: I077ce96aed3c79045d5e8438109a8b1690ff1218 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock1-1/+1
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: Reviewed-by: Chris Sherlock <> Tested-by: Chris Sherlock <>
2017-03-17remove unused defines from HRC files in variousNoel Grandin1-1/+0
Change-Id: Ia1ba313d2438f04a84bcfcbbbcf6fffea5c1921d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-01-26Remove dynamic exception specificationsStephan Bergmann1-1/+1
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, basicStephan Bergmann1-0/+1
Change-Id: Ic3e265e05c69942c5c1c7d1b83f65f2cbe35ca1f
2016-10-19loplugin:expandablemethodds in basctl..chart2Noel Grandin1-1/+0
Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-09-13loplugin:dllprivateStephan Bergmann1-4/+3
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann3-7/+7
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-29BASIC : Remove useless SbxBase::GetCreatorArnaud Versini1-1/+1
Change-Id: I3d9aa358ffaefc11b7d2427f2b567c360be2c667 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-13BASIC: Use more often std::unique_ptrArnaud Versini1-1/+3
Change-Id: I37f3b35afcf3b4dba30a6ba841a59e0d851f1ebb Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-07-18BASIC: Remove useless overridesArnaud Versini1-5/+2
Change-Id: I49eb680bb0945a65a98978e98750fd62669fd820 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-06-27loplugin:singlevalfields in basic and fix leakNoel Grandin1-1/+0
And fix leak in BasicManagerImpl where it would never have freed the streams. Change-Id: I1e99c2c6a70a8cac27dd5c86a7042efc3de7a578 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-04-13loplugin:passstuffbyref in basicNoel Grandin1-2/+2
Change-Id: Ie93b33502325f00ba95ab168a445a347148f9edd
2016-04-12Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: Ic59b23de2c11e8a0a86c3711a4507cd76e07896f
2016-03-08tdf#94306 Replace boost::noncopyable with plain C++11 deleted copy ctorsSteven Guo1-3/+2
Replaced boost::noncopyable with plain C++11 deleted copy ctors in /basic/* files. Change-Id: I9c0eb0a51ec5cb25c88c72b55f42864e73006e6b Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <>
2016-01-05Fix typosAndrea Gelmini1-1/+1
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727 Reviewed-on: Reviewed-by: Andras Timar <> Tested-by: Andras Timar <>
2015-11-18remove unused typedefs and inline use-once typedefsNoel Grandin1-4/+3
and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-47/+59
Ported to Python with improved performance and features. The new script is invoked from the same which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts ( which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-11-115th step to remove tools/rtti.hxxOliver Specht3-7/+0
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Oliver Specht <>
2015-10-26basic: replace boost::ptr_vector with std::vector<std::unqiue_ptr>Michael Stahl1-3/+6
Change-Id: Ieba2fb34e0279871d36b4fe80d9de76e614b5cde
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-12/+12
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-18boost->stdCaolán McNamara1-1/+0
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-07-20com::sun::star->css in basicNoel Grandin1-5/+5
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2015-06-27coverity#1308445 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I831637f7f2fb2c552de8c20dc9f5da4e8783b935
2015-06-24remove SFX_NOTIFY macroNoel Grandin2-13/+9
it has not served any purpose since we switched to using normal C++ RTTI for the SfxHint objects Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe1-1/+1
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-05-19tdf#90110: basic: fix Randomize statementMichael Stahl1-1/+1
- time() is used to seed the RNG but since it only has second resolution, the same values will be generated if it's called multiple times like in the bug report - BASIC using the global rng would be fine except that BASIC Randomize takes an optional parameter to set the seed, which should continue to be supported, but should not affect the RNG state for non-BASIC users of comphelper::random (regression from df466d79cb126667cc9d5c108367bfa4f5ce76c8, but the old implementation was even more delightfully absurd, where Randomize was essentially srand((sal_uInt16)rand()) ...) Change-Id: I0f30e509de08f933c02ac77c5d932b20e79586c5
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin2-2/+2
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13loplugin:staticmethodsNoel Grandin1-6/+6
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-02-05Updated all precompiled headers.Ashod Nakashian1-1/+5
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin1-1/+1
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-07Resolves: fdo#87003 - Kill BOOST_FOREACHPieter Adriaensen1-1/+0
Conflicts: avmedia/source/framework/modeltools.cxx basic/source/sbx/sbxbase.cxx sd/source/filter/eppt/pptx-epptooxml.cxx svx/qa/unit/svdraw/test_SdrTextObject.cxx sw/qa/core/uwriter.cxx sw/source/core/doc/CntntIdxStore.cxx sw/source/core/doc/DocumentLinksAdministrationManager.cxx sw/source/core/doc/docnew.cxx sw/source/core/doc/gctable.cxx sw/source/core/doc/htmltbl.cxx sw/source/core/doc/sortopt.cxx sw/source/core/doc/tblcpy.cxx sw/source/core/doc/tblrwcl.cxx sw/source/core/docnode/ndcopy.cxx sw/source/core/docnode/ndtbl.cxx sw/source/core/docnode/ndtbl1.cxx sw/source/core/frmedt/tblsel.cxx sw/source/core/text/itratr.cxx sw/source/core/tox/ToxLinkProcessor.cxx sw/source/filter/xml/xmltble.cxx Change-Id: Id176d4e052c719c9afdf91ed450de84d8d2bc486 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-10-23basic: move SbxAppData to a BasicDLL memberMichael Stahl1-7/+3
... so it is deleted by ~SfxApplication. Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-08-13update_pchThomas Arnhold1-1/+2
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert1-1/+1
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: Reviewed-by: Thomas Arnhold <> Tested-by: Thomas Arnhold <>
2014-07-11new loplugin: externalandnotdefinedNoel Grandin1-0/+2
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2