path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2013-12-31don't access beyond end of empty stringCaolán McNamara1-0/+2
Change-Id: Ie772d7a60fd65b93ca66c543eb2786ce7f109004 (cherry picked from commit 978172bb00529b6283502abf7552fb0e828a7df5)
2013-12-16initial install-package-foo target for partial installsBjoern Michaelsen1-1/+1
make packageinfo target add uiconfig file translations add missing l10n config files add missing help files in packageinfo Reviewed-on: Reviewed-by: Björn Michaelsen <> Tested-by: Björn Michaelsen <> Conflicts: helpcontent2 translations a2498a118e729276a78ef3a4eb43b5d0b302d326 9bb39bdd677af4be0da621370c51eb9e22ecc33f a7e654cdeffd832f51016ff51aa180fe3924ff4e 4ee41fdb600cb3a89da387dffe64e6a30192761c 349fb24a388775c58be7a326832b3fc0ec38180f 8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06 Change-Id: Id5f6f5c1f3e46df2d9033ccd5bbf2af6ab38a9e8 Reviewed-on: Reviewed-by: Björn Michaelsen <> Tested-by: Björn Michaelsen <>
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-5/+5
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-1/+4
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin1-1/+1
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11basctl: include <> for external includesNorbert Thiebaud12-29/+29
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
2013-11-08fdo#71306: fix printing from basic ideIvan Timofeev1-1/+3
regression from e13a3d566ecc34a46e037aca1b2d70e58501e422 Change-Id: I0d734e112038746aa48df669d4b82b644a95c220
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-1/+1
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin2-4/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-1/+1
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28Remove unnecessary SyntaxHighlighter::Tokenizer statefulnessStephan Bergmann1-8/+0
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it. Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann1-3/+1
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Move implementation details to syntaxhighlight.cxxStephan Bergmann1-0/+1
(and clean up a little) Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann1-9/+9
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-25fdo#54938: More uses of cppu::supportsServiceMarcos Paulo de Souza2-40/+4
Change-Id: I90a7a07a43559b8d7e1d4b886b2624255200d46b Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Stephan Bergmann <> Tested-by: Stephan Bergmann <>
2013-10-23convert code to use OUString::endsWithNoel Grandin1-1/+1
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22HighlightPortion's indizes into strings should be sal_Int32Stephan Bergmann1-2/+2
(Had to fix type of some variables holding TextPaM::GetIndex() values from sal_uLong to sal_uInt16 to avoid -Werror,-Wsign-compare failures when comparing those against HightlightPortion's nEnd.) Change-Id: Ia8a0ba682ae28e86e394ee48adff3225eb8de053
2013-10-22Use conventional std::vector idiomsStephan Bergmann1-28/+36
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22Unwind HighlightPortions typedefStephan Bergmann1-8/+8
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist2-2/+2
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-16cleanupThomas Arnhold1-6/+0
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-12What (who?) are OW and MTF?Tor Lillqvist1-0/+5
Change-Id: I47b9b91d72e423c0ef37eaa9f081e755adfc36d6
2013-10-12Test WNT instead of the vague UNXTor Lillqvist1-3/+3
Change-Id: I99aa82d29d056afde92d258fd5cdf13359f9b74c
2013-10-11Basic: When we warned & stopped the program, don't warn again.Jan Holesovsky1-1/+1
It's extremely annoying to have to dismiss the warning with every keypress ;-) Change-Id: Ie117085ef25676065aedd0744cf618e1b566688b
2013-10-11-Werror,-Wunused-variableStephan Bergmann1-2/+1
Change-Id: Iac999c157d0d3fdb737bd2d92240e252cfb05333
2013-10-11Fix whitespace.Jan Holesovsky1-3/+3
Change-Id: I76acfa77eea862a1562521eea5160ed054f68650
2013-10-07CID#738562 uninitialized memberCaolán McNamara1-2/+3
Change-Id: I65f64b1604c9c0aa3538d6e9384014fd44e16c0b
2013-10-07CID#738561 uninitialized memberCaolán McNamara1-11/+12
Change-Id: Icac2ca781f067975746d4b861fcbd60e6577b64e
2013-10-07CID#738560 uninitialized memberCaolán McNamara1-5/+6
Change-Id: I270455041b73450e6ed1fc5a05e68c88db4310ab
2013-10-07CID#984418 unused returned pointerCaolán McNamara1-1/+1
Change-Id: I92864b2491882e0553b87d9d87d126ec30ef3974
2013-10-07CID#984417 unused returned pointerCaolán McNamara1-1/+1
Change-Id: I638d7d89b7c1414aac34bcf1c92fdde8eee98e2a
2013-10-07CID#738954 unused returned pointerCaolán McNamara1-1/+1
Change-Id: Ieb47b91dd745db400c7ad4756167de758a625a64
2013-10-03CID#738559 uninitialized memberCaolán McNamara1-5/+6
Change-Id: I68d9c84dbaa1a9a8d60d572027fcbc1d8c481e8e
2013-10-03CID#738558 uninitialized membersCaolán McNamara1-2/+4
Change-Id: I159693ff794482c772186947fa6ce5cb9aa71ad6
2013-10-02-Werror,-Wdeprecated-declarationsStephan Bergmann2-0/+28
Change-Id: I22101fec4b75e567153c6401ab754e1a5e158a77
2013-10-01convert basctl module from String to OUStringNoel Grandin14-146/+146
Change-Id: Iac38d4fd5d1d8b5c305bbb20eb1b40a7c7dec9bf
2013-09-22Related: fdo#38838 remove UniString::CompareIgnoreCaseToAsciiCaolán McNamara5-12/+12
Change-Id: I4a9b34d63d2534a35aa9a878b8c2bec15262c2be
2013-09-17convert basctl/source/inc/basobj.hxx from String to OUStringNoel Grandin3-7/+6
Change-Id: Ied011ae19ef850826f52f4ebd5a22dba0caf5d2b
2013-09-13fix for fdo#69173 crasherNoel Power1-0/+3
the layout changes for the basic IDE ( for the object browser and object catalog ) seem flacky, I have seen since those changes have been introduced some strange ( but random ) behaviour ( like the odd unrepeatable core ( maybe related to this ) and also sometimes Modules appearing in the tree under the wrong nodes etc. I'm no expert in the basic IDE code but this patch seems to fix the problem. However there is one drawback, in the core inducing scenario the tree view ( object catalog ) dissappears, this is because the patch suppresses the problematic layout in this case ( as the layout seem not to be currently able to deal with 'no-existent' (recently) deleted current window ) Probably in this scenario a fallback currentwin (instead of nil) could be set this would behave better but ideally. Ultimately the layout class should probably be modified ( possibly redesigned ) Change-Id: I9d1e23bd6fc4aae32aa78da8278c318f7051136a
2013-09-03WaE: C4101: 'ex' : unreferenced local variableTor Lillqvist1-1/+1
Change-Id: I804bafb4057e1bb409b7f30d79554f2773cb3967
2013-09-03completition->completion :)Ivan Timofeev2-6/+6
Change-Id: I7a5ae7cc0d6a253bbc27db076babedd65c89be1a
2013-09-02GSOC work, renaming+listbox right side fixGergo Mocsi2-5/+5
Fixed the small bug in positioning the listbox to the right side. Function ResizeListBox was renamed to ResizeAndPositionListBox. Change-Id: I3cea54ad5658ee1628935b4975f52fe78c1ff5c3
2013-09-02GSOC work, fix the clipped listboxGergo Mocsi1-27/+20
Listbox clipping works correcly on the right side and on the bottom. The function calculations are done from the initial position: if the actual X/Y coordinate + width/height exceeds the visible area, listbox is poitioned up/a bit left. Change-Id: I17ff28cd23423819b55d7079c6d35484b567899c
2013-09-02GSOC work, fixed clipping of the listbox in the bottomGergo Mocsi2-19/+18
Listbox positioning on the bottom is corrected. Change-Id: I75af0ff68b24ad26e9c9bd41d91a6ac9d1fa9d1c
2013-09-02GSOC work, arrow navigation+TextSelection problems fixedGergo Mocsi2-8/+34
I've added a new function called EditorWindow::GetLastHighlightPortionTextSelection, which gets the last edited word (from the highlight portion), and creates a TextSelection from it. Later, this is used to remove/replace text in the listbox when pressing the tab key. The proble was, that is cleared the whole line, but now, it just clears the newly edited word. Change-Id: I61b6721696e89002705c9980579023b42ad1faaa
2013-09-02GSOC work, fix strange TextPaM errorsGergo Mocsi1-25/+40
Wrong TextPaM's caused the autocorrection to insert the string multiple times, this is now fixed. I use the values from the HighlightPortion struct. Change-Id: I5ff5f01c06738088639186c35eb58ee9ff497d95
2013-09-02GSOC work, multiple fixesGergo Mocsi1-2/+2
Code completion: parser recognizes extended types ony when the checkbox is checked. Fixed a crash caused by a misspelled uno type. Fixed function CodeCompleteDataCache::Clear() to clear both internal variables. Change-Id: I82fdd2e1cf749237e2e2de4a9a2fc7d07fb7eb4a
2013-09-02GSOC work, options fixGergo Mocsi1-5/+8
Tools/Options are now saving correctly. I've added a check for empty string in EditorWindow::HandleCodeCompletition. Change-Id: Ib5d75fe840e3c3fd12cd7175fb7828b8a1d76db6
2013-09-02GSOC work, small fixesGergo Mocsi1-28/+22
Some code fixes in function EditorWindow::HandleAutoCorrect(): updating the module and getting the data from parse is necessary(not just when code complete is on). Removed some duplicate code when checking for the type of the actual highlight portion. Change-Id: I29a62dae23f2c28e54f9185ac59ff2747c64e0d7
2013-09-02GSOC work, autocorrect procedures+variablesGergo Mocsi1-6/+23
Fixed some small issue with the right arrow key in the ListBox. Autocorrection now correct all variable types and procedure names. Change-Id: Iff1abaf10c621aef04772837faa272bb6f987e37