summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2020-02-26explicitly call ActivatePageHdl when programatically calling set_current_pageCaolán McNamara1-3/+6
Change-Id: I6113e51565cf4f89e77829f56e08f6b98f2fe244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-26tdf#130925 use the maximum document line number for the width calculationCaolán McNamara1-1/+2
not the max line number in the range currently getting rendered Change-Id: I447e4152ef6a1ec327a95a8260d1616940e5d6c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25check if edit can be enabled after setting cursor into treeCaolán McNamara1-0/+1
Change-Id: I264dc4db7e3ddc64faf0edec18d96d2c46ce00f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann2-3/+3
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19can avoid including svtools/ctrlbox.hxxCaolán McNamara1-9/+1
Change-Id: I953089dd1416cd24721241fff3a6d21354211a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld CodeCompleteWindowCaolán McNamara4-145/+189
Change-Id: Ibe620a42592761ee25d6329d26b1b1c452bdfd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89007 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19merge common code togetherCaolán McNamara9-47/+24
Change-Id: I1c514c1a83dac4556ad68b44972a97fb4b3384e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19remove and replace newly unused ctorCaolán McNamara4-14/+7
Change-Id: I67e0dc6fe419ad0cac04105cb2e89435dd3fc107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld WatchWindow panelCaolán McNamara12-415/+430
Change-Id: Idb43d7bd168ce37fce8694946be6c7de7ca5a2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88930 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld StackWindow DockingWindowCaolán McNamara5-28/+111
Change-Id: I46626fdbfcaeabed48da9ae14fe5d351c335df55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld SelectorListBox Item WindowCaolán McNamara1-1/+1
Change-Id: I9752d03d9a70831d6e15fe3ac3ebdfc7d2728550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16use fwd decls of StatusBarCaolán McNamara1-2/+1
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16use fwd declsCaolán McNamara1-11/+1
Change-Id: I06a4049d84d3ef755b713c045f686361782bdfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88807 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16clang-format accessibility & basctl with under 5-percent lines of changeMuhammet Kara2-7/+4
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: Idc890cac4bb6aed4e36c3556a2abc0744fd086df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88770 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara1-1/+2
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara2-3/+2
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Restore simple undo and redo buttons for the basctl moduleMaxim Monastirsky1-3/+0
Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module. These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo. This commit removes the unused controller, and restores the previous behavior with the other controller. Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13use TopLevelWindowLocker for the lock other windows problemCaolán McNamara1-7/+6
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13remove unneeded includes and update pchCaolán McNamara3-6/+7
Change-Id: I6b38e96e6eb509e9d1ea0acaf30cb2a542bdbc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara1-1/+3
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 adding a document dialog or modules doesn't update catalogCaolán McNamara1-4/+7
in basctl UI, seems to be since... commit 44861f2435a0c487d4fb5b196f7e4fe7f9569396 Date: Fri Aug 17 07:29:20 2012 +0200 Object Catalog in Dialog Editor if it even really worked before that changed UpdateObjectCatalog to only get called for non-document changes Change-Id: I77a94bb4859cc399e86d75fdf2c9ca7c50288b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#57307 - Expand word boundaries to include connector punctuationsAndreas Heinisch1-6/+3
Include connector punctuations when adding a variable to the watch window using "Enable Watch (F7)" in order to add the correct variable name. Change-Id: Idaf7699dde3f4147d603c6aea4b2381e2af497a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I2b0fe68cf5346a6788bbd63242eadf872d58a87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88556 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-12drop newly unused TreeListBoxCaolán McNamara5-1057/+2
Change-Id: Iea157bb472ee409a1a15b9f6c9cfe0adc21d1a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12weld ObjectCatalogCaolán McNamara7-79/+122
Change-Id: I1979c6f8f5705360aa0df8cb7aeaeca00cd66ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12only freeze/thaw if we have toCaolán McNamara3-2/+22
because gtk will relayout and things jump around confusingly and unnecessarily Change-Id: I817e803f8ad7e523e5855326fc097f8798ddb679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12we always want to expand/collapse on double clickCaolán McNamara1-5/+5
Change-Id: Idf5496b44f5e2d5782d99317029aa0e9cb99e8d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara1-1/+1
a) for vcl version, listen to modify and select, instead of just modify so we can get the artificial select via uiobject that the mobile makes use of. (and disregard the modify which we know will lead to select so we get just one event in that case) b) default to assuming something has been picked "directly" unless we know otherwise. ideally the result is that https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: Ibbf33eab88dabd55d0c329aa00c8adaf001a4f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11ensure the module combobox gets updated with the current selectionCaolán McNamara1-7/+7
Change-Id: Ia9bf71c1890d9f2700a67ad9a3727dbf140c0492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara1-1/+1
xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11add some more libs to libmergedNoel Grandin2-2/+8
and fix a consequent symbol name clash in basctl Change-Id: Idc836fcbb379e1046a60008391635eb6241b27c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10weld SvxFmAbsRecWin item windowCaolán McNamara1-1/+6
Change-Id: I6a11d8ba226b28447e2ab04925090491d6953132 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08weld LibBox and LanguageBox Item WindowsCaolán McNamara5-108/+176
Change-Id: Ifdbef243093b588887c3d3fe1efcaf2e4c7c982a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08crash in manage languages in basic ideCaolán McNamara1-0/+6
when there is more than one language, there needs to be two separate columns with a renderer each, not one column with two renderers Change-Id: Id4f2c9938fd3bd0aa3e006166df6081d57ef57df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07property browser appearing as a blank area when changing modulesCaolán McNamara1-5/+6
under gtk, so just don't create it until we need it Change-Id: I0fd86c6b587788c42646a107746e8e4e10f2a13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88230 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop newly unused FontSizeBoxCaolán McNamara1-4/+1
Change-Id: I8a84ce74888e1d3c468251ddd3633aedf6339a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák1-7/+110
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin1-2/+2
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28remove some unused local varsNoel Grandin1-2/+2
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#124176: Use pragma once instead of include guardsAleyna Doğrucan3-12/+3
Change-Id: Ib0708c72fff342c25f79662cc3f4bbbfdfe0574a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86230 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-27tdf#124176:Use pragma once instead of include guardsayhanyalcinsoy5-20/+5
Change-Id: Ie00f05a3661a9fd6159c424e01f11e7bb1ea45fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85640 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-24loplugin:makeshared in basctl..canvasNoel Grandin2-4/+4
Change-Id: I1461da594db222abbaeccfb636194b9790f5dbe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87271 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-22tdf#42949 Fix IWYU warnings in basctl/Gabor Kelemen43-73/+85
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id956a2aaffb7ac8787847eedc4860bf9f4b70184 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86943 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-14tdf#129360: don't try to use uninitialized objectsMike Kaganski1-15/+9
And also don't forget to re-initialize member list of watch item. Another old bug masked by hacks removed in commit 62f3f3d92aa204eaaa063b30d7ade44df501b997. E.g., previously in code Type t1 var1 var2 End Type Type t2 var1 var2 var3 End Type Sub test Dim v1 As t1, v2 As t2, v v = v1 v = v2 End Sub breaking on line 'v = v1', expanding v in Watch, and stepping to next line, didn't update the children count. After the change, this surfaced, and now fixed. Change-Id: Ia47f5363a2fc62042701ff14d084870d1cced392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86792 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-13tdf#129360: fix old unsigned underflowMike Kaganski1-10/+16
... discovered thanks to 62f3f3d92aa204eaaa063b30d7ade44df501b997: properties count may be 0, and unconditionally subtracting 3 from that will give a big number. Previously this was masked by a "Very Hot Fix" in SbxArray::GetRef that was dropped in the said commit. This unifies property count correction in the two places that use it: in WatchTreeListBox::RequestingChildren, where it was correct, and in WatchTreeListBox::UpdateWatches, where underflow happened. Change-Id: Ie980bc9571b2555cc2f643e770d824d5e2eb3731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86700 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-10use more std::make_sharedNoel Grandin3-5/+5
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-07tdf#124176: Use pragma once instead of include guardsAleyna Doğrucan3-12/+3
Change-Id: Ib2c93eb61d8d4c944a1b7de074fd0e9e48715ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86232 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-01Removed executable permission on fileAndrea Gelmini1-0/+0
Change-Id: Id84b58da363210a3ff54aacebfcfc5c3ead3f5be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86085 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-01tdf#126506 - Adjusted height margin of the tab barU-DESKTOP-8OSNV7R\DrRobotto1-1/+3
Adjusted the height margin of the tab bar in the Basic IDE in order to reflect the new look of the TabBar from tdf#124572. Change-Id: I4fadec983405b05c7330f762f4ed2e12d3a40d27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86048 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-12-26use more TOOLS_WARN_EXCEPTIONNoel Grandin1-1/+2
so we get more useful log messages when stuff goes wrong Change-Id: Ia55db7ab1a4d79b0f281673fbbb06c61745fa89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 11:42:07 +0000