summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin2-5/+5
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-12these can all be made constCaolán McNamara2-2/+2
Change-Id: I6a8af82e8612196f20143f4997eb95c80a2ca13d
2015-02-12BASIC IDE : add the current procedure name in the status barLaurent Godard4-28/+83
Change-Id: Icecef1748bcc964670b0b95263314d9d8a4555f0 Reviewed-on: https://gerrit.libreoffice.org/14367 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10coverity#1268024 coverity#1267686: basctl: uncaught exceptionMichael Stahl2-3/+14
DlgEdObj::_propertyChange() should have same exception spec. as XPropertyChangeListener::propertyChange(). Change-Id: I8d5b628b7cc382dae55a9e17bf813fba647453eb
2015-02-07loplugin:deletedspecialStephan Bergmann3-7/+7
Change-Id: I71bfb6628bb746498ff47d6d9aba50e150757144
2015-02-05Updated all precompiled headers.Ashod Nakashian1-38/+2
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-01coverity#1267686 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Iab9067590cd15b3b60cfa2a98ee6be30d2fdf13d
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin1-3/+3
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin5-30/+30
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-12Resolves: #i120772# do not ignore last three properties...Tsutomu Uchino1-1/+8
when special properties not found in watching window (cherry picked from commit 8815f3f3fbb3632cccbbf8476f4c40c9bda8eb6e) Conflicts: basctl/source/basicide/baside2b.cxx Change-Id: I6069d55b9f894846a7b4d81b981cf4523b444753
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin5-7/+7
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin5-7/+7
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl1-1/+1
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin2-3/+3
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05fdo#39596: replace cstyle castsJuan Picca1-10/+9
Change-Id: I1a0814ec973b1dc0f4db4ee88a999d9ffc219e7a Reviewed-on: https://gerrit.libreoffice.org/13701 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05fdo#67343 Arrange Help button in a secondary groupAdolfo Jayme Barrientos4-0/+5
This helps de-clutter action button groups and eases visual scanning. This patch also contains little layout tweaks where needed to separate the Help button from its neighbors when the dialog is too small. Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce Reviewed-on: https://gerrit.libreoffice.org/13427 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara1-2/+2
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-22avoid 'don't create ItemSets with full range before FreezeIdRanges assert'Caolán McNamara1-1/+1
Change-Id: I3dbb760cd5dbf2e72d1886eaca537bb9ecf9f8cc
2014-12-18basctl: Use appropriate OUString functions on string constantsStephan Bergmann3-4/+4
Change-Id: I3e1ff06ac42b53d4cbbdc5a4590bf505d0746d2d
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky3-3/+0
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-09timers: Timer never started, remove it completely.Tobias Madl1-1/+0
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4
2014-12-09changed timers to idleJennifer Liebel2-8/+8
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09changed timers to idlesJennifer Liebel2-5/+5
Change-Id: Ic045e0c066ff1f607f0582b88e72375efaaa708f
2014-12-08Remove more unnecessary header includes and use forward declaration.Kohei Yoshida1-0/+1
Change-Id: I88d0fb0e7c20d4b1414516e3bd2f961811b2eb8c
2014-12-08reduce scope of local variablesMichael Weghorn5-5/+7
This eliminates some of the warnings from Cppcheck report of 2014-11-29. Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9 Reviewed-on: https://gerrit.libreoffice.org/13330 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05loplugin:unreffunStephan Bergmann1-1/+1
Change-Id: I6dbb20c82b58b81aa4cfb8cc3cf80f6d1202075d
2014-12-05Removed useless includes in basctl/source/basicide/ treeAndrea Gelmini50-242/+6
It compiles on Windows and Linux, here, with flags: --with-help --with-java --with-lang="it" Made with the ignorant brute force of removing each include one by one. The tree with each commit (used to bisect) it's here: https://github.com/Gelma/core/commits/gr_push_brute_force_slot_2 Conflicts: basctl/source/basicide/bastype2.cxx Change-Id: If88eebb6ecba6ae7ab1e98713b66b10f1ad57dca Reviewed-on: https://gerrit.libreoffice.org/12963 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-04be more explicitDavid Tardon1-1/+1
Change-Id: I33b639b3505d5db2ea8b708d80e68e576ec53308
2014-12-04impl. Clone for all subclasses of SdrPageDavid Tardon2-2/+13
Change-Id: Ie370161e51ff83cb605bc57d317ff945404e5611
2014-12-04ooo#93212 avoid slicing during construction of SdrPageDavid Tardon2-1/+14
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b
2014-12-03Use std::initializer_listStephan Bergmann1-11/+9
Change-Id: I726fc6429a2eb7827d09d04584fd0b725e78f650
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl3-8/+8
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25all these ids and their associated resources were unnecessaryCaolán McNamara2-5/+1
Change-Id: I3f538668c9c5f1727b8cf49ab72fd5879e12f156
2014-11-25We now only need one bit of information hereCaolán McNamara2-2/+2
whether there *is* an id, or whether there is not an id. An id of 0 seems to be used as a flag that an interface is some sort of superclass which can be subclassed by something else and have its toolbars etc reused. Convert this to a bool so we don't need an a resource id for each one and just drop the third arg for the normal "final" case and use a different define for the inheritable case Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-11-22timers: Timer never started, remove it completely.Tobias Madl2-13/+0
Change-Id: I119529498f4bea014e5e0d3d81c39203080ff1c4 Reviewed-on: https://gerrit.libreoffice.org/13030 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-11-21HIG fixes for basctlAdolfo Jayme Barrientos11-341/+262
And a menu item and dialog rename: Goto Line (Number) → Go to Line Change-Id: I5889486ddd7925a9ade889787889a9b9b6221f39 Reviewed-on: https://gerrit.libreoffice.org/12971 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-19Fix typo in deletelangdialog.uiAdolfo Jayme Barrientos1-3/+3
Change-Id: I20602fb7f048c2c79073b47539cad6419fb90bb5 Reviewed-on: https://gerrit.libreoffice.org/12969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+3
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-1/+1
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-2/+2
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-1/+1
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+3
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-3/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-17/+13
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky3-6/+6
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky3-5/+5
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23loplugin: cstylecastNoel Grandin14-42/+42
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist1-1/+1
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-1/+1
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 11:29:33 +0000