summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2015-11-16Resolves: tdf#95021 crash on closing macro dialog editorCaolán McNamara2-1/+8
VclPtr related, dialog dtor is never called, so timer is never stopped and timer refers to deleted parent data (cherry picked from commit 0943adb2f7ec319891c11889b40c9a69f0d1027e) Change-Id: I804ba082817802c0017e61c6b86c5d3694995ea8 Reviewed-on: https://gerrit.libreoffice.org/19926 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 33df62efe3c94b87b765f8334c8b614eb896338b)
2015-08-31tdf#93077 - basic dialog localization issues.Michael Meeks1-14/+22
Don't remove non-existent languages to clean the dialog. Avoid crashing when adding languages to a non-localized dialog. Change-Id: Ie356177e00e56c214727d513ae0ce6d62d32591c Reviewed-on: https://gerrit.libreoffice.org/17932 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-20Resolves: tdf#92896 wrong delete language dialog pathCaolán McNamara1-1/+1
Change-Id: I720e95c6c5e8b613ef880aa65f5e8cdb85143b58 Reviewed-on: https://gerrit.libreoffice.org/17566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-06tdf#92258 - fix crash editing macro module name.Michael Meeks1-3/+5
Change-Id: I8e0bbab7d7497ed7c136ddbfba73618834d5a204
2015-08-06rendercontext: Mass fix of using the wrong size.Jan Holesovsky1-1/+1
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6 Reviewed-on: https://gerrit.libreoffice.org/16421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin1-1/+1
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-06tdf#91702 - fix stack-based MessBox allocation.Michael Meeks3-5/+5
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29tdf#91484 fix macro editor - Invalidate in paintTomaž Vajngerl2-1/+25
Change-Id: I787da9a665e54caea229def185076b29c00fd11e Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin1-1/+1
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung7-27/+27
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-26tdf#91575 - CRASH: when "My Macros & Dialogs Standard" window closeNoel Grandin2-4/+6
Change-Id: Iad4f67e78a0aa4c67f0c450e17278f873944aa23 (cherry picked from commit dbca69b975ea8b25c040f12441d70f90cf0e9ab4)
2015-05-20coverity#1298898 coverity seems a little confused hereCaolán McNamara1-1/+1
Change-Id: Ibc80e242b8fda8fb304ed5cd1a52716d1b7fc33d
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin1-1/+1
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20convert TEXT_DRAW constants to scoped enumNoel Grandin1-1/+1
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-19basic: used typed LINKsNoel Grandin2-3/+3
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
2015-05-18cppunit: noExplicitConstructorCaolán McNamara9-21/+44
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
2015-05-18basctl: Use typed LinksNoel Grandin5-15/+11
Change-Id: I0e0b6086852c06df88e1b623d4631f364eb28b09 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-05-18callcatcher: update unused codeCaolán McNamara2-24/+0
Change-Id: I43dd399368953c629916dad8104a296f837a6344
2015-05-18refactor how font, fg. and bg. are applied in widgets/controlsTomaž Vajngerl2-2/+3
- Move vcl::RenderContext to outdev. - Change some methods on vcl::Window to accept RenderContext as parameter. - Add ApplySettings to vcl::Window - This method is called before painting. Refactor existing classes that use InitSettings to have ApplySettings or mark the classes to be refactored later. - Add RenderSettings for adding defered settings to rendering. This is similar to ApplySettings but for more ad-hoc calls. Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
2015-05-15tdf#91239 - return VclPtr's from Create Fn.s and add missing dispose logic.Michael Meeks8-24/+36
Change-Id: I802b841040f608b5586704745cc9817603fb1879
2015-05-15tdf#91239 - add missing disposeAndClear logic for basctl.Julien Nabet1-0/+6
Change-Id: If5c8fbf453e47921b472a987e9e6cff283464dcf
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini6-29/+0
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-14cppcheck: noExplicitConstructorCaolán McNamara3-10/+10
Change-Id: I42d135456c7f9ce8bbd77db553be96149e4e75af
2015-05-14convert QUICKHELP constants to scoped enumNoel Grandin1-1/+1
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
2015-05-14refactor "basctl" classes to use RenderContextTomaž Vajngerl9-239/+155
Change-Id: I6eb54af9f793c614c823123c6f16a3dc4f3a0c0b
2015-05-12Switch VclBuilder constructors to use VclPtr.Michael Meeks3-5/+3
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-11Revert "Switch VclBuilder constructors to use VclPtr."Michael Meeks3-3/+5
Behaves oddly; not ready yet. This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c. Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
2015-05-11Switch VclBuilder constructors to use VclPtr.Michael Meeks3-5/+3
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin3-10/+10
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann1-1/+1
Change-Id: I13f6c41a9918363d1b91d64ab2b8c331d007561a
2015-05-11refactor TreeListBox to use RenderContextTomaž Vajngerl1-16/+11
Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann3-3/+3
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann1-2/+1
Change-Id: Ic59c2c9079dce37ad76b6a1396a719d372253674
2015-05-09tdf#91052 - more macros for 'make' constructors.Michael Meeks3-3/+6
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann4-4/+5
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-07convert BUTTONDIALOG constants to scoped enumNoel Grandin1-7/+7
Change-Id: Icbf73fe55ad604f762dd2b98fd39189bab82f061 Reviewed-on: https://gerrit.libreoffice.org/15648 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-07Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann1-0/+1
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07refactor "TextEdit" & co. to use RenderContextTomaž Vajngerl1-3/+3
Change-Id: Ib26ecb9640d23714acec73304f26e2fd6af90ed4
2015-05-06convert DEFAULTFONT_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann4-7/+4
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann2-3/+2
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-04-30Gradually typed LinkStephan Bergmann3-9/+9
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29coverity#1296211 pCurWin == pNewWin at this pointCaolán McNamara1-1/+1
should silence coverity#1296211 Explicit null dereferenced Change-Id: I0798db1b88bfec94139995db552029b18a9562af
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann7-35/+12
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann1-1/+1
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29convert SDRSEARCH_ constants to scoped enumNoel Grandin2-2/+2
Change-Id: I1495dbaf05b642d98f41639d41f831f007601df3
2015-04-29convert LANG_LIST constants to scoped enumNoel Grandin1-1/+1
Change-Id: Ibd699cfdfd3266c2965a5b6368cfe2f4431b7fb4
2015-04-29mass rewrite Paint(Rect&) to Paint(RenderContext&, Rect&)Tomaž Vajngerl7-16/+16
Change-Id: Ia1667246064d11827dbd149def15e5bf08b119b8
2015-04-28basctl: fix GCC-4.7 buildMiklos Vajna1-2/+2
Change-Id: I1166987f49d2a9b67de95a9c43380f0e3ebf09dc
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks44-495/+859
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 08:47:53 +0000