summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2016-05-03Resolves: tdf#99425 crash when closing dialog editorCaolán McNamara1-1/+4
with undocked "Object Catalog" toolbar Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da (cherry picked from commit 4f92eb777ab17e0a2ee478572a46d060742902e1) Reviewed-on: https://gerrit.libreoffice.org/24281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-04-21tdf#97380: don't destroy completely window when replace dialogJulien Nabet1-1/+1
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 210 inline bool isApplication() const { return m_bValid && m_bIsApplication; } (gdb) bt 0 0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 1 0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311 2 0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256 3 0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=..., aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154 4 0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213 Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed Reviewed-on: https://gerrit.libreoffice.org/24139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 60b61b7859ca357e0a2b6953888954a46d64999d) Reviewed-on: https://gerrit.libreoffice.org/24140 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock1-1/+1
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-03-14Resolves: tdf#95428 backspace in readonly macro editor hangsCaolán McNamara1-4/+3
Change-Id: I16568b00e92d18f32818188ba3ab8df92bbd13aa (cherry picked from commit 5b3f84cec471ddbde98a46220096cdb952bb1935) Reviewed-on: https://gerrit.libreoffice.org/23087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-11-25loplugin:unusedfields in include/svxNoel Grandin1-2/+2
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-20Remove last redundant toolbar:style propertiesSamuel Mehrbrodt1-1/+1
Change-Id: I42fa834464fd4cd7f0c1f11e310c1145fb1f071b
2015-11-20loplugin:unusedfields in basctlNoel Grandin5-11/+5
and improve the plugin to search for only WARN_UNUSED and fundamental types Change-Id: Ic06207758e28d44d64d76d8119fd76b5b098bb05
2015-11-20Remove redundant toolbar:style="radio" propertySamuel Mehrbrodt2-31/+31
Change-Id: I56969839a93af975466ab6c28f2f87557e4d7f1b Reviewed-on: https://gerrit.libreoffice.org/20074 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-19Remove redundant toolbar:style attributesSamuel Mehrbrodt1-1/+1
These have been defined in the widgets Change-Id: If46a6862872286a454804846128bd8658f60af9b
2015-11-19loplugin:sallogareasStephan Bergmann1-1/+1
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin1-3/+1
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-141/+521
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin2-4/+2
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-12Resolves: tdf#95021 crash on closing macro dialog editorCaolán McNamara2-1/+8
VclPtr related, dialog dtor is never called, so timer is never stopped and timer refers to deleted parent data Change-Id: I804ba082817802c0017e61c6b86c5d3694995ea8
2015-11-11loplugin:nullptrStephan Bergmann1-1/+1
Change-Id: If35c6033938f69d1a557828eacbad99968d25547
2015-11-115th step to remove tools/rtti.hxxOliver Specht15-20/+2
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann39-213/+213
Change-Id: I27f1d5ee55338372b1c24187b63d23ae39e0a8b3
2015-11-09new loplugin: oncevarNoel Grandin3-9/+3
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann5-7/+7
Change-Id: Ica41a359a75e2e7ad0402cb52cc6f2107f4fa002
2015-11-04yyyyyNoel Grandin2-8/+8
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin5-13/+9
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-29tdf#95416: Get rid of #include "../foo/bar.hxx" style includesTor Lillqvist5-11/+12
Sample commit of what should be done, for the basctl module. Change-Id: Ied47ea3129844179f2624c6870c05e48540fd0f6
2015-10-20loplugin:defaultparamsStephan Bergmann1-3/+3
Change-Id: I8485bec1c31597e5a27db706a907eda788a053bf
2015-10-19loplugin:defaultparamsStephan Bergmann5-14/+14
Change-Id: If39ad8e936b3a46de00770993a4a7c3676c676d2
2015-10-19convert DBG_ASSERTWARNING to SAL_WARN_IFNoel Grandin1-1/+1
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes much more sense. Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin1-6/+1
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-16sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.Jan Holesovsky2-10/+10
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.Jan Holesovsky2-11/+10
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16convert Link<> to typedNoel Grandin4-11/+7
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-15convert Link<> to typedNoel Grandin2-5/+3
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann33-369/+369
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann4-6/+6
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12convert Link<> to typedNoel Grandin6-13/+9
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb Reviewed-on: https://gerrit.libreoffice.org/19305 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-06Prefer getSelectedFiles to getFiles (basctl)Julien Nabet3-6/+6
Change-Id: I09cdad8770eba515c36220fbfb355220c9fa3bef Reviewed-on: https://gerrit.libreoffice.org/19217 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-05Called C++ object pointer is null DBG_ASSERT->assertCaolán McNamara6-13/+12
Change-Id: I3094fc1728135fb9e8b229826cd2e30925e89b11
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+2
Change-Id: I886253de9980082186c41d361eb5a30e5f3923bc
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann1-3/+3
Change-Id: I039fa6b7fb666b4108b37d5aa17b2dcd42d2af53
2015-10-02Remove some unused includesStephan Bergmann1-1/+0
Change-Id: I4701ecd6be7dae64994397007fe13f30b6d7f64f
2015-10-02tdf#94205 Use o3tl::make_unique instead of new + std::movebureken1-3/+1
Change-Id: I27ed3c3fb826e7ce63b0bc12f7d17e18b21c9949 Reviewed-on: https://gerrit.libreoffice.org/19071 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin2-7/+0
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini3-3/+3
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3 Reviewed-on: https://gerrit.libreoffice.org/18938 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann4-17/+17
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29tdf#94559: first step to remove rtti.hxxOliver Specht1-2/+2
replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-25tdf#94497 UI: Object catalog not available in menu > View in BasicIDECor Nouws1-0/+2
Change-Id: I996723cf3af8365d078103bb54d469f7a2c735fe Reviewed-on: https://gerrit.libreoffice.org/18838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-24convert Link<> to typedNoel Grandin2-6/+4
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b Reviewed-on: https://gerrit.libreoffice.org/18825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21hide ScopedPtr::reset and add disposeAndClearCaolán McNamara1-3/+2
Change-Id: I55d6e789abd408b8478a2b9ae141d8899af2c309 Reviewed-on: https://gerrit.libreoffice.org/18745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-20convert Link<> to typedNoel Grandin2-11/+5
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511 Reviewed-on: https://gerrit.libreoffice.org/18700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-18boost->stdCaolán McNamara11-25/+20
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17convert Link<> to typedNoel Grandin2-3/+2
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-14boost->stdCaolán McNamara10-21/+19
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 04:10:00 +0000