summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2017-08-09Reorganize Scheduler priority classesJan-Marek Glogowski2-2/+0
This is based on glibs classification of tasks, but while glib uses an int for more fine grained priority, we stay with our enum. 1. Timers start with DEFAULT priority, which directly corresponds with the previous HIGH priority 2. Idles start with DEFAULT_IDLE priority instead of the previous HIGH priority, so idle default becomes "really run when idle". As RESIZE and REPAINT are special, and the DEFAULTS are set, there is just one primary decision for the programmer: should my idle run before paint (AKA HIGH_IDLE)? If we really need a more fine-grained classification, we can add it later, or also switch to a real int. As a result, this drops many classifications from the code and drastically changes behaviour, AKA a mail merge from KDE is now as fast as Gtk+ again. Conflicts: formula/source/ui/dlg/formula.cxx svx/source/sdr/event/eventhandler.cxx sw/source/uibase/docvw/srcedtw.cxx sw/source/uibase/utlui/unotools.cxx vcl/source/uitest/uno/uiobject_uno.cxx Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9
2017-08-09Change all Idle* LINKs to be Timer*Jan-Marek Glogowski5-7/+7
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Conflicts: avmedia/inc/mediacontrol.hxx avmedia/source/framework/mediacontrol.cxx avmedia/source/framework/soundhandler.cxx avmedia/source/framework/soundhandler.hxx basctl/source/basicide/baside2.hxx basctl/source/basicide/baside2b.cxx basctl/source/dlged/dlged.cxx basctl/source/inc/dlged.hxx chart2/source/view/charttypes/GL3DBarChart.cxx chart2/source/view/inc/GL3DBarChart.hxx cui/source/dialogs/cuigaldlg.cxx cui/source/dialogs/linkdlg.cxx cui/source/dialogs/thesdlg.cxx cui/source/inc/backgrnd.hxx cui/source/inc/chardlg.hxx cui/source/inc/cuigaldlg.hxx cui/source/inc/linkdlg.hxx cui/source/inc/macroass.hxx cui/source/inc/thesdlg.hxx cui/source/options/optjava.cxx cui/source/options/optjava.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/chardlg.cxx cui/source/tabpages/macroass.cxx dbaccess/source/ui/inc/JoinTableView.hxx dbaccess/source/ui/querydesign/JoinTableView.cxx dbaccess/source/ui/tabledesign/TEditControl.cxx desktop/source/app/app.cxx desktop/source/deployment/gui/dp_gui_dialog2.cxx desktop/source/deployment/gui/dp_gui_dialog2.hxx editeng/source/editeng/impedit.hxx editeng/source/editeng/impedit3.cxx extensions/source/bibliography/bibcont.cxx extensions/source/bibliography/bibcont.hxx extensions/source/bibliography/toolbar.cxx extensions/source/bibliography/toolbar.hxx extensions/source/update/ui/updatecheckui.cxx forms/source/component/ListBox.cxx forms/source/component/ListBox.hxx formula/source/ui/dlg/formula.cxx formula/source/ui/dlg/funcutl.cxx fpicker/source/office/iodlg.cxx framework/source/services/autorecovery.cxx include/formula/formula.hxx include/formula/funcutl.hxx include/sfx2/basedlgs.hxx include/sfx2/dinfdlg.hxx include/sfx2/dispatch.hxx include/sfx2/dockwin.hxx include/svtools/asynclink.hxx include/svtools/filechangedchecker.hxx include/svtools/treelistbox.hxx include/svtools/wizdlg.hxx include/svx/fontwork.hxx include/svx/graphctl.hxx include/svx/imapdlg.hxx include/svx/modctrl.hxx include/svx/numvset.hxx include/svx/sidebar/PanelLayout.hxx include/svx/svdpntv.hxx include/vcl/dockwin.hxx include/vcl/syswin.hxx include/vcl/texteng.hxx include/vcl/toolbox.hxx include/vcl/window.hxx linguistic/source/lngsvcmgr.cxx linguistic/source/lngsvcmgr.hxx reportdesign/source/ui/inc/DesignView.hxx reportdesign/source/ui/report/DesignView.cxx sc/inc/chartlis.hxx sc/inc/document.hxx sc/inc/scmod.hxx sc/source/core/data/documen2.cxx sc/source/core/tool/chartlis.cxx sc/source/ui/app/scmod.cxx sc/source/ui/dbgui/filtdlg.cxx sc/source/ui/dbgui/sfiltdlg.cxx sc/source/ui/docshell/autostyl.cxx sc/source/ui/inc/acredlin.hxx sc/source/ui/inc/anyrefdg.hxx sc/source/ui/inc/autostyl.hxx sc/source/ui/inc/conflictsdlg.hxx sc/source/ui/inc/filtdlg.hxx sc/source/ui/inc/navipi.hxx sc/source/ui/inc/tphfedit.hxx sc/source/ui/miscdlgs/acredlin.cxx sc/source/ui/miscdlgs/anyrefdg.cxx sc/source/ui/miscdlgs/conflictsdlg.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/pagedlg/tphfedit.cxx sd/inc/drawdoc.hxx sd/source/core/drawdoc4.cxx sd/source/ui/dlg/brkdlg.cxx sd/source/ui/dlg/filedlg.cxx sd/source/ui/framework/configuration/ConfigurationUpdater.cxx sd/source/ui/framework/module/ShellStackGuard.cxx sd/source/ui/framework/module/ShellStackGuard.hxx sd/source/ui/inc/BreakDlg.hxx sd/source/ui/inc/View.hxx sd/source/ui/slidesorter/controller/SlsAnimator.cxx sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx sd/source/ui/view/sdview4.cxx sfx2/source/appl/appcfg.cxx sfx2/source/appl/newhelp.cxx sfx2/source/appl/newhelp.hxx sfx2/source/control/dispatch.cxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/basedlgs.cxx sfx2/source/dialog/dinfdlg.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx sfx2/source/dialog/filedlgimpl.hxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/new.cxx sfx2/source/inc/templdgi.hxx sfx2/source/view/ipclient.cxx starmath/inc/edit.hxx starmath/source/edit.cxx svtools/source/contnr/imivctl.hxx svtools/source/contnr/imivctl1.cxx svtools/source/contnr/svimpbox.cxx svtools/source/contnr/treelistbox.cxx svtools/source/control/asynclink.cxx svtools/source/control/tabbar.cxx svtools/source/dialogs/wizdlg.cxx svtools/source/graphic/grfmgr.cxx svtools/source/inc/svimpbox.hxx svtools/source/misc/filechangedchecker.cxx svx/inc/sdr/overlay/overlaymanagerbuffered.hxx svx/inc/svdibrow.hxx svx/source/dialog/_contdlg.cxx svx/source/dialog/contimp.hxx svx/source/dialog/fontwork.cxx svx/source/dialog/graphctl.cxx svx/source/dialog/imapdlg.cxx svx/source/dialog/svxbmpnumvalueset.cxx svx/source/form/datanavi.cxx svx/source/form/formcontroller.cxx svx/source/inc/datanavi.hxx svx/source/inc/formcontroller.hxx svx/source/sdr/overlay/overlaymanagerbuffered.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx svx/source/sidebar/media/MediaPlaybackPanel.hxx svx/source/stbctrls/modctrl.cxx svx/source/svdraw/svdibrow.cxx svx/source/svdraw/svdpntv.cxx svx/source/tbxctrls/grafctrl.cxx sw/inc/doc.hxx sw/qa/extras/uiwriter/uiwriter.cxx sw/source/core/doc/DocumentStatisticsManager.cxx sw/source/core/doc/DocumentTimerManager.cxx sw/source/core/doc/docdesc.cxx sw/source/core/docnode/threadmanager.cxx sw/source/core/inc/DocumentTimerManager.hxx sw/source/core/inc/threadmanager.hxx sw/source/ui/dbui/mmoutputtypepage.cxx sw/source/ui/envelp/labfmt.cxx sw/source/ui/envelp/labfmt.hxx sw/source/ui/inc/mmresultdialogs.hxx sw/source/uibase/docvw/edtwin.cxx sw/source/uibase/docvw/srcedtw.cxx sw/source/uibase/inc/edtwin.hxx sw/source/uibase/inc/navipi.hxx sw/source/uibase/inc/srcedtw.hxx sw/source/uibase/inc/unotools.hxx sw/source/uibase/utlui/navipi.cxx sw/source/uibase/utlui/unotools.cxx vcl/backendtest/VisualBackendTest.cxx vcl/inc/svdata.hxx vcl/inc/unx/gtk/gtksalmenu.hxx vcl/source/app/svapp.cxx vcl/source/edit/texteng.cxx vcl/source/window/dockmgr.cxx vcl/source/window/dockwin.cxx vcl/source/window/paint.cxx vcl/source/window/syswin.cxx vcl/source/window/toolbox.cxx vcl/source/window/window.cxx vcl/unx/generic/print/genprnpsp.cxx vcl/unx/gtk/gtksalmenu.cxx Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-08-09Change Idle to be a Timer subclassJan-Marek Glogowski1-1/+1
Drops a lot of duplicated code, as Idle is just a convenience class for instant, mostly low priority timers. Conflicts: include/vcl/idle.hxx Change-Id: I847592e92e86d15ab1cab168bf0e667322e48048
2017-08-09Refactor Scheduler to add Task classJan-Marek Glogowski2-2/+2
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Conflicts: desktop/source/lib/init.cxx include/vcl/scheduler.hxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx svx/source/sdr/event/eventhandler.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx sw/source/uibase/docvw/srcedtw.cxx toolkit/source/awt/vclxtoolkit.cxx vcl/backendtest/VisualBackendTest.cxx vcl/source/app/scheduler.cxx vcl/source/window/window.cxx Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-02-15tdf#105386: crash with macro organizerJulien Nabet1-1/+3
bt part: 0 SvTreeList::GetParent (this=0x560670dd2e40, pEntry=pEntry@entry=0x0) at /home/julien/lo/libreoffice/svtools/source/contnr/treelist.cxx:1693 1 0x00007fd90573298c in SvTreeListBox::GetParent (this=this@entry=0x560670dd0d60, pEntry=pEntry@entry=0x0) at /home/julien/lo/libreoffice/svtools/source/contnr/treelistbox.cxx:779 2 0x00007fd8dfc3b4d8 in basctl::ExtTreeListBox::NotifyAcceptDrop (this=0x560670dd0d60, pEntry=0x560670e90b20) at /home/julien/lo/libreoffice/basctl/source/basicide/moduldlg.cxx:180 Change-Id: I033440c1fcc50e2c7a0bb1eed0efa4559c514126 Reviewed-on: https://gerrit.libreoffice.org/34280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 18be4782ad4a98041d9680f8d76a213b8fd49362) Reviewed-on: https://gerrit.libreoffice.org/34287 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit effeccd268305a2d3537cc89e4e35f682505afcb) Reviewed-on: https://gerrit.libreoffice.org/34292 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-11tdf#104830, need an own termination listener for lib objectsMarkus Mohrhard1-1/+1
The destruction of the SwDLL object happens already through the normal termination listener but the other termination listeners might still depend on it. Also the outstanding events might need the SwDLL instance to be still around. This makes the destruction of the instance explicit and at a time when it should be safe. We should use the same code for calc, impress, math and base as well. Change-Id: I50b8f30426f5a4a54e362e748fe962839abca73e Reviewed-on: https://gerrit.libreoffice.org/32856 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit ad915fafd54f9115faea7147f82d80a942af2d68) Reviewed-on: https://gerrit.libreoffice.org/32928 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-05tdf#93592 Make it possible to add default language resource to dialogeditorNiklas Johansson1-13/+6
During the conversion of uno services a few lines where removed that probably should not have been removed. This caused the dialog editor to crash if you tried to add a new language resource to a document fdo#93077. The fix for that bug fixed the crash but also made it imposible to add a language resource to a dialog that isn't previously translated. With this patch the functionality should be back on track, adding/removing language resources without problems at least as far as my testing goes. Change-Id: Ie6e083837894a219bf8e9c75dec6bf7652d51615 Reviewed-on: https://gerrit.libreoffice.org/30462 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 1453bc4ab3d42c34c32a7da63ed6f7bdbe513c2d) Reviewed-on: https://gerrit.libreoffice.org/31533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara10-32/+32
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-23Convert SbxClassType to scoped enumNoel Grandin7-10/+10
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b Reviewed-on: https://gerrit.libreoffice.org/25259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin1-1/+0
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin2-2/+1
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin1-1/+1
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara1-0/+1
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara2-14/+2
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-0/+1
Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
2016-05-06connectivity: replace boost::remove_reference with std::remove_referenceMichael Stahl1-1/+0
Change-Id: I7c11fcdaf8065fa86d224ad2fab88b0bcb907255
2016-05-04use Any constructor instead of temporariesNoel Grandin5-95/+39
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann1-2/+1
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21Resolves: tdf#99425 crash when closing dialog editorCaolán McNamara1-1/+4
with undocked "Object Catalog" toolbar Change-Id: I70d51cec699333c5cfc1461d61734c1bbb5323da
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin5-27/+22
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-8/+8
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke4-18/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18Remove the hardly used SyntaxLineSet typedefRyan McCoskrie2-3/+2
Change-Id: Ib38bbbdcc65620329d1471d0d61ede65c4f834e6 Reviewed-on: https://gerrit.libreoffice.org/24176 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-16tdf#97380: don't destroy completely window when replace dialogJulien Nabet1-1/+1
0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 210 inline bool isApplication() const { return m_bValid && m_bIsApplication; } (gdb) bt 0 0x00002aaaf64ff222 in basctl::ScriptDocument::Impl::isApplication (this=0x9999999999999999) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:210 1 0x00002aaaf64fa12e in basctl::ScriptDocument::isApplication (this=0x576b458) at /home/julien/lo/libreoffice/basctl/source/basicide/scriptdocument.cxx:1311 2 0x00002aaaf648f6d7 in basctl::MarkDocumentModified (rDocument=...) at /home/julien/lo/libreoffice/basctl/source/basicide/basobj3.cxx:256 3 0x00002aaaf645e2a9 in basctl::implImportDialog (pWin=0x576b210, rCurPath=<error reading variable: Cannot access memory at address 0x999999999999999d>, rDocument=..., aLibName="Standard") at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1154 4 0x00002aaaf645eda9 in basctl::DialogWindow::ImportDialog (this=0x576b210) at /home/julien/lo/libreoffice/basctl/source/basicide/baside3.cxx:1213 Change-Id: I7365b2cacc8a3783fdc8e573bbc10ff574d9c4ed Reviewed-on: https://gerrit.libreoffice.org/24139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-16basctl: prefix some membersJulien Nabet4-142/+142
Change-Id: I59660153a33e83dc9457fbee082e8da444b04b58 Reviewed-on: https://gerrit.libreoffice.org/24126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin3-3/+3
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I5c166398df5a16c5c9123ce3c046cbf6d64b9fa4
2016-04-12Get rid of _SVX_NOIDERESIDSStephan Bergmann2-10/+4
Change-Id: Iab728d51c24ccbedad5fa181850a673129d489ae
2016-04-12clang-tidy performance-unnecessary-value-param in basctlNoel Grandin7-69/+59
Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11fix copy assignment signaturesJochen Nitschke1-1/+1
get value by reference introduced in commit 8c2f2e1dd77cdce9bdf63beff5a79f91adc44630 and commit f9b200ce54cd67ddc04747f9676568a86e14d864 Change-Id: Iba84dd752f4cbdde9f3676c434d107efabe63a38 Reviewed-on: https://gerrit.libreoffice.org/23974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05sequence->vector in xmlscriptNoel Grandin1-1/+2
Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4 Reviewed-on: https://gerrit.libreoffice.org/23795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara1-2/+4
Change-Id: I9510a16bf4ac5dd2c3da16c618841918daea8cfb
2016-04-04tdf#94306 replace boost::noncopyable in ..Jochen Nitschke3-7/+10
.. accessibility, avmedia, basctl, basic and bridges remove boost from module if not needed anymore Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2 Reviewed-on: https://gerrit.libreoffice.org/23744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke1-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-1/+1
Including no keywords from extern "C" blocks Change-Id: Id0304994a692f1004993dda2ffd7fb819ab8e8d0 Reviewed-on: https://gerrit.libreoffice.org/23670 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke1-1/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl6-36/+36
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin1-1/+1
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30tdf#96505: fix wrong SfxDispatcher::Execute calls ...Michael Stahl6-15/+29
... that are now busted on all 64-bit platforms since commit 57d0caacee2f395be2e89b78f8ece2d47b2c8683 but were already busted only on 64-bit WNT before. SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall, const SfxPoolItem* pArg1, ...) assigns the varargs to a "const SfxPoolItem *", so passing in "0L" is only correct if long is 64-bit, but on WNT 64-bit long is 32-bit, so use "nullptr" already. Change-Id: I50448d8ad121c4881be549623d44c44b00e56d98
2016-03-23loplugin:constantparam in basctlNoel Grandin3-4/+4
Change-Id: I08ab924a9bb69bede4247cfe8c50921520a4f4a7
2016-03-18convert SvButtonState to scoped enumNoel Grandin1-3/+3
Change-Id: I601f9e2fe33e85cf3f7dc52ee20d68202bd2b09d
2016-03-18drop unused params from SvLBoxItem and all it's subclassesNoel Grandin1-3/+3
looks like this is fallout from commit ac7acb0a "Merged SvTreeListBox and SvLBox." (in year 2012) Change-Id: Iaebeae64fc7cd3ba11f5f45b53bcb65bf906e906
2016-03-17loplugin:constantparam in sfx2Noel Grandin2-2/+2
Change-Id: I53e690ab8d50fb3ce43ba633fc018e7b66e591cd Reviewed-on: https://gerrit.libreoffice.org/23321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in toolsNoel Grandin1-3/+3
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin9-24/+23
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-7/+0
I removed the OSL_DEBUG_LEVEL > 1 conditional and replaced it to OSL_DEBUG_LEVEL > 0 as suggested in easy hack. Change-Id: If5f086f280d01e7a80be59f3c992dc2d0a7663cf Reviewed-on: https://gerrit.libreoffice.org/23062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-09Resolves: tdf#95428 backspace in readonly macro editor hangsCaolán McNamara1-4/+3
Change-Id: I16568b00e92d18f32818188ba3ab8df92bbd13aa
2016-03-09loplugin:constantparam in basctlNoel Grandin2-15/+9
Change-Id: I07d22585e768335f61d70bf18807479a2675804a
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-07 22:40:59 +0000