summaryrefslogtreecommitdiff
path: root/basctl/source/basicide
AgeCommit message (Collapse)AuthorFilesLines
2014-01-27coverity#982152 Unchecked return valueCaolán McNamara1-1/+5
Change-Id: I58fd11e38fa0b8ba7efeff8861aeec17742999c3
2014-01-27coverity#735667 Unchecked dynamic_castCaolán McNamara1-1/+2
Change-Id: I747b6bcfb1e57fd3f21250b274f2f179e1982d7c
2014-01-27coverity#1130421 Improper use of negative valueCaolán McNamara1-14/+15
Change-Id: Iefdd854cb0348b187b95f4a89d52482381c73dfc
2014-01-22Related: #i50481# improve Select All command in Basic IDETsutomu Uchino2-1/+17
see also fdo#37211 i.e. commit 4bc2724240b11ce4dfb7adafbe1f1c260fa44030 (cherry picked from commit f841659faf09fec69c962959b9da032fa0bc2b16) Conflicts: basctl/source/basicide/baside2.cxx basctl/source/basicide/baside2b.cxx basctl/source/basicide/baside3.cxx Change-Id: Id679b1e16b87ec8d81fb78039318728320b9d5bc
2014-01-19coverity#735600 : Division by zeroNorbert Thiebaud1-0/+1
Change-Id: I67c2af62144872c4ad0ac7e17be5bb9a5883ba69
2014-01-19coverity#1000814 coverity#1000815 : Unintended sign extensionNorbert Thiebaud1-2/+2
Change-Id: Ia9e40dba5ef2beca2ebc6cc40672d6804d430af0
2014-01-19coverity#735599 : Division by zeroNorbert Thiebaud1-1/+5
Change-Id: I1a69224793eb39d88894e1090672bdb641c88a02
2014-01-19coverity#735598 : Division by zeroNorbert Thiebaud1-1/+3
Change-Id: I288b46a933d8a301823deed8fccae9764b74e840
2014-01-18Window::PreNotify should return boolStephan Bergmann2-12/+12
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-17bool improvementsStephan Bergmann4-5/+5
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
2014-01-17Window::Notify should return boolStephan Bergmann1-4/+4
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17Remove use of deprecated css::document::XEventBroadcaster/ListenerStephan Bergmann1-13/+13
Change-Id: I178ae590fec87f53e90db5aa6e560cd146c0676b
2014-01-16Introduce com.sun.star.frame.theGlobalEventBroadcaster singletonStephan Bergmann1-3/+3
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance service. Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-14Remove unused bForBrowsing parameterStephan Bergmann1-3/+1
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
2014-01-14PrepareClose should probably return boolStephan Bergmann1-1/+1
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
2014-01-13SvTreeListBox::ExpandingHdl should return boolStephan Bergmann2-2/+2
Change-Id: I39a854910299ab2e7c64beabda381bb9f0bd2891
2014-01-13disentangle CalcSizeCaolán McNamara1-1/+1
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-10SfxPoolItem::operator ==, != should return boolStephan Bergmann1-1/+1
...and SfxEnumItemInterface::HasBoolValue, too. Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-06convert module and dialog tabpages to .uiCaolán McNamara5-251/+100
Change-Id: I2954a734b44be22d4d7ffae17480dde1c0ac64e7
2014-01-06basctl::CheckBox all loaded from .ui now, drop resid ctorCaolán McNamara2-12/+0
Change-Id: Ie11fdcea9d307518cabfa519ddccc65997250519
2014-01-06convert lib page to .uiCaolán McNamara3-189/+104
Change-Id: Idd9e3c1ab1c63baa11f503c20d46f3d13e6f78a3
2014-01-03add some borders hereCaolán McNamara2-5/+9
Change-Id: Ica1f2872759366120b9329f168f18788a8e239b3
2014-01-03convert import library dialog to .uiCaolán McNamara4-95/+45
Change-Id: Iaedcbeb5618ece65692a9688ccb5c13aad1e6626
2014-01-02Convert break point dialog to .ui formatCaolán McNamara4-205/+65
Change-Id: I750133b673e135399ab9c04953550bea1db3a9e8
2014-01-02allow simple MessageDialogs to be created from just message stringsCaolán McNamara1-17/+15
Change-Id: I9f8324d1c61bd55ccc78e67699ebdfa946e48af6
2014-01-01const this upCaolán McNamara1-1/+1
Change-Id: Id4b832b04368627a7df243c881ac203d1d2a0140
2013-12-31convert export basic dialog to .ui (600th .ui conversion)Caolán McNamara3-62/+9
Change-Id: I67511e69f763761cd1631263fccd0704daf1886b
2013-12-31MessageDialog isn't ready for this usage just yetCaolán McNamara1-15/+17
Change-Id: If6c886ac4115dd0a030660fd0147491815fa411a
2013-12-31convert new lib dialog to .uiCaolán McNamara3-82/+32
and a drive-by on some no .src InfoBox and ErrorBoxes to MessageDialog Change-Id: Ideb58a0042ed45a49bff9b336622dfe11bb363ab
2013-12-31don't access beyond end of empty stringCaolán McNamara1-0/+2
Change-Id: Ie772d7a60fd65b93ca66c543eb2786ce7f109004
2013-12-31convert goto line dialog to .uiCaolán McNamara4-62/+13
Change-Id: I4c4ec4f2169d001e6f09c9c7bb06a4b0b327a2f8
2013-12-24convert organize macros dialog to .uiCaolán McNamara5-113/+42
Change-Id: I210ab0bb294ddfefc3f60cffe64b72e5d8fa4650
2013-12-18vcl get rid of xub_StrLen and STRING_LEN in outdev3Norbert Thiebaud1-1/+1
a new log section (sal.rtl.xub) is used to display alert in case of suspicious len == 0xFFFF (aka STRING_LEN) Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e Reviewed-on: https://gerrit.libreoffice.org/7117 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-05Get rid of DECLARE_STL_STDKEY_SETStephan Bergmann1-0/+3
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
2013-11-27Properly encapsulate svt::TextWindowPeerStephan Bergmann1-1/+1
Change-Id: Iffa67c345a03852ad7872031b4c5a87e223ffcad
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-5/+5
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin1-1/+1
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11basctl: include <> for external includesNorbert Thiebaud11-28/+28
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
2013-11-08fdo#71306: fix printing from basic ideIvan Timofeev1-1/+3
regression from e13a3d566ecc34a46e037aca1b2d70e58501e422 Change-Id: I0d734e112038746aa48df669d4b82b644a95c220
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-1/+1
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin2-4/+4
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-1/+1
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28Remove unnecessary SyntaxHighlighter::Tokenizer statefulnessStephan Bergmann1-8/+0
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it. Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28Fold SyntaxHighlighter::initialize into ctorStephan Bergmann1-3/+1
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused. Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28Move implementation details to syntaxhighlight.cxxStephan Bergmann1-0/+1
(and clean up a little) Change-Id: I6e660708d8ca1509b89b306cd428dc38c8b03f2c
2013-10-28Remove unused SimpleTokenizer_Impl::nLine/nColStephan Bergmann1-9/+9
...which are never read; remove thereby unused parameters from functions. Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-23convert code to use OUString::endsWithNoel Grandin1-1/+1
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-22HighlightPortion's indizes into strings should be sal_Int32Stephan Bergmann1-2/+2
(Had to fix type of some variables holding TextPaM::GetIndex() values from sal_uLong to sal_uInt16 to avoid -Werror,-Wsign-compare failures when comparing those against HightlightPortion's nEnd.) Change-Id: Ia8a0ba682ae28e86e394ee48adff3225eb8de053
2013-10-22Use conventional std::vector idiomsStephan Bergmann1-28/+36
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22Unwind HighlightPortions typedefStephan Bergmann1-8/+8
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c