summaryrefslogtreecommitdiff
path: root/avmedia
AgeCommit message (Collapse)AuthorFilesLines
2017-07-19gtk3: make video playback fill playback windowCaolán McNamara1-0/+2
Change-Id: I43f2f77889856dc6a3b0c3a3775826dbb000be7a Reviewed-on: https://gerrit.libreoffice.org/40168 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-13Reorganize Scheduler priority classesJan-Marek Glogowski3-3/+3
This is based on glibs classification of tasks, but while glib uses an int for more fine grained priority, we stay with our enum. 1. Timers start with DEFAULT priority, which directly corresponds with the previous HIGH priority 2. Idles start with DEFAULT_IDLE priority instead of the previous HIGH priority, so idle default becomes "really run when idle". As RESIZE and REPAINT are special, and the DEFAULTS are set, there is just one primary decision for the programmer: should my idle run before paint (AKA HIGH_IDLE)? If we really need a more fine-grained classification, we can add it later, or also switch to a real int. As a result, this drops many classifications from the code and drastically changes behaviour, AKA a mail merge from KDE is now as fast as Gtk+ again. Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9
2017-07-04avmedia: remove trivial copy ctorJochen Nitschke1-15/+0
Change-Id: I650067c981f2fd3582687ffd562a1f8057e49fc2 Reviewed-on: https://gerrit.libreoffice.org/39501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: avmediaStephan Bergmann1-2/+1
Change-Id: I38a63a672de06b5f75370e0d08ce96d85cdb1cb3
2017-06-23loplugin:unusedfields in accessibility..comphelperNoel Grandin2-5/+2
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695 Reviewed-on: https://gerrit.libreoffice.org/39137 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke1-1/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin3-6/+6
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05avmedia : Simplify Window::WindowArnaud Versini1-35/+11
Change-Id: Idf5dc2814d2c4eb8e3a20a0e32e08839d2e6c5f7 Reviewed-on: https://gerrit.libreoffice.org/38392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin1-1/+1
since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: avmediaStephan Bergmann3-14/+14
Change-Id: Ie7716d05d6e98a8aa2a96f26ceb4dcd3b77b1ad3
2017-05-19make string translation loading more uniformCaolán McNamara5-27/+28
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19loplugin:comparisonwithconstant in accessibility..basegfxNoel Grandin2-2/+2
re-running this plugin on these modules now that sberg has improved the plugin. Change-Id: I1818b1fa540cf62b81219a4f3ed2dcae8ff0e838 Reviewed-on: https://gerrit.libreoffice.org/37805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-17AVMEDIA_RESSTR define can go nowCaolán McNamara3-6/+5
Change-Id: I9220cae493facf05d5ee9a9bb341a14e6448c2a5
2017-05-16loplugin:comparisonwithconstant in avmediaNoel Grandin6-9/+9
Change-Id: Iba0a1969648e95f6e0f6a947f067c5b8e4eb3406 Reviewed-on: https://gerrit.libreoffice.org/37667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin1-1/+1
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07avmedia: remove useless mutex and lockArnaud Versini1-19/+0
Change-Id: Ia6088fdb8734acb76c38067246fa626ddf964f8e Reviewed-on: https://gerrit.libreoffice.org/37344 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock2-2/+2
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert avmedia module away from OSL_ASSERT to assertChris Sherlock2-2/+2
Change-Id: Ie484788019f11299c4e4796268507b9b16b7fd4a
2017-04-28loplugin:checkunusedparams in accessibility and avmediaNoel Grandin2-4/+2
Change-Id: I94df9a65578792fb06f3b3259603f70ca1e0b3db Reviewed-on: https://gerrit.libreoffice.org/37059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25remove bitmaps from .src filesCaolán McNamara8-126/+96
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky8-8/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin2-5/+5
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Fix buildStephan Bergmann1-1/+3
Change-Id: Ic6644d03a7d6dd41422731d0b4015df831752087
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna5-9/+9
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-26Fix typosAndrea Gelmini1-1/+1
Change-Id: Idbf0aa261b829e83d4c08a2e989a4ced871dc6de Reviewed-on: https://gerrit.libreoffice.org/35616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-17remove unused defines from HRC files in variousNoel Grandin1-1/+0
Change-Id: Ia1ba313d2438f04a84bcfcbbbcf6fffea5c1921d Reviewed-on: https://gerrit.libreoffice.org/35310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann3-3/+3
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03avmedia: silence pointless warning about VLCMiklos Vajna1-1/+1
It's expected that we have a list of services and some of them can't be created. On linux when VLC can't be created the gstreamer one is used, and everything is fine; no need to warn about this situation. Change-Id: Idd8e4aed54390b6559615b689585924668075ff3 Reviewed-on: https://gerrit.libreoffice.org/34849 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-28new loplugin unoanyNoel Grandin1-3/+3
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-26loplugin:loopvartoosmallStephan Bergmann1-5/+3
Change-Id: I62c14c2e9d10345b29d133003238df9ce2021f3d
2017-02-15Drop :: prefix from std in [a-b]*/Tor Lillqvist3-4/+4
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd Reviewed-on: https://gerrit.libreoffice.org/34320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-10Remove MinGW supportStephan Bergmann1-6/+0
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-02loplugin:useuniqueptrStephan Bergmann1-5/+7
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-01makeAny->Any in accessibility..avmediaNoel Grandin3-6/+6
Change-Id: I70f2dfa66d7b66738a840e4a7b5c7fb1b8d7b39f Reviewed-on: https://gerrit.libreoffice.org/33756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann52-695/+400
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski5-7/+7
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-20loplugin:dynexcspec (macOS), avmediaStephan Bergmann1-0/+2
Change-Id: I71199437cfaaf5f72f3b38a3269e2ae84b282c6d
2017-01-18use rtl::Reference in MediaWindowImplNoel Grandin2-13/+13
instead of storing both a raw pointer and an uno::Reference Change-Id: Id42d43e14b573d48310b9e353667da80d171110e
2017-01-17loplugin:stringconstantStephan Bergmann2-2/+2
Change-Id: Ia8e65f768d47dbbec126545aa1cf859efa59cc38
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski3-3/+3
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2016-12-27DirectShow moved from DirectX to the Windows APIDamjan Jovanovic1-1/+1
at least 10 years ago, so don't require DirectX to build the avmediawin library which uses DirectShow. Patch by: me (cherry picked from commit 8a8dd41ed0bc8c9ecf1faa27761a56b5a8fedcc2) Change-Id: I10926cb3c34bf3986c0341c1151360f1dfd5a21e Reviewed-on: https://gerrit.libreoffice.org/32411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-23unwind AVMEDIA_IMGLST/AVMEDIA_IMGLST_L ImageListsCaolán McNamara4-48/+118
Change-Id: Idf115c12c5da138141010673ed2bf0525aec6aaa
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann1-4/+1
Change-Id: I5e9910d3b5ca070e34e7621a2d3009e5c6fc0586
2016-12-20Drop ListBox include from ComboBox headerJan-Marek Glogowski1-2/+4
ComboBox just uses ListBox internally Change-Id: Ieed279160db1c9918bd9f3e37102b59ea62f0581
2016-12-13post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara1-10/+0
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13change from glew to epoxyCaolán McNamara2-6/+2
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13fix mac build after OSL_TRACE->SAL changes (2)Noel Grandin1-0/+1
Change-Id: I978e45207cd9ba96d487da92a51aaab24258855b
2016-12-13fix mac build after OSL_TRACE->SAL changesNoel Grandin2-5/+4
Change-Id: I811d4b4be5ed20a90f405900b9f8a81b5381dd7c
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin4-39/+5
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9