summaryrefslogtreecommitdiff
path: root/avmedia
AgeCommit message (Collapse)AuthorFilesLines
2016-06-07Resolves: tdf#100258 crash on disposing media playerCaolán McNamara1-3/+5
SfxDockingWindow::dispose() will call SetFloatingMode false its floating, which recreates the mpMediaWindow and so the assert occurs about living children. So toggle out of floating mode before deleting mpMediaWindow to avoid that Change-Id: I0b1cae149261fa43611b9f9a39465ce718e33484 (cherry picked from commit ec2425ad5fb39df5ad952b27d49e172fdd7ff00d)
2016-05-21Split OpenGLContext up into SalInstance specific classesCaolán McNamara1-1/+1
which, at least theoretically, allows there to be vclplug specific ones. i.e. a gtk3 specific one which doesn't assume gtk3 is running under X Change-Id: I6c007a87abbd3049b6fffc70d349e3b7ac445eec
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara2-2/+2
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara2-2/+2
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin1-1/+1
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara1-0/+1
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin1-2/+2
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11fix mac build: missing quoteCaolán McNamara1-1/+1
Change-Id: Iab61990c27d8de6ec023d9890dc2c69433a4816e
2016-05-11Include cppumaker-generated .hpp, not .hdlStephan Bergmann4-4/+4
Change-Id: Ib0451f26edbfbcdfdca78caa97bd09bc65ec2782
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-04-28tdf#97087 Give comprehensible, unique names to idlesMuhammet Kara1-0/+1
Timers and idles should have programmer comprehensible, unique names Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101 Reviewed-on: https://gerrit.libreoffice.org/24388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-21clang-tidy modernize-loop-convert in a*Noel Grandin1-2/+1
Change-Id: If8eada464c6dc7350e50fc90eb27aa47bd90e198
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin3-3/+3
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12Avoid reserved identifierStephan Bergmann1-3/+3
Change-Id: Ie881d77774ea05b5683850c113cf3f6b1d6f2ca7
2016-04-05headless build: reset ENABLE_GLTF and use that setting as beforeOliver Specht2-4/+0
Change-Id: Iea54c59393c7c2955ec5fa321d9e9ea7b57b198a Reviewed-on: https://gerrit.libreoffice.org/23831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-04tdf#94306 replace boost::noncopyable in ..Jochen Nitschke4-8/+17
.. accessibility, avmedia, basctl, basic and bridges remove boost from module if not needed anymore Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2 Reviewed-on: https://gerrit.libreoffice.org/23744 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#96505 Remove 0L occurences from avmedia and basegfx modulesslideon1-4/+4
No compiler warnings on my machine Change-Id: Ibd303c64f04f6f52272ac19c3069da2f14cb4e9a Reviewed-on: https://gerrit.libreoffice.org/23558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31sfx2: make SfxDispatcher::Execute() less variadic ...Michael Stahl1-1/+2
... and less overloaded; C++11 initializer_list should make undefined behavior as fixed in ba0a866b83f016fd460320e7d057dd107e019f19 less likely. Change-Id: I15cc0804451b6a4fcbfaa623f9a30db222207865 Reviewed-on: https://gerrit.libreoffice.org/23666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-31Spurious closing parenthesisStephan Bergmann1-1/+1
Change-Id: I0b723b758a4728816587a26d9b9b28cdc06f5dd1
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin2-2/+2
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-30avmedia: fix varargs call for WNT 64-bitMichael Stahl1-1/+1
SfxDispatcher::Execute(sal_uInt16 nSlot, SfxCallMode eCall, const SfxPoolItem* pArg1, ...) assigns the varargs to a "const SfxPoolItem *", so passing in "0L" is only correct if long is 64-bit, but on WNT 64-bit long is 32-bit, so use "nullptr" already. Change-Id: Iaf41efa795fd4439daab7ed7ec334d8ad8c476f3
2016-03-29avmedia: the Module makefile already checks and disables thatMichael Stahl1-2/+1
Change-Id: I4620a0358e06e56684954f208d19bd4350e397a5
2016-03-28avmediaogl now seems to require ENABLE_GLTF for some reasonTor Lillqvist1-1/+2
Change-Id: Id5b65b944ed06598238f5ab139c52d4de5ca1f84
2016-03-25fix headless buildOliver Specht4-4/+16
disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-03-17Resolves: tdf#96989 videos playback at maximum possible volumeCaolán McNamara2-6/+23
On systems with flat-volumes then setting the volume directly on the playbin to 100% results in resetting the global volume to the maximum possible volume. We expect to set as % of the current system volume. Putting an intermediate volume object into the pipeline does the more expected thing. Change-Id: I911d6fffba0983e4fd7b455e820959a96115de34
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin3-26/+26
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-10fix for 10 sec hang with audio-only formats with gstreamer1Caolán McNamara1-1/+2
just do the same as we did for gstreamer 0.10 and set the size found condition once we get the message even if there is no size Change-Id: I826d76dd1097432e5bd33d4acc1a187b8e5068da
2016-03-04-Werror,-Wunused-macrosStephan Bergmann1-1/+0
<https://msdn.microsoft.com/en-us/library/windows/desktop/ms647466%28v=vs.85%29.aspx> "About Strsafe.h": When you include Strsafe.h in your file, the older functions replaced by the Strsafe.h functions will be deprecated. Attempts to use these older functions will result in a compiler error telling you to use the newer functions. If you want to override this behavior, include the following statement before including Strsafe.h. #define STRSAFE_NO_DEPRECATE Appears to no (longer?) be relevant here, as reported by clang-cl. Change-Id: I94a576b71a2a34edd6009059fc5047ba59ec0f12
2016-03-04Silence -Werror,-Wnon-virtual-dtorStephan Bergmann1-0/+8
Change-Id: Ie346bca98a2da91e20ddb533ab19720f193291d4
2016-03-03loplugin:unuseddefaultparams variousNoel Grandin1-4/+2
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22loplugin:write only fieldsNoel Grandin3-7/+4
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-17use consistent #define checks for the Windows platformNoel Grandin3-3/+3
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16loplugin:cstylecastStephan Bergmann1-1/+1
Change-Id: I17025698070d3140eb2d09b705020ee4e0ee97c1
2016-02-16gtk3+wayland: play video via gtksink gstreamer elementCaolán McNamara3-56/+122
Change-Id: Ib371fa06eda73962cbe94739e69a68b46c26e4bf
2016-02-10vcl: move CommandEvent functions from header to cxx fileChris Sherlock1-1/+1
Moving functions from commandevent.hxx to commandevent.cxx, this means they are no longer inline, but there was no clear reason as to why they were inline in the first place! I've also reordered the header to ensure that CommandEvent is the first fully declared class, the data classes get declared after this (hence the forward declarations). This makes reading this header much easier. One more small thing: a few if statements had braces in the primary if block, but not in the else block, which is IMO bad style and can possibly lead to errors. I've made the else block use braces. Change-Id: I79b010bd66d3c9f4a74d4fa470f62d0263c811f4
2016-02-09Remove excess newlinesChris Sherlock1-1/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock36-354/+130
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock3-3/+3
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-01-26Silence more warnings, clang-cl's /W4 now also includes -WextraStephan Bergmann1-1/+1
Change-Id: I20fa3b02570bdbc3ccd297401a7669b0fda5c624
2016-01-25more Windows build fixesNoel Grandin1-4/+4
after my OInterfaceContainer2 change Change-Id: I345c47fac366759f61e6336b39feb91210dd25bd
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin1-4/+4
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-18loplugin:unusedfieldsNoel Grandin3-8/+4
Change-Id: I321b594f1190cdd997b4769161e1c02d31f46213 Reviewed-on: https://gerrit.libreoffice.org/21566 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann3-4/+4
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-10Fix typosAndrea Gelmini1-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05Fix typosAndrea Gelmini1-1/+1
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27 Reviewed-on: https://gerrit.libreoffice.org/21078 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-24loplugin:unusedfieldsNoel Grandin3-6/+3
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-23loplugin:unusedfields in avmediaNoel Grandin3-6/+3
Change-Id: I725a80cf7b6f2b728e650d0f365d063931b17ea7
2015-12-20loplugin::stringconcatStephan Bergmann1-3/+3
Change-Id: I212293d369be8279d886379359fc90e930ad9719
2015-12-20Fix mis-edit in d0652bfd2b87fad10c141e3bf3f5d0c0a8683cb5Tor Lillqvist1-1/+1
Change-Id: I637544c19c407389041343c951e7cbb7129bc1a2
2015-12-20Change a local DBG macro to SAL_INFOTor Lillqvist1-40/+26
But actually, I am starting to lean more and more towards the opinion that very little of our debug output code is actually useful to keep in the sources permanently. When somebody wants to debug some part of the code, they will very likely want to add much more detailled tracing anyway, temporarily. Change-Id: I6a60a130e3b72ba3d6ad32a1b22a2a9f3ac66b27
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 16:59:53 +0000