summaryrefslogtreecommitdiff
path: root/accessibility
AgeCommit message (Collapse)AuthorFilesLines
2017-02-15Drop :: prefix from std in [a-b]*/Tor Lillqvist12-22/+22
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd Reviewed-on: https://gerrit.libreoffice.org/34320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-14drop unused LIST from SvTreeAccRoleType enumNoel Grandin2-6/+2
Change-Id: I378dea43b0c08675419a5399e5999c34441497fe
2017-02-14Convert WindowType to scoped enumNoel Grandin6-15/+15
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin4-18/+0
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann30-2/+32
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01makeAny->Any in accessibility..avmediaNoel Grandin8-47/+47
Change-Id: I70f2dfa66d7b66738a840e4a7b5c7fb1b8d7b39f Reviewed-on: https://gerrit.libreoffice.org/33756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2-12/+6
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann117-2329/+1653
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, accessibilityStephan Bergmann13-4/+32
Change-Id: I4857292372116bd8330403456d415476a5435f11
2017-01-17use rtl::Reference in AccessibleGridControlAccessNoel Grandin2-83/+59
instead of storing both raw pointers and uno::Reference Change-Id: Ie2306b619bec81707c5cff4debb8c7462ac2f9a1
2017-01-17use rtl::Reference in AccessibleBrowseBoxAccessNoel Grandin2-50/+36
instead of storing a raw pointer and a uno::Reference Change-Id: I4326cbda900e053599f1e753cb1bff122bdecc44
2017-01-16new loplugin: useuniqueptr: accessibilityNoel Grandin2-7/+5
Change-Id: I0994bfcae23a2714c78e16c9baa7e0a018d46513 Reviewed-on: https://gerrit.libreoffice.org/33144 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12a11y crash on accessing disposed TabControl during close of impressCaolán McNamara1-3/+8
Change-Id: I3064eb136ed3a6a32acd64bfb2f6fbe31595e1cf
2017-01-10accessibility: prevent possible deadlockArnaud Versini1-2/+2
Change-Id: I1dc409644ed2e2bdd0cd38c8343c4ada1af7127b Reviewed-on: https://gerrit.libreoffice.org/32137 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09accessibility: simplify lockingArnaud Versini11-144/+135
Change-Id: I87580eabf87fffd86068b5b2e44672aa1f9ffe84 Reviewed-on: https://gerrit.libreoffice.org/32136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-07accessibility: simplify CharacterAttributesHelper.Arnaud Versini2-30/+7
Change-Id: I62063745e704c941fdce306228ebbe3522c3b438 Reviewed-on: https://gerrit.libreoffice.org/32738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-06Localize return value of EditBrowseBoxTableCell::getAccessibleNameMuhammet Kara3-12/+28
Change-Id: I040c1b9b8680a366819254e1d44b80115a339bbf Reviewed-on: https://gerrit.libreoffice.org/32441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-30cleanup tailing backslashesJochen Nitschke1-1/+1
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23loplugin:unusedmethodsNoel Grandin1-3/+0
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5 Reviewed-on: https://gerrit.libreoffice.org/32336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19tdf#104767: Fix calculus of child index in commitTableEvent (accessibility)Julien Nabet1-1/+1
bt: 1 0x00002aaade2fea5b in accessibility::AccessibleGridControlTableBase::ensureIsValidIndex (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTableBase.cxx:257 2 0x00002aaade2f97f2 in accessibility::AccessibleGridControlTable::getAccessibleChild (this=0x5555586abdb0, nChildIndex=11) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControlTable.cxx:60 3 0x00002aaade2ee054 in accessibility::AccessibleGridControl::commitTableEvent (this=0x555557e97500, _nEventId=5, _rNewValue=uno::Any(void), _rOldValue=uno::Any(void)) at /home/julien/lo/libreoffice/accessibility/source/extended/AccessibleGridControl.cxx:354 Seems a regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=0f32ba56a1e775e8ecd6c827ebd48f7f2fb51c81 Change-Id: Ia973eb381832da27ecc39fc5273f67a685d5a7bb Reviewed-on: https://gerrit.libreoffice.org/32205 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-13accessibility: cleanup AccessibleBrowseBoxBase implementationArnaud Versini11-108/+99
Change-Id: I5c9b96e2ebd2ac98dfa610346c1da89fbf56e2d2 Reviewed-on: https://gerrit.libreoffice.org/31916 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-10tdf#93430: Return the right offsets for runsTamás Zolnai1-0/+15
MultiLineEdit is a special control which can have more text portions with different text attributes. Change-Id: Iab51dba0d0344fad4358f4961c968c031b1660b6 Reviewed-on: https://gerrit.libreoffice.org/31813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-09Edit accessibility: intended to use dynamic cast hereTamás Zolnai1-1/+1
This is not necessarily a multilineedit. Change-Id: Ibcbc104513bc6523e61efa5f3ff22efd3422e036
2016-12-09Fix 32-bit buildsStephan Bergmann1-1/+1
Change-Id: Ia9739aaf2d6d5d7083cf9b9aa7dc7819fbb0f941
2016-12-09tdf#93430: Cannot get accessible text attributes for 'Not in dictionary' entryTamás Zolnai1-1/+43
Change-Id: Iaa2b4fdb582025b763d43f0f24960e2ccee708e3 Reviewed-on: https://gerrit.libreoffice.org/31778 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-08convert SFX_HINT to scoped enumNoel Grandin1-27/+28
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08tdf#88206 replace cppu::WeakImplHelper* in unotoolsJochen Nitschke2-0/+2
[needs 288386f6986622461f28276ff7ff3e7172143159 "Another 'Do not export whole class to avoid MS C++ implicitly exporting...'" to build with MSVC] Change-Id: I8de7c4a1947ce91f9a629536e481c012e7c5c7ec Reviewed-on: https://gerrit.libreoffice.org/31679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin23-169/+172
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-26tdf#99687: Find Text widget fails to emit object:text-caret-moved eventsTamás Zolnai1-1/+1
Must be an integration bug: efb23f29983f87104a684e7fab00b84fc59d131d Change-Id: I53b15975fb97a299103fab870307b03b2607e9e5 Reviewed-on: https://gerrit.libreoffice.org/31238 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin10-21/+21
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:oncevarNoel Grandin1-4/+2
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d Reviewed-on: https://gerrit.libreoffice.org/30668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke1-1/+1
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01loplugin:expandablemethods in accessibilityNoel Grandin20-154/+29
Change-Id: I51d13c12274d99623b97f611e30204bea624cbfc
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke1-5/+4
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-11loplugin:refcountingStephan Bergmann2-4/+4
Change-Id: Ia7ec56c754d6eafcd4c6d981a0d8ca03af23a18e
2016-10-11parent will definitely exist at ctor timeCaolán McNamara1-7/+5
Change-Id: I3d30b17e4105a98ad6ab378cee7128cac23f1dc0
2016-10-11Resolves: tdf#103032 a11y crash on listbox dispose in toolbar dropdownCaolán McNamara4-52/+50
Change-Id: I70bce310ba9b46efdbdfdec8d2c6689d0ba2e655
2016-10-05loplugin:unnecessaryoverride in accessibility..chart2Noel Grandin6-34/+0
Change-Id: I14ba52fe8352f8bbdfcaa90177f4f3ac9f0e08b1
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann12-12/+12
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke1-1/+0
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-14loplugin:constantparam in accessibility to basicNoel Grandin5-11/+9
Change-Id: Id77cbcaefebf310a5d99c6ac12d154e182fd0a1c Reviewed-on: https://gerrit.libreoffice.org/28860 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14tdf#88205 use list ctor for uno::Sequence a11y to canvasJochen Nitschke6-31/+19
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18 Reviewed-on: https://gerrit.libreoffice.org/28866 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13chmod 644 some source filesStephan Bergmann1-0/+0
Change-Id: Icd8821278635c1bd27b5185cddf5dc25dfba7eb4
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann57-62/+62
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc.Gökhan Gurbetoğlu1-19/+13
Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08 Reviewed-on: https://gerrit.libreoffice.org/28584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-05convert ScrollType to scoped enumNoel Grandin1-5/+5
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-08-26convert SV_ITEM_ID_LBOX defines to scoped enumJochen Nitschke1-1/+1
and remove unused SV_ITEM_ID_EXTENDRLBOXSTRING Change-Id: Ic84d9341d0225b01b9ef46814483c66b1af307b5 Reviewed-on: https://gerrit.libreoffice.org/28397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:constantparamNoel Grandin3-7/+5
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04loplugin:countusersofdefaultparams in accessibility,avmediaNoel Grandin6-6/+6
Change-Id: Ic173f43c882384fe594e8ba3e44aedc3796a45f6 Reviewed-on: https://gerrit.libreoffice.org/27792 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-15Improve loplugin:unnecessaryoverrideStephan Bergmann2-6/+0
<sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 06:14:52 +0000