summaryrefslogtreecommitdiff
path: root/accessibility
AgeCommit message (Collapse)AuthorFilesLines
2015-04-13loplugin:staticmethodsNoel Grandin2-3/+3
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
2015-04-09loplugin:staticmethodsNoel Grandin2-2/+2
Change-Id: I715374b531da2850434b2436633b6042ecb9ebe0
2015-04-03Resolves: tdf#82998 no object:active descendant changed emittedCaolán McNamara1-40/+16
for listboxes in WB_DROPDOWN mode which means the dropdown exists, but when the drop down is not activated. I think it's plausible that there was confusion around "b_IsDropDownList" and that the meaning taken by the author was the the dropdown is active if b_IsDropDownList is set, so renamed that to bHasDropDownList and take the old "b_IsDropDownList" path when "b_IsDropDownList && ..IsInDropDown()" Folded the then both equal code paths of the LISTBOX code together. No idea if there should be an additional equivalent AccessibleEventId::SELECTION_CHANGED for LISTBOXES like COMBOBOX instead of AccessibleEventId::ACTIVE_DESCENDANT_CHANGED in the dropdown not active case. Change-Id: I6db3ec21b392b7bf1b488235464202bb326f2535
2015-04-03Related: tdf#82998 rearrange, no logic changeCaolán McNamara1-34/+41
Change-Id: I1d3a6a552bd535622009b43e0633a357b1a919e6
2015-04-03Related: tdf#82998 assume VALUE_CHANGED makes sense only for windowsCaolán McNamara1-1/+5
jdiggs: I believe [VALUE_CHANGED] is expected for Windows' accessibility APIs. However for ATK/AT-SPI2, value-change events are expected only for the sorts of things which implement AtkValue (scrollbars, progressbars, sliders, spinbuttons, etc.) Combo boxes, lists, and the like should not be emitting this event. Change-Id: I9dcab7fb4004a24f88915f904eb508dfee2d4ae5
2015-04-03Related: tdf#82998 don't emit an Indeterminate state change for boxesCaolán McNamara1-14/+2
Emitting object:state-changed:indeterminate is appropriate for things like tri-state checkboxes when the state is neither fully checked nor fully unchecked. ... jdiggs think that this event doesn't make sense in this instance for any platform's accessibility API Change-Id: Id8288522a825ad7ff61524ad4f225a79c015bb8f
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann3-4/+4
Change-Id: Ifab61517e0b2e721b85a3e2cc7d927198f1690c4
2015-03-20tdf#88230: cleanup solar mutex yieldingPranav Kant7-21/+16
Use SolarMutexReleaser, instead. Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin1-1/+1
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-09V801: Decreased performanceCaolán McNamara2-3/+3
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-02-24Avoid unnecessary bad downcasts to ToolBoxStephan Bergmann1-6/+6
Change-Id: I239aee06ce543b6f7c213d845313ca51b3a5502d
2015-02-22Typo: aditional->additionalJulien Nabet1-1/+1
Change-Id: I7db230949a97da28c60101d8cce1e30fbc08535c
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara11-173/+169
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-07loplugin:deletedspecialStephan Bergmann7-24/+16
Change-Id: I39285a4eb7f205cc89cd2aa4e48ccbfc9ccfd83e
2015-02-02callcatcher: remove some unused methodsCaolán McNamara2-29/+0
Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara6-66/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-27tdf#88702 ACCESSIBILITY Toggle buttons state not reliably updatedNiklas Johansson1-4/+3
We need to adapt the accessibility code to handle VCLEVENT_TOOLBOX_ITEMUPDATED, since it is now sent from vcl/source/window/toolbox2.cxx. I have tested the patch successfully on Windows and Fedora. Change-Id: Ia4328d3c34547cc28ce9a3946f90223442ee84e3 Reviewed-on: https://gerrit.libreoffice.org/14190 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin15-21/+21
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-07Accessibility: Expose keyboard short-cuts of menu entriesNiklas Johansson1-0/+4
On Windows the keyboard short-cuts of menu items like "Open Ctrl+O" is not exposed to accessibility tools on Windows. On Mac and Linux it is. If I understand Microsoft's notes correctly, it is expected that the short-cut gets appended to the accessibleName. This is what Acrobat Reader, Internet Explorer, Firefox is doing. And with this patch LibreOffice as well. For info from Microsoft on the matter see: http://msdn.microsoft.com/en-us/library/windows/desktop/dd318482%28v=vs.85%29.aspx Change-Id: I4ed7c4c45998063bb50744b44c792351070489d7 Reviewed-on: https://gerrit.libreoffice.org/13516 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-06fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin1-4/+4
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara2-2/+0
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara1-2/+2
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-08reduce scope of local variablesMichael Weghorn1-3/+2
This eliminates some of the warnings from Cppcheck report of 2014-11-29. Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9 Reviewed-on: https://gerrit.libreoffice.org/13330 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-30fdo#86117 a11y: Exception when closing popup from ToolBox w/o separatorMaxim Monastirsky1-1/+7
For some reason PopupWindowControllerImpl::WindowEventListener is getting the VCLEVENT_WINDOW_HIDE event twice, and while processing the second one the ToolBox no longer has an active down item, which results in a IndexOutOfBoundsException in VCLXAccessibleToolBox::getAccessibleChild, because ToolBox::GetItemPos(0) correctly returns TOOLBOX_ITEM_NOTFOUND. But when a ToolBox has at least one separator, ToolBox::GetItemPos(0) "detects" its position as the current down item, and no exception is thrown. Probably it just hides the bug, because it seems to me that getting the hide event twice is the real bug here. Change-Id: If018350dd91cd959c0c8f7d6859474f95fb8cd1e Reviewed-on: https://gerrit.libreoffice.org/13173 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava6-8/+8
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin1-4/+4
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin3-8/+6
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin1-2/+2
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin1-1/+1
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-5/+5
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18convert SV_BMP_ constants to enumNoel Grandin1-4/+4
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-2/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-08coverity#1242517 Arguments in wrong order (gold ?)Caolán McNamara2-2/+2
Looks like they are backwards to me Change-Id: I20f38050172c1671a81d6ab7de80123ad1703528
2014-10-03coverity#1242449 Identical code for different branchesCaolán McNamara1-4/+1
Change-Id: I0cffc9df6d971393ae874060a8c306e12966370c
2014-10-02loplugin: cstylecastNoel Grandin8-31/+31
Change-Id: Ib36c0f4f8afa0bcaafa0836182e90a9f1d8aff75
2014-09-30loplugin: cstylecastNoel Grandin9-20/+20
Change-Id: Ie5cbad7ee18b0ecbca5df97808431be577449c32 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin37-68/+68
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin10-11/+11
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15accessibility: sal_False/True -> false/trueStephan Bergmann21-41/+41
Change-Id: I4ac9d6ce48217893246a82fde4546dad09c58bd0
2014-09-12toolkit: sal_Bool -> boolStephan Bergmann1-2/+2
Change-Id: I8819d408e8556bbf38605c2feef2fa87d8dd41c3
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin1-3/+3
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist4-5/+5
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-07-18coverity#1132662 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: Ifbaa05e70c8958d0289047efb75a13e0b8a13a4b
2014-07-08use SimpleReferenceObject in svtools moduleNoel Grandin1-24/+0
to replace hand-rolled version Change-Id: I7a1048ff1ea335c3934fe7e91a09489a4d7aeb96
2014-07-08use SimpleReferenceObject in accessibilityNoel Grandin1-0/+1
to replace hand-rolled version Change-Id: I9dd8d02024702972722b43f2654db91eb3da3794
2014-07-04Notify screen readers when selection changes in listboxesNiklas Johansson1-1/+6
When you change selections in listboxes without dropdown fuctionality an accessilble event needs to be sent, this does not happen today. An example of such listbox is the Suggestions in the Spelling and Grammar dialog. Change-Id: I6100c88ae5398d8bf3f511aee7b35e88fbf151f5 Reviewed-on: https://gerrit.libreoffice.org/10087 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-02fix some more indent and strip ::rtl::Caolán McNamara1-7/+7
Change-Id: I8a4f220e6e07babbb2fa8f8dcab524ba90e62986
2014-07-02Related: #i124856# guard against crashJürgen Schmidt1-1/+1
Patch By: hanya Review By: jsc (cherry picked from commit efe87c0d84e5f76034378d48d0d1fc2025a37645) Conflicts: accessibility/source/standard/vclxaccessiblebox.cxx Change-Id: I24fd4278406dacea33230cc1bf1528e3c5aaedf2
2014-07-02fix some mangled indentationCaolán McNamara1-39/+14
Change-Id: I09be3a66562e1c5c1c2b27c670672f63b0a652b0
2014-06-20hmm, that's not rightCaolán McNamara1-3/+3
Change-Id: Id714a54b08127c594c108c824bb0dedd74bb5c06
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-24 23:42:49 +0000