summaryrefslogtreecommitdiff
path: root/accessibility
AgeCommit message (Collapse)AuthorFilesLines
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann69-1237/+1237
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-25svtools: sal_Bool->boolNoel Grandin2-8/+8
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25Reduce IAccessibleTabListBox to what's actually usedStephan Bergmann1-2/+2
...the calls to getAccessibleChild(0) and getHeaderBar(BBYTE_COLUMNHEADERBAR) ultimately all ended up at AccessibleBrowseBox::implGetHeaderBar(BBTYPE_COLUMNHEADERBAR). Change-Id: Ie25659e19d0d1ce2dcde2d1440ecc69b4fa265b0
2014-03-25Remove dead codeStephan Bergmann4-73/+0
Change-Id: Ia9035189bd01d3a3e5e3222760fc392f3f78880f
2014-03-25Remove dead codeStephan Bergmann20-113/+4
Change-Id: Id522113f1ba0c9e7b1356acc01a79e0e90a5e752
2014-03-24svtools: sal_Bool->boolNoel Grandin8-12/+12
Change-Id: Ic765d1a28960dbeca9501852b5e84cfdfe6ac47e
2014-03-18Use cppu::BaseMutex and remove need for Paragraph/ParagraphImpl splitStephan Bergmann2-175/+163
Change-Id: I790e14feb50fefe3b2efa505118b332d065970fc
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin2-4/+4
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-15fdo#63154 Remove some solar.h referencesAlexandre Vicenzi2-6/+5
Remove some solar.h from tools. Replace sal_uLong by size_t, sal_uInt32 and sal_Int32. Change-Id: I38961db046337a3ea4ef75d64afa424d81391f34 Reviewed-on: https://gerrit.libreoffice.org/8582 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-14OAccessibleContextWrapperHelper does not implement XAccessibleContextStephan Bergmann1-3/+3
...but rather some (non-virtual) base functionality for use in derived classes (that do implement XAccessibleContext) Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-13a crash sometimes seen in a11y in baseCaolán McNamara1-14/+15
Change-Id: Id8b7c8394a4e8bc1477c34056b8014d311186d7e
2014-03-11No need for implGetBounds to be SAL_CALLStephan Bergmann13-13/+13
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-10accessibility: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann9-75/+9
Change-Id: I7f8848adf245a4fdf56bff67cc15ee0efb818c43
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke5-34/+36
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05remove unused code in accessibility::DocumentNoel Grandin2-41/+0
accessibility::Document::justifySelection(TextPaM&, TextPaM&) accessibility::Document::notifySelectionChange(int, int) Change-Id: I3a5c79ada69c1530ebbbf386bf271f3a83843815
2014-02-26Revert "Let's use RADIO_BUTTON and CHECK_BUTTON roles"Stephan Bergmann1-6/+4
This reverts commit 97d4f7e07462cbc33e8ebf0bc2bbf8a17c232d50, which appears to be incomplete: CHECK_BUTTON is not defined anywhere.
2014-02-26Let's use RADIO_BUTTON and CHECK_BUTTON rolesJulien Nabet1-4/+6
Thank you Caolán and Niklas for your support! Change-Id: Ied978b36cc309b2668889d878a309d1a1400633a
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann123-1926/+1926
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26cppcheck: duplicateIfJulien Nabet1-7/+9
- replace duplicate TIB_DROPDOWN test with TIB_DROPDOWN + TIB_DROPDOWNONLY - consider also TIB_RADIOCHECK as AccessibleRole::TOGGLE_BUTTON Change-Id: Id159349ae1515681f47c373ba3d839ed406284ab Reviewed-on: https://gerrit.libreoffice.org/8164 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25Remove visual noise from accessibilityAlexander Wilms78-314/+314
Change-Id: I876e5c4d1991b35c1dc2cea709d8a2ddf781b012 Reviewed-on: https://gerrit.libreoffice.org/8225 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-24Replace exisiting TriState, AutoState with more generic TriStateStephan Bergmann5-14/+14
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-23Remove unneccessary commentsAlexander Wilms53-1564/+1318
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxxTobias Lippert16-3/+16
Added vcl/settings.hxx to all cxx files which require it. This helps to speed up compilation after changes to the settings. Conflicts: sc/source/ui/dbgui/pvlaydlg.cxx Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4 Reviewed-on: https://gerrit.libreoffice.org/7933 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-19Related: fdo#74242 hook up a selection and caret change for multiline editsCaolán McNamara1-0/+1
a) split the textengine selection changed broadcast into a text selection changed and text caret change event b) handle both in existing places that handled the text selection event c) listen for them in VclMultiLineEdit and translate to VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and VCLEVENT_EDIT_CARETCHANGED handling in accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-19Related: fdo#74242 #i104470# we now have a seperate CARET_CHANGED eventCaolán McNamara1-17/+14
so cursoring left and right in normal non-multiline edit widgets should give a11y cursor-changed events Change-Id: I91e86e43d049793912b3ffcc2802bb9aa4b3857c
2014-02-11accessibility: add some missing locks in new codeMichael Stahl4-9/+18
Change-Id: Ic38a07c592a89973ca1df807505f87910e84a17f
2014-02-10the return of callcatcherCaolán McNamara2-15/+0
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-07std::less is the default hereStephan Bergmann1-1/+1
Change-Id: I57428772187d3487668eca2f553c74e18e4f736e
2014-02-07auto_ptr -> scoped_ptrStephan Bergmann4-15/+9
Change-Id: I05c461deca118f1a1b75d94b4d00ce797987e8d6
2014-02-07Avoid unnecessary heap allocationStephan Bergmann4-22/+8
Change-Id: I7bc1a0960cc100c51b90c50838a5ef620f3c763f
2014-02-05Doxygen warnings correctedChris Sherlock2-3/+3
* Doxygen spits out a lot of warnings about not being able to find match function signatures, etc. This is because in some headers we have a using namespace statement, in others it gets confused between ::Window and Window (!). * Wrong use of tags: + Lots of @seealso - should be @see + Wrong usage of @overload - corrected with the right function signature + HTML tags that doxygen doesn't recognize removed Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-04fix ambiguitiesCaolán McNamara2-3/+3
Change-Id: Ice46cfbe8a21c5e641e09070128b8f412411c9d9
2014-02-04Related: #i123862# use O*String's isEmpty() method...Herbert Dürr1-2/+2
to check for emptiness in modules starting with 'a' Patch-by: j.nitschke@ok.de Review-by: hdu@apache.org (cherry picked from commit 40b2ffbb1036c2f2db50965525009213d8fd6343) Conflicts: accessibility/source/extended/accessibleiconchoicectrl.cxx accessibility/source/extended/textwindowaccessibility.cxx accessibility/source/standard/vclxaccessiblebox.cxx accessibility/source/standard/vclxaccessibletoolboxitem.cxx automation/source/server/recorder.cxx automation/source/server/statemnt.cxx avmedia/source/framework/mediacontrol.cxx avmedia/source/framework/soundhandler.cxx avmedia/source/gstreamer/gstplayer.cxx avmedia/source/viewer/mediawindow.cxx Change-Id: I8e6d6754282634f6931a2e7f73f08f70c23d452e
2014-01-28bool improvementsStephan Bergmann5-7/+7
Change-Id: I09ac60e907b7c0a78934dce05343e2ba2b6df49f
2014-01-28Resolves: #i124008# listbox entry's are selected automatically...Steve Yin2-0/+2
on mouse over instead of mouse click (cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3) Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28coverity#983594 Uncaught exceptionCaolán McNamara2-4/+10
Change-Id: Ic49f88b44216a24df8a236b755d22b2537245c5f
2014-01-28coverity#706219 Uncaught exceptionCaolán McNamara2-4/+10
Change-Id: I1c2566337347679453bee46a78a4a0ecd7fdd2fb
2014-01-23fdo#63154 Removed unused solar.h referenceAlexandre Vicenzi1-3/+0
Change-Id: I6b2f9e04e2232570c8bb9f36252b23a70c5f7525 Reviewed-on: https://gerrit.libreoffice.org/7604 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-19coverity#1132668 : missing break in switchNorbert Thiebaud1-84/+81
Change-Id: Ia759081e7ccc9105898f25025ea567d900d33b13
2014-01-19coverity#1158122 : Explicit null dereferencedNorbert Thiebaud1-2/+4
Change-Id: I6ffec6e69ca5ddb01998653d2f7637ed062bdc80
2014-01-19coverity#1132662 Dereference after null checkNorbert Thiebaud1-1/+1
Change-Id: Iaccf8bb7903702d2bed3c4fc2195172e18ead6c7
2014-01-19coverity#1132661 Dereference after null checkNorbert Thiebaud1-13/+10
Change-Id: Ida147599810b0aff4a7ebd00b90475b1c6cd1366
2014-01-19coverity#1132660 Dereference after null checkNorbert Thiebaud1-16/+13
Change-Id: Ib184d73f2ced3beca8540a37bab74c4a712170ba
2014-01-15fdo#57950: Remove chained appends in accessibilityAnderson Roberto1-8/+1
Change-Id: I4ba583a891933068ab4003307d09693180c7b61f Reviewed-on: https://gerrit.libreoffice.org/7436 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-16svtools: rename IAccessibleTableControl::dispose()Michael Stahl2-2/+2
... to not confuse it with XComponent::dispose(). Change-Id: I056fdf77f9116d1c22f8ca9313a0ea313fb1c4aa
2013-12-16accessibility: don't crash if the TableControl is deadMichael Stahl2-7/+10
AccessibleGridControlAccess: clear the m_pTable member in dispose() so it is no longer accessed later. Change-Id: I490c84ce1bee55c9c69eb29b81ddfbe808301797
2013-12-16accessibility: Mutex cleanup in AccessibleGridControl* classesMichael Stahl9-116/+93
For unknown reasons this uses both SolarMutex and a OBaseMutex::m_aMutex to lock some but not all methods, which seems odd. - remove a third mutex AccessibleGridControl::m_aMutex that appears unused - lock OBaseMutex::m_aMutex in AccessibleGridControlBase::isAlive() which accesses rBHelper members, which should be sufficient - lock SolarMutex in all UNO methods - remove misc weird stuff like TC_SolarMethodGuard Change-Id: I8321757fb4a5043a05c23f2dc9801f5d8c8d911e
2013-12-08Drop duplicate #includeTakeshi Abe1-1/+0
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-05fdo#39956 Delete JABDavid Ostrovsky57-12785/+0
JAB has been discontinued in favor of the native IA2 bridge. Change-Id: I88461f73c620507d3e97b077ea2abdd2229322e1 Reviewed-on: https://gerrit.libreoffice.org/6819 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-11-28Related: #i123768# [ia2] remove pseudo-automatic noisy commentsHerbert Dürr2-2/+0
Change-Id: I346518267294556ce529966fe168440de05a38c6