summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-11-27tdf#126043 use another bulk_insert_for_eachCaolán McNamara7-45/+81
Change-Id: I05c3fc6e708d000ba955981dbd8d11371ea99da2 Reviewed-on: https://gerrit.libreoffice.org/83686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27crashtesting: export of fdo50613-3.odt to docx crashesCaolán McNamara3-3/+32
there are multiple objects in the doc and the ole cache hovers at the max size at which it wants to purge excess object. On save to docx, object a's chart model is fetched in order to save it, this triggers activating that object a, so object b is purged from the cache. storeOwn is called on b to save it to the document persist storage. During save of object b to document persist, ChartView::getExplicitValuesForAxis is called, which calls impl_updateView which eventually calls lcl_setDefaultWritingMode. *if* IsCTLFontEnabled is on, then chart digs through its parents objects looking for a chart in order to see what the writing direction is at the insertion point of the chart, or failing that for the page its on) (this also seems dubious as it might be any chart, not the current chart) To see if the object is a chart it calls getPropertyValue("CLSID") which brings the object into the ole cache, another object is purged from the cache, and the object purged is object b (which is in progress of getting purged already) object b is now purged in the inner case, so when control is returned to the outer storeOwn the object properties have been deleted and all is lost disallow a purge within a purge Change-Id: Ia21e794759aa82b6bcf39c638be8b47ac58a9bb3 Reviewed-on: https://gerrit.libreoffice.org/83808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26Fix for 2 commits related to cppcheck:Julien Nabet2-4/+2
1) https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e1ae2a9a0d2d9185b49677fa4ea2a2b1fe8bab2 I had let "size" and "fields" initialized twice instead of initializing only 2) https://cgit.freedesktop.org/libreoffice/core/commit/?id=e6ab01ce532d1db01579b70bd476b2f643522bf9 put back original order for NestedKeyImpl and adjust initialization accordingly Change-Id: I6ca4e6520558011c359f8ea089b6d431ad79edfe Reviewed-on: https://gerrit.libreoffice.org/83810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-26tdf#43021 WIN opt-out of OS recent folder usageJan-Marek Glogowski7-48/+20
The Microsoft documentation for SetFolder explicitly mentiones "In general, we do not recommended the use of this method. [...] SetDefaultFolder is the better method." If SetDefaultFolder is used the recently-used folder overwrites the value passed to SetDefaultFolder, which is shared between all file pickers. With this patch we rely on the LO internal mechanism to show the last used directory in the file picker. Regina's workaround basically does the same, as it just sets oRegistryKeyContent.WorkPathChanged, which triggers the internal path to use SetFolder instead of SetDefaultFolder. If you're wondering about the GetFolder() handling, the MS API docs have this: "Gets either the folder currently selected in the dialog, or, if the dialog is not currently displayed, the folder that is to be selected when the dialog is opened." So the call to GetFolder(), after the dialog is closed, returns the folder set by the SetFolder call, not the folder selected by the user, in case of the save dialog at least. Change-Id: Ia24f47848501df82727bfb2a99db723468bfe5b1 Reviewed-on: https://gerrit.libreoffice.org/83409 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-26tdf#126607 Qt5 activate window before setFocusJan-Marek Glogowski1-1/+5
.., and prevent Qt5MainWindow to take any focus. Our top level Qt5MainWindow shouldn't handle focus directly, as it's always completely drawn by the child Qt5Widget, which also handles input. So prevent any direct focus handling by setting the Qt5Widget as the focus proxy of the Qt5MainWindow. Also setting the focus of the child widget on its own seems to do nothing at all. At least I didn't see any difference after commenting the code block. But it at least has some effect, if you call setFocus on the real window, but that breaks Impress full screen mode, which somehow gets scroll bars?! Not that I understand why this is needed. At least the original X11 code just calls XSetInputFocus in this case. Change-Id: I591c031a17a7ae0b5486760cd1802522d4088678 Reviewed-on: https://gerrit.libreoffice.org/83689 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-26tdf#128698: MySQL/MariaDB direct Connection: time-values not written to tableJulien Nabet1-1/+1
Initialize MYSQL_TIME my_time structure before using it Same idea as part of f4393330b2bbebc7290b72ad2f5b81d26244ac64 but by using modern initialization instead of memset Change-Id: Ife9741604e7bf8f0fbe4671ddb16a56204f4fa43 Reviewed-on: https://gerrit.libreoffice.org/83811 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-11-26Remove unused DemoRenderer::maColorWhiteStephan Bergmann1-2/+0
(found by upcoming loplugin:unusedmember) Change-Id: I518c70d3f4011bd5f0f582ca239dc6f8e49d9656 Reviewed-on: https://gerrit.libreoffice.org/83813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26xmloff,sw: fix handling of invalid attribute with multiple ':'Michael Stahl20-48/+61
ooo53770-1.odt contains an invalid attribute style:style:use-optimal-row-height, which was round-tripped as an unknown attribute, triggering the assert in CheckValidName(). This reveals a confusing mess of SvXMLNamespaceMap::GetKeyByAttrName functions. The bCache flag for one of them was accidentally inverted in commit 78f0d15893c56d7368ddd7ded4e70f2a3bb9d2f4 "loplugin:constantparam in xmloff/" There are basically 2 use cases for this: * XML element and attribute names, which are XML QName and contain at most 1 ':' * XML attribute values, which are namespace-prefixed and may contain any number of ':' in the "local" part of the value Because caching is explicitly disabled for Calc formulas, just resolve the inconsistent bCache by always caching element and attribute names, and never caching attribute values, so we need just 1 flag. Change-Id: I363ea2229d0bf5c7199d61b0fee0d9f168911bfa Reviewed-on: https://gerrit.libreoffice.org/83619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#129037 add a way to select multiple entries of a ListBox togetherCaolán McNamara3-1/+37
Change-Id: I362a9e9e644e15f0dd3aeb691973a0979d17eeb0 Reviewed-on: https://gerrit.libreoffice.org/83771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#127403 Revert "VCL keep / return the original set TextEngine font"Jan-Marek Glogowski4-31/+58
This reverts commit cc223fa12a61ba0e580b884386a7f5d7efd0541f. All the other attenps to fix this seem to cause timeouts in the Jenkins clang_dbgutil build. I don't have one around and no time to investigate further, so let's see, if the revert passes. Change-Id: Ib915185eaf79073523351705baf28df3c62906f1 Reviewed-on: https://gerrit.libreoffice.org/83654 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-26SpellingPopup: Fix Ignore All execution.Tamás Zolnai1-45/+42
Change-Id: I13520c1f14530cc1f04290d4d0b204cc45b124eb Reviewed-on: https://gerrit.libreoffice.org/83786 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-26tdf#128985: ODP: Style text directions revert to RTL on save and re-openTamás Zolnai1-24/+22
First we need to check duplicate writing modes and then ignore the defult LR_TB writing mode. Change-Id: I166141abd6286fc48c095ef92751e420fb197b3e Reviewed-on: https://gerrit.libreoffice.org/83785 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-26tdf#128605 DOC import: fix cont sect break with different top/bottom marginMiklos Vajna3-3/+13
Word has a feature to attach different page margins to sections, and then refer to these section definitions via continuous section breaks. The result is that the margin changes never introduce a page break, and left/right margins are applied instantly, while top/bottom margins are applied from the next page. Now in Writer, either these continuous section breaks are mapped to a page break and all margins show up as expected, or we don't do a page break, and then the number of page breaks are as expected; but you can't have both at the same time till the feature is missing in Writer core. Commit c5ed52b1cd6f22787c94bec035ceecf9e1da3271 (ww8import create a pagedesc if continuous section changes margins (bnc#875383), 2014-07-21) tweaked this decision, so that the DOC import always creates a page break, but left the DOCX import unchanged. Fix the bug by going back to not creating page breaks on top/bottom margin changes: this resolves the scenario and still keeps the original situation fixed, too. Change-Id: Id0e8c3a4ce40db8da024a0a20005eb0445325a1a Reviewed-on: https://gerrit.libreoffice.org/83789 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-26Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib0c7988306a55740281daa75f24e0d393be9bb02 Reviewed-on: https://gerrit.libreoffice.org/83823 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-26Fix typoAndrea Gelmini1-1/+1
Change-Id: Iee87dbb1a2e02891728a0aad2361fce60a479433 Reviewed-on: https://gerrit.libreoffice.org/83821 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-26Remove unused OpenCLEnv::mpOclCmdQueueStephan Bergmann1-1/+0
unused since 4eea4af8924e3b1bb00c22cf1f9d21fc4dec6e83 "tdf#103204 opencl: initialize command queue on demand" (found by upcoming loplugin:unusedmember) Change-Id: Ic8ab914699d5a99338abdfc315001603a8255e1b
2019-11-26Remove unused StateChangeEvent::return_typeStephan Bergmann1-1/+0
(found by upcoming loplugin:unusedmember) Change-Id: I0259881207d2014df460ed83afe3da0a13068147
2019-11-26sw: WW8 import: fix again asserts on fdo45983-1.doc export to ODTMichael Stahl3-8/+14
The problem is that we now insert 2 dummy characters at the start of a fieldmark instead of 1, so the checks in RedlineStack::MoveAttrs() were off by 1 and we get the same invalid redline containing the start but not the end of a fieldmark. (regression from 7f2e61f884949ab27bcb7e1a02ece9a5cb4354b9) Change-Id: I9752ca4c3a281539e37ddac4fe811e2f9d7374a6 Reviewed-on: https://gerrit.libreoffice.org/83783 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-26Remove some unused includesMiklos Vajna2-7/+0
Change-Id: Ia24c806f227570f7a000e85eece75c9d02d25a4b Reviewed-on: https://gerrit.libreoffice.org/83782 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-26cppcheck: performing init in init list (sw/vcl/xmloff)Julien Nabet21-203/+147
Change-Id: I8e6c77847e1c2ec386c27c34b75160f4a44da2fe Reviewed-on: https://gerrit.libreoffice.org/83717 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-26loplugin:staticmethods (clang-cl)Stephan Bergmann2-2/+2
Change-Id: Ie3b1e7d8a048bc161770bfb01f4d94e14a3fdea9 Reviewed-on: https://gerrit.libreoffice.org/83768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26nss: fix Android buildMiklos Vajna1-0/+21
By not building some of the test code. The first hunk is necessary to avoid: /home/vmiklos/git/libreoffice/master-android/external/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lpthread clang: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:379: abstract] Error 1 make[2]: *** [Makefile:143: build_nspr] Error 2 make[1]: *** [/home/vmiklos/git/libreoffice/master-android/external/nss/ExternalProject_nss.mk:35: /home/vmiklos/git/libreoffice/master-android/workdir/ExternalProject/nss/build] Error 1 make: *** [Makefile:120: nss] Error 2 The second hunk avoids: cd testlib; make libs Traceback (most recent call last): File "/home/vmiklos/git/libreoffice/master-android/external/nss/nsinstall.py", line 164, in <module> sys.exit(nsinstall(sys.argv[1:])) File "/home/vmiklos/git/libreoffice/master-android/external/nss/nsinstall.py", line 112, in nsinstall os.makedirs(args[0]) File "/usr/lib64/python2.7/os.py", line 157, in makedirs mkdir(name, mode) OSError: [Errno 17] File exists: 'out/..' make[6]: *** [../../../../coreconf/rules.mk:392: out/../anchor.o] Error 1 make[5]: *** [../../../coreconf/rules.mk:81: libs] Error 2 make[4]: *** [../../coreconf/rules.mk:78: libs] Error 2 make[3]: *** [../coreconf/rules.mk:101: libs] Error 2 make[2]: *** [coreconf/rules.mk:101: libs] Error 2 make[1]: *** [/home/vmiklos/git/libreoffice/master-android/external/nss/ExternalProject_nss.mk:35: /home/vmiklos/git/libreoffice/master-android/workdir/ExternalProject/nss/build] Error 1 make: *** [Makefile:120: nss] Error 2 Change-Id: I11906f56ef717842778e14edf4037bd92e42cd86 Reviewed-on: https://gerrit.libreoffice.org/83775 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-26Resolves tdf#129003 - Capitalization of menu entry "Show Tip-Of-The-Day"Heiko Tietze2-5/+5
Now Tip-of-the-Day Change-Id: I715d87cdd6b5d9a7d06a218ed8d1922037fea91b Reviewed-on: https://gerrit.libreoffice.org/83694 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-26loplugin:nullptr (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I2e74a01c3500c1ac646479c571b6806c0fc566c1 Reviewed-on: https://gerrit.libreoffice.org/83769 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26loplugin:external (clang-cl)Stephan Bergmann5-0/+24
Change-Id: Iab2231e90e55c7e583a2fafd08469ee01b02ce82 Reviewed-on: https://gerrit.libreoffice.org/83767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26Mark external/mdds/Wdeprecated-copy.patch as upstreamedStephan Bergmann1-0/+2
Change-Id: Idfcf192dd93df3809b5da195356747a7d3ae3d3d Reviewed-on: https://gerrit.libreoffice.org/83761 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26loplugin:consttobool (clang-cl)Stephan Bergmann29-193/+193
Change-Id: I81fea38cd737a8be74e6ece333ca37cc434a1c33 Reviewed-on: https://gerrit.libreoffice.org/83765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26lok: calc formula bar tunneling: function list callbackMarco Cecchetti4-0/+68
Added a lok callback for sending the list of functions matching the current characters typed by the user. Change-Id: Ia971fc55ec5eb961b4098592a8049dd0eed3ba14 Reviewed-on: https://gerrit.libreoffice.org/83750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-26Comment the searchInMetaFile methodMuhammet Kara1-0/+4
Change-Id: Icbf1f852f8deb5392a820b46db4da19aef30f491 Reviewed-on: https://gerrit.libreoffice.org/83757 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-26tdf#94288: Show chart props sidebar on activationMuhammet Kara1-3/+21
Change-Id: I2119b59e3b4e36a34c9925cb624558d2da49ecc7 Reviewed-on: https://gerrit.libreoffice.org/83715 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-26tdf#126043 use bulk_insert_for_eachCaolán McNamara2-30/+26
Change-Id: I68b5a7805a2e0a76d1871448a011fdde7f7cdb1e Reviewed-on: https://gerrit.libreoffice.org/83685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26Resolves: tdf#129027 make manage names resizableCaolán McNamara1-1/+0
Change-Id: I8b82c3dfbf07ddb565d767a223c2c46b924a29e8 Reviewed-on: https://gerrit.libreoffice.org/83733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - typo Change-Id: Ieecbb87c4afb9451d9b009e1107bee0388505d86 Reviewed-on: https://gerrit.libreoffice.org/83760 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-26tdf#128252 - Make "Hide" and "With condition" experimentalHeiko Tietze1-0/+10
Unlcear functions made experimental until documentation is available Change-Id: I9e08752802409b05647d23f9ddd6514f109d1592 Reviewed-on: https://gerrit.libreoffice.org/83509 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-26tdf#126043 module identifier already knownCaolán McNamara2-4/+2
Change-Id: I710180ed125bbea250694cfb5f7d12cb1b07f782 Reviewed-on: https://gerrit.libreoffice.org/83675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 don't bother converting to OUStringCaolán McNamara1-3/+3
Change-Id: I179354659e4ee118138b994c7848c1dda39317bb Reviewed-on: https://gerrit.libreoffice.org/83678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 we can use the stock attribute to skip an intermediate BitmapCaolán McNamara1-0/+4
Change-Id: I972774bb2b2b3e494804145a1eebca57e519c3bd Reviewed-on: https://gerrit.libreoffice.org/83680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 drop intermediate OUStringCaolán McNamara1-4/+2
Change-Id: I96906737bfe0f40b8a4c0b2f88dde7cc40daeab0 Reviewed-on: https://gerrit.libreoffice.org/83677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 freeze/thaw around bulk insertCaolán McNamara1-0/+6
Change-Id: I2dd9aedc305a4fe1992fe8c52fee85ade8589a5b Reviewed-on: https://gerrit.libreoffice.org/83674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 identify the frame module just onceCaolán McNamara2-11/+11
Change-Id: I7f68cf67838bb08672975e7a38cf213022e39ed8 Reviewed-on: https://gerrit.libreoffice.org/83672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 use CommandInfoProvider::GetModuleIdentifierCaolán McNamara1-11/+1
which probably already has a cached ModuleManager Change-Id: Id653e57ecf40061ace086881344a85d7413a5afc Reviewed-on: https://gerrit.libreoffice.org/83671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara31-101/+172
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - typo Change-Id: I9b5e55add1c1b6848b0df82776322382254ba35f Reviewed-on: https://gerrit.libreoffice.org/83753 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Clarify handling of empty paragraph in TOC Empty heading or paragraph will not display in TOC. Change-Id: Ia7549d8f22ccf63148150140cd1ccd0bf3b3aba0 Reviewed-on: https://gerrit.libreoffice.org/83720 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-26We use the system clipboard on iOS and not the "LOK clipboard"Tor Lillqvist2-2/+23
The use of the system clipboard was implemented for iOS in vcl already in cp-6.0. This "LOK clipboard" thing is for different situations in web-based Online and not applicable for the iOS app. Change-Id: I679b5c27d308a563eadaf1e543ce8c45d763f3c6 Reviewed-on: https://gerrit.libreoffice.org/83339 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-26Add ooo.vba.word.XDocument.Close() method and implementTor Lillqvist3-0/+8
Will be needed in COLEAT. And seems like a fairly obviously missing API otherwise, too. Change-Id: I990c605a7e3f9cff3b72f20a626477d010da9852 Reviewed-on: https://gerrit.libreoffice.org/81369 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit b0b0788ba040be2bf42aa19313759ba9f4811d38) Reviewed-on: https://gerrit.libreoffice.org/83660 (cherry picked from commit 1562900446a99623a30fa9e719322a8c24132f9d)
2019-11-26loplugin:indentation no longer needs to blacklist binaryurp/source/bridge.cxxStephan Bergmann1-3/+0
...since bfaf25f59352eb81c7f53c741995a82021f4b0ff "Silence -Werror,-Wunused-variable (clang-cl)" taught it about leading [[maybe_unused]]. Change-Id: I0d3baf66623c50cfb35d3923273fb1129f66213f Reviewed-on: https://gerrit.libreoffice.org/83728 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26sw: remove SwNodes::CheckNodesRange()Michael Stahl2-36/+9
Looks like it's the same as ::CheckNodesRange(..., false). Change-Id: I1938892cdba9ff1d9758a0f1b6cb516e28f5d8bd Reviewed-on: https://gerrit.libreoffice.org/83708 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-26sw: document CheckNodesRange functionsMichael Stahl2-2/+12
Change-Id: I6ca104773eee6809258fdea6be6370b726da8fd4 Reviewed-on: https://gerrit.libreoffice.org/83707 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-26Add note that SwVbaDocuments::Close() does nothingTor Lillqvist1-0/+1
Change-Id: Ibf4d175b4b4a0b9f168401e52af6b0459aacd046 Reviewed-on: https://gerrit.libreoffice.org/81368 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 61a656cb9c7db1863e56d1183cb82c7e8be63cc5) (cherry picked from commit 5c5034a6d5d411fedf1fb00e736c55b7bdd6f840)