summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-08-27Resolves: #i96720# FilePicker: setDefaultName...Damjan Jovanovic1-2/+12
setDefaultDirectory "broken" Display the proposed filename even when the URL specified for the file picker directory is invalid. As the Win32 file picker sadly allows both paths and URLs for directories, users try paths on other more restrictive platforms, and since the file picker there shows neither the directory nor the file, they wrongly conclude both are broken. Patch by: me (cherry picked from commit 42d181e761c9903bfe5dd71334cadacebd1d0dc8) Change-Id: I3f99937b667d7fe5198f6445ccd4d0e22d48c7c7 Reviewed-on: https://gerrit.libreoffice.org/28426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-06#i124867#: jpg options shows initially wrong estimated file sizeDamjan Jovanovic1-2/+2
File main/svtools/source/filter/exportdialog.cxx ExportDialog::GetGraphicStream() creates the compressed file from which the file size is obtained, calling GetFilterData() to obtain the properties used to save it. GetFilterData() returns image properties, like JPEG colormode and quality, PNG compression/interlacing/translucence, BMP color and RLE coding, etc. In the case of JPEG, the quality is read from maSbCompression.GetThumbPos(). The problem is that in ExportDialog::updateControls(), maSbCompression.SetThumbPos() is called AFTER GetGraphicStream(), meaning the stream is created with the old thumb position. This patches it to call GetGraphicStream() later, immediately before using that stream, so that its properties such as compression are updated first and the size is calculated correctly. Reported by: myspaces at hotmail dot fr Patch by: me (cherry picked from commit 48cf17d5fac7e77aa82caa454cd0f26cd10faaa0)
2016-05-17Make CSV line parsers consistent with CSV field parsers.Damjan Jovanovic1-6/+53
Our CSV field parsing algorithms treats fields starting with a quote (immediately at the beginning of the row, or after the field delimiter) as quoted. A quoted field ends at the corresponding closing quote, and any remaining text between the closing quote and the next field delimeter or end of line is appended to the text already extracted from the field, but not processed further. Any quotes in this extra text are taken verbatim - they do not quote anything. Our CSV line parsers were big hacks - they essentially read and concatenate lines until an even number of quote characters is found, and then feed this through the CSV field parsers. This patch rewrites the line parsers to work exactly how the field parsers work. Text such as: "another" ",something else is now correctly parsed by both Calc and Base as: [another "],[something else] instead of breaking all further parsing. Patch by: me (cherry picked from commit 60e93b8b5b6bc4220d66e95cd234a37f3c8f8fd7) Change-Id: Iced60fad9371e17a2e5640cd7169804b18cf5103 Reviewed-on: https://gerrit.libreoffice.org/24999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-10Drop redundant parenthesis.Pedro Giffuni1-4/+4
Found with coccinelle: http://coccinelle.lip6.fr/ Currently only applied to C code. (cherry picked from commit aaf15142bcbc44f0e06a3357d2b21ecf9c673d21) Change-Id: I7d43b024752ebd47e84e2e51028f8fd132410800
2016-04-05Resolves: #i126901# CSV import: values with + or - followed by...Damjan Jovanovic2-5/+11
thousand separator and 3 digits (eg. +,123) are imported as a number Do not allow numbers parsed from CVS files when "Detect special numbers" is off, to contain thousand separators before digits, even if after a +/- sign (eg. -,123 or +,789). Treat these as strings instead. Also added unit tests for this. Patch by: me (cherry picked from commit 10458a24f4e6cc311e65fb80ce576fed39937be2) Change-Id: Ic946fc6a11326861f238157ddb651bc5a5b28edd
2016-03-29tdf#96099 fixes trivial typedefs, ::std::vector<OUString>Apachev Ivan9-30/+21
Change-Id: If01819b43c6cf4665e0aca90f9fb2b4363feae69 Reviewed-on: https://gerrit.libreoffice.org/23060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-02-15Related: #i126658# Add description about NoLabel property...Kay Schenk1-0/+7
on css.awt.UnoControlFixedTextModel Patch by: hanya (cherry picked from commit 92ff48eb981610cb1565cd5472a6714feb7f68a6) Change-Id: I44bbf7d49add8e49d3cb8e1a19839626a2f69b63
2016-02-07Platforms that need CLOSESOCKET_DOESNT_WAKE_UP_ACCEPT for sockets usuallyDamjan Jovanovic2-8/+8
need it for pipes too, and even if it isn't necessary it can't hurt. In particular, on FreeBSD 11-CURRENT it seems pipes no longer wake up from accept when closed in other threads, so let's deal with that before FreeBSD 11 is released. Reported by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> Patch by: me Tested by: Matthias Apitz <g u r u a t u n i x a r e a d o t d e> (cherry picked from commit e18ecd4f644cfbe5d6b871c7ff6c76bd5c220504) Change-Id: I1b4c0438fbcc2ea53625f235906936fc1403e195
2016-02-02Resolves: #i126762# Ignore dictionary not in specified location.Kay Schenk1-1/+9
Damaged "registrymodifications.xcu" causing problems with backups and spell checker (cherry picked from commit 983e71fa37e12fbae29eddc2b855ddaf6280cc0e) Change-Id: I279275e11fb2ee6a223c7905652165d1b7a2e0ac
2015-12-27Resolves: #i126753# fix invalid parse of GSUB table for OpenType fontsTsutomu Uchino1-0/+1
(cherry picked from commit 9396ecb77711fb7da043f9865f9803a12d830daa) Change-Id: Ib34aa2310d83afec83b4a85f1661b763415159ed
2015-12-16Resolves: #i126272# compile error : if statement followed by End If...Damjan Jovanovic1-1/+1
- in next Line ??? Allow the Else in a single-line If statement to be terminated by a comment instead of only EOL. Patch by: me (cherry picked from commit cbd43d0cb1165add5b9b559c3608a93ea631da13) Change-Id: I3dcf014c9fe501bc9770ae3cfd69e7730c0b86cb
2015-12-15Use %tx to print ptrdiff_t.Damjan Jovanovic1-2/+2
Patch by: me (cherry picked from commit 7d41b0a9559a388fe558cf7e8d81e4909a785af3) Change-Id: I5e087de043bf454268e4a3ccf24d9e25de3735ee
2015-12-15Use %p to print pointers in sal backtraces..Damjan Jovanovic1-3/+3
instead of 0x%x + conversion to integer. Patch by: me (cherry picked from commit 25f185144085ebe06405a5d8f19a11544ed7f794) Change-Id: I49197aed7bc2dc92a4b54d9aa6a7dce95ebadcfb
2015-12-15Resolves: #i19221# Print Tab(5); "Hello" does not workDamjan Jovanovic3-1/+17
Implement the Tab() function in AOO Basic. Patch by: me (cherry picked from commit fa1315d25186643ea537972609c117e0c9bb1fbc) Change-Id: Ifa9843661ce3862347c6351a078ddb207169182a
2015-12-11Do not assume time_t is long.Pedro Giffuni1-2/+2
time_t is long on some platforms but not on all. This plagues a warning on FreeBSD. Taken from: Jung-uk Kim (cherry picked from commit 1c030e286ac7a82eaa5b87c0f950894ab6be5027)
2015-12-02Calculate substring indexes properly, avoiding an unnecessary ↵Damjan Jovanovic1-1/+1
IndexOutOfBoundsException. Patch by: me (cherry picked from commit d46d79f2261eb6be2fb74254f09520f5ef2baa88)
2015-11-30fix the value of FRAME_PTR_OFFSETDamjan Jovanovic1-1/+1
in backtrace.c and diagnose.c - it's 3 because of the EBP/RBP register's position in the jmp_buf (https://github.com/freebsd/freebsd/blob/master/lib/libc/amd64/gen/_setjmp.S and https://github.com/freebsd/freebsd/blob/master/lib/libc/i386/gen/_setjmp.S). Patch by: me (cherry picked from commit 87451f66edfa425e51289ac6f12ee110d7109a02) Change-Id: I5f18cd9145f90db351c124c6f914411f1ffc2a83
2015-11-30Use the ptrdiff_t printf format code for backtracing on FreeBSD.Damjan Jovanovic1-10/+4
Patch by: me (cherry picked from commit e0e462a3e64576be14a4341f4dc4a2d56f22fa2a) Change-Id: I1c59b2b631dbfd508d85abb774f27187ded47c17
2015-11-30i66807 - Fix GCC warning in backtrace.cPedro Giffuni1-1/+9
The Bugzilla issue has another fix for sparc but I have no way ot test it. (cherry picked from commit 24e9542bcfaec3b49e5e825bf36d4bf524d69080)
2015-11-30Fix the stack frame layout for backtraces on FreeBSD.Damjan Jovanovic1-2/+0
Patch by: me (cherry picked from commit 0faee39deac292694d036d753b7dc1c4513e045f)
2015-11-26i126615 - Allow build on FreeBSD Mac PowerPCG5Pedro Giffuni1-0/+3
These appear to have been missed from earlier effort Brave attempt by: Curtis Hamilton (cherry picked from commit abb9cd92ab4614d606df8ced0d57916dcb04289c) Change-Id: Ia778e090c46220d83388ea1a9485b9009787f191
2015-11-25i125711 - Illumos port: generalize MAX_ALIGNMENT for SolarisPedro Giffuni1-2/+4
GCC in Ilumos appears to behave exactly like the Solaris SUNPRO compiler so generalize the case for Solaris. (cherry picked from commit e1da117c49fc02af9543e32526bf1c04657534c4) Change-Id: I3fa619f34c35608b187c3aa394552ac78c3f0c20
2015-11-25#i117960# Basic: Line Input doesn't work in single-line IfDamjan Jovanovic1-1/+2
i92642 added the ability to use certain keywords as variable names (eg. name = 1, line = "hi"), but also caused a regression where "Line Input" is broken in single-line If statements. This patch fixes that by allowing Then and Else to also be the start-of-line tokens expected to immediately preceed the "Line" token in order for that "Line" token to be recognized a keyword instead of a variable name. Also added FVT spreadsheet tests for "Line" as both a variable name and as "Line Input". Patch by: me (cherry picked from commit f8a51d0f5a645704bc2bdc939474ac931d55559c)
2015-11-19Related: #i72580# Add descriptions about State property and button commandTsutomu Uchino2-0/+13
(cherry picked from commit 78dce87d4bd6936f0310d96381a0130f3ba82ed0) Change-Id: Ide972a5574c0062a7ee4e4300e512715c55e8d37
2015-11-13Related: #i126649# Fix wrong at tag namesTsutomu Uchino5-9/+7
(cherry picked from commit 902cd9fe198a4e24843b0e4432cbc2dd3c587056) Change-Id: I7cac635d9e7b6eae93466ced0349edc01caab0c2
2015-11-10#i126029# Base query wizard error due to missing quoting of table and column ↵Damjan Jovanovic1-0/+4
names During the Base query design wizard, com.sun.star.wizards.ui.FilterComponent.getFilterConditions() calls com.sun.star.wizards.db.SQLQueryComposer.getSelectClause() before its getFromClause(). However the getSelectClause() needs composedCommandNames which is populated only by getFromClause() in order to quote table and column names. Without this, table and column names that need quoting (spaces, special characters, reserved words) produce errors. (cherry picked from commit 046771cac8605e5826a150e4454eff332b65d517)
2015-11-10Resolves: #i61854# Basic: Default title of Msgboxes should be changedDamjan Jovanovic1-1/+1
Found by: berend dot cornelius at germany dot sun dot com Patch by: Pathangi Janardhanan Jatinshravan <JATINSHR001 at e dot ntu dot edu dot sg> Review by: Damjan Jovanovic (cherry picked from commit 519770a2b47d4bb95a7616cedcc1582ae83ab205) Change-Id: I61c9eacd285c8335925f1569b64bb2d600caf545
2015-11-10Use the UIConsts constants for resource IDs in...Damjan Jovanovic1-1/+2
main/wizards/com/sun/star/wizards/query/QuerySummary.java (cherry picked from commit 77ff55a4a1f25c1dc21d083cee43b4506bf91410) Change-Id: I538aa5761506d430bdbe70de03301f971f363e52
2015-11-10Use UIConsts constants for offsets to resource IDs in main/wizards.Damjan Jovanovic3-17/+20
(cherry picked from commit 95efcaf575dced8cc18f2ca9fb874d772ad23595) Change-Id: I8bb247c92f0326da916940f4fc7999d81998297a
2015-11-10Resolves: #i56289# no GROUP BY - COUNT from wizardDamjan Jovanovic2-18/+3
Implement the COUNT operator for GROUP BY in the Base Query Wizard, and delete some unused resource strings to make space for it. Found by: dtinazzi at easyasp dot it Patch by: me (cherry picked from commit 1f6546d6c0e6670d59e6beb05d15c80327634e6c) Change-Id: I6395566275cea6a33cdc64968b3b31aa17d61554
2015-11-04Resolves: #i126627# wrong type description in @see tagTsutomu Uchino18-28/+28
(cherry picked from commit a17388ff7dfeda73445967f7680cd7dc2832c95e) Change-Id: I8056767f88f4a6ced01a34f116e94f8e7192eefa
2015-11-04Resolves: #i61277# Basic open file with random access erases all data.Damjan Jovanovic1-1/+1
StarBasic tries to emulate truncation of files opened for writing by deleting them before opening them (if they exist). However there are exclusion to the truncation behaviour when the file is opened in append mode or is a binary file. Another exclusion - that was missing with disasterous consequences - is that the file should not be truncated when opened in random access mode. (cherry picked from commit 72b2f07ccac7578ef36fc2b92dcba49abe397ebc) Change-Id: Ic0053039ce5fd67ad42bf5332ae301d83f1a158d
2015-10-14Resolves: #i126586# FreeBSD automation deadlock: osl_closeSocket()...Damjan Jovanovic2-14/+18
doesn't wake up thread stuck in accept(). Generalize the "#if defined(LINUX)" workarounds to the *BSDs. (cherry picked from commit 4c7bfe32168912844a50059b2a901f6434c0f86f) Change-Id: I1649f6d1a63ae2daf8e6ff650d8af6ea89a6d449
2015-10-13Fix building with --enable-pdfimport on FreeBSD.Damjan Jovanovic1-2/+0
Found-by: Don Lewis Patch-by: Don Lewis (cherry picked from commit 788b479fff17918d21d26f71ce33c4cea0835251) Change-Id: Idb72387186a7575989292179d52e4629415e5741
2015-10-05malloc + memset (0) --> callocPedro Giffuni2-12/+6
Drop useless casts while here. (cherry picked from commit fc4e91e7288d13c40cc78bfa680c7a1e6047c087) Change-Id: I435c64400d0631926211fbcdc1d38e140462fec1
2015-09-29i#126557# increase number of lines of dropdown of category listboxKay Schenk1-0/+1
(cherry picked from commit 48cb20bb5c32f076f295c7490d6ba9ac96e85ed0) Change-Id: I18ba8a781e111fd7706de1eadb41c93a78e27c62
2015-09-12#i126516# Document the return values for the TYPE() formula function in the ↵Damjan Jovanovic1-1/+1
online help too. (cherry picked from commit 4149f99e7bede959d8bec6b4131a205d6e98d6b7)
2015-09-12Updated coreDamjan Jovanovic1-0/+0
Project: help f1c4e58c8faf814723c205d61ca0608dfd2376ac i#126516# TYPE() formula help doesn't document value 64 for arrays Change-Id: Ia3dd7a45877101323ee4be9746c18124e0a6ab29
2015-09-03Fix some perl shebangs.Pedro Giffuni14-14/+14
Most important perl scripts already use a portable method but fix these nevertheless. (cherry picked from commit 93496a6c1e5b2ae1756dc9b8043e2267209387da) Change-Id: Id8b5e974356701e66f9dd8a6bd7a58fd4f5633ae
2015-08-28Resolves: #i112383# CLng("&HFFFFFFFF") fails on 64-bits...Damjan Jovanovic1-1/+1
rather than returning -1 Found-by: andrew Patch-by: Damjan Jovanovic (cherry picked from commit 175afdcb151d9ce1238dc9fec59f2dfc2eb07345) Change-Id: I996bbfa82b10716318944f390ea53e0a5ae7c89c
2015-08-26Resolves: #i117989# Basic functions return wrong results for dates <1900-1-1Damjan Jovanovic1-22/+2
Also extended our spreadsheeet test to search through more columns, open spreadsheets with macros enabled, and added a test for the the Year(), Month(), Day(), Hour(), Minute(), and Second() functions comparing Calc's formulas vs StarBasic's runtime functions. Found-by: villeroy Patch-by: Damjan Jovanovic (cherry picked from commit a68493266e9212119f31e58c256f00fb9bcc8d20) Change-Id: I8f2115c623a1d35db5b7fc8184a9118c3eca6fcd
2015-07-08i#107734 Support for Math Input Panel in Windows 7Regina Henschel9-1/+116
The patch introduces a new command .uno:ImportMathClipboard to module Math. It imports MathML content from clipboard and transforms it to Starmath It handles clipboard MIME type 'application/mathml+xml' and plain text, which can be interpreted as MathML segment. It partly solves issues #i14252, #i34781, and #i53509 too. Review by: Hanya <hanya.runo@gmail.com> (cherry picked from commit 9ec2148653436be8612273439180749e71e2ce58) Conflicts: dtrans/source/win32/ftransl/ftransl.cxx officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu sot/inc/sot/formats.hxx sot/source/base/exchange.cxx starmath/sdi/smath.sdi starmath/source/view.cxx Change-Id: I6cb5e8f737ee2e39f9ce96aba841db347a8806e4
2015-04-06Resolves: #i95167# XIRR() function gives Err:502Regina Henschel1-7/+28
Patch by: Driss Ben Zoubeir <driss.zoubeir@gmail.com> Review by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 85cd072198d9024c20b741c04a20ef99fc9b5910) Conflicts: scaddins/source/analysis/financial.cxx Change-Id: I385d5f9bfa840fe609cb5723f2d4d57d26fd0d6c
2015-04-06Resolves: #i81637# Replace column header "Title" by "Name"Ariel Constenla-Haile1-1/+1
Patch by: Driss Ben Zoubeir <driss.zoubeir@gmail.com> Review by: arielch@apache.org (cherry picked from commit b923454a0922b6767b28c8dc131534b8daf6d96b) Change-Id: Ifef870645491537217bf85b772b130d3bb4a92fd
2015-03-27Small fix for BSD.Pedro Giffuni1-0/+1
Part of Code Review: https://reviews.freebsd.org/D2055 Author: Don Lewis (truckman at FreeBSD) (cherry picked from commit ecebe457c968bfd30a99a435210b0bdbb117faef)
2015-02-11Related: #i125985# Change Insert Footnote toolbar commentKay Schenk1-1/+1
Suggested by Keith McKenna, Comment 28. (cherry picked from commit 45c93e33d0c8ec527dd7c3af66fb9f9dea527871) Conflicts: officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu Change-Id: Ib5706cae8f7ca282803f0e133c4786fbbb39262a
2015-02-01Resolves: #i114416# use default service name for scroll bar...Tsutomu Uchino2-0/+7
if failed to detect the control-implementation (cherry picked from commit 23e16b91ad69a123e795d63f2d4862d94412d582) Conflicts: xmloff/source/forms/elementimport.cxx xmloff/source/forms/elementimport.hxx Change-Id: I0ab4f9ff909ceba18a74d38488f6d0bdb3126110
2015-01-30Resolves: #i67663# add vertical alighment on property UITsutomu Uchino2-1/+2
(cherry picked from commit 2b2128d0665dc390ae90739c84bc387f399ebe87) Conflicts: extensions/source/propctrlr/formmetadata.cxx Change-Id: Ic6d708454009e8023dc2e601043409377fd6cb34
2015-01-27Resolves: #i85241# store settings about value highlighting in documentTsutomu Uchino2-8/+13
(cherry picked from commit d3fb83cbaea17418def1ace6e868d8892d64d85d) Change-Id: I34b4ee12e4af8300a51d72f0dd36e27c79832eb5
2015-01-27Resolves: #i98734# save/load ScaleMode property of image control on dialogsTsutomu Uchino8-1/+77
Suggested by: Frank Schönheit <frank.schoenheit@gmx.de> (cherry picked from commit 350c4f9a01b88d4fd1006465151348ac5d459f1a) Conflicts: xmlscript/source/xmldlg_imexp/exp_share.hxx xmlscript/source/xmldlg_imexp/xmldlg_expmodels.cxx xmlscript/source/xmldlg_imexp/xmldlg_export.cxx xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx xmlscript/source/xmldlg_imexp/xmldlg_import.cxx Change-Id: I2a11809112c0b1b53349f5b74dca20897d4a6acd