summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
4 daysandroid: Update Android Gradle Plugin to 8.3.2Michael Weghorn2-68/+13
... as suggested by Android Studio. Also update the Lint baseline file, as the build would otherwise fail due to this new warning: > Task :lintReportStrippedUIEditingDebug Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html > Task :lintStrippedUIEditingDebug FAILED /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 213 errors and 1 warning were filtered out because they are listed in the baseline file, lint-baseline.xml [LintBaseline] /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 6 errors/warnings were listed in the baseline file (lint-baseline.xml) but not found in the project; perhaps they have been fixed? Another possible explanation is that lint recently stopped analyzing (and including results from) dependent projects by default. You can turn this back on with android.lintOptions.checkDependencies=true. Unmatched issue types: PrivateResource, RedundantNamespace, TypographyEllipsis (3), UnusedNamespace [LintBaseline] /home/michi/development/git/libreoffice-WORKTREE-android/android/source/AndroidManifest.xml:109: Error: Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed. [DiscouragedApi] android:screenOrientation="landscape" > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Explanation for issues of type "DiscouragedApi": Discouraged APIs are allowed and are not deprecated, but they may be unfit for common use (e.g. due to slow performance or subtle behavior). 1 errors, 0 warnings (213 errors, 1 warning filtered by baseline lint-baseline.xml) FAILURE: Build failed with an exception. Change-Id: I621b2334fef954bcd341cdde9034187f455339e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166114 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
4 daysImprove case rotation in sentence caseOliver Specht5-20/+36
Rotating case (Shift+F3) applies sentence case only if multiple words are already selected or selects sentence if SENTENCE_CASE is going to be applied. Change-Id: I9e8536d7744a344d7ad54150783e91e843e0e81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165986 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
4 daysCase rotation in Impress: skip sentence caseOliver Specht1-2/+8
Sentence case does not make sense if a selection contains less than two words. Rotation then skkips to the next case mode. Change-Id: I79d6560c494b716a53bfed654027f6f37dc6c362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166115 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
4 dayspivot: improve format matching, add empty cell checking to testsTomaž Vajngerl5-80/+273
The patch improves the pivot table cell format matching with the output data, so we check if there is a complete match or a partial match. A partial match is when we found one match for a field, but other fields are not set, and if this partial match is found in exactly 1 line of output data, then we treat it as a complete match. This also refactors the code so there is code no duplication for column and row matching code - they work in the same way, just in a different orientation. This also adds checking of empty cells to the tests, so we can make sure there is no other cell in the pivot table that got the pivot table cell format applied to. A new test case was also added to the test class. Change-Id: I102ec8e33bc7a3f26bc898568ee0e33abe08bd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166086 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayslok: provide global random symbol to find random device.Michael Meeks3-2/+29
This is vital for lok when used in a jail with no random device, but with an inherited file-handle to /dev/urandom. Use 'dup' to avoid changing code that wants to 'close' the handle after use. Change-Id: I15f40fb251f180a2394af030f56e47f2bf9651d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166113 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysUpdate git submodulescolton Garrett1-0/+0
* Update helpcontent2 from branch 'master' to 38b6934ddac36ab4294213d1ff4387dacee49d63 - tdf#86637 - OpenCL Help page enchancements Change-Id: I01b8718b2fdda3003ca32a15e6d443a546f83259 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166127 Tested-by: Jenkins
5 dayscid#1596323 Dereference null return valueCaolán McNamara1-4/+7
Change-Id: I63eeb8662ee28f1a0e990160b1ff9992d9d9337f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daysRelated: tdf#160056 FormulaResult may ref an initial interpreter FormulaTokenCaolán McNamara4-0/+31
If a token from the original tokens, supplied to a parallel group calculation while RefCounting was disabled for those tokens, ends up as a FormulaResult token, then fix up the ref count when parallel calculation ends Change-Id: I2587c25d216ab170725017b67b97d203a578160b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 dayscid#1596322 Resource leakCaolán McNamara1-2/+2
Change-Id: Ied68c2c6d69437ea0236724279b2353015cd1e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daysconvert OCellValueBinding to comphelper::WeakComponentImplHelper (II)Noel Grandin2-58/+66
second attempt at landing this Change-Id: I1dd3597b0047131c99b3ec81a3cb5eabf9bf8a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daystdf#33603 Typo: 'Notes Panel' -> 'Notes Pane'Samuel Mehrbrodt1-1/+1
Similiar to 'Slide Pane' Change-Id: If96afc4c054bbbff7c9bf8c5f4309e8eeb419d77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166005 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
5 daystdf#33603 Allow adding Notes Panel to toolbar/menubar/keyboard shortcutsSamuel Mehrbrodt1-3/+3
Change-Id: Ic3e8f6b5a0cc8697c62e8f10f69ff53859f33d3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166004 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
5 daystdf#33603 Make notes panel available in readonly modeSamuel Mehrbrodt1-1/+1
Change-Id: I2dd10802f3798b2e87833d3cd8ebd21366e0f546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166003 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
5 daystdf#33603 Fix Close button not working in Notes PaneSamuel Mehrbrodt12-751/+9
Remove duplicate command and now unused NotesChildWindow Change-Id: Idef94086ca91dd1474070c426c37ef921ad4fa03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166002 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
5 daysUpdate libxmlsec to 1.3.4Miklos Vajna3-37/+2
Allows dropping xmlsec-nss-Ensure-NSS-algorithms-are-initialized-754.patch.1, which was a backport. Change-Id: Ifdd0b5285daa79116a91ab2d122a9809f8effb5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166019 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysGeneralize basegfx::fround for templated return typeMike Kaganski64-271/+297
And use it when assigning to tools::Long Change-Id: I0814d7bac9cdd48191ba69c64e3b12a4973b3417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 daysofz#68019 Null-dereference READCaolán McNamara1-1/+1
Change-Id: Ie0c9c5a74e6ae87a0bd4c35320a687458d1d9902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166074 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daysCorrect {bg-BG} formats with group separatorEike Rathke1-9/+9
The leading # digit before the separator was omitted. This never worked as intended. Change-Id: Idf8a6cf246b8db4e6d5361bc1c5f66c1c0c057c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166072 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
6 daysRound in XmlWriter::attribute when passing a doubleMike Kaganski6-46/+57
Before, it truncated. Rounding provides a closer value. Change-Id: I213e6ae34ada2f5081cb2c8b2ef431448c712b37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysRelated: tdf#160056 1 entry is more common than no entriesCaolán McNamara1-9/+9
Change-Id: I78fe8969120f894cf5c0a71fb61611af2d203d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daysRemove duplicate includeAndrea Gelmini1-1/+0
Change-Id: Ifc9b71acc50e2a53cee194801245c287079b62ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166069 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
6 daysUse more o3tl::convertMike Kaganski1-1/+1
Change-Id: I2a4f109b8c1031d0330f249b7666ae65f9fae7ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166062 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski1-3/+3
Change-Id: I922502c80d79b8432a46e97178bc87f43847f996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166061 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convert in lotuswordproMike Kaganski21-168/+166
Change-Id: I7ec74dc105f846307f5bf3d3c8cedcc4aebb64a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166058 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski1-10/+6
Change-Id: I281ff1be4663d752a4e1a7e4d38556cefb641bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166060 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski1-4/+4
Change-Id: I8a3c5d0e1a29219ab27bde75809ca9d8dce7e093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166059 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski1-3/+6
Change-Id: I5a6a1c05083fbaef71e94799a61c6f918a5134f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166064 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski2-2/+2
Change-Id: I56d6909dc3b1a7d45e4e3f45583321b1338838cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166063 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysSwContentTree: remove repeated pointer assignmentJim Raykowski1-21/+12
The selected entry does not change within the CommandHdl function therefore assignment of the pointer to the selected entry SwContentType does not need to be repeated elsewhere in the function. Change-Id: I025ecb9259e2ee46a64d55c75d0c3f3c8cc625ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166018 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
6 daysUpdate git submodulesTaichi Haradaguchi1-0/+0
* Update helpcontent2 from branch 'master' to 1f63165a8f02d96fbdb0b9b8bea287389edb1121 - Change the strings in the help pages ...to follow changes in the UI strings.[1][2][3] [1] "Fix extended tip in mmselectpage.ui" <https://git.libreoffice.org/core/commit/1aeec70c2a635a69e90d2643f2e524bb342378ae> [2] "Fix extended tips" <https://git.libreoffice.org/core/commit/b5c40d4864b07861e889244834635c8cfc957d6e> [3] "Add the strings "dialog" after "Macro Selector" in extended tips" <https://git.libreoffice.org/core/commit/a8fda337a88ca4d47218efa9ee44e7bfd590d30c> Change-Id: I8b99344960d284e149b52534dfcd075e5c687816 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165123 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
6 daysRelated: tdf#160056 don't set nVal twiceCaolán McNamara1-6/+12
Change-Id: I0da3e0c7f18271f6104d52b50d65e96564650b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daysRelated: tdf#160056 rename/rework GetDoubleAsReference to SetDoubleCaolán McNamara4-12/+6
Change-Id: I7e79e8d422fe7f426bb7c7360b11f836a5484574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166053 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daysofz#68019 Null-dereference READCaolán McNamara1-2/+3
Change-Id: I9ad5d907c4739877d51b74ef0f2e275d94119f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daystdf#143148 replace includes guards in vcl textlineinfo with pragmaHakimOttey1-4/+1
Change-Id: I733263074a5c4911499a6b5becfbbc87cbda968d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166044 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
6 daystdf#158067 Replace OUStringLiteral with _ustrAaron Bourdeaux3-13/+4
Change-Id: I3a58469c52055121e8726cee2d3e42ecd23cdf96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165826 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
6 daysUse more o3tl::convertMike Kaganski4-21/+26
Change-Id: Ia525e051b53dd6082f2f11ff884677c8b8c6a20c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166051 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysSimplify and use more o3tl::convertMike Kaganski1-59/+35
Change-Id: Ic7babea4eec3633d40d306488fea252d6f2636be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166050 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysUse more o3tl::convertMike Kaganski1-51/+9
Change-Id: Id31185592ccbb3507c939b241d5aab82c09c96f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166049 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysRelated: tdf#160056 all maTokens are FormulaTypedDoubleToken*Caolán McNamara1-2/+2
Change-Id: I6eacaf58c25ef9c5cb930a79177471c79a6a26c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 dayssfx2: fix crash in InterceptLOKStateChangeEvent()Miklos Vajna1-7/+11
Notice how e.g. the TransformPosX case already performed the same null pointer check. Crashreport backtrace: > program/libmergedlo.so > InterceptLOKStateChangeEvent > sfx2/source/control/unoctitm.cxx:1143 > program/libmergedlo.so > SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) > sfx2/source/control/statcach.cxx:432 > program/libmergedlo.so > SfxBindings::Update_Impl(SfxStateCache&) > /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:919 (discriminator 2) > program/libmergedlo.so > SfxBindings::NextJob_Impl(Timer const*) > /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173 Change-Id: I141d4f9ec50d0ce7a0eeaba69752c31390a1f9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166027 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
7 daysSimplify a bit, and use more o3tl::convertMike Kaganski1-25/+12
Change-Id: I30f619b81d831db9c1e212a1588d5696b9ad3dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166048 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
7 daystdf#160567 Replace duplicate style A4 with A0Laurent Balland18-36/+36
Style A4 was defined twice and A0 was missing. Rename second A4 with A0 and change size to 48pt Change-Id: I529b4fab5223269908867531873d36d3e878e7e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166045 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
7 daysRelated: tdf#160056 elide ref counting for initial tokensCaolán McNamara5-8/+63
The initial tokens provided to interpreting will be restored to their original ref count when interpreting is complete. So we could elide expensive ref counting for them for the duration of the the threaded group calculation. Possibly "temp" tokens that are created just during interpreting could additionally use thread-unsafe ref counts presuming they only appear in a thread specific context. Change-Id: I1f5b0198e83027781be15812680079f28b6a4e27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165259 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
7 daysMark obsolete Impress/Draw config keys as deprecatedGabor Kelemen2-0/+8
Practically unused since 2007 commit 56ca5814a1843a31d23b249f1960a31532c6b5bd Change-Id: Idd7cf4f239efed16a151fc4c755c249947d927f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165859 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
7 daysDrop unused SdOptionsContents classGabor Kelemen2-67/+1
seems to be practically out of use since 2007 commit 56ca5814a1843a31d23b249f1960a31532c6b5bd part of patch series '#i80528# Removal of draft paint modes' Change-Id: I770bab8b1973bec099ffdaa3243f1c0d2995ee52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165858 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
7 daysRemove duplicated includeAndrea Gelmini1-1/+0
Change-Id: Ie70543c67549498d51eeb53d262b52f8ef1ec700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166043 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
7 daysFix typoAndrea Gelmini1-1/+1
Change-Id: If0fbaae23b98d3bdd178473db8fdb8ab2263ef67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166042 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
7 dayspivot: Export Pivot Table "formats" element(s)Tomaž Vajngerl8-53/+184
This change adds the "formats" element tree export for a pivot table. The source are the formats (sc::PivotTableFormats) added to the pivot table - in the ScDPSaveData class. This are currently set on import but in the future hopefully those are also set through the UI. Change-Id: I5ed8f7e8d7ac248b0222a884fb97555ef6bb8427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166035 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
7 daysDon't use lround when assigning to a doubleMike Kaganski2-4/+4
Change-Id: Ifdfd351cf1f2848b754ec7a4c6f6cb9a56f478d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165939 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
7 daysAdd VclPtr operators to natstepfilterMike Kaganski1-1/+11
And fix a vector-related filter Change-Id: Icd3f5bd5a04a1385dff3f3413792a7aad544a506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166029 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>