summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-05-21tdf#132956 Chart view: fix missing plot areaBalazs Varga5-12/+38
Do not reduce the inside area of the chart depending on the size of the legend. Use the default legend size. Regression from commit: 739ed2c29f49ea5e83bcd1352b2644c2e2d09f7b (tdf#115630 tdf#88922 Chart: fix custom legend position and size) Change-Id: Ic191229d7ceab1f2689ab07424353108f8cb2b95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94059 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Tünde Tóth <tundeth@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-21tdf#133035 DOCX export: fix position of unnamed OLEAttila Bakos3-1/+9
Position export depended on OLE object names, instead of the type of anchoring. Follow-up of commit 2150fdc7d0f63288ac56c33cb898589512057642 (tdf#131539 DOCX export: fix position of OLE objects). Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ib98a19cb012047f37a5830c81541ef00c55589dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94190 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-21Fix typoAndrea Gelmini1-1/+1
Change-Id: If4e8241ca82fae3fa445248edc6a5d8c4a552a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94624 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-21Make Impress Insert Table dialog asyncSzymon Kłos6-110/+151
Change-Id: If8b48cfe983819387c066d3bd81a42dad8947489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94591 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94612 Tested-by: Jenkins
2020-05-21Make Insert Table dialog asyncSzymon Kłos4-86/+118
Change-Id: Id2458c16f259a58e2376f42104a9a6c9056cab11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94536 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94589 Tested-by: Jenkins
2020-05-21drop some unnecessary includesCaolán McNamara1-3/+0
Change-Id: Idf507ea5a9790bf54ef98ed4f0cc89e2c01cc8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21center vertically the interactive cell widgets if they won't fitCaolán McNamara1-3/+11
Change-Id: Iae7cc83ece1707e9fd38708e4f0911e529565f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin19-137/+108
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21weld ListBoxControlCaolán McNamara12-340/+506
Change-Id: I5a8c7d68e4c147eb938b0217dc6368c832e465c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21sw: handle CollapseEmptyCellPara when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c (sw-collapse-empty-table-par-like-html.diff:, 2010-09-14), it's on by default and off for old ODF documents. Change-Id: I372c3447b0f8d63a4608543bb466817d694cbff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-21tdf#133052: DOCX import: fix top auto margin of subitemsLászló Németh3-9/+16
(nested lists) and other items of lists, when auto margin is defined by paragraph style, and list items have got w:numPr. Follow-up of commit 162d74ae7a53eb1cde738f0a7558f297b8162f7a (tdf#132807 DOCX import: fix top auto margin in lists). Change-Id: I4cf470173fa367ac07e15dc901b0e202178c9fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94588 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-21loplugin:sequenceloopNoel Grandin1-1/+1
Change-Id: Ib785e6c581785fc4a477be38788a6544032b6ff0
2020-05-21tdf#132389 - case-insensitive operation for non-ASCII charactersAndreas Heinisch3-3/+52
Support case-insensitive operation for non-ASCII characters in the Replace function in Basic. Change-Id: I48069ad7be1ae0f012c52f595cc44e6b50580b94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21use for-range on Sequence in f*Noel Grandin68-657/+617
Change-Id: I820255001c1b96d1f4b76a203f3c0f76fa09fe66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21vcl: change bitmap::loadFromName to be like BitmapEx const.Tomaž Vajngerl1-3/+12
Change-Id: Icb055c55b261514a91d76ce2dcb74862152fca56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-21Missing includeMike Kaganski1-0/+1
Building on Windows with PCH disabled: [CXX] vcl/jsdialog/jsdialogbuilder.cxx C:\lo\src\core\include\rtl/ref.hxx(113): error C2027: use of undefined type 'TabPage' C:\lo\src\core\include\vcl/tabctrl.hxx(33): note: see declaration of 'TabPage' C:\lo\src\core\include\rtl/ref.hxx(111): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)' with [ reference_type=TabPage ] C:/lo/src/core/vcl/jsdialog/jsdialogbuilder.cxx(207): note: see reference to function template instantiation 'rtl::Reference<reference_type>::~Reference(void)' being compiled with [ reference_type=TabPage ] C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled with [ reference_type=TabPage ] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\utility(289): note: see reference to class template instantiation 'VclPtr<TabPage>' being co mpiled C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\utility(290): note: see reference to class template instantiation 'std::pair<VclPtr<TabPage> ,VclPtr<VclGrid>>' being compiled C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\xtree(330): note: see reference to class template instantiation 'std::pair<const rtl::OStrin g,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>' being compiled C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\xtree(752): note: see reference to class template instantiation 'std::_Tree_node<std::pair<c onst rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>,std::_Default_allocator_traits<_Alloc>::void_pointer>' being compiled with [ _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>> ] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\xtree(1189): note: see reference to function template instantiation 'void std::_Tree_val<std ::_Tree_simple_types<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>>::_Erase_head<std::allocator<std::_Tree_node<std::pair<const rtl: :OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>,std::_Default_allocator_traits<_Alloc>::void_pointer>>>(_Alnode &) noexcept' being compiled with [ _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>, _Alnode=std::allocator<std::_Tree_node<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>,std::_Default_allocator_traits<std::allocator<st d::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>>::void_pointer>> ] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\xtree(1189): note: see reference to function template instantiation 'void std::_Tree_val<std ::_Tree_simple_types<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>>::_Erase_head<std::allocator<std::_Tree_node<std::pair<const rtl: :OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>,std::_Default_allocator_traits<_Alloc>::void_pointer>>>(_Alnode &) noexcept' being compiled with [ _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>, _Alnode=std::allocator<std::_Tree_node<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>,std::_Default_allocator_traits<std::allocator<st d::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>>::void_pointer>> ] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\xtree(1187): note: while compiling class template member function 'std::_Tree<std::_Tmap_tra its<_Kty,_Ty,_Pr,_Alloc,false>>::~_Tree(void) noexcept' with [ _Kty=rtl::OString, _Ty=std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>, _Pr=std::less<rtl::OString>, _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>> ] C:\lo\src\core\vcl\inc\jsdialog/jsdialogbuilder.hxx(131): note: see reference to function template instantiation 'std::_Tree<std::_Tmap_traits<_Kty,_Ty,_Pr,_All oc,false>>::~_Tree(void) noexcept' being compiled with [ _Kty=rtl::OString, _Ty=std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>, _Pr=std::less<rtl::OString>, _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>> ] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1425~1.286\Include\map(75): note: see reference to class template instantiation 'std::_Tree<std::_Tmap_traits<_ Kty,_Ty,_Pr,_Alloc,false>>' being compiled with [ _Kty=rtl::OString, _Ty=std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>, _Pr=std::less<rtl::OString>, _Alloc=std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>> ] C:\lo\src\core\vcl\inc\salvtables.hxx(1032): note: see reference to class template instantiation 'std::map<rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid >>,std::less<rtl::OString>,std::allocator<std::pair<const rtl::OString,std::pair<VclPtr<TabPage>,VclPtr<VclGrid>>>>>' being compiled make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:303: C:/lo/src/build/workdir/CxxObject/vcl/jsdialog/jsdialogbuilder.o] Error 2 Change-Id: Id67ce45b1652a2915508963adb65e1e1f5c51dcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-20vcl: optimize jpeg files for Exif checkingTomaž Vajngerl4-0/+0
11kb -> 700b Change-Id: Idbd1cb84de081975fed71cb6575779c53f958523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94600 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20remove commented codeTomaž Vajngerl1-1/+0
Change-Id: Ief714e8905f9e79da8457bb33ce84b8f6d6bd30e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94602 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20sd: FuSearch - prefix member varsTomaž Vajngerl2-29/+29
Change-Id: I6048962a5db43b7ff9a9d20398484d7082648840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94601 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20Restructure DrawOutDevDirectCheck to avoid using uninitialized pointerMike Kaganski4-47/+23
The check for source device's mpGraphics is moved into drawOutDevDirect, since failing it must result in immediate return from the function. Check for this->mpGraphics also moved into drawOutDevDirect, since it's dereferenced in DrawOutDevDirectProcess, unclear why was it skipped in some cases previously. Removed unreachable warning. Change-Id: I4ad882f8f60d6543786aef2ec1651e499d47874d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94463 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-20use for-range on Sequence in e*Noel Grandin20-206/+192
Change-Id: I77dc12356ee45b1dee9acaf8a73dea81588822d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20Simplify the logicMike Kaganski1-32/+17
Change-Id: I722ca67189d9ca3061b544335cd2ca22a35a5011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94461 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-20move ComboBox to toolkit-only headersCaolán McNamara16-15/+23
Change-Id: If5f0ab1fba8fa7302b7c0e8d2b25761ab64c97e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20weld ComboBoxControlCaolán McNamara9-217/+140
Change-Id: Ie862bb782b4c3e203af88d45c850ce0cab60f2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20writerfilter: clang-format these filesMiklos Vajna11-232/+171
I added these files more or less recently and they have long lines. Use clang-format to break at a sane column limit. (And I now promise I won't remove more files from the clang-format blacklist for a while.) Change-Id: I7eae945defe67fa19c4bd9f4789d7918bb45bf9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94585 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-20tdf#126363 DOCX shape round-trip: keep original line widthRegényi Balázs4-1/+18
to avoid of rounding error of EMU -> 1/100 mm -> EMU conversions, which messed up recognition of preset line widths in MSO. Co-authored-by: Szabolcs Tóth Change-Id: Ide0e393e667848683f00f9ba7a73ff8a45a908b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94043 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-20fix -Werror=maybe-uninitializedNoel Grandin1-1/+1
Change-Id: I718016b5f9120c18868ed798785af1f8108be25b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20vcl: remove double colonChris Sherlock1-1/+1
Change-Id: I58d8d997a51929d23b13f2bb2bc00c68836e41e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94562 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20jsdialog: refresh on notebook changesSzymon Kłos4-2/+59
Change-Id: I81159d043add3d8bdd1b81f26f642f99c1430f73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94183 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94558 Tested-by: Jenkins
2020-05-20jsdialog: send tab namesSzymon Kłos3-0/+27
Change-Id: Iaae09ec6fc1af0de7f052b89a09ea184a023be70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94182 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94557 Tested-by: Jenkins
2020-05-20fix some more python 3.8 deprecation warningsNoel Grandin1-2/+2
Change-Id: I8bdbf05f1357aea83a3cdda2f06d63c7d04de8f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20use for-range on Sequence in d*Noel Grandin31-193/+164
and fix bug in GenericClipboard::initialize, where it was looping through the arguments, but always reading the first one. I'm guessing it was never an issue because it is always called with only one argument Change-Id: I8f72b6bce8c77a69c7d75115e34630e2c308261e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20jsdialog: react on button state changeSzymon Kłos2-0/+29
Change-Id: I19b8b4f123373da1acc7e2815086a67bcdb43e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94148 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94556 Tested-by: Jenkins
2020-05-20chart2: avoid assert on SvxAdjustItem with WhichId 0Michael Stahl1-1/+0
Insert a chart, then insert a rhombus shape into the chart: svl/source/items/itemset.cxx:150: SfxItemSet::SfxItemSet(SfxItemPool&, std::initializer_list<SfxItemSet::Pair>): Assertion `svl::detail::validRange(p.wid1, p.wid2)' failed. Presumably this item doesn't actually do anything since it was added in 2009 in commit 4d3c143900d87f23cb4e66f1ebf9e0dae0541e0f Alternatively it could be EE_PARA_JUST perhaps? but not sure if that can always be used. Change-Id: Ia1addb1095714acafe7db596ece4b9a706354d34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-20meta:non-whitespace-character-count attribute is knownhimajin1000003-3/+6
also, fixed a typo and re-positioned the item to the correct index. Change-Id: Ibac232a9e6851a0c59884bc82ead5de36ac2e391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94454 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-20vcl: refactor by creating SetBackgroundColorAndBounds() functionChris Sherlock1-18/+22
Change-Id: If547bde70db4e5a22bcbb9fc004cc575a62b23b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94395 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20vcl: refactor by creating RecordMapModeChanges() functionChris Sherlock1-3/+8
Change-Id: I5f0b8b9e0d85cdd71dffdc1f9f95d4660a7e0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94394 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20vcl: refactor by creating GetActionAfterBackgroundAction() functionChris Sherlock1-20/+27
Change-Id: Ice78e9433863be8966cd5b9caac663e684332f71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94393 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-20tdf#132169: sw: Add UItestXisco Fauli1-0/+61
Change-Id: I7f0f17bc96d73cead6c8fd4269ea7cee1d85bca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94552 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-20external/skia: Mark c++20.patch.0 as reported upstreamStephan Bergmann1-0/+2
Change-Id: Ia8434915829682880c0f2161f935d6608a18fd81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94555 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-20Drop workarounds for what looks like an MSVC compiler glitchStephan Bergmann1-2/+2
...now that 02b1a8f533d88c90004b1ea294f853f4b73f8c01 "Fix ambiguous symbol" removed the---apparently unnecessary---using directive from vcl/jsdialog/jsdialogbuilder.cxx, which had presumably caused the MSVC compilation error documented in dd5852f47beceb4a3b3f869cf6d3c24f3bf90ef4 "Work around what looks like an MSVC compiler glitch". I have no idea what the other ::MenuButton qualification, added with 02b1a8f533d88c90004b1ea294f853f4b73f8c01 in addition to the using-directive removal, was supposed to be good for, but lets assume that it is not actually needed as a workaround in any other build scenarios either and remove it too. Change-Id: Ib896562579c81d1b49e7edab47bc7cded445d46c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94541 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-20jsdialog: Common weld::Widget implementationSzymon Kłos2-12/+34
Change-Id: Iab21652c6abaf143fb421d6030f6acc394733bcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94073 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94489 Tested-by: Jenkins
2020-05-20NFC sw layout: optimize assignment of bAllowSplitOfRowJustin Luth1-6/+3
1.) Remove unnecessary test for !bDontSplit, since by definition, bTableRowKeep requires !bDontSplit const bool bDontSplit const bool bTableRowKeep = !bDontSplit && ... const bool bAllowSplitOfRow = bTableRowKeep && ... 2.) Put the trivial !bPrevInd test first and so potentially avoid the non-trivial lookup of AreAllRowsKeepWithNext(pFirstNonHeadlineRow) 3.) bAllowSplitOfRow by definition contains the two requirements of !bDontSplit and !pIndPrev, so pull out and test earlier - potentially avoiding further tests. This also emphasizes its similarity to bEmulateTableKeep. Change-Id: I41cb72aa03371eacfdb68d63dc3df21f85e755bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93635 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-20tdf#130479 FODG import: fix handling of <draw:fill-image> in stylesMiklos Vajna5-0/+361
Regression from the image handling rework, the problem was that the old, URL-based code had explicit handling of mxBase64Stream, while the new, XGraphic-based code assumed that by the time we reach the end of of the bitmap style element, maAny already contains the graphic. Fix the problem by improving XMLBitmapStyleContext::EndElement(), so it loads the graphic from the base64 stream if we don't have a graphic already. Change-Id: I6d90f1470a5b797fb51789901081ccd7a6fd29e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-20loplugin:unusedfieldsNoel Grandin6-41/+43
Change-Id: If179d0a13f3c9f7a49e3efe9027a64368ed600a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94544 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20use for-range on Sequence in cppuhelper,cuiNoel Grandin18-284/+264
Change-Id: I482d48e29ddc9690d9c671cde2f6b0c611ec378d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-20Fix contexts for translatorsSo Yanaihara1-8/+8
Change-Id: Ia0aada81a4f7c286545a0dc7c6c73a4cd7a0fb8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90857 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-20tdf#tdf99711: sw: Add UITestXisco Fauli2-0/+51
Change-Id: Ic03d43de5b83addcc25e857ae198ffcdd769f775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94551 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-20Korean Dangi Calendar Testcase tdf#125446DaeHyun Sung2-2/+2
Add testcase for Korean Dangi Calendar format tdf#125446 Change-Id: I4b0e59fd5aba97d4b45204bd4b3f2bc5c18ab442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89296 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-19tdf#60378 doc import: merged cells - don't null right borderJustin Luth3-14/+11
Well, don't null them out at all, for the benefit of merged cells, where the right border might be lost. There doesn't seem to be any point in clearing a border because LO sets a "merge adjacent line styles" in the borders which does exactly what the comment indicated it was trying to do. This option has been around since at least LO 3.5. Change-Id: I22954e5fc31dc1c072f1ff5ccaaa05cd0f69fda4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93064 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-23 18:51:24 +0000