AgeCommit message (Collapse)AuthorFilesLines
2017-04-06tdf#104686: do not crash if Menu has been somehow disposedAron Budea5-32/+58
The rare crashes in MenuFloatingWindow::ImplGetStartY() and MenuFloatingWindow::ImplScroll(bool) likely happen because of a disposed Menu. Let's guard against invalid accesses. Change-Id: Ie31240abbc48c06edd40d0a95f319725cdb3db16 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Meeks <> Reviewed-on: Reviewed-by: Aron Budea <> Reviewed-on: Tested-by: Aron Budea <>
2017-04-06changed wording of cell merge warningAndras Timar1-1/+1
Change-Id: I3b57f63eded0c925589f6baabcd09a72971943ae
2017-04-06Updated coreAndras Timar1-0/+0
Project: translations f11be1f85346090aee3a0db00b5c42ec3385b7e2 changed wording of cell merge warning Change-Id: I1d6c819ae9f63fe23d0e1747faa9a68da906738a
2017-04-06tdf#106359: register .iqy in MSI and treat them as templatesMike Kaganski6-6/+16
Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit 0c547776340c3983a867890b34f4a931215f8f52) Change-Id: I7ae94c7717fbea03d96c539e05eeb565bafefd9f Reviewed-on: Reviewed-by: Mike Kaganski <> Tested-by: Mike Kaganski <>
2017-04-05sType and sSubType are already normalized to ASCII lower caseMike Kaganski1-3/+3
... upon successful return from INetContentType::parse Change-Id: I8a0c50c1c655477138578e59031b64fb6b2b7218 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit 97f048e633f07655eda000ae4f4da818c935091e) Reviewed-on: Tested-by: Mike Kaganski <>
2017-04-05tdf#106955: Detect XML by MediaTypeMike Kaganski2-3/+45
According to Extensible Markup Language (XML) 1.0 (see, all parts of XML prolog (including XML declaration) are optional, so XML stream without <?xml ... ?> is well-formed (though not valid). XMLFilterDetect uses only XML declaration to detect if the file is to be processed further. However, this creates problems with said documents. This commit checks if the document has MediaType set to one of known XML media types, in case when the check for XML declaration failed. Change-Id: I31627c0e3a39bee241f609650280ebac3f1cede8 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit 156f778593ca9c57845076a88c6b544a63e12e7a) Reviewed-on: Tested-by: Mike Kaganski <>
2017-04-05tdf#106525: Implement an XSLT import filter for ADO rowset XMLMike Kaganski8-2/+280
There are online services and management systems (like SharePoint) that allow to export datasets in ADO rowset XML format ([MS-PRSTFR], Usually they are intended to be open with MS Excel as a spreadsheet (with autofilter). This allows to open this data in Calc. Change-Id: I495cd790138bdd6bd24630c0f422a0c8b4e3d0fb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> Reviewed-on: Tested-by: Mike Kaganski <>
2017-04-05tdf#106955: Open WebDAV resources on which PROPFIND failsMike Kaganski1-3/+87
When PROPFIND fails on a WebDAV resource, its IsDocument property stays undefined, and so stream creation fails. Proposed solution is to default to IsDocument=true for all WebDAV documents where we cannot get the property from server. Such resources also fail to return their locking options, so defaulting to server properties. When later locking is attempted on it, the attempt fails with user notification (a dialog saying that getting information from server failed). Proposed solution is to check Content-Disposition header in such resources, and in case it's attachment, disable lock on this resource. The rationale for this is that "In a regular HTTP response, the Content-Disposition response header is a header indicating if the content is expected to be displayed ... as an attachment, that is downloaded and saved locally" (see MDN: Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit fbc04c97231d629c1b5e9e57203dbe8d8eb06714) Change-Id: I91dbffa8bdf0fe900c11d2f8c9c9394d2104bb49 Reviewed-on: Reviewed-by: Mike Kaganski <> Tested-by: Mike Kaganski <>
2017-03-27Bump version to 5.1-24cp-5.1-24Andras Timar1-1/+1
Change-Id: I8fc85d5189c9ee8bddd1a83fa57c1f4fe096e5df
2017-03-27tdf#106799 WW8: Accept TTP Mark without Cell MarkMike Kaganski3-1/+18
Paragraph mark of inner table (0x0D) sometimes has sprmPFInnerTtp, but no sprmPFInnerTableCell. This still counts as cell end (at least, MS Word treats it that way). Unit test included. Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit 59af9cbbccee600408c89e872d548d153523ab1f) Change-Id: I5589cdd486c03ca4567d61882826cc7c245a40c9
2017-03-27Resolves: tdf#106729 ensure VistaFilePicker init before accessCaolán McNamara2-1/+18
(cherry picked from commit a15ec82edebf14baa41a888ead7da8e0556ab0bb) Change-Id: I238599cf5ed464c4bb99a894ac47126fbc32796d
2017-03-26Revert "nss: remove nss-pem.patch"Andras Timar4-0/+6402
This reverts commit 2a9e6ecc61b232be08d8b1687874289ca0fe8d43.
2017-03-26upgrade nss to version 3.27Andras Timar21-6497/+278
Change-Id: Id9805d79ab5ed17dda48b680d80c0d6fd3a72772
2017-03-26upgrade libxslt to version 1.1.29Andras Timar11-2051/+7
Change-Id: Id767422facef7d5cc51e107e12948abe24693f25
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky3-0/+98
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-24lok: Allow setting of the language during load.Jan Holesovsky5-1/+99
Conflicts: desktop/ desktop/qa/desktop_lib/test_desktop_lib.cxx include/LibreOfficeKit/LibreOfficeKit.hxx Change-Id: I9dbb62950e639376c26122ceb9fcec2982b3ca82
2017-03-24changed wording of cell merge warningAndras Timar1-1/+1
Change-Id: Ib2773d1aca6ff0ca8bfad2263b59daf1450fff6a
2017-03-24Updated coreAndras Timar1-0/+0
Project: translations 8ba1c3a82ca9f1b13f2bd3aebe2e41e40f8b582b changed wording of cell merge warning Change-Id: I024b805f10df7462b813204715372ab4dbdcf322
2017-03-24tdf#75369 Start Center: Non-installed applications aren't greyed outAkshay Deep2-0/+22
Reviewed-on: Reviewed-by: Samuel Mehrbrodt <> Tested-by: Samuel Mehrbrodt <> (cherry picked from commit 80cb33570557010547a08b5b1cd6bc0c1ee018fc) Change-Id: I52de5d7062bebe816e90ba39f559cd57dfc1067c
2017-03-23lok sd: Fix crash when searching.Jan Holesovsky1-5/+14
This is a follow-up of ed5450f2a5ed8e72b48b4d976217746cea04a5c9 where the check for the HasView has been removed. Turns out that there are conditions when this really can happen, leading to crashes in the LOK searching. Unfortunately I did not manage to find a reliable reproducer to create a unit test :-( - so I suspect this commit might be more a workaround than a root cause fix. Would be great to find out the exact conditions leading to the situation when the EditEngine does not contain the EditView, and evaluate this fix against that - but that's hard without a reliable reproducer. A unit test for this fix is missing from the same reason. The unit test from ed5450f2a5ed8e72b48b4d976217746cea04a5c9 still passes. (cherry picked from commit 9fc3d9b445d8c2bb8e259b42430cfe089642ab03) Change-Id: I1cca7219817119d27a224b35efb660a84d35b8fa
2017-03-22tdf#96522 - [ANIMATION] Animation Spiral in does not workNoel Grandin1-0/+95
blind fix for this since I cannot seem to make it work on my dev box no matter how far back I go. This seems to be a regression from commit c7e8f21a538c409abe70b90d7bba38386e90a876 "loplugin:unusedmethods" Change-Id: I99f0f0ca662a5fe246057b1bb8da3bd3d3c7bac6 (cherry picked from commit 4dfba3b59021f55957fc486531f8fdc67cc307b0)
2017-03-22Bump version to 5.1-23cp-5.1-23Andras Timar1-1/+1
Change-Id: I177e6a63dfcb23416fb383901490a96e59096e98
2017-03-21fixup for 'sd lok: Don't search on master pages & notes in Impress.'Andras Timar1-1/+1
Change-Id: I7049e45b1f1f22e32cc4bcbda89586491c4c5d9b
2017-03-20lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky2-4/+52
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e
2017-03-17sd lok: Don't search on master pages & notes in Impress.Jan Holesovsky2-3/+24
Change-Id: I43ed9f53618dca09e0289bffadc2c05056e0eebb
2017-03-17tdf#106488 - workaround to disable un-necessary locking for the kit.Michael Meeks1-0/+5
Not ideal, not suitable for Android etc. Better fix in online/master. Change-Id: I49299cdae19fa91c294196e6d82582aaf376fab7 Reviewed-on: Reviewed-by: Jan Holesovsky <> Tested-by: Jan Holesovsky <>
2017-03-17lok: It's not that important to skip some of the messages.Jan Holesovsky1-6/+6
More important is always to perform the paint. Change-Id: I392dd6cea4a5f43a646fca04d284b365b5fb5b78
2017-03-15Calc: safer life cycle handling for OutputDevice in SdrPaintWindowMarco Cecchetti2-25/+25
Change-Id: I5469332c4ef98bce8cd9c2caff5bf61dbf102b23 Reviewed-on: Reviewed-by: Marco Cecchetti <> Tested-by: Marco Cecchetti <>
2017-03-15LOK: Calc: unit test for invalidation on insert imageMarco Cecchetti2-0/+68
Change-Id: Ie7c55c3a5c366618cafa51f9f1a102fb3cb26ec5 Reviewed-on: Reviewed-by: Marco Cecchetti <> Tested-by: Marco Cecchetti <>
2017-03-15LOK: Calc: invalidation on insert imageMarco Cecchetti11-10/+131
Change-Id: Ib0ec104b14385473a2a7f7dc2a33558d998996fa Reviewed-on: Reviewed-by: Marco Cecchetti <> Tested-by: Marco Cecchetti <>
2017-03-15Revert "Invalidate the entire sheet after having inserted the image."Marco Cecchetti2-51/+1
This reverts commit fe87a31885dc870a9a8e4c4dcb105a4a5627164f Change-Id: I8fb9b67696913c1de0778d22b242673c89b07813 Reviewed-on: Reviewed-by: Marco Cecchetti <> Tested-by: Marco Cecchetti <>
2017-03-12Bump version to 5.1-22cp-5.1-22Andras Timar1-1/+1
Change-Id: Ib9fb351996cd63280cc138f43c900b97b9beaf40
2017-03-12tdf#106359: Open Web Query (.iqy) filesMike Kaganski2-1/+90
As per, the files are plain-text files with an URL and optional GET and POST parameters (static and dynamic). This commit introduces basic support to open these files (without support for POST and dynamic parameters). Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Mike Kaganski <> (cherry picked from commit 099f9406b6657a03a37fbe5cedf7cb7da765d4aa) Change-Id: Ib733c97780d363243644247196402f402c495cd1 Reviewed-on: Reviewed-by: Andras Timar <> Tested-by: Andras Timar <>
2017-03-11tdf#106217: Wrong size and position of a shape inside chartTamás Zolnai3-0/+30
Same code which was added to the method DrawingFragment::onEndElement() in d178d7bef193565a7d6aacbc37a58dfc4bd7b316 A shape's size and position inside a chart object are primarily defined by <cdr:from> and <cdr:to> tags in drawing.xml, but in the same file we also have an <a:xfrm> tag which is used for the same thing (defining size and postion) in general. Testing with MSO it seems it ignores what values are set to <a:xfrm> and uses only the <cdr:from> and <cdr:to> values. The test document showing this problem must be created an earlier version of MSO, becuase <a:xfrm> is set to some random values. Editing the chart and saving it with MSO 2013 the <a:xfrm> values are set consistently with <cdr:from> and <cdr:to> pair. Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tamás Zolnai <> (cherry picked from commit aa204f1c09a760d6753c408376ab7307fb13ad91) Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626
2017-03-10ofz#770 JOHAB_73 table starts at 0xA not 0x2Caolán McNamara1-1/+1
the start value is out by one row Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <> (cherry picked from commit a99f52608f38fb6be309fdfa22c7f4c418031394)
2017-03-08Re-introduce a check I dropped in 47b5f3a07236bb07a681e99e509c78e3af18c0b5Tor Lillqvist1-1/+2
Without fully understanding the code, best to let the condition be there. Use the same function to check for validity as before. (IsValid() which was renamed to IsValidForXml().) (cherry picked from commit a77908a2d82986ad9d2d9597536d1e22ce2cafd2) Change-Id: If50df539737352f12cb0178706cbc38512a99366
2017-03-08A 'CondFmt' record can have a maximum of three CF records following (eek)Tor Lillqvist2-6/+16
What an odd restriction. Oh well. Don't export the conditional formats for the cell(s) in that case then. See Change-Id: I4eeec8d33f9fbc572a02f727f38564d6c43b4f10
2017-03-08Make sure that the 'stAuthor' field of a 'NoteSh' structure filfills the specTor Lillqvist1-1/+7
Its length must be greater than or equal to 1 and less than or equal to 54, so if the author is empty, use a single space, and otherwise truncate to max 54 characters. See Change-Id: I7604ae9e1d8eea336b42116ea7d305e183e6ca51 (cherry picked from commit 27e34a7dbb9aa2ce52ca529ec835d54c6a5508fc)
2017-03-08tdf#104729 FILESAVE Save author name in comment during export to .xlsxBartosz Kosiorek3-0/+24
Change-Id: I59d46f6a713e4f252844cda0f631ace239d73cdb Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <> (cherry picked from commit 36cdf3c35459df63ce137e550a6840a61865c0ca)
2017-03-08Write the 'FtNts' subrecord of 'Obj' when necessaryTor Lillqvist1-1/+20
See : nts (26 bytes): An optional FtNts structure that specifies the properties of this comment object. This field MUST exist if and only if cmo.ot is equal to 0x19. Change-Id: Ib4a007940c29a4f8eac1087601cfc7d242cfebd3 (cherry picked from commit 20a7d4b16d600101f4073ad4ce669a7566bf14c1)
2017-03-08It's SetSliceSize, not SetSliceLenTor Lillqvist1-2/+2
Change-Id: Ife4449f5afa7321c18e8eb963878d9c037f6d623 (cherry picked from commit 93a53e0ebba62873c768d887c6aa1125967aa9e4)
2017-03-08Use symbolic constants instead of hardcoded numbersTor Lillqvist1-3/+4
The constants were commented out, so uncomment them. Probably lots of the same left. Change-Id: Iac87bef3bc331ae126741efbb4d58cc539e5a42a
2017-03-08The 'fLockObj' field of an 'ObjProtect' MUST be 0x0001 says the specTor Lillqvist1-1/+2
So generate such a record only when the protection state is on. See Change-Id: I710395527cd53dc47018806e51fcc699e11fb461 (cherry picked from commit 4a332d54b80bbc502ccc98bf924a269e00c10070)
2017-03-08The 'reserved1' bit of a 'Formula' MUST be zero according to current specTor Lillqvist1-1/+1
See . This means we will never set the EXC_FORMULA_RECALC_ONLOAD flag, hmm? Change-Id: Ic081caa7f98426394cbc7b0b320fa1a5a9a34f6c (cherry picked from commit 727ee3f92a8882914ac3f68eaf53ac519ace5f38)
2017-03-08Set the 'unused2' bit of 'Font' to 1 iff 'uls' is greater than 0 per specTor Lillqvist1-0/+2
See . Change-Id: I4ff278f4cdd388947bbe81b88b6c39ff2b208b1a (cherry picked from commit 970f8dc7847967719652590f71f0f19e46ba7268)
2017-03-08tdf#106283: Registry settings are not read properly on WindowsTamás Zolnai1-0/+22
Read also a type value from registry so user can specify a type for a property of an extensible group. Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Stephan Bergmann <> (cherry picked from commit 145accd9a5b55070959d40c9314d870dffa5e4bc) Change-Id: I4105ba559a64ce96bfe5a390660ad7f349ba894c
2017-03-07Revert "tdf#106283: Registry settings are not read properly on Windows"Tamás Zolnai1-1/+1
This reverts commit ed930e8eabe20c3656720a3d7578fbb533296287.
2017-03-07tdf#106291: WW8 import: Properly treat column spansMike Kaganski3-20/+92
Previous code unconditionally treated all cells in merge groups as rows span, thus in some conditions it merged incorrectly when there were cells from same row. The fix is inspired by SwTable::PrepareMerge(). Also, fixed improper adjustment of too narrow cells in WW8TabDesc::CalcDefaults(), which also happens in files where column spans are represented by spanned 1-twip-wide cells. Unit test included. Change-Id: If043cfc466879d45141c655f7be1588792f898d3 Reviewed-on: Reviewed-by: Mike Kaganski <> Tested-by: Mike Kaganski <> Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Miklos Vajna <>
2017-03-06Resolves: ofz#727 don't allow negative sizes or indexesCaolán McNamara2-17/+15
remove extra size in favour of vector size and don't resize and memcpy data, just use vector::insert Change-Id: I8efb91a8c11fbd862c0458042554cf7e94b813cd Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <> (cherry picked from commit 789dc289b8b7ff79a6195e8648d0ac6be5cf13bb)
2017-03-06fail on unknown version flagsCaolán McNamara1-3/+2
Change-Id: Icbd2608a3341652b1b40f6bdebb66c4caf6e810a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Michael Stahl <> (cherry picked from commit 90643e244cbd42866a49a7cf878dc9473ab2e6c0)