summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-12-07tdf#121658 Add option to not hyphenate words in CAPSSamuel Mehrbrodt31-125/+268
* Add checkbox to pagraph dialog * Store property in paragraph model * Move docx import/export from grabbag to paragraph model * Add ODF import/export * Add ODF unit test * Add layout test Change-Id: Id4e7c5a0ad145c042f862995d227c31ae2aa0abd Reviewed-on: https://gerrit.libreoffice.org/83979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69) Reviewed-on: https://gerrit.libreoffice.org/84620
2019-12-07tdf#101977 add new track changes uno commands to writer NB+ menubarandreas kainz5-55/+275
Change-Id: I06e48f37af435d9927b764de1a972687bbd7bf2a Reviewed-on: https://gerrit.libreoffice.org/84671 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit d139529dff85282772d334edcebdccf23d2d9c97) Reviewed-on: https://gerrit.libreoffice.org/84678
2019-12-06tdf#127237 fix table background color in Impress importnd1016-0/+33
When the background color is set at the table level in PPTX, instead of at cell level, the background color fails to show up in Impress. Change-Id: I2838e5b56e4a2414494ee99c0f8975b7256ac6dc Reviewed-on: https://gerrit.libreoffice.org/78377 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 4c2254cbebca53c34fa48a1dd90cebe434f24274) Reviewed-on: https://gerrit.libreoffice.org/84644 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-06Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-4' - tdf#129171 Clarify NETWORKDAYS_EXCEL2003 Embed note from Date functions. Change-Id: Iac77cd6610ef6118978fa5ff5495a5e53d94e4d6 Reviewed-on: https://gerrit.libreoffice.org/84668 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-06Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-4' - Update list of missing icons for Help Change-Id: I1a5b28ddb0e057c83a1da88b8b9337a0479a217d Reviewed-on: https://gerrit.libreoffice.org/84659 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-06Update git submodulesLibreOfficiant1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-4' - fixing 'related topics' layout for a conciser display Change-Id: I01535595b22ea3cb59111bfd5c681283fd94049c Reviewed-on: https://gerrit.libreoffice.org/84625 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-06tdf#129071 Qt5 handle windows with parents as dialogsJan-Marek Glogowski3-8/+9
This is the main fix for this bug. Qt Xcb is a little picky here. It won't tell the window manager about the transient state, using WM_TRANSIENT_FOR, for all Qt::WindowTypes. The QPA internal list (see isTransient function) doesn't include the Qt::Window, which is qt5 VCL's primary used window type. This has two consequences: 1. LO dialogs show up in the plasma task manager as seperate windows. 2. LO has to handle the transient state itself, instead of relying on the window manager. This results in flickering, because LO can just push a transient window to the top again, after the parent window was activated and therefore drawn in front. So this just declares all windows with parents to be dialogs. Almost everything else should be a top-level window anyway. If not, there is SalFrameStyleFlags::DIALOG to create a parent-less dialog window. Change-Id: I89a6d46fd09e4f1d1d2904e152a26733eb266079 Reviewed-on: https://gerrit.libreoffice.org/84298 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit d8e3a08f06dcfea02c3f2f2a8578486381d77df7) Reviewed-on: https://gerrit.libreoffice.org/84619
2019-12-06KF5 drop KF5FilePicker::executeJan-Marek Glogowski3-29/+7
To prevent calls to Qt5FilePicker::updateAutomaticFileExtension, it is simply made virtual with an empty override. This is needed, because the KF5 file picker has its own automatic extension handling. The main motivation is the fix for tdf#129071, which will result in some major changes to XExecutableDialog::execute, so this will prevent larger code duplication later. Change-Id: I5f747f0828cb8a65b4e7043f3ee68ebd31973e6a Reviewed-on: https://gerrit.libreoffice.org/84297 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit c0cdb01ef33042be76251c4a353e0582a0838e0e) Reviewed-on: https://gerrit.libreoffice.org/84605 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06tdf#121300 sw: adapt at-char selection to latest at-para designMichael Stahl1-2/+7
Also use heuristic from commit 91b2325808a75174f284c48c8b8afc118fad74e4 to not delete on backspace/delete selections for at-char flys. Change-Id: I8f561eb0176e0655b715366d1ffe3c71fbee9e30 Reviewed-on: https://gerrit.libreoffice.org/84622 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 98d1622b3721fe899c4e1faa0b4cc35695253014) Reviewed-on: https://gerrit.libreoffice.org/84629 Tested-by: Jenkins
2019-12-06tdf#120546 fix DOCX overriding numrule formatJan-Marek Glogowski2-2/+19
... at least in the view. This "fixes" the import side of the exported OOXML document with multiple overridden numrule character format. This prevents the change of the shared numrule, which results in all bullets being formatted like the last overridden numrule. What is missing is a consistent way to edit the override, as the override is currently just stored in an internal attribute, the "ListAutoFormat" property. Fixing editing for good will be a larger work, as "ListAutoFormat" must be reflected in the GUI and must have a higher priority then the numrule format. Currently positioning the curser in front of the number or bullet entry lets one change the numrule format, which is applied to all bullets of the same rule. This special DOCX override mode is enabled by the import filter setting DocumentSettingId::APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING to true. This should also change the edit mode, so that a change of the entry doesn't modify the rule, but the override and this must also be reflected in the GUI character settings. Change-Id: I057f7a354bc3c413b114eec772e06c7063029699 Reviewed-on: https://gerrit.libreoffice.org/81878 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 6ed12ab2d0742f86ce25defec3c776562dbfad9a) Reviewed-on: https://gerrit.libreoffice.org/84624 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-12-06tdf#121300 sw: consistent fly at-pargraph selectionMichael Stahl14-143/+374
As a follow-up to commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5, add IsSelectFrameAnchoredAtPara() function and use it to harmonize at-para fly selection across all relevant operations: * CopyImpl: - it had a pre-existing bugs that would lose a fly anchored to the 2nd (1st fully selected) node of a redline - remove a bunch of code for finding the last node of the body content, which doesn't matter for the remaining at-fly checks - flys that already existed at the insert position need to have their anchors corrected * DeleteRange: - get rid of the bDelFwrd checks * MoveRange: - the ALLFLYS flag would be obsoleted by the new selection, were it not for the writerfiler "special hack", see below * also adapt A11y and UI selection, SwRootFrame::CalcFrameRects() The selection behavior is changed: * the bDelFwrd case is quite odd, some code was checking whether a deletion was "forward" or "backward" and removing only the flys at the point node while retaining the flys at the mark node; this worked in a very non-obvious way relying on sw_GetJoinFlags actually calling Exchange() on the cursor, and then SwUndoDelete stored it in m_bJoinNext, but it turns out that only SwUndoMove also has a m_bJoinNext and it's dead, and no other Undo has such a flag, so this only worked for "delete". It's not obvious what the value of this is, let's just ignore the "direction". * Selections exclude the start and end position except if it's a fully selected node or at the start or end of a section (i.e. Ctrl+A should also select every at-para fly). * An exception is made in case the selection looks like it's a backspace/delete joining 2 paragraphs; flys are not deleted in that case because it seemed annoying (and as it happens, Word does not appear to delete flys in that case), particularly if both of the nodes are already empty. This is done with a heuristic, it's conceivable to pass down some flag from DelLeft()/DelRight() but probably this is good enough. A special hack is needed to keep writerfilter happy for now; it likes to anchor flys at nodes which it then deletes in RemoveLastParagraph(), which likely could be improved there. The ALLFLYS usage in SwRangeRedline::MoveFromSection() could be removed (because the end-of-section check already handles the case) except for this, because it turns out that the ODF import runs SetRedlineFlags with a temporarily reset IsInXMLImport() flag because of its effect in thints.cxx, so during the move IsSelectFrameAnchoredAtPara() can't check it. tdf#108124 scenario works better, now everything that's selected is both copied and deleted. Fixes the problem where an at-para fly at the 2nd node of a redline where the 1st node is partially deleted was lost on ODF export. Change-Id: I168013665e70ff0a5f198e09f3fa3afc06ba0449 Reviewed-on: https://gerrit.libreoffice.org/84576 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 91b2325808a75174f284c48c8b8afc118fad74e4) Reviewed-on: https://gerrit.libreoffice.org/84621
2019-12-06cleanup "tdf#117274 XLSX export: fix VML comment shape type id"László Németh1-4/+7
Limit special MSO ID check for attribute values. Follow-up of commit c5d37d324cd6d17114c209de1862344ad58a1d93. Change-Id: I0f16b0df0c5575b799bb505a93c660c15b3273c5 Reviewed-on: https://gerrit.libreoffice.org/84549 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 579db0d2d3d2ddf5a5f8feaa2e7cc4dde81d7701) Reviewed-on: https://gerrit.libreoffice.org/84592
2019-12-06tdf#129136 Call _wgetdcwd with "harmless" invalid parameter handlerStephan Bergmann1-1/+26
The documentation of _getdcwd/_wgetdcwd specifies: "If the specified drive isn't available, or the kind of drive (for example, removable, fixed, CD-ROM, RAM disk, or network drive) can't be determined, the invalid-parameter handler is invoked." (<https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/ getdcwd-wgetdcwd?view=vs-2017>) The default handler terminates the process, so temporarily install a "harmless" one. (e30f3bcd25762236eb739584dc71691123527c9f "Revert 'fdo#38913: Prevent invalid parameter handler crashes'" had removed a global "harmless" handler installed with _set_invalid_parameter_handler to handle JVM-related issues, but which was then considered no longer necessary. I assume that for those JVM-related issues there was no obvious place where to install a temporary _set_thread_local_invalid_parameter_handler, and that that was the reason for the global _set_invalid_parameter_handler in sal_detail_initialize. I cannot find any information that _set_thread_local_invalid_parameter_handler would be available in fewer versions of Windows than _set_invalid_parameter_handler, and might even be missing on Windows versions that we target.) (It appears that at least when building with MSVC 2019 and running on Windows 8, with an --enable-dbgutil build (presumably due to MSVC_USE_DEBUG_RUNTIME) a "Microsoft Visual C++ Runtime Library: Debug Assertion Failed!" error dialog still pops up, which needs to be quit with "Ignore" before our invalidParameterHandler is called.) Change-Id: I983d622eb03549873a63305f51bf0869d7fea33a Reviewed-on: https://gerrit.libreoffice.org/84597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 9235990b4eacbc8a90750da8bdf2fb15f99a9d79) Reviewed-on: https://gerrit.libreoffice.org/84612
2019-12-06sw: add getter for RES_PARATR_LIST_AUTOFMTMichael Stahl1-11/+71
Change-Id: Ic492dd4062a5ce659a996fb96f3ed9e12d1767ce Reviewed-on: https://gerrit.libreoffice.org/84581 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit d8c36a8771398327ba83884a2e0aa82a6d7c8492) Reviewed-on: https://gerrit.libreoffice.org/84615
2019-12-06tdf#126192 tdf#126030 (related) Package translations of ooxKelemen Gábor2-0/+2
Now that there are some available, new mo files need to be added to the installer. Tested with Spanish on Windows to work. Change-Id: Id70305fa5a674bc9e302aa6937a03c4573888da4 Reviewed-on: https://gerrit.libreoffice.org/84569 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a36a3f65d19497a0f6f13780b8e2bf0068c94c18) Reviewed-on: https://gerrit.libreoffice.org/84610 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-06tdf#99602 writerfilter: export only default subscript in stylesJustin Luth3-0/+23
support for subscripts in character styles was added in LO 6.4. On import, we just assume default values for superscript and subscript _FOR STYLES_. So exporting should do the same thing. What was happening was that - for the non-default, non-automatic subscript settings - the character style fontsize was being reduced to the proportional size, but then on import the reduced fontsize was loaded, as well as the default subscript settings being applied again, reducing it by another 42%, so effectively the subscripting was being applied twice. Yes, defaults-only means that anyone tinkering around with non-automatic subscripts won't get exact replication - but trying to emulate LO's percentage based system and Word's fontsize/distance system is way too complex when styles are involved. Just note that subscripts/superscripts are used and let the computer handle it - which generally looks best anyway. Reviewed-on: https://gerrit.libreoffice.org/84008 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 8f7010eb47119a2428b77f5d79fc8577d9914958) Change-Id: Idef6a084abff47dcdbe7a340cf74273a7482d430 Reviewed-on: https://gerrit.libreoffice.org/84395 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-06tdf#127955 check if position stored in user config is in range for the treeviewCaolán McNamara1-1/+1
https://crashreport.libreoffice.org/stats/crash_details/8c4a3136-73be-4536-ad6f-ce97ae0368dd Change-Id: I320f965eb622f90f8059f85e7ba2ff203419ab3f Reviewed-on: https://gerrit.libreoffice.org/84600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06tdf#128712 clarification and addition of Draw tipsSeth Chaiklin1-1/+4
Split one tip into two different tips. Added two more Draw tips Change-Id: Idbb9b5ba0c136a8cb110eb8b7ed8f8d2855c9221 Reviewed-on: https://gerrit.libreoffice.org/84161 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6e70a98b15c97ad2a3714aae5a5bfa22d307f236) Reviewed-on: https://gerrit.libreoffice.org/84594 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-06Qt5 hide more Qt5FilePicker detailsJan-Marek Glogowski4-47/+32
* Make most members private * Drop some unused members * Rename some single-char variables for easier reading * Spread some constness * Finalize the KF5FilePicker class * Test the native picker setting of the QFilePicker, instead of an additional bool member This is just some refactoring. While not strictly needed, it helps keeping the following patches fixing tdf#129071 more compact. Change-Id: I15ffe4de848a9498d7f61f99bcf031257da7cb08 Reviewed-on: https://gerrit.libreoffice.org/84456 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit f33b6e915fdc29cff25cc93784a04df866ad6bc3) Reviewed-on: https://gerrit.libreoffice.org/84551 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-06handle unsetting ImageCaolán McNamara1-1/+4
Change-Id: If4a3ab94c268caeebdc42c664c568aa9004c50ad Reviewed-on: https://gerrit.libreoffice.org/84580 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06tdf#101513 arrangement of customizeable items in NB groupedbar compandreas kainz4-3790/+3790
Change-Id: I79f91f9b1f1fc5d91912061c004865a94f1371a6 Reviewed-on: https://gerrit.libreoffice.org/84563 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 5799555fbfe378b22b5b36e0e7f9573ec9b26a31) Reviewed-on: https://gerrit.libreoffice.org/84586
2019-12-06Resolves tdf#129140 - Wording in printer dialogHeiko Tietze1-3/+3
Wording improved Change-Id: I67fcee9bdae869eb57882b1944e8975d4c564735 Reviewed-on: https://gerrit.libreoffice.org/84572 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 291b1acd3b9664ed41954458648448d7799d4df9) Reviewed-on: https://gerrit.libreoffice.org/84590
2019-12-06Fix "Open Hyperlink" context menu in scSamuel Mehrbrodt1-1/+1
Change-Id: I05fce087d20123447c1e5bd0f27db8d1c9ef3641 Reviewed-on: https://gerrit.libreoffice.org/84518 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 069a45e661086d1014855ca4f7ad384ba5752bb6) Reviewed-on: https://gerrit.libreoffice.org/84577
2019-12-06tdf#128666 Only enable hyperlink actions when just the field is selectedSamuel Mehrbrodt8-48/+33
Change-Id: I984df967877a47fb9f89c3626737348a87d3ffa5 Reviewed-on: https://gerrit.libreoffice.org/84418 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit f31c3ebb60e4678eb09e377b638b368531df47dc) Reviewed-on: https://gerrit.libreoffice.org/84571
2019-12-06tdf#128466: Accept also JPEGTor Lillqvist1-1/+1
Change-Id: If8499cde875e03cb6c56259badd64ba6aee08a66 Reviewed-on: https://gerrit.libreoffice.org/82584 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 7dba640b5691c22d6529e53752255fddc2b461e6) Reviewed-on: https://gerrit.libreoffice.org/82618 Tested-by: Jenkins (cherry picked from commit 3adb591bc632854dc9f0af0c8498ae45171080a7) Reviewed-on: https://gerrit.libreoffice.org/84524
2019-12-05tdf#127939: Make slideshow touch input work properly again on iOS 13Tor Lillqvist1-24/+22
For some reason, navigator.userAgent in WebKit on iOS 13 claims it to be a Macintosh, so our old code to recognise iOS did not work any longer. Also the Hammer.js included in this file looked at navigator.userAgent and its decision what to do based on that did not work properly either. Simplify our code by handling swipe gestures all the time, even when such won't be generated (on mouse-only devices). Also, Hammer.JS was too eager to think it detected a pointer-only device based on the presense of window.PointerEvent. That sems to be present now in iOS 13. Let's not blindly think that means it is a pointer-only device. If the device supports touch events, don't bother with PointerEvents. Change-Id: I57d972415798967e871c6e262f16043561ed6af5 Reviewed-on: https://gerrit.libreoffice.org/81404 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 8f78d6a0d1b4d8d2e21aad9e90510fe6be4df5bb) Reviewed-on: https://gerrit.libreoffice.org/83731 Reviewed-on: https://gerrit.libreoffice.org/83883 Tested-by: Jenkins (cherry picked from commit 8012a200d1a7c5cd1b64a147ca6899fb8863ce8b) Reviewed-on: https://gerrit.libreoffice.org/84529
2019-12-05We use the system clipboard on iOS and not the "LOK clipboard"Tor Lillqvist2-2/+23
The use of the system clipboard was implemented for iOS in vcl already in cp-6.0. This "LOK clipboard" thing is for different situations in web-based Online and not applicable for the iOS app. Change-Id: I679b5c27d308a563eadaf1e543ce8c45d763f3c6 Reviewed-on: https://gerrit.libreoffice.org/83339 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 8ce79f1a9188ae389dc8be1f53de0000b3ca0951) Reviewed-on: https://gerrit.libreoffice.org/84528 Tested-by: Jenkins
2019-12-05Add comment about confusion in SwCommentRuler::CreateJsonNotification()Tor Lillqvist1-1/+19
No code changes. (cherry picked from commit 5b6d23dcd0f2f779b4bbffe7f427a7c397f41c95) Change-Id: Ibc46b3e55038e84f2ad80ff12b277b2e2c77a4ce (cherry picked from commit 0fb2b9b23ac3d082251217b3478917b387fe162c) Reviewed-on: https://gerrit.libreoffice.org/84532 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-12-05lok: calc - store zoom in the view itself.Michael Meeks5-33/+64
Don't duplicate this on the ITiledRenderable interface, which is not a per-view construct, this just confuses everything. Store & restore the zoom level before/after rendering a tile - unfortunately this is not done by the most optimal view yet. Change-Id: I1f7dfaa353333f45c5601d49a9bca784d34fb81a Reviewed-on: https://gerrit.libreoffice.org/84281 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 3b7661cda1c910524a2c4e3394417971fa025f31) Reviewed-on: https://gerrit.libreoffice.org/84303
2019-12-05update creditsChristian Lohmaier1-1586/+1653
Change-Id: I7f35a5dcb3d5c22439890163699e0c9999f256eb (cherry picked from commit fafa1b740c111584203eb1a8e6be48ef524759d3)
2019-12-05tdf#101513 arrangement of customizeable items in NB tabbed compactandreas kainz3-2555/+2342
Change-Id: Ibf1f958d2086b0a631097aee9f903aee202767c1 Reviewed-on: https://gerrit.libreoffice.org/84468 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 81f01259dfe29b7ee73c42d3b44934d6fc973cd8) Reviewed-on: https://gerrit.libreoffice.org/84550
2019-12-05Resolves: tdf#129191 text properties in header/footer not setCaolán McNamara1-1/+1
EditEngine has a non-virtual void SetText( const EditTextObject& rTextObject ); ScEditEngineDefaulter inherits from EditEngine but does using EditEngine::SetText void SetText( const EditTextObject& rTextObject ); so has another SetText with the same signature that does something different, so calling via an EditEngine pointer gets the unwanted base version Change-Id: I72e368e6698d5b9a205180cfd2c4f800be7846f8 Reviewed-on: https://gerrit.libreoffice.org/84544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05Add a comment telling what "frame margin" means hereTor Lillqvist1-0/+1
Change-Id: Ie6d088217c066ec3091fb28925947175cf62634f (cherry picked from commit 21b68c4cd7ce108cf334607ced0b20e7b5914c20) (cherry picked from commit 51794501045a6f8b0f6f1c04b6aee2e28647b4ea) Reviewed-on: https://gerrit.libreoffice.org/84531 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-12-05Fix build with USE_AVMEDIA_DUMMY (iOS, at least)Tor Lillqvist1-4/+4
We need boost headers also for avmedia/source/avmediadummy.cxx now. Change-Id: Ib1fd2c19aaf62beb759bfee5ec51f167d0966df4 Reviewed-on: https://gerrit.libreoffice.org/84011 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 8d8a3f66e57aefd7cf7d3bb6cb62059de5beded2) (cherry picked from commit de62d0c77e2f9e24f72fd638cb5c5e365ff164b5) Reviewed-on: https://gerrit.libreoffice.org/84530 Tested-by: Jenkins
2019-12-05tdf#128133 WIN don't exit after link-output filterJan-Marek Glogowski3-7/+3
The linker output filter command (gb_filter_link_output) ends with an exit "${PIPESTATUS[0]}", which will quit the current Makefile shell command always after calling the linker. This prevents the later shell code of that line to run, which includes the merge of the DeclareDPIAware.manifest. That manifest would tell Windows that LO binaries are "<dpiAware>true</dpiAware>", to prevent System DPI scaling. Since it's not merged, LO is scaled by the OS, resulting in blurry fonts. Since there is no reason to have an extra make "function", like ifeq or multiple definitions, this includes the code directly. Additionally the MS linker has localized output, so this patch uses a more generic regexp to filter-out the default link message, which works with the English and German locale. Change-Id: I0099f6c38ca0eda18c7b0c108529bc73189c1504 Reviewed-on: https://gerrit.libreoffice.org/84099 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit d10db7846602c16701dde019f12f61fd536e9ae4) Reviewed-on: https://gerrit.libreoffice.org/84457 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-05Add ooo.vba.word.XDocument.Close() method and implementTor Lillqvist3-0/+8
Will be needed in COLEAT. And seems like a fairly obviously missing API otherwise, too. Change-Id: I990c605a7e3f9cff3b72f20a626477d010da9852 Reviewed-on: https://gerrit.libreoffice.org/81369 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit b0b0788ba040be2bf42aa19313759ba9f4811d38) Reviewed-on: https://gerrit.libreoffice.org/83660 (cherry picked from commit 1562900446a99623a30fa9e719322a8c24132f9d) (cherry picked from commit 939331c0935d671984079051fda03feb3dcf23d9) Reviewed-on: https://gerrit.libreoffice.org/84527 Tested-by: Jenkins
2019-12-05Add note that SwVbaDocuments::Close() does nothingTor Lillqvist1-0/+1
Change-Id: Ibf4d175b4b4a0b9f168401e52af6b0459aacd046 Reviewed-on: https://gerrit.libreoffice.org/81368 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 61a656cb9c7db1863e56d1183cb82c7e8be63cc5) (cherry picked from commit 5c5034a6d5d411fedf1fb00e736c55b7bdd6f840) (cherry picked from commit 405c9f65c5dbfddf1f9162716fab0d30e44c420e) Reviewed-on: https://gerrit.libreoffice.org/84526 Tested-by: Jenkins
2019-12-05sw: insert image: set anchor to at-char by defaultMiklos Vajna2-2/+2
This changes the default set in commit 4f40bf6a79de6d60da0a5090cdfeda6242e889f0 (sw: insert image: set anchor to as-char by default, 2019-07-04), to have a better compromise, taking both Word defaults compatibility and usability into account. The problem is that users are used to just inserting an image and being able to drag it to its final location, which is broken with as-char anchoring. So default to at-char anchoring, this is still something that is fully interoperable to Word (unlike the old to-para anchoring), but allows the easier image move again. (cherry picked from commit a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db) [ See the discussion at the end of <https://gerrit.libreoffice.org/#/c/75091/> for the motivation of this backport. ] Change-Id: Ibc61ae167fc9e5cc31b04c83e854556309e27fd4 Reviewed-on: https://gerrit.libreoffice.org/84513 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-05Add some more source files for breakpointing convenienceTor Lillqvist1-0/+198
Change-Id: I0008393be56341fe7e1f385bd111475b67446240 (cherry picked from commit 73a957a967af241df8ff642f9919b6a4689c63dd) Reviewed-on: https://gerrit.libreoffice.org/84525 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-12-05Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-4' - Fix image and icon dimension issues with svg icons, image must set width and height. Change-Id: Idce5d74e4f07277d7bff532d941bc5d62648b095 Reviewed-on: https://gerrit.libreoffice.org/84558 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-12-05tdf#109425 NB tabbed accessible for screen reader usersandreas kainz4-705/+786
Change-Id: If5c1db1579d40e68ba6e8092025e687dd8addd03 Reviewed-on: https://gerrit.libreoffice.org/84472 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 328c9a674057759f616c584a8ae75ca018d10fdc) Reviewed-on: https://gerrit.libreoffice.org/84502
2019-12-05add ConfigureDialog item in NB burger menu buttonandreas kainz3-0/+3
Change-Id: I926a0b5ff9cb09a8a05e60c0a86eb11a2a201073 Reviewed-on: https://gerrit.libreoffice.org/84504 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-05tdf#128611 sw: improve rotated text layout in table cellsMiklos Vajna8-0/+130
The problem was that in case a table with 1 row and 2 cells has rotated text in the A1 cell, then the row height is 0, so we aggressively try to break up the text into multiple lines. Then the A2 cell adds more content, so the row height is increased, but the A1 cell is not re-layouted to make use of the increased amount of vertical space. A similar (but working) situation is vertical alignment of cell content, there adding more content to A2 re-formats A1. Fix the problem in a similar way: track if a text frame contains at least one rotated portion, and throw away the portions of the text frame at the end of SwCellFrame::Format(), after vertical alignment is handled. (cherry picked from commit 0fa95852b0968fa2a35efb8ca816949c58af56e0) Change-Id: I65383bb1af486771dc671dca3d8bbf1831ba94ff Reviewed-on: https://gerrit.libreoffice.org/84506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-05tdf#129083 Writer: fix native paste from CalcLászló Németh1-2/+2
Paste the copied Calc worksheet cell by cell in a Writer table again instead of inserting it as a nested table in the actual cell. Regression from commit e9e6d4b058e13165f3dde1ca7822eec97dfe8aa7 (tdf#116685 Make the RICHTEXT take precedence over EMBED_SOURCE). Change-Id: I226c35f9f5ca3955b2ef498d1d0aeedfcec61987 Reviewed-on: https://gerrit.libreoffice.org/84389 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 84a6d8b79455291f35211e4bd6aad3c7a0fcc9bc) Reviewed-on: https://gerrit.libreoffice.org/84398 Tested-by: László Németh <nemeth@numbertext.org>
2019-12-05tdf#128428 RTF: switch off longer space at \dntblnsbdbLászló Németh3-0/+42
The Word 6.0 (Japanese) compatibility option \dntblnsbdb switches off the balancing of SBCS/DBCS characters, including the longer space sequences. Note: using \dntblnsbdb, it will be possible to set normal (short) space sequences in RTF export, too, to avoid broken document layout during RTF round-trip. Fix regression from commit 24b04db5a63b57a74e58a7616091437ad68548ac (tdf#123703 RTF import: fix length of space character sequence). Change-Id: I5ade9e0a2db0bde204d1debe831058045fd8f586 Reviewed-on: https://gerrit.libreoffice.org/84397 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit cd7241e3d2892c2a115265f842f464d017d7c7e1) Reviewed-on: https://gerrit.libreoffice.org/84414 Tested-by: Jenkins
2019-12-05headless: Don't leak the cairo context in drawPixel().Jan Holesovsky1-1/+4
Change-Id: If841f655ac634eee2dc7ca6e9445d2f204546545 Reviewed-on: https://gerrit.libreoffice.org/84445 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5b607ae89de9494c01952852df30a6f77206eadc) Reviewed-on: https://gerrit.libreoffice.org/84470 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-05tdf#129054 Chart OOXML Import: Fix size of Pie ChartBalazs Varga5-1/+40
Do not shift (set to false ShiftedCategoryPosition) the category axis for Pie chart with complex category. Change-Id: I3b1d99899a2daf9fd7a596c88531797aa5084734 Reviewed-on: https://gerrit.libreoffice.org/83871 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit ea97f0926e138712c3800f5274012f0f04fc1c47) Reviewed-on: https://gerrit.libreoffice.org/84187 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
2019-12-05colibre icon: add sc_styleupdate iconandreas kainz2-0/+10
Change-Id: I2d877779e1a2cb3bd2e7092e0902763ee12dbd1b Reviewed-on: https://gerrit.libreoffice.org/84393 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 23c987dc4e4ccdd2f031b7cb0eb915b7abcdacc3) Reviewed-on: https://gerrit.libreoffice.org/84447
2019-12-05Colibre: Fix for tdf#127415rizmut13-4/+16
Change-Id: Ic32506f55d703fc87cf1152d5565d5b4a8ed831f Reviewed-on: https://gerrit.libreoffice.org/84355 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 0f3e778257f6fdb04cfd3434907c1388c659d847) Reviewed-on: https://gerrit.libreoffice.org/84471
2019-12-05Colibre: content tiltingrizmut137-381/+1059
- clean duplicate icons - add 32 item in links.txt - sort the links.txt content Change-Id: I51e344859ee8dd12f658fc17aba838bfe23f9273 Reviewed-on: https://gerrit.libreoffice.org/83959 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 2bf687bebb30defe576ddb20c1c9680979ed3086) Reviewed-on: https://gerrit.libreoffice.org/84466