summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-05-23Add missing mpAlphaVDev handlingMike Kaganski4-5/+42
... a pre-requisite for re-implementing soft edge to use mpAlphaVDev necessary to keep objects' transparency when applying the effect Change-Id: I56f5c0f2468c32843abbc1f14e06861a22f6919d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94662 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-23Tidy up generation of Application::GetHWOSConfInfoMike Kaganski2-22/+20
... so that it doesn't add "; " in the end unconditionally. This makes version info in About dialog prettier. Change-Id: I914b8bd808230681f768c9da679941c604fc5eab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94671 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet18-26/+26
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-22always use region band in Skia's setClipRegion (tdf#133208)Luboš Luňák6-15/+191
Do like other VCL backends do. Change-Id: I64b5d5a2fb131b41c70aa63eaf84022e9aa9fab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94702 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-22Related: tdf#133189 values not updated when units changedCaolán McNamara2-4/+4
do it for all of them, not just the writer one. A braver move. Change-Id: Ib1f635ccc6a70c1ef00f82449bd351c82da7a13d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#133043 explicitly set the combobox edit textCaolán McNamara1-4/+2
because earlier we set it to "" rather that set_active(-1) so its still at the same active pos with the wrong text so setting a new active pos that's the same as the old active pos is a nop from the vcl case the original code used Edit::SetText so leave the logic as it is traditionally rather than try to change that Change-Id: I520d1c0371579850d073d37295ccc7d852298aaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#129686: Revert "tdf#118776: pptx import: draw char noFill as transparent"Xisco Fauli4-28/+23
Revert it for now towards LibreOffice 7.0 and add unittest This reverts commit e01df3488abe6d319c6874ca870afb82a3ad9b1e. Change-Id: Ic6aba5948f9c6e55199def0476918fbd496321bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94704 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-22support rendering a widget snapshot to an OutputDeviceCaolán McNamara4-2/+51
Change-Id: I7beecd8f9579d5ae4b60a839f4a71c3238e0666d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22Resolves: tdf#133269 infinite regressCaolán McNamara1-1/+2
Change-Id: Iffd7306517ceca94eb6db5360c7d5069c8958acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94664 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22uitest: Add wait methods for slow elementsXisco Fauli6-24/+43
some elements take some time to be updated, specially with slow machines or ASan+UBSan builds Use the same time based approach used for launching the dialogs also reintroduce 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b Change-Id: Ia1cca74474ef65578bbc60a53a8a511402a082b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94648 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-22Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to abe8187060201a5e62844b53d3786c6b99070ec2 - tdf81599 Better Help pages for Calc Solvers Add information on algorithms paramenters Change-Id: I36f330593687efa616594e397cb7d6054c2198ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94703 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-22remove unnecessary polypolygon subdivideLuboš Luňák4-21/+0
As the comment already says, it's not necessary. And it is partially responsible for tdf#133016 by splitting an area into smaller parts, which then do not line up completely when AA-ed. Change-Id: If35e2118a0cd9c9b315b9666165c51659a9434e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94578 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-22smartart import: handle multiple <a:schemeClr> in <dgm:fillClrLst>Miklos Vajna10-29/+105
The TODO in the ColorFragmentHandler ctor was right: we only handled the last <a:schemeClr> child, but there can be multiple one. Use them based on the index of a shape in a <dgm:forEach> loop. Move the TODO to the only place which still assumes a single color in the color list. Change-Id: I1c5c4f82e621f1110ef06b0490ff79f82f60f214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94697 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-22Add source files from xmlsecurity/source/xmlsecTor Lillqvist1-0/+38
Change-Id: I173846f9073364ac5573744e9d03cdbef22a8c10
2020-05-22Add source files from desktop for breakpointing convenienceTor Lillqvist1-0/+98
Change-Id: If5bc137d95dd507fbf748b45c11d6b18094dc0ba
2020-05-22Drop useless functionsMike Kaganski2-7/+2
Change-Id: Icaa07529278f91bae61736ff4526ee84f994cfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94672 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-22Resolves: tdf#133189 values not updated when units changedCaolán McNamara1-0/+4
Change-Id: I7028974e9a916a630f5530c65952103ada702212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22tdf#50916 Fix keyboard shortcut for enabling very large spreadsheetsBartosz Kosiorek1-0/+1
Change-Id: I8783378c65067bb386ab5b45850ea0f74e735b2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94695 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2020-05-22Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 505d1059a09b83edd70fc8f441e87c203f62993c - tdf#132643 Translate German section IDs Change-Id: I0621b01895a7419fb73c45d604aaadd9d4cf9828 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94631 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-22Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 49dec51a6e288b8fc1428707b83c3746d7a44855 - tdf#132643 Translate German section IDs Change-Id: If39c27318f05e838a6b71edc192f7238ad4532fb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94632 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-22Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 739199319192c5869957267dbc5b8e7634e532b2 - tdf#132643 Translate German section IDs Change-Id: Id6e284793d770e59f2912199e6d7b1da2fff1bd4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94630 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-22Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to f3ff7c75c90975c352ac489226307a75b0cd261c - tdf#132643 Translate German section IDs Change-Id: I9bc82acfaee3f7d9fb5a28f8da757f3946ddffde Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94629 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-22Resolves: tdf#133183 select style under mouse on right click context menuCaolán McNamara2-4/+30
Change-Id: I4317f6702b7a0e172d059fe83614aab94845b201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22Resolves: tdf#133180 use full width of canvas for preview renderCaolán McNamara1-3/+4
Change-Id: I1fa3f0fd8505712155c72c25b67da1ab6d4753e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22PaintToDevice doesn't use its Size argumentCaolán McNamara4-5/+5
Change-Id: I45ce895ac67be9aaf137e0e4c79954488f23a6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-22Related: tdf#132536 drop FreetypeManager FreetypeFont cachingCaolán McNamara30-502/+112
the FreetypeFont only makes sense in the context of the FreetypeFontInstance it belongs to so remove the faux "garbage collection" and just have FreetypeFontInstance own the FreetypeFont and keep it simple. Setting a value low enough to make the garbage collection kick in just crasheed libreoffice by pulling FreetypeFont out from under living FreetypeFontInstance seeing as the Cache/Uncache was by the FreeTypeTextRenderImpl not the FreetypeFontInstance which had HarfBuff faces which continued to point to the removed FreetypeFont There is still a cache at the LogicalFontInstance level, so this aligns the libfreetype platforms with windows, mac etc. Change-Id: Iac669fae8dc1df81a5bc10d2943d84a2ff623180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara40-43/+50
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22convert properly SkiaSalBitmap to WinSalBitmap (tdf#133152)Luboš Luňák2-4/+16
The code didn't account for topdown bitmaps. Change-Id: Ia326834cfd6d2d022579fdde24828f7e0a8d8b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94643 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara48-135/+120
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22lok: MSForms: update callback's documentation.Tamás Zolnai1-1/+6
Change-Id: I1bf41986f63a18abada7d268dc610df24b4c1144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94661 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-22Dont show unnecesary buttons on mobile in wordcountSzymon Kłos1-2/+2
Change-Id: Id6c58f04d29945c23cdcca0c83bba0141ab87c86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94619 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94656 Tested-by: Jenkins Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-22Revert "Move messagedialog header to shared include"Szymon Kłos6-5/+5
This reverts commit 2c2af2ebf8b2bed78286df4b4ffcbac556223ca8. Change-Id: I287abf8fa7239e67d7764cd96a12ab77431b572e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94465 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-22tdf#41995: sxx: ODF export: save SVG to ODF 1.2 as wellMichael Stahl1-1/+2
... and SVM into ODF 1.2 Extended (compatibility mode). Change-Id: I2056ddac40570fdf69178349ff546cd313709b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94575 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-22[API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODFMichael Stahl9-71/+13
org.openoffice.Office.Common.Save.Document.SaveBackwardCompatibleODF was added in 2007 and apparently enables storing invalid ODF (or OOoXML) to workaround bugs in OOo <= 2.3; nobody should need it in this day and age, and the OOoXML export has been removed anyway. bce5e157785745a6729db62b15fb98bc396cddee 2007 c7a3859693971bf7103bfb0d05d64712e724fa37 2007 7477a65e09b20917adf025550c550f8822b508ee 2007 77baabe992c77018a0467ffec8f9482f8d76b66b 2007 575222083e058a740f5ad69e14e18622c3d4f7af 2007 66b908b45cde78af020b35e817e67bc40b8493f0 2007 Change-Id: Ib3f730c7c9ac6fbbbbae9fb4a42c1bd65f6c93df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94571 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-22Don't show styles frame in insert table in onlineSzymon Kłos3-1/+7
Change-Id: I2ee2daef028b49a409920c0fe83190575e7a82c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94639 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94657 Tested-by: Jenkins
2020-05-22xmloff: create XMLMetaExportOOO instances with an uno constructorMiklos Vajna5-26/+9
See tdf#74608 for motivation. Change-Id: Ie3bed67b736ea3a3c8071336594bcbe54c6618a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94651 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-22Colibre: tdf#133250 inconsisten colors iconsRizal Muttaqin14-6/+6
Change-Id: I2f362e0f0463d7201f0168f7d9a8bdd0c408ac61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94653 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-05-22writerfilter: pStyle no longer defines PROP_NUMBERING_STYLE_NAMEJustin Luth1-2/+0
This is legacy code. Previously, this could be added every time pStyle was defined. So a pStyle might have copied its numbering style-name to the paragraph before the numId was processed. But now the copying only runs at ::finishParagraph, so now nothing writes a PROP_NUMBERING_STYLE_NAME before numId is processed. Obsoleted by commit cc1c9c7484d97167021301f32c3397124c4d79f5 Introduced by commit e7ab4bb6b0e83f01148ffff41e8c5eaa0c5ba0a4 Change-Id: I6220106d16a531e61eadc8205f1d6b30db3af907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94594 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-05-21tweak to narrow stretchable widget defaultsCaolán McNamara2-1/+3
Change-Id: Idcaea1fbd9df0389e2182f1014e8d3ed45d1b2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21split out labelitemwindowCaolán McNamara7-45/+50
Change-Id: If5121b58538708a47783aee099bc426408989cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21uitest: sw: grab focus before using toggle button in navigatorXisco Fauli2-0/+7
otherwise the focus in on the document since ada385f1cba427416c1e8517cb6a45b61ceff7b0 Change-Id: Ia8300fdceb4f50f89c6d90f238483a4c785163d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94647 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-21Move messagedialog header to shared includeSzymon Kłos6-5/+5
Change-Id: Ice8d01d2bb62667667a4c5f0366120cdb7600472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94635 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-05-21fix image caching in Skia (tdf#133215)Luboš Luňák2-2/+9
The image size should be part of the key. Change-Id: I615e5d99ec347941fa06655b89902f3db84aef22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94634 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-21tdf#76481 speed up searching in autofilter pulldownNoel Grandin1-31/+29
turning setUpdateMode on/off fixes the common case, but we need to special case the "return to show all items" situation On my machine this takes the searching time from "more than 30s" to "just under 1s" Change-Id: I02d11c428e82dba1e840e981507337a1012dd09f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21FmXListBoxCell doesn't need to implement css::awt::XListBoxCaolán McNamara6-507/+42
FmXListBoxCell implements css::awt::XListBox but none of that functionality is needed locally where it is used to pick a value in a cell when edited interactively. As an XInterface a FmXListBoxCell does fall into the script::XEventAttacherManager attach/detach sink-hole so its very difficult to determine if it (and any of its siblings) really need to implement the amount of uno interfaces they actually implement, so this is a little speculative. See https://ask.libreoffice.org/en/question/152691/how-to-populate-combo-box-within-table-control-in-form/ for an example of the ComboBox interaction case which is similar to this ListBox case. The exotic "multiselection" option definitely isn't shown as an option in the property browser for a listbox column in the table control. Change-Id: I7bdc351e615c9df708a30e4396f6f352fabaed36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21sw XHTML export: properly write <li>...</li> around multiple paragraphsMiklos Vajna4-16/+69
Writer just has a list of text nodes, but ODF and HTML can have multiple paragraphs inside <li>, in case the non-first text nodes have their RES_PARATR_LIST_ISCOUNTED set to false. Improve b6f7a4908d1c3fc610440a1cbbbc1673a53da8b6 (sw XHTML export: properly write <li>...</li> around paragraphs, 2018-04-11) to make the decision around when to write </li> based on not only the current but also the next text node. This way we omit </li> for non-first paragraphs inside <li>, but keep writing it in other cases. Change-Id: I994855961aeea92050268dba5f19f125c7ad2b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94622 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-21use for-range on Sequence in testtools..xmloffNoel Grandin13-68/+62
Change-Id: I05b02a2f8b4b9091c7de0f7e98409d5b608ed250 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21Accept iOS 13.5 SDKTor Lillqvist1-2/+2
Change-Id: I78756c8f89536e9a462448a7dc21a69c76520f44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94613 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-21use for-range on Sequence in i18npool..sdNoel Grandin14-74/+63
Change-Id: I19eba57bc6058c317473d0746f06699a09ba2830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21tdf#132956 Chart view: fix missing plot areaBalazs Varga5-12/+38
Do not reduce the inside area of the chart depending on the size of the legend. Use the default legend size. Regression from commit: 739ed2c29f49ea5e83bcd1352b2644c2e2d09f7b (tdf#115630 tdf#88922 Chart: fix custom legend position and size) Change-Id: Ic191229d7ceab1f2689ab07424353108f8cb2b95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94059 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Tünde Tóth <tundeth@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-18 14:07:22 +0000