summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-03-20make: map slowcheck to gbuild's build and slowcheckMiklos Vajna1-1/+1
This is meant to to fix the Jenkins Windows/macOS buildbots after they started to run 'make unitcheck slowcheck'. (cherry picked from commit 4054a30e2b2fa254dfb20718ce757ceb2f638fd5) Change-Id: I128448ca3a190969c0cc0f02d2c27bc0a373129b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90793 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-20tdf#130208 use TableCellBackgroundColor instead of BackgroundColorandreas kainz4-5/+5
Change-Id: I2f1d5fdf976f9e787d64098a091022182156e401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90408 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 2a5dfda892ca444eca2a0fcba2b28b9c9fd2915e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90403 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-19Adapt o3tl::span to removal of std::span::cbegin et alStephan Bergmann2-13/+0
<https://cplusplus.github.io/LWG/issue3320> "span::cbegin/cend methods produce different results than std::[ranges::]cbegin/cend", as implemented now in <https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commit; h=247f410b83797a1840573840cc2a539ef9d7f96b> "libstdc++: Remove std::span::cbegin and std::span::cend (LWG 3320)". Turns out we only used the removed member functions in o3tl/qa/test-span.cxx. Change-Id: I6c73797594b4e0e753a88840033d54961e271df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89261 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 6fbfad6b00e8c35346ee59cd32a0d7ccc0d8c19c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90634 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-18tdf#131118 VML import: fix size of non-autosize shapes containing textMiklos Vajna3-3/+21
Regression from commit b92293b3943423324064a8513c2e114d18817179 (tdf#103983 VML import: handle <v:textbox style="mso-fit-shape-to-text:t">, 2020-01-20), the problem was that in case we disable autosize too late, then the size will be already set during adding text to the shape. Do it before adding text, this way adding text won't change the shape size, so it'll be correct at the end of the import. (cherry picked from commit 4ee7ee1c4a515479bc174543af4dbc400035c0ba) Change-Id: I9410fc695c3edfa5089d845864bf237e71c533c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90602 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-18Update git submodulesAndras Timar1-0/+0
* Update dictionaries from branch 'libreoffice-6-4' to 390a74603cd452dc35b34bc956927d519953bcab - tdf#130999 fix registration of Greek dictionary Change-Id: I7b85d588c67c9b05f3856d92544fb0a0348594ea Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/90626 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-18tdf#131069 always produce utf-8 from gettextCaolán McNamara1-0/+3
Change-Id: I311e647f08b4d541825e7790d971b98b5b5bfe40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90631 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#128281 Increase a checkbox height in Windows installerRoman Kuznetsov1-2/+2
Change-Id: Ic0bc2af1dd565dc9c24a74de8900da771f052a95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e6d008f131c7ca532a9e8410b424b3323d581978) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90404 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#131337: fix range for "Surface angle" (tab "Shading" in "3D Effects")Julien Nabet1-2/+2
Should be to 90° max instead of 1000° Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=11d0c28601dc89c48e67a7b39ba82dd52e660334 author Caolán McNamara <caolanm@redhat.com> 2014-12-28 16:30:18 +0000 committer Caolán McNamara <caolanm@redhat.com> 2014-12-30 15:43:39 +0000 commit 11d0c28601dc89c48e67a7b39ba82dd52e660334 (patch) tree 75e0e9d83694637de1e3b95a25c66de911d381bc parent 04299dba24d04b08d54f4f5945d340d7abfa73e4 (diff) convert RID_SVXFLOAT_3D docking window to .ui This is an epic dialog with lots of moving parts Change-Id: I867723f65273bf46b0693910d88e11a9197384c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90397 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-17tdf#125520 create a persist correctly for OLEArmin Le Grand2-1/+25
If the D&D-Start described as in the task is an OLE object we need to create a Persist-object to copy the included EmbeddedObjectContainer Change-Id: Ib8b9677bbc3e6c5b3895abc55e6da5b0a96e33d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90263 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90336
2020-03-17Set Firebird creation option experimentalJulien Nabet1-0/+6
See: http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-Firebird-creation-option-experimental-tt4274028.html http://document-foundation-mail-archive.969070.n3.nabble.com/ESC-meeting-minutes-2020-02-20-tt4274082.html for rationale Change-Id: I73d1563575252ebbcfb764753294bceb29e9bf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit dc3c6e64650f0347648598dae0fa67c296ad36f5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89132 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-17tdf#131076 allow 'return' in GtkComboBox to activate default widgetCaolán McNamara1-2/+28
typically ok and accept the dialog. alt+down is documented as the default menu-activate key binding, space will also work to popup the menu from a combobox. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7a078207fbfd71b33cb51c38b3886351fedcde8d) Change-Id: I7bec880670cc006b288996d6f59a88fe9a9fb8cc tdf#131223 let return deactive active popup Change-Id: Ib116a1eb047aa9f1a5ca7a2ec9333a793addd304 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0d81a613ef5af22253e51d9917c5d5c94d764456) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90381 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17Resolves: tdf#126366 revert use of SfxDispatcher::LockCaolán McNamara1-21/+0
Revert "tdf#121607 defer other requests until password dialog is dismissed" This reverts commit 205aeffda1a29865576fb865f23dfb6761ebfab1 as far as I can see the original problem doesn't reappear anyway Change-Id: If5fd3383f3473662bc87a367fad2c1febe1c6a23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90388 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17mysterious greyed out native toggle buttons when in foregroundCaolán McNamara1-0/+5
and flipping to normal mode when in background. Change-Id: I100efb651515b044d56a8c3838569cf717b37d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90279 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-17tdf#130150 Improve clipping in PDF exportArmin.Le.Grand (CIB)4-33/+100
For more info and discusson please have a look at the task. It reverts the change from tdf#99680 which did a wrong paradigm change in how clip in Region(s) is defined and tries to fix the underlying error in a more correct way. This includes problems noted in tdf#44388 and tdf#113449. This is a decent improvement, but - due to dealing with numerical problems - not yet the whole healing. Still thinking about how to solve this for good. Adapted PdfExportTest::testTdf99680() and PdfExportTest::testTdf99680_2() as needed, empty clip regions are allowed again. Added comments, too. Had to change solvePolygonOperationAnd to work on ranges if both inputs *are* ranges. The AND-case is then completely solvable. Also increased geometry for transformations of clip geometries - may help later. Change-Id: I2370447597faa6efb81d58ee31c63654e304262e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89874 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 6dff631f8f4b964b48aadde52a1e1b8b04b9ba53) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89923 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-16tdf#126742 Don't change visible area while retrieving itSamuel Mehrbrodt1-2/+0
This leads to funny size changes in embedded calc docs Change-Id: I2c4a0fbebb782faae7508e7d61c8da9d440a5916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90247 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit c185263f45a556e6c695c766476e67fbd2ea3593) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90386 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-16Resolves: tdf#129985 OOXML import: do not force a fixed-locale number formatEike Rathke1-1/+1
... instead of system locale. Change-Id: Ie7b4c6a560468f142df6916f50bfda9daaf7c379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5b88a664b1ad2b5761a4672678845cc77be6cd4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90399 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#131291: Add UItestXisco Fauli2-0/+75
Change-Id: I65aede1899d2c509fd52f8db0657ec3a5791f681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90430 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90390
2020-03-12tdf#131185 Prevent unnecessary SwapIn calls.Gülşah Köse2-3/+9
When the http response is 404 or something like that we shouldn't retry the download embeded image constantly. This causes libreoffice to short freezes. Change-Id: I7381d04f12e9fbea961dd0e3333ea0d39aa93d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90102 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90045 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-11update creditsChristian Lohmaier1-1352/+1402
Change-Id: I90fba19d96f0fce6ca0e63c83e6dd45087f81c0a (cherry picked from commit 1a3d18ecaabec6f7b8f0f615df2222a6687d2224)
2020-03-11tdf#130986 Chart OOXML export: fix number format of custom labelBalazs Varga3-6/+20
Export correct sourceLinked attribute in c:dLbls/c:dLbl/c:numFmt, as in c:dLbls/c:numFmt. Change-Id: I0e52720b3cb2c99550a779763f01ba12f762050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89638 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89947 Tested-by: Jenkins
2020-03-11Resolves: tdf#130400 reserve ctrl+page_up and ctrl+page_down for notebooksCaolán McNamara1-0/+29
Change-Id: I627298cb844967eeb1e166720e3951be732a4dc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89016 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89481 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-11tdf#131184 Allow comparing text ranges in table with body textSamuel Mehrbrodt3-4/+29
Change-Id: I191d8778d362cd28474eea6d18bfe40044887e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90038 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-11Resolves: tdf#131248 a11y crash when closing SQL Edit QueryCaolán McNamara1-0/+3
Change-Id: I39db7b352dd460f46092a054bfa89f5acdda54c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90273 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-11Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-4' to 27997432892d8cb1f8f8226194d0a637851ad13d - update translations for 6.4.2 rc2 and force-fix errors using pocheck Change-Id: I0462e8a1db3c2d1df87ac6eaec555f91b4e680c1
2020-03-11tdf#131088 Automatic Control Focus not workingNoel Grandin1-1/+1
regression from commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: Id0dd46c3d40f8acab980147c4c7f64911bc30d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 17c467a66d799bda88d6cdb84b7fecbbd7d1fdf5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90276
2020-03-11tdf#131146 Linked Calc: changes are lost in last edited cellSerge Krot1-2/+4
Change-Id: I768ccc1d98a0785806986a6ffc70de057991e08a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90009 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit a91e19e30833c2743c1c2ce010a2d0f06aad7706) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90039
2020-03-10sw: DOCX export: fix bookmark inside sdtDropDownMichael Stahl3-2/+24
Word refuses to open a document that has a w:bookmarkEnd inside w:sdtContent but with no text content following it. It turns out that the bookmark position is wrong anyway, it should end before the text according to Writer's model. It shouldn't make a difference whether the end is inside the sdtContent or preceding the SDT, so write the text content of the SDT from the EndField_Impl(). Another idea would be to move the writing of bookmarks in EndRun() before the StartField_Impl() but who knows what that would break. (regression from d55b26a093bdbced08985dbc7113190b52a8bc66) Change-Id: I476c0829814b061d80811cc6817923ee06013a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90100 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 1f5af453b5994c9e8ccd0756882b98715c75114b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90030 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-10tdf#128880 sw btlr: fix SwFrame::GetPaintArea() for the row span caseMiklos Vajna6-8/+42
To be specific, this focuses on the case where a single cell has btlr direction, but the containing row does not, and there is a row span. The old code that took the logical right of the cell frame served two purposes, it seems to me: - in the rare case where the 1st row is wider then a subsequent row, we make sure that as the cell frame is expanded downwards, we're still inside the table polygon - in the tb-rl ("Japanese") case, the logical right maps to physical bottom, and this way the cell frame is OK to render not only into its own row frame, but can expand also downwards. Given that btlr maps left to bottom, this mechanism is broken there. Be consistent with the working tbrl case, so just expand towards the logical left in the btlr case. The rest of the changes just make sure that SwAttrHandler::FontChg() calls SwFont::SetVertical() with the correct bVertLayoutLRBT parameter, which instantly fixes the actual position of the text. (cherry picked from commit 74f0105a2c140d078932576b457a327f3d2490a6) Conflicts: sw/qa/core/layout/layout.cxx Change-Id: I9032e7c6de72cec704843f3aae3c7848e139ebfa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90251 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-10tdf#131208 Don't try to set cursor focus after style applyJim Raykowski1-1/+1
It seems after a style is applied, the outliner view pointer points to an OutlinerView that has been removed. This results in a crash when trying to access OutlinerView functions to set cursor focus to the document. Avoid this by checking if a style has just been applied. Change-Id: Idda11567506fcc60a830dce70b86e12e2079c7a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90198 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit b39c08773db9bea776001c6ccf043684c2dfe08d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90266 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10Delete google_breakpad::ExceptionHandler before calling _exit()Mike Kaganski4-63/+54
While debugging tdf#129712 on Windows, I saw this sequence: 1. nullptr was dereferenced (the reason for tdf#129712). 2. ExceptionHandler::HandleException was called (in workdir/UnpackedTarball/breakpad/src/client/windows/handler/exception_handler.cc). 3. It called ExceptionHandler::WriteMinidumpOnHandlerThread. 4. Minidump was created in ExceptionHandler::ExceptionHandlerThreadMain. 5. Document Recovery dialog was shown in Desktop::Exception (in desktop/source/app/app.cxx). 6. After closing dialog, _exit() was called in Desktop::Exception. 7. All threads except main were terminated. 8. Another access violation was thrown in the "minimal CRT cleanup". 9. ExceptionHandler::HandleException called again. 10. ExceptionHandler::WriteMinidumpOnHandlerThread hung on WaitForSingleObject because handler thread that should release the semaphore was terminated already at step 7. The process had to be killed manually. This change destroys the breakpad handler at the start of Desktop::Exception, which de-registers itself (on Windows it uses SetUnhandledExceptionFilter). Other than preventing the hang, the rationale also is that keeping the handler after first minidump creation is wrong: even if the second minidump creation succeeded, uploading it to crashdump server would give not the actual problem, but some unrelated stack. Change-Id: If12d0c7db519693f733b5ab3b8a288cef800a149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86104 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 12b5892cf9c78dd917f2e50672cd250478e6c7d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89861 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-10tdf#93831 xlsx file full of pictures of numbers slow to openNoel Grandin1-0/+9
Change-Id: I6c984c84c409519a986eacb265c943307a7b57af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90245 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit edf13fe1247e7ef411a9ff5435385573fad01f56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90044
2020-03-10tdf#131060 tdf#117088 chart view: fix missing or truncated axis labelsBalazs Varga3-11/+52
if we have enough space under the horizontal X axis. Note: allow truncation of vertical X axis labels only if they are text labels and the position is NEAR_AXIS or OUTSIDE_START. Regressions from commit 35d062f7879d5414334643cb90bff411726b2168 (tdf#116163: Limit label height in chart if needed) and commit 26caf1bc59c81704f11225e3e431e412deb8c475 (tdf#114179: Custom size and position of the chart wall) Change-Id: Idf86bc2b5482bb50a266cda57cc502621c2e08ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89829 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 7c300296dd727990455449b19b111b9fc49eadad) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90043 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10sw: DOCX export: fix first-line indent of list itemsMichael Stahl3-2/+442
The problem is that since CVS import, if a SwTextNode has a first-line indent and is in a list or outline that has LABEL_WIDTH_AND_POSITION mode, then MSWordExportBase::OutputTextNode() will throw away the node's first-line indent and overwrite it with the numbering's. Experiments indicate that adding the numbering's value to the node's value fixes most cases, but RTL still doesn't work in many cases. Change-Id: I9707f475dac4e501642ebaf51c0117107fd34a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89634 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 74e3c95b9b628a0b326790b62b4e378a12d02997) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89642 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-10crash after master document navigator updateCaolán McNamara1-4/+7
master document navigator will otherwise crash on using update selection/all/etc if there is no tooltip requested (which does a "hard" update) before user uses the up/down buttons to move the areas around Change-Id: I913df2d0922fbabdf3409a25c30b4cce6113dc8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90028 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-10tdf#131212: Implement change user password in FirebirdJulien Nabet3-6/+16
Command retrieved from https://firebirdsql.org/refdocs/langrefupd25-security-sql-user-mgmt.html Change-Id: Idd16c74cd3b00f8a5c9cc135e11ac032811557f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90182
2020-03-09failure seen as setting length of -1 and returning nullCaolán McNamara1-2/+6
Change-Id: I84e7b3a4ad63e70499910f09bd4c70a43137fa10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90103 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit beabc0deddce2a5ce0a9f9b20316a7798a08318c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90031 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-08tdf#131217: position arg in Blob::getBytes begins at 1 not 0 (Firebird)Julien Nabet1-2/+2
See part of bt here: https://bugs.documentfoundation.org/show_bug.cgi?id=131217#c5 According to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=38ce989b4f9d2aead097e5a2e95b819def7e2624 position can't be 0 Change-Id: Ia7bf973b820b8642b45eb0bbc125011cab99de9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90186 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit bb51f81507a405266d251297684bd3ab60998197) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90036 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-03-08tdf#131210: avoid infinite loop in 'Date acceptance patterns'Julien Nabet1-0/+2
Change-Id: Ib049b5d44f91e2b36c068e1ef351ae81707d885e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-08tdf#131137: Fix Checkbox "Do not distort objects in curve" does nothingJulien Nabet3-7/+11
includes too: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9e8839c934da9744b8f584debc0ad026e49f4a28 which was just an oops. See https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c3 and above all https://bugs.documentfoundation.org/show_bug.cgi?id=131137#c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90054 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 6d9930f307f08d2c32ee1bcca577cf643955cec9) Change-Id: Ibd38d13be7ef6956d6c26e6f5f71a6751a56b25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90029 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-07tdf#131164: Fix crash on Tools>User Administration (Firebird)Julien Nabet1-2/+2
see https://bugs.documentfoundation.org/show_bug.cgi?id=131164#c8 Change-Id: If55a7b015e4e14575c3933a98c70ed4aaf4d7c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90123 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit dada19a89cbdc5f089fe1200275a1688a1ff1967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90032 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-06tdf#129096: Document Recovery: Use TypeDetection on loadVasily Melenchuk1-0/+32
Loading of recovered document happend before via XFilter::filter is not updating media descriptor of document. But this is important for password protected documents to store entered password and used encryption type. To avoid this problem let's use TypeDetection which during its work will ask user for password and store all the info in modified media descriptor before actual recovery attempt. Change-Id: Ide2ebf0955e0937cdc7c9d7165593b71f904649b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88844 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins (cherry picked from commit 8461127750e1fe92a615409505256132e54fb8e8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89788 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2020-03-06tdf#131000 fix stuck combo box property editorJan-Marek Glogowski2-3/+2
If you create a combo box control with a lot of entries, like a large cell range in Calc, LO will take a long time to render that cell content into the small, line-height MultiLineEdit (MLE). This doesn't happen for master, because it contains commit 1efeb17837c22499f00299c033ae59ba3910f7d7 ("weld Property Browser"), which changed the whole dialog and is much too large for a backport. A debugger shows LO is stuck in TextEngine:: CreateLines, which is part of the MLE resize call stack. Checking the master patch, it also replaces the MLE with a mere Edit. And since editing now always happens in the popup, no functionality is lost. So this patch just does just that MLE => Edit replacement for old releases. This results in a much faster visible / usable property editor. For the attached test document with 4000 entries, resize time goes down to 5s instead of minutes. Fun fact: since you can't actually edit that entry in the example bug document, because its content depends on Cell data, all the "work" is basically mood. Change-Id: I7583e0ed1a70765c9f3bd7ff730e920a833bf30b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89417 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-05tdf#129796 junk in reference edit boxNoel Grandin1-1/+1
regression from commit ebdf70cc68989d209965768edc8a3bdf27543c48 Date: Fri Sep 20 15:18:01 2019 +0200 convert SwFieldTypesEnum to scoped enum Change-Id: Ifec7eb3bb3570f277aed365dcf38da477e437fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0c225c7c2b47d7ec57ab7f3f2a900aaac78031d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90026
2020-03-04Resolves tdf#127782 - New Print dialog is too highHeiko Tietze1-2/+2
Amends Iea41f9cf335b75210de0acf5688fddd5e3dd3dbb Change-Id: Ic669332245ad9c5ee6366765da8a5bc632dd159c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89423 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit b268715912d4c2034b9b9d38e75446bef7bbb11f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89921
2020-03-04tdf#130680 sw_redlinehide: fix crash in SwUndoDeleteMichael Stahl1-7/+18
The problem is that the code that adjusts pLastNode in SwContentNode::DelFrames() assumes that the nodes are deleted forward but MoveNode() runs backward so the only solution is to put pLastNode temporarily onto some node without checking if it has been fully deleted, while skipping over tables and sections. At the end of MoveNode() it must be on a valid (not fully deleted) node again. (regression from b86ff2c6a88aa41379e74f11e8ec8497ff85ffd0) Change-Id: If54c01f885e0c040aed9068823deae7dd167fd50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89896 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 4769f431d93139eb3c470e5bb4e7c3c33d46a41f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89910 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-04tdf#126904 calc right arrow large unexpected column jump in protected sheetNoel Grandin1-1/+2
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3b6f6e5430c97ef52f63c406eb3c3b39b9dd578e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7ae33e175007d04021f5e911e3f7f6cbd0966804) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89914 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-04tdf#123873 DOCX IMPORT: fix unhandled textwrap for objectsBakos Attila3-0/+12
The OLE objects (in this case charts) had bad wrap option setting and this lead to misplaced objects. Now this parameter is set according to the file. Change-Id: I506be91b6801f0ffc3942e514f81119d895fdcb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88091 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit affe9c8384475fc85027703332bc0f1b36eaa0a6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89908 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-04tdf#84399 VML import: map <v:shape o:spt="202"> to TextShapeMiklos Vajna7-1/+53
This partially reverts commit 81f9fe3a14f0fc99afbfa7ce3a26a9c7855d0919 (fdo#74401 VML groupshape import: only handle v:rect as TextShape, 2014-03-19), which wanted to map triangles to custom shapes. It was overlooked that we can have not only explicit rectangles and custom shapes, but also <v:shape> elements which have their shape type explicitly set to TextBox. The later is now again handled similar to rectangles. This keeps the triangle case working, but fixes the <v:shape o:spt="202"> case. We need to make this decision while parsing the XML, so some rework is needed to have earlier access to its container (group shape or draw page) and also to its shape type. (cherry picked from commit 198685ded79d64b21023ee85e9a15fa1b32705a0) Conflicts: include/oox/vml/vmlshapecontainer.hxx Change-Id: I33a4b3cd03b0df5d93cffa19e7ea834113df2bdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89876 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-04Qt5 unify font attribute conversionsJan-Marek Glogowski4-113/+144
Adds conversion functions for VCLs FontWeight, FontWidth and FontItalic to Qt5FontFace and remove the partial "switch" tables from KF5SalFrame. And correctly handle the FontWidth in Qt5Font as the stretch value, so the default font in qt5 gets the correct stretch and doesn't look bold. Also contains commit b9a124aae67cbd64917f07f2dca6603f149c018b ("Qt5 just ignore invalid font attributes"). This ignores the *_DONTKNOW and _FORCE_EQUAL_SIZE values, except for the stretch, where we map DONTKNOW to QFont::AnyStretch. Change-Id: I698986416dff13e6dfaf9dfa7f95851b89e9137d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89813 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 63ea1e811a3b3806b6b2408d759a449f4e086eb3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89797 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-03tdf#101710 Fix invalid style:data-style-name attributeMaxim Monastirsky12-80/+177
There were two problems with this attribute: 1. It was written in style:table-cell-properties instead of in style:style. 2. It was referencing a number format id, instead of a style name. Moreover, the data style wasn't even exported as part of office:styles (if at all). Both import and export were affected. For export, it was easily possible to reuse some related stuff from Calc, so that stuff was moved into xmloff and used from there (there are no logic changes for Calc). For import, loading of the invalid attribute was kept for compat reasons. Although it's only useful for automatic number formats, as the data styles weren't exported properly anyway (e.g. see the document attached in bugzilla). Conflicts: sw/qa/extras/odfexport/odfexport.cxx sw/source/filter/xml/xmlfmt.cxx xmloff/source/table/XMLTableExport.cxx Change-Id: I8b70ad205972fada6f3845837d6ed5928d7d6406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89551 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 59ace23c367f83491a37e844d16f7d716eff6346) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89774
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-19 15:17:40 +0000