summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-02-20Version 6.4.1.2, tag libreoffice-6.4.1.2libreoffice-6.4.1.2Christian Lohmaier3-0/+0
2020-02-20bump product version to 6.4.1.2Christian Lohmaier1-1/+1
Change-Id: I6e958cb853a3fbc9ef76d8c90638132b71792175
2020-02-20tdf#130187: Don't crash on exiting print preview with NotebookbarMike Kaganski5-26/+36
Crash caused by this sequence (tested in Writer): 1. Closing print preview, frame is attached to controller; 2. This calls SfxNotebookBar::StateMethod 3. There notebookbar's listener is added to list of the controller's context change event listeners 4. Then in SwPagePreview::~SwPagePreview, notebookbar's listener is added to that list again 5. ContextChangeEventMultiplexer::addContextChangeEventListener detects second addition, and throws an unhandled exception. I don't know why starting listening is needed in SwPagePreview dtor; unfortunately commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd doesn't say much about context and reasons. ControlListener is renamed to ControlListenerForCurrentController to emphasize that it operates on the current controller of notebookbar's frame; and its bListen parameter meaning was reverted: previously its "true" value awkwardly meant "stop listening". All direct operations with listener of notebookbar are replaced with calls to notebookbar's methods. In ContextChangeEventMultiplexer::addContextChangeEventListener, uno::UNO_QUERY_THROW was replaced with uno::UNO_QUERY, because not only chart controller may appear here, and it's not an error: e.g. SfxBaseController doesn't implement lang::XServiceInfo. Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd. Change-Id: Ief1aed188d8f02a6cfe3ea25f4d082dfdf449f32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87582 (cherry picked from commit fb2382ad4f33b885650ad5156ccaec4e90661806) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-20update creditsChristian Lohmaier1-1629/+1663
Change-Id: I35d24b2ace80622fc81935039a833121f1da2795 (cherry picked from commit be3de666fd452e5c9d61411ecd9d4815a99419b3) (cherry picked from commit 2efa404bcbcf472627fd198db8e341836229659f)
2020-02-20Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-4-1' to e0ab576083bd57c682b7a4dab7865f9ded9864a3 - another update of translations for 6.4.1 rc2 Change-Id: I3be9f0c9e9dcb3d45e0900ab788aebc542b72a92 (cherry picked from commit 862fedc0284368cd404a9157d20dda48f09f21f2)
2020-02-20tdf#130482 sw: fix text alignment in shape textMiklos Vajna3-12/+61
Regression from commit a3c7a8282ddd08c7ed4a15d23089d09e418f8fae (jsdialogs: apply .uno:Color and CharBackColor to floating text frames, 2019-11-08), the problem was that the original code populated aNewAttr, while SetAttrToMarked() was only invoked in case there were arguments. Fix this by making pNewAttrs a copy, so lcl_convertStringArguments() can work on it in place, and then restore the old code that copied from pNewAttrs to aNewAttr. This fixes the no-arguments case and keeps the lcl_convertStringArguments() case working. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88227 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit b03504bf054bd4094b985ef8ebb9ac55fa69a487) Change-Id: If7bf2d7b21e48d513a512ec6127b61ee74635ef5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88296 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 942c0d71a91839fc1762c7e93417e7bb703ea3cf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88303 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-20tdf#130362 sw: fix anchoring of inline math objectsMiklos Vajna8-5/+151
Regression from a7528cd6f17ea5c5b29e7d607e54c62de0d9e7db (sw: insert image: set anchor to at-char by default, 2019-11-18), that defaulted to at-char anchoring for charts and images. What was not considered is that math objects had a previous as-char default (not to-para), and that is supposed to be unchanged. (cherry picked from commit a2f85c062aafb3fd9dfb1c6c6e87e1e73e7545a3) Change-Id: I2a91af6425035b48a0e47ad9b10939945855cd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87997 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 282cf1507d51573e5e9a4611b1e775b433168ca7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88228 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-19Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara1-1/+4
Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88689 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19tdf#130404 python3: add new windows .pyd modules for 3.7Michael Stahl1-0/+3
Unfortunately forgot that in b10be5d48433076f0b7238d818020f708553e114 Change-Id: I59043a576c45f9329a3fad9a5d50e7fefa901934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88977 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit e62b9937ed33388055560ca0710990742b530aec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88950 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit fc464ae2441a17f465682420d969ae59d24eacc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88951 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-19Resolves: tdf#130593 set correct range for spinbuttonCaolán McNamara1-2/+2
Change-Id: I6691f2709aa4053798fcc1744f9f41c3c3866a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88496 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit d021827a277c08053d11b7319f9b6180b4988684) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88695 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-19Resolves: tdf#130486 setting distributed results that justified cannot be setCaolán McNamara1-4/+9
Change-Id: If80c935b7e33b5c7146eb562daf2303688160653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88274 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 818598e609ad9160af52ae8b02d772ca29f9ad7b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88396 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-19tdf#130462 call SetMinOutputSizePixel before SetOutputSizePixelCaolán McNamara1-1/+1
Change-Id: I04716e91b7c9b5f1e9db1fd175f5dcbe0600bf1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88116 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit c852f0e4ac4cee2a1b69ff8b1c5cab6633664098) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88237 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-18Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-4-1' to 5c5a417c8f0d5778c8e2cdbc8fbb655e53c42aea - update translations for 6.4.1 rc2 and force-fix errors using pocheck Change-Id: I01b679e2a76c170a7f07a619cb0623cd170034fc (cherry picked from commit bf63f313ef100e20d4c7e1f74ea90fc8f9b6387e)
2020-02-18Update git submodulesAndras Timar1-0/+0
* Update translations from branch 'libreoffice-6-4-1' to b2a25de35fc4bb132dd450362e39184d8b4d1afe - Updated Slovenian translation Change-Id: I3238c05476a9930a43361d886a56cfc82bbda757
2020-02-18tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'"Xisco Faulí1-11/+2
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371. Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 09e6824bc868990095233825c415556399dd0652) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88500 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88502 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-17tdf#122218: Hack to avoid blurry text with macOS SDK 10.15Stephan Bergmann3-0/+26
...by setting the LC_VERSION_MIN_MACOSX load command's sdk value to n/a in the soffice executable. See <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c167> for how this helps, even though I have no idea why it helps. (Adding that -platform_version linker option appears to generate warnings like > ld: warning: passed two min versions (10.13.0, 10.13) for platform macOS. Using 10.13. but which are probably harmless.) (cherry picked from commit 645fe53be0dc36535dba0ed684e21ca4cda80d70) Plus cherry-pick of follow-up b7fd89100d8653dc73955780358fe31d38b68ebf "tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_version" (and resolving the merge conflict in desktop/Executable_soffice_bin.mk). Change-Id: I043498c7ff2d148d4a7e1e0e9d46241b638f2eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88697 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-17tdf#130373 substitute color only works if left set to transparent.Noel Grandin1-0/+4
regression from commit e27be9dfbcf8636a7440f828435b1860dfa38977 Date: Wed Jul 3 15:07:44 2019 +0200 move some Bitmap replace logic inside vcl Change-Id: I0d985314367e26134c940e54f485db373d4c3642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 407c45d54c189d5e9488e868e503f02955825b82) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88696 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit ed9bee5429294833476685b66f3e662ae27809b0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88700 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-17tdf#130623 owner of FieldControl needs to set its allocationCaolán McNamara2-1/+30
which works fine automatically when its in a dialog (copy table) but not automatically when hosted inside the design view this will make the gen case work in master, and the gen and gtk case work in 6-4 Change-Id: I530cfa0a7e1f5b62c6812ffde255c1edf478930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 96018929add55cff71a036be3a67df385b023471) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88694 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-16tdf#130440 only select first page fallback if seting to current page failedCaolán McNamara3-13/+12
Change-Id: Iee4f9cef9659837e9ce131e3bfc8da3e8d87bf84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88388 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 4abdcf7c73d16f6fee28dd0502f06a8385ebf019) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88505 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-16tdf#130640: Revert "tdf#124983 In calc make printable page...Xisco Fauli1-23/+0
...borders also initially visible" This reverts commit caeb7b141280a65e60525f11a7e6514b76e12e11. Change-Id: I691934db79982c16bf0f43e7e38b00f3ab440a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88616 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit c4281cb41e6b76cabd5fe42fc707877e864dfb82) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88646 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b3e302b98dd7b992b7aa5a7f6756980d3edafc83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88692 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-12tdf#130555: Prevent negative aSelection.Min()Stephan Bergmann1-2/+7
...which would violate the the preconditions of the later call to maText.remove. When BreakIteratorImpl::previousWord (i18npool/source/breakiterator/breakiteratorImpl.cxx) is called to e.g. move back over a single space at the start of the text, at least for an en-US locale it will fall through to the call to BreakIterator_Unicode::previousWord (i18npool/source/breakiterator/breakiterator_unicode.cxx) at the bottom of the function. That in turn calls icu::BreakIterator::preceding, which is documented (workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) to return icu::BreakIterator::DONE (i.e., -1, see workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) in that case, which causes BreakIterator_Unicode::previousWord to return a Boundary with startPos == endPos == -1. The documentation of UNO method css.i18n.XBreakIterator::previousWord (offapi/com/sun/star/i18n/XBreakIterator.idl) is silent about the expected return value in such a case. But lets assume that returning such a [-1..-1] Boundary is as intended, and locally address this case in Edit::ImplDelete, making aSelection start at the start of the text. Change-Id: I40e17ba602088e72aa6962cb41dd8e1cdf6e2561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88431 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8f26dc13b65b1a05d948d9c95110c86315e8f20) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88402 (cherry picked from commit d84eaea950f276e7ba0d155cdbed056bcc815255) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88490 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-11crash in manage languages in basic ideCaolán McNamara1-0/+6
when there is more than one language, there needs to be two separate columns with a renderer each, not one column with two renderers Change-Id: Id4f2c9938fd3bd0aa3e006166df6081d57ef57df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88223 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 68072f4c0abbcfefcde930b779eb7703f5c91eb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88286 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11update creditsChristian Lohmaier1-1890/+2199
Change-Id: I21a49cb649ebdc6b8af50f0b92decb77887e721c (cherry picked from commit 52ee72a0e5ea6e590a98d3388e1cf12fa75583b6) (cherry picked from commit e22cb7f9bb04be8eab38f50ae4169d8f511ceb15)
2020-02-11tdf#129912 correctly stop unstyled footnote parsingJan-Marek Glogowski4-1/+43
The bug document somehow manages to generated a footnote, which never terminates the format loop in SwTextFrame::Format_. It contains an unstyled footnote, which I wasn't able to reproduce to create in Word. So I manually edited the XML of the included unit test document, which I used to develop the original patch, and which reproduces the broken parsing behaviour. This patch correctly stops the parsing of the custom footnote reference, if the text run containing the footnote reference is finished, which also fixes loading the bug document. The unit test checks various footnote variants, which represent different problems I found when developing the custom footnote parsing in commit a991ad93dcd6807d0eacd11a50c2ae43a2cfb882 ("tdf#121441 improve DOCX footnote import") and now also includes an unstyled one. It also contains a (still?) broken footnote test, with a complex differing footnote. Change-Id: I748955285d76b6f3122d1da5d8823068f3d7633f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87981 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 7d886eec953efa593708db9560d0e69ac12c99cf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87993 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit a4567fb085ae313f514d2001b9e52499c9887a56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88304 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-11Resolves: tdf#130484 controls become disabled on click final checkboxesCaolán McNamara1-2/+0
they always triggered disabled the current state in the roadmap, but disabling a roadmap step now really disables the associated window in vcl. These two particular toggles don't actually affect the current roadmap state, so don't call state-modified when changing them. That doesn't change the ye-old weird case that the logical state of this final step is disabled, but don't let the wizard find that out when toggling radiobuttons that don't contribute to the roadmap state Change-Id: I5927d20ea461a294e76014892c90ad0b5f39fb6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88281 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 1fbf3a70dbbbab2f810afae5f3e928a6d59c6325) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88297 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-11Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara1-1/+1
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88048 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 5cbaec2ffd289f6b3e1dce15c00d5b1d3c2f815e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88234 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07tdf#130080 soffice.sh: Avoid exporting empty LC_ALLMichael Weghorn1-2/+6
The previous way of doing LO_SAVE_LC_ALL="$LC_ALL" LC_ALL=C export LC_ALL # ... (call some tools,...) LC_ALL="$LO_SAVE_LC_ALL" resulted in the LC_ALL environment variable explicity being set to an empty string in case it was not set at all previously. For some reason, an LC_ALL explicitly set to an empty string (other than an unset LC_ALL) makes the system ICU on various Linux distributions assume an "US-ASCII" encoding, even if the locale is otherwise configured to be a UTF-8 one. Since the corresponding detection from ICU is used in the KF5/Qt stack, that resulted in the Plasma-native file picker assuming an ASCII-encoding, and thus having problems with files containing non-ASCII characters. To avoid this, don't export LC_ALL if unset or set to an empty string. A big thanks to frinring on IRC #kde-devel for the analysis of why the Plasma-native file picker is affected by LC_ALL being set to an empty string! I could also reproduce that the following sample program run with 'LC_ALL=' on KDE Neon Developer edition printed "US-ASCII" when using the system ICU, while it printed "UTF-8" when using a self-built ICU as of current master (commit d6b88d49e3be7096baf3828776c2b482a8ed1780) instead, but did not further investigate why: #include <unicode/ucnv.h> #include <iostream> int main() { std::cout << ucnv_getDefaultName(); } Change-Id: Idee88f200b6edecdb2633ed6e6fa70b370ffcf0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88003 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins (cherry picked from commit 25649502e08a52087dea5e482d34a1d4150f0930) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88035 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d037d971b4f4f408c7a6b6c15a0c7e742f61d354) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88125 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-07tdf#129789 bitmap in comment lost on loadNoel Grandin1-1/+1
regression from commit b4a1b89cc84086dfd6f471d7f23fecf0ec8f3331 tdf#119650 slow saving spreadsheet with comments, part 2 Change-Id: I8f6aa6b784b50b80311a420bdff9195ba88f5cff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 174ba963e05c9dedd57c2027f8656fe1f17030c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88042 (cherry picked from commit 9ffcc046a3f6afc659dfbe296507204b2e8fa670) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88113 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-05bump product version to 6.4.1.1.0+Christian Lohmaier1-1/+1
Change-Id: Id5f995158b098e70d35b1e586e76213b6d141580
2020-02-05Branch libreoffice-6-4-1Christian Lohmaier4-1/+1
This is 'libreoffice-6-4-1' - the stable branch for the 6.4.1 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.4.x release, please use the 'libreoffice-6-4' branch. If you want to build something cool, unstable, and risky, use master.
2020-02-05Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-4' to d59e1a1139a80dea04deb923460e01f63a723156 - update translations for 6.4.1 rc1 and force-fix errors using pocheck Change-Id: Iad3ec1e57f7db985e65431d7234c11bad2673905
2020-02-05Related: tdf#130143 freeze/thaw around bulk insertCaolán McNamara2-0/+10
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87864 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-05tdf#130389: Data ranges dialog, data series tab, move up/down reversedJulien Nabet1-1/+1
Change-Id: I6a12acacec9bad33cab9fd86b0ffa7193ee74b75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87921 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 93670d6cb7669b41d20feb91309eeb9930c67a27) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87982
2020-02-04Place button text in tooltip if it doesn't fit into the buttonSamuel Mehrbrodt1-0/+5
Seen this happening in custom sidebars (from extensions). When the text is too long for the button, it will get cut off and there is no way to view the button text. Change-Id: I86ce72154e0371bdf24480be41517855dc3ce050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87692 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit dabb6176407067ef8d46bdde863b087457805c6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87948 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-04Revert "Add ODF 1.3 strings to Save options page"Michael Stahl1-14/+1
This reverts commit ef39938dea14666a5835b6ae85091c1010f8ae8d. Reason for revert: Nasty side effects if the user actually selects the new values because the dialog code isn't adapted, see https://gerrit.libreoffice.org/c/core/+/87900 Change-Id: Ie220974dcf58b23401b21e5fa43e7d2f5d7978ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87901 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-02-04Related: tdf#129933 assert on pasting over selection in editCaolán McNamara1-1/+5
when its selected right to left with cursor flashing at the start format->paragraph->area->color->pick, cursor into hex# edit, end to cursor at the end, shift + home to select all, right to left, ctrl+c, ctrl+v, assert Change-Id: I8e29108ddff94487c298bd5e6607b98f5f841afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87885 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04tdf#130216: normalize paths with .. segmentsMike Kaganski1-11/+23
... which obviously are rejected by SHGetFileInfoW and SHParseDisplayName that it calls internally. Change-Id: I2f5f3c675ea6aa1c2d92eef30be4399a8d600255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87565 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87737 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04tdf#114746 Restore asian and complex tags in Impress templatesLaurent BP27-1019/+1017
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: I2c23ad83296c73b6e4c028cbb5a10d4b62d1e134 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86074 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04Resolves: tdf#130364 let font treeview fit to available dialog spaceCaolán McNamara3-74/+95
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 49d8e5fb744534f4af7e5c7f08dee7a95bcc6ed5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-04gtk: make sidebar media panel "play video" workCaolán McNamara1-5/+4
blank impress, insert video, use sidebar media panel to play video, without this chage the video playes in a toplevel window because the size is 0x0 so the widget doesn't get created in the first place Change-Id: I7200423a693fb475dede357071ef10030c5bb790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87696 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-04gtk: resizing video elements has no effect once the video has played onceCaolán McNamara1-1/+19
Change-Id: Ice8e688a7909bcfffc477479110a69e4770996d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87697 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-04Propagate warning error code from dBASE export, tdf#130020Eike Rathke1-9/+11
Long time existing code cleared all warnings set by the actual export routine. I could not figure out why this ever was done. It started short after the initial OOo import with commit 0ec1e9cbdfb4be18ea18b6b9be567d23bff5963f CommitDate: Fri Oct 27 18:00:10 2000 +0000 dBase export: don't set warning errorcodes that did not set warnings at the medium anymore without giving a rationale. Change-Id: I0f26d0644890c53557076ac7b99ffe7c8756a047 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87109 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6a308d2bfaf1d756aa4cfca6a40b80cf5e88e5fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87189 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-03GtkImage property should be icon_name in welded dialogsCaolán McNamara1-4/+4
Change-Id: I8e832599854e3ef52f25167e35470939c6e75bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87840 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-03Resolves: tdf#130061 numbering dialog adjustments missingCaolán McNamara1-0/+38
since... commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5 Date: Sun Oct 20 00:44:05 2019 +0200 tdf#128257 Bullet Dialog update so spinbuttons were disabled Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87879 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-03Unit test for stable at-page anchored fly positionJan-Marek Glogowski2-0/+43
This is the unit test for commit 5cee586a97a11c23dd252accc42099bd5e9b4187 ("sw: fix moving of at-page anchored flys to different page"). Originally the error was just triggered by toggling "View -> Field Names". Luckily it's also triggered by adding some text to page four, so no need for some UI test. Change-Id: I3a63b50dd898788607c3d24a848d8f43ae966377 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87776 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 5fed8bb5f6f65963fed27f96de3be14dff830d38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87847 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-03ofz#20422 reversed conditionCaolán McNamara1-1/+1
Change-Id: I5f880e24aee029e3560da986969d46500b5ed044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87805 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-02opengl slide transitions not working with glm >= GLM 0.9.9.0Caolán McNamara1-0/+1
tracked it down to... Removed default initialization, use GLM_FORCE_CTOR_INIT to restore the old behavior so adding in GLM_FORCE_CTOR_INIT to get them working again Change-Id: I1c6e7d8eb748fce40f0c518ff708708e5fb1e3d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87790 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2020-02-01SdImportTest::testPDFImportShared fails for --disable-pdfiumStephan Bergmann1-0/+9
...with > Test name: SdImportTest::testPDFImportShared > assertion failed > - Expression: false > - failed to load file:///.../sd/qa/unit/data/pdf/multipage.pdf during CppunitTest_sd_import_tests, because vcl::ImportPDFUnloaded always returns false then which gets propagated down to > #0 in vcl::ImportPDFUnloaded(rtl::OUString const&, std::__debug::vector<std::pair<Graphic, Size>, std::allocator<std::pair<Graphic, Size> > >&, double) at vcl/source/filter/ipdf/pdfread.cxx:358 > #1 in SdPdfFilter::Import() at sd/source/filter/pdf/sdpdffilter.cxx:58 > #2 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:485 > #3 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:768 > #4 in SdModelTestBase::loadURL(rtl::OUString const&, int, std::unique_ptr<SfxAllItemSet, std::default_delete<SfxAllItemSet> >) at sd/qa/unit/sdmodeltestbase.hxx:183 > #5 in SdImportTest::testPDFImportShared() at sd/qa/unit/import-tests.cxx:1218 (If the tests currently disabled with IMPORT_PDF_ELEMENTS were enabled, see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2019-December/084003.html> "sd: disable pdf import tests", then they would work fine with --disable-pdfium as I just checked, so they don't need to be covered by the new #if.) (Found with <https://ci.libreoffice.org//job/lo_tb_random_config_linux/2100/>.) Change-Id: I96e83f478c344123af0c5bcd0b5a82af01b1b9da Reviewed-on: https://gerrit.libreoffice.org/85259 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ced9702c9fcba0c702f0b910c3f1f5dae69a4f5a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87796 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-31Adapt to C++20 deleted ostream << for sal_Unicode* (aka char16_t*)Stephan Bergmann1-6/+6
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print a pointer rather than a (presumably expected) string. But here it should be fine to print pointers, esp. as there are null pointers involved. Change-Id: I62fad4cb9eaaa612989f035f686086ef29093d70 Reviewed-on: https://gerrit.libreoffice.org/84351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 1f0c54c250c2390962105128dcf871aad0689323) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87775 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-31Adapt CPPUNIT_ASSERT to C++20 deleted ostream << for sal_Unicode (aka char16_t)Stephan Bergmann19-2/+53
<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1423r3.html> "char8_t backward compatibility remediation", as implemented now by <https://gcc.gnu.org/ git/?p=gcc.git;a=commit;h=0c5b35933e5b150df0ab487efb2f11ef5685f713> "libstdc++: P1423R3 char8_t remediation (2/4)" for -std=c++2a, deletes operator << overloads that would print an integer rather than a (presumably expected) character. But for simplicity (and to avoid issues with non-printing characters), keep printing an integer here. Change-Id: I751b99ee32d418eb488131ffa130d6f7d6d38dc7 Reviewed-on: https://gerrit.libreoffice.org/84348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5d8f0fad50f90195a11873c70ddab4644f5839ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87760 Reviewed-by: Caolán McNamara <caolanm@redhat.com>