summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-07-19Change the most obvious Date+=(long)... to Date+=static_cast<sal_Int32>(...)Eike Rathke18-47/+47
Simple search git grep -l 'Date.*[+-].*[(<] *long *[>)]' Since commit f5b0cc2a3690ba963b3f150886e1d5ddddee9530 Date: Sat Jul 1 16:01:15 2017 +0200 Date operators +,-,+=,-= have sal_Int32 operands instead of long. Change-Id: I2387cbceadcb056831225e4111353980d50a94d4 Reviewed-on: https://gerrit.libreoffice.org/40163 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19tdf#108881 : do not assume that chart objects always...Dennis Francis1-13/+20
...have data ranges associated with it. Empty charts do not have data ranges. Reverts the part of c55d52262ea1d5f869a9528fd051ee19e687f1cc which makes this assumption. Matching test cases (in uitest) coming up soon in another commit. Change-Id: I60f0f03a8c937ecfdff95047bdfeeb7733eff4a4 Reviewed-on: https://gerrit.libreoffice.org/40057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19connectivity: merge OCalcColumns and OWriterColumnsMiklos Vajna9-112/+17
Turns out createObject() only needs the base class OFileTable, and then these can be shared. Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017 Reviewed-on: https://gerrit.libreoffice.org/40183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcPreparedStatement and OWriterPreparedStatementMiklos Vajna9-100/+16
Into a single OComponentPreparedStatement, as both of them just provide prepared statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Ib1074871d63de83f16861081050e57442ebf0ffa Reviewed-on: https://gerrit.libreoffice.org/40182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcStatement and OWriterStatementMiklos Vajna9-103/+16
Into a single OComponentStatement, as both of them just provide statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Iad2852f93783ec3c4a672f4b86424b4aa0ae8eaf Reviewed-on: https://gerrit.libreoffice.org/40181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcResultSet and OWriterResultSetMiklos Vajna11-301/+50
Into a single OComponentResultSet, as both of them just provide data source functionality based on a file loaded into an LO component, so they can share code. Change-Id: I19352e592a45d7a58d834e72645dec72d77ce7c9 Reviewed-on: https://gerrit.libreoffice.org/40180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19tdf#93328 : Assign the ScInterpreter results back to ScFormulaCell...Dennis Francis3-0/+40
when the formula cell type is unknown before interpreting, otherwise the cell is treated as of type string later when used by the interpreter. Added unit-test testIterations() in ucalc that tests the establishment of circular chain of references and editing of a formula cell that already belong to the circular chain. Change-Id: Ib13b05b20d17c0696fce0ac9eefd9e621bdc0c5f Reviewed-on: https://gerrit.libreoffice.org/40165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19tdf#107975: Revert "fix deleting an image anchored to last paragraphMichael Stahl3-19/+5
... in document" This reverts commit 2903d85d6197829633d7f96c95cd55821c2c20ff. It was a good idea, but is not complete. Change-Id: Ia0da2640889ce6e78b89b27c75fae9d6508afd40
2017-07-19oss-fuzz: fix wmffuzzerCaolán McNamara2-2/+2
Change-Id: Idd6a03ed46161c6d35088401ae2816edc8a69f8b
2017-07-19loplugin:constparams in cppuNoel Grandin5-8/+8
Change-Id: I0e772b8cf4ee281b5f3e26131df985607a569c48 Reviewed-on: https://gerrit.libreoffice.org/40156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19Updated coreOlivier Hallot1-0/+0
Project: help 96683c90c8faf8af6bcee5a149f3a7a6acefcf26 Code cleanup in XSLT remove unecessary template Change-Id: Ie7b615d75c33702e79dc052b87c2a392038964c6 Reviewed-on: https://gerrit.libreoffice.org/40186 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-19Updated coreOlivier Hallot1-0/+0
Project: help 125c3e6a3faab4062b69ab78c636192e5f3763b9 Fix a $title variable in XSLT transform Change-Id: I7463572330e2338e73266f487d88b3d1beeff741 Reviewed-on: https://gerrit.libreoffice.org/40184 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-19tdf#108928 Branding 6.0Heiko Tietze2-0/+0
Improved splash Change-Id: Ie691567fc265ebd6100029843b111be3ce97c804 Reviewed-on: https://gerrit.libreoffice.org/40120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-19tdf#109188 Always load documents read-only in SwOneExampleFrameSamuel Mehrbrodt1-1/+1
Should be no problem since 38a3743e0c5d52f9386f74097fd512d3133fbbe3 Change-Id: I0ce47bc2bdaa900559a16baf25305066977caa6d Reviewed-on: https://gerrit.libreoffice.org/40140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-19sw mailmerge: add writer data source testcaseMiklos Vajna4-0/+15
Fails with commit 83b43ef2223b66484e0e90e7b614886e06f955b5 (sw mail merge: add support for the new 'writer' connectivity driver, 2017-07-18) reverted. Change-Id: I675e15bdbc655a34cca3de2b5d070167ca69cac8 Reviewed-on: https://gerrit.libreoffice.org/40174 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19revert fix typosThorsten Behrens1-1/+1
This revert the part of commit d948d66509022befdb6e2c589859ca7dee9e5347 Author: Andrea Gelmini <andrea.gelmini@gelma.net> Date: Sat Mar 18 20:07:23 2017 +0100 Fix typos that changes the odf 1.2 schema Change-Id: I6307513bc1494b656c031168375cd30224914b33
2017-07-19vbaapi: File dialog produces pathTamas Bunth1-3/+13
instead of file url Change-Id: I6f4cab23edd1fabe93290a26adc5fb77f2a55e8b Reviewed-on: https://gerrit.libreoffice.org/40170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-07-19CheckWebQuery: Don't use OUString::createFromAscii for user inputMike Kaganski1-1/+1
Change-Id: I26803984c0a9e172aa4ceb7bfc9d26abb14ca207 Reviewed-on: https://gerrit.libreoffice.org/40173 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19tdf#108835 Fixed writer crash on adding Autocorrect Entry:Mohammed Abdul Azeem4-9/+16
ZipPackageStream::saveChild seeks and reads on the same stream, so it cannot be done parallely. Also, read on BufferedStream tries to aquire the same mutes, which is already aquired by the calling method resulting in deadlock. Using UnbufferedStream here should solve both. Change-Id: I25b7ca2ff3c31125cf107fe404f9af66435bec7d Reviewed-on: https://gerrit.libreoffice.org/40160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-19Separate SvxMenuConfigPage from cfg.cxxMuhammet Kara5-457/+670
Change-Id: I6e56756628bbbf3900f946715ce8b95bbe78ae03 Reviewed-on: https://gerrit.libreoffice.org/39341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 091a7f474adac69b1808e5c812952586d253a809) Reviewed-on: https://gerrit.libreoffice.org/39956
2017-07-19gtk3: make video playback fill playback windowCaolán McNamara1-0/+2
Change-Id: I43f2f77889856dc6a3b0c3a3775826dbb000be7a Reviewed-on: https://gerrit.libreoffice.org/40168 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-19Missing @since tagsStephan Bergmann2-0/+4
...from 83535a28c57ffb59f795dd35332d6b3426071e32 "emfplus: create a wmf/emf/emf+ primitive based importer" Change-Id: Id628c834cea2ae4cb031fdd68feff5db1e887d13
2017-07-19android:Update configure.ac to support NDK 15.1.xbrainbreaker1-5/+5
Change-Id: I07ec4df7cb5aaf4b491fac1202d2607af9f56968 Reviewed-on: https://gerrit.libreoffice.org/39780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19CompilerTest_compilerplugins_clang: disable test failing with clang-3.8Miklos Vajna1-1/+3
10:28 <@vmiklos> noelgrandin: clang-3.8 is unhappy for the unusedfields plugin: https://pastebin.com/raw/MJ30aKcs 10:30 <@noelgrandin> vmiklos: ... probably best to just disable the unusedfields solenv testing in the .mk file Change-Id: I1873f1f76d7a7b0438002ffda9180abe582e07d7
2017-07-19Favourites feature in Special charactersAkshay Deep9-32/+792
Change-Id: I8273b95132d48a51e841ec3792139007b4e7b55a Reviewed-on: https://gerrit.libreoffice.org/39752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-19loplugin:constparams in connectivityNoel Grandin45-110/+113
Change-Id: I9b81c6227fb3c89a832640058a11444f72019694 Reviewed-on: https://gerrit.libreoffice.org/40155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19loplugin:constparams in desktopNoel Grandin18-39/+40
Change-Id: Idba3acbd1e6ad5e1ce1cae9f80f764906ab8b143 Reviewed-on: https://gerrit.libreoffice.org/40157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19loplugin:constparams in svtoolsNoel Grandin62-139/+139
Change-Id: I2620419828864363af55011abe56143bb7d42f48 Reviewed-on: https://gerrit.libreoffice.org/40154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19enhance unusedfields plugin to find readonly fieldsNoel Grandin7-51/+2482
Change-Id: I4da97443fc7eb14fd94959a026ab45a9256c055f Reviewed-on: https://gerrit.libreoffice.org/40158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19[API CHANGE] offapi: remove unused css.xml.crypto.XMLEncryptionMiklos Vajna4-49/+0
This is mostly just the offapi/ part, more C++ code can be removed in xmlsecurity/ after this. XMLEncryption wasn't used by internal code since it was added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23 (libxmlsec, 2004-07-12). It seems to be unlikely that this non-published service was used by 3rd-party code, since it was specific to other xmlsecurity/ code, not generic functionality that could be useful in other contexts. Change-Id: Ia0168f67d1c8ff7a019760ac436511f219eee94e Reviewed-on: https://gerrit.libreoffice.org/40162 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19osl: fix a number of doxygen comments in unx/file_path_helper.hxxChris Sherlock1-109/+58
Change-Id: Icd5553505e48b650103597e40311ac11ba388259
2017-07-19osl: fix file_path_header.cxx commentChris Sherlock1-5/+2
Change-Id: I671ba9d48d327ccabc8851bee596831e04a6f62a
2017-07-19osl: fix header commentChris Sherlock1-18/+11
Change-Id: I06829e4ad0efc78244083e48bf9cd10422ff5e2e
2017-07-19osl: remove comment cruft osl/socket.hChris Sherlock1-5/+0
Change-Id: I785cc08e5450530f885b1bf38b50517029d6fb92
2017-07-19Followup to 56638d1a6d9ba - fValid -> bValidChris Sherlock1-23/+23
In 56638d1a6d9baebfe27cbf82ccf0376926c6a530 we renamed to BOOL to bool, but we also need to change from fValid to bValid. Change-Id: I6a2c2931d8872ee2cfefa43c3f06fff5d5ce0629 Reviewed-on: https://gerrit.libreoffice.org/40115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-18tdf#109194 cleanse startup notification foo from envThorsten Behrens1-0/+8
So when the desktop environment does startup notification, this DESKTOP_STARTUP_ID gets passed on to the launched application. Problem is, XDG spec says app should read it from the env, then discard - which LibreOffice never does. When passed on to child processes, funny effects might ensue, so let's just erase this at the end of VCL init, when I'm reasonably sure every gtk/kde/whatnot backend did read it. Change-Id: I1f758c7a02455028d2b520c144ffe32538621f19 Reviewed-on: https://gerrit.libreoffice.org/40153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-18remove unused CntWallpaperItemCaolán McNamara7-291/+0
Change-Id: I47cf9fc37bb64a80a21ed805bff2bb3ac3eb6da5 Reviewed-on: https://gerrit.libreoffice.org/40148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18loplugin:oncevarTor Lillqvist1-0/+1
Change-Id: I538903412a351ba901c2b2149e450ebc7e80916a
2017-07-18loplugin:oncevarTor Lillqvist1-3/+3
Change-Id: Ic7c5ec9bb7cc7aff61279f2027cf5a9e1b31e36f
2017-07-18Eliminate some unnecessary temporary Date instancesEike Rathke5-15/+12
Change-Id: Idede71608458acf4d23504b3a6a1cba557f370d1
2017-07-18sw mail merge: add support for the new 'writer' connectivity driverMiklos Vajna4-5/+29
By mapping the .odt, .sxw, .doc and .docx extensions to sdbc:writer:. If we are at it, also accept xlsx next to xls. Change-Id: I8c6769b282adec1e7e8d191170e7aa9b324f2018 Reviewed-on: https://gerrit.libreoffice.org/40147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18dbaccess: introduce DATASOURCE_TYPE::DST_WRITERMiklos Vajna14-15/+41
By mostly reusing the spreadsheet code. This way the UI allows creating a data source where the backend is a Writer document (containing at least one Writer table). Change-Id: I42186d46aaa86fa96ebae0807c97306d6d00d6d4 Reviewed-on: https://gerrit.libreoffice.org/40146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18no copy neededJochen Nitschke1-52/+2
coerce_value(..) is a local static function without side effects Change-Id: Id153ad26973b5724b33f144ae9eba49562b15067 Reviewed-on: https://gerrit.libreoffice.org/40040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-07-18Change nonsense non-const Date* GetNullDate() to const Date&Eike Rathke34-101/+96
* first, a non-const Date* may leave the impression that one could change the NullDate through the pointer, which is only partly successful; luckily no one did that * second, there is always a NullDate so checking for nullptr is superfluous * third, the pointer was dereferenced (maybe after a check) everywhere to obtain the NullDate, luckily.. Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
2017-07-18fix terrible state of chassisCaolán McNamara2-9/+0
Change-Id: Idc0a4ea5def17e00af8c8dfec6efb797252e5a00 Reviewed-on: https://gerrit.libreoffice.org/40144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18merge last entry of cntids.hrc into sfxsids.hrcCaolán McNamara7-35/+1
Change-Id: I78ba63d5d455ef9fe2e4c6cf2f67d88c921100d1 Reviewed-on: https://gerrit.libreoffice.org/40143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18SID_VIEW_FLD_PIC looks like a StarOffice < 6.0 holdoverCaolán McNamara3-141/+0
that can't exist anymore Change-Id: If94801fe854bc8ccf4307fce2674944f63e95d4c Reviewed-on: https://gerrit.libreoffice.org/40142 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18move SID_DISTRIBUTION to reportdesignCaolán McNamara2-2/+1
Change-Id: Ia34d484485aed454d5463ec7e8f25f20af540490 Reviewed-on: https://gerrit.libreoffice.org/40141 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18try sleep instead of blocks annotationCaolán McNamara1-1/+1
Change-Id: I2d80ed40b5ec4c8db62053d8bb6c9d0c9ad24da2
2017-07-18CppunitTest_filter_eps_test add missing componentMiklos Vajna1-0/+1
Missing since commit 098b685e901974dc9d0248b6e2fd06644c954e84 (No reason to silently misbehave when these UNO services are missing, 2017-07-18). Change-Id: Iee2f43fca11ce635833700fb087883013c59d985