summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-05-13Revert "simplify the vcl<->toolkit connection"Noel Grandin46-98/+105
because it introduces a link-time dependency of vcl on toolkit, and toolkit already depends on vcl This reverts commit f7a86c5cdf4323c99d26512bf78de7f7c380667d. Change-Id: Ibdd4f3e8221d70e2abd8fcbda67f85af3ac0396e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-13sw XHTML export: fix handling of list labelsMiklos Vajna2-1/+98
This is building on top of commit 119b6876c92e4cdae44583c4b1b1419d3533e3ee (sw XHTML export: properly write <li>...</li> around multiple paragraphs, 2020-05-21), but the use-case here is a numbering with list labels only. The first problem was that the list label had its <li> suppressed, but not its </li>. The other problem is that <ul> can only have <li> child elements, so at least fix the case where the list only has list labels, in which case even <ul> and </ul> should be omitted. Change-Id: Id38978a40d8618f483e3e9d499f75838d5b2adb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115543 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-13error: use of undeclared identifier '_exit'Caolán McNamara1-0/+1
Change-Id: I6802c8afe4b02ec8398fa9d62728694ddc6f770f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-13sw_uiwriter: Use a template in makefiles to reduce duplicated codeXisco Fauli5-228/+100
Change-Id: I2aa29480766f943ad24d97635c50eb8b49ca8795 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115536 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-13Introduce SwSectionFrameInvFlags to replace magic numbers in ...Miklos Vajna2-14/+25
... SwSectionFrame::SwClientNotify() SwSectionFrame::UpdateAttr_() is not yet updated to produce these. Change-Id: I2eba563916420fa78d77b9656898ce333abce6e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115507 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-12fix leak in canvas testNoel Grandin1-1/+1
Change-Id: I01d52e67711b0201bbabb8c36e990f494466ae55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12suppress more basic leaksNoel Grandin1-1/+2
Change-Id: I283457e47b919411455afac209e78e508139f9af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12unused include lineCaolán McNamara1-1/+0
Change-Id: I6a41cfa184a653f1b84cf6f33c391ccd531ffc2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12rename ui-converter-skeleton to ui-rules-enforcerCaolán McNamara1-2/+7
Change-Id: I1cc0fd704be075a7c387363a49bd84b159831aca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12add truncate-multiline for uniformityCaolán McNamara1-0/+1
Change-Id: I731b2427b49586ba06e83ce36a13e3508caa3119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12tdf#112603 tdf#142014 tdf#142139 WMF/EMF Fix line widthBartosz Kosiorek3-1/+33
Previosly line width was always 1, and changing width do not affect line. Change-Id: I462096b915e053fa089e85860f124466b650558a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115497 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-05-12sc_ucalc: restore formula options after using themXisco Fauli3-14/+183
Otherwise, it might affect other unittests Change-Id: I0750979742e6193f627a1eaf9b1e35f97976278b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-12simplify the vcl<->toolkit connectionNoel Grandin46-105/+98
No need to store two different pointers and hide the underlying class behind an UNO interface Change-Id: I72c55e912caa9eae1cffa6c9d1b1d480e5668d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12tdf#137810 sw: fix SwXNumberingRules setting CharStyleNameMichael Stahl4-11/+51
During ODF import, due to removal of the pDocShell parameter, this hits else rCharStyleName = sCharFormatName; while setting the "CharStyleName" property and later GetNumberingRuleByIndex() prefers m_sNewCharStyleNames over the format set in the SwCharFormat?? Also, "BulletFontName" has a similar problem; otoh "HeadingStyleName" only makes sense on chapter numbering. The m_pDoc and m_pDocShell members are such a WTF. (regression from ae0e4a6ba9be2fa99ac2be8e20157806e36209b2) Change-Id: I9d4d4cd7aeb7e6e29221d53facaff213fd4e35a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115495 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-12fix ubsan use-after-freeNoel Grandin1-0/+25
after commit 2ed8c34bca56c1a30d727b21d9096cb77e88197a Date: Wed May 5 10:54:44 2021 +0200 use a single global item pool for chart2 draw model Change-Id: I5f6b1b1917f60c9a8603b58368da8b34f174f7db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115478 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-12gtk4: add a typedef for different gtk_widget_translate_coordinates arg typeCaolán McNamara5-25/+19
Change-Id: I07c514309d1c687361609818d1d16e808e8b4a56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12tdf#141307: adapt null-checkBjoern Michaelsen1-1/+1
- if we check pNd for nullptr, we need to expect it to be nullptr - in that case we shouldnt use the pointer before the null check Change-Id: Ia9d11abe32fac10f36fdbfcefeadd51891f1834e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115264 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-05-12gtk4: add widget_get_first_child to wrap gtk_widget_get_first_childCaolán McNamara2-23/+20
and equivalent gtk3 calls Change-Id: Iab6801466d6677ae5a7419470ce3bb32e16e68ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: wrap gtk_image_get_icon_name for different version argsCaolán McNamara2-3/+12
Change-Id: I38f2c11309965b08a5c85f543127f3c8b6720e08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: enable CreateBuilder but forward to generic one stillCaolán McNamara2-3/+9
Change-Id: Ifba5d0de1606ed238a3e71c4149baf1c97848b1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115483 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk[3|4]: drop m_xFrameWeld before gtk_window_destroy invalidates m_pWindowCaolán McNamara1-0/+1
for gtk4 Change-Id: If9446411bd5dde1ad1b0d5d02bd0354b63f5c3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115481 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: renable providing parent to native dialogsCaolán McNamara1-2/+0
Change-Id: Ic21d57d8c58db855d80cb905e45a3cd37985ca0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12fix some VirtualDevice leaksNoel Grandin6-4/+6
Change-Id: I645543fa27ca8b75b36ed7798f0af7b81fd09f49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12Update git submodulesMarco Pinto1-0/+0
* Update dictionaries from branch 'master' to 4fa94195b8136364dd40bf2b0366a0fe32058899 - Updated the English dictionaries: GB+US+CA+AU+ZA Change-Id: I0bc59f1c11ef10ff597ab2d7c18fcdbc648a472a Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/114824 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2021-05-12gtk4: reenable gtk message dialogsCaolán McNamara1-19/+81
Change-Id: I115901d5e86be7aee261df4d548b8b660e904f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12Update to ICU 69.1Eike Rathke5-61/+19
Change-Id: I32836175a877349777dcbb6eb7b0d813aa31199a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115479 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-12vcl PDF tokenizer: fix EOF position when \r is not followed by \nMiklos Vajna3-1/+94
Otherwise this would break partial tokenize when we only read a trailer in the middle of the file: m_aEOFs.back() is one byte larger than rStream.Tell(), so we reader past the end of the trailer, resulting in a tokenize failure. What's special about the bugdoc: - it has 2 xrefs, the first is incomplete, and refers to a second which is later in the file - the object length is as indirect object, triggering an xref lookup - the first EOF is followed by a \r, but then not with a \n This results in reading past the end of the first trailer and then triggering a lookup failure. FWIW, pdfium does the same in <https://pdfium.googlesource.com/pdfium/+/59d107323f6727bbd5f8a4d0843081790638a1dd/core/fpdfapi/parser/cpdf_syntax_parser.cpp#446>, we're on in sync with it. Change-Id: Ia556a25e333b5e4f1418d92a98d74358862120e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115466 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-12Guard against isCXX11ConstantExpr on dependent expressionStephan Bergmann1-2/+4
> Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), function isCXX11ConstantExpr, file ~/llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 15540. ...as would have hit with a preliminary version of ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator += overloads" Change-Id: I652063b4eebd076973eaa57219df91cd1fbef312 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-12Fix broken TOX in Online.Gülşah Köse1-10/+0
1. Open a German file in the Online 2. Insert a new paragraph, and change its style to "Ueberschrift 1" 3. Go to the Table of Content, and choose "Update Index" 4. See the index got destroyed, and when you look at the list of styles, the "Ueberschrift 1" has disappeared, and "Heading 1" appeared instead. This reverts part of: commit ca435be45f316120b9df6c9d547b781ed975817d writer: handle styles in multiple languages for online Change-Id: I82e46b3cf7824df6efdbb4b2a16716153ddae0df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114683 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115273 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12fix leak in VCLXWindowNoel Grandin3-21/+48
which is a little tricky because dispose() can be called from either side (vcl::Window or VCLXWindow) Change-Id: Ifc380feec6bec84b2cf7d903d42db00755d4cd97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-12tdf#141426 Remove GtkPaned struct unnecessary tabs.Gülşah Köse3-204/+181
In development tool we need GtkPaned for only properties tab. Unnecessary hide() show() calls for the other tabs(Interfaces, Services, Methods) causes complex problems about inital height of the second pane with gen plugin. Change-Id: I7523ef0bc425d7fc97ec5bd9e30e874f88e354f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115450 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12tdf#141426 Fix VclBox inital size allocation.Gülşah Köse2-2/+2
Change-Id: If7380c9dbbcda091a2de93b722bf90182677af6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-12gtk4: wrap gtk_widget_get_root vs gtk_widget_get_toplevelCaolán McNamara6-94/+45
Change-Id: I416b157defd927e7c2fa828c5d3b3ba2a5e20c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: wrap gtk_css_provider_load_from_data for arg difference in gtk versionsCaolán McNamara6-45/+23
Change-Id: Iabbf7f6a746efae2ec4abecfb27b4b097ce822ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115447 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: unset gtk_popover_set_has_arrow for popover menusCaolán McNamara1-0/+1
which is what I see in e.g. the gtk file dialog so lets follow that pattern. Change-Id: I505318c0e1e12ea8c75d2960184092927fd2f744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12gtk4: improve gtk_dialog_run replcement to not crash on ESCCaolán McNamara1-8/+18
e.g. open/save file dialog Change-Id: I71813125589866affc2313c72e44159c15501ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-12Optimized OString operator += overloadsStephan Bergmann1-9/+45
...similar to how OUString got an operator += overload for std::u16string_view with c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicit". In this case, though, we can easily add enough overloads (which forward to the one taking std::string_view) to avoid any ambiguities at call sites. We had left this out in the past as there is no suitable rtl_string_newConcat* function to use in the implementation, but we already had inline implementations of OStringConcat/OStringNumber overloads, so stick to that pattern here with the new std::string_view overload. Change-Id: I329036ea2b62cb921b4dbc1eef7c45a9cdb56e13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115452 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-12external: update pdfium to 4500Miklos Vajna6-26/+22
Change-Id: I38c85fb3e30ffd1f7fc0a11948fc01338f7bb205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115444 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-12tdf#142196 sw: crossing out images anchored to characterLászló Németh6-8/+127
Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d (tdf#78864 sw track changes: cross out deleted images). Change-Id: I3daa772ac80f777e1badc58a424f98b1d655acba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115442 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-11sc_ucalc: remove duplicated methodXisco Fauli6-188/+153
Change-Id: I720c40bfc218b3f442217d3bb7189fce1baaf4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115449 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-11Revert "tdf#141015: Show Mail Merge toolbar when DBData has data source"Mike Kaganski1-3/+1
This reverts commit 346153f08c907739ca310934ad45814379971027. It seems to create more problems than expected, and there's no way to remove DB association other than editing document XML. Change-Id: I93171f17c01e231abbcfa9a816fdadce83c983ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115283 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-11fix leak in SwUndoInsSectionNoel Grandin2-14/+17
Change-Id: I68e0c0570ac7b6f5ebce06900947fa296cbedd03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11tdf#139241: partially revert 059f07f9f33460c809a93e0fda1165f5c6f6d805Mike Kaganski1-2/+8
And instead normalize the start and end values before creating rectangle. Change-Id: Ib9921f1a537ca88a70cedf989d2f696180ad68e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115284 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-11There’s no need to SHOUT to the userAdolfo Jayme Barrientos1-1/+1
Nowhere else in LibreOffice’s UI are keyboard shortcuts indicated in all-caps. Don’t do it; we’re not in the ’90s. Change-Id: Ieb8aa32797d422c2ac067fab5d061de6d2176908
2021-05-11ofz#32899 missing scripting_BrowseNodeFactoryImpl_get_implementationCaolán McNamara1-0/+1
Change-Id: Ifd7d40f67234bc852776cde8d7855f86f73a8fb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk[3|4] don't create File Dialog with buttons that need to be removedCaolán McNamara1-44/+4
just create it without the offending buttons in the first place Change-Id: I0708e69a82e8fbabf149b64186a9d20cfd011cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11tdf#141982 tdf#142139 Add rotation and line width support to ROUNDRECTBartosz Kosiorek3-3/+38
With this commit the ROUNDRECT is able to change line width and transformation (including rotation) is supported. Change-Id: Ic303a74adf0fd0dd452353f250a13140603d492e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115429 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-05-11gtk4: replace gtk_dialog_runCaolán McNamara2-7/+39
with effectively the same thing, so still a loop within a loop. File Dialog now appears and is semi-functional Change-Id: Ibd7584c5e41b5de84975c3cb7886fe97a74d8587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk4: incomplete GetDisplayBuiltInScreen implementationCaolán McNamara1-3/+18
only x11 possible as far as I can see, maybe we can assume index 0 is built-in otherwise. We like to default to put the presentation console on the built-in laptop monitor and the presentation on the external projector. Change-Id: I5d17403032b04750a5fb4d52904db0a81a6234c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115436 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk4: reduce ifdefsCaolán McNamara1-8/+5
Change-Id: Ibfbc5a37666c233590cf2d4169730a89d37ff7f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>