summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-04-27CommandType is "long" type not "short" typeJulien Nabet10-17/+17
See https://api.libreoffice.org/docs/idl/ref/namespacecom_1_1sun_1_1star_1_1sdb_1_1CommandType.html + discussion here: http://document-foundation-mail-archive.969070.n3.nabble.com/Type-of-CommandType-short-or-long-tt4299416.html Important remark from Stephan: "...the data type corresponding to UNOIDL LONG (i.e., 32 bit) is xs:int, not xs:long" Change-Id: Ic8f027e8a5be96bdb2e5629b0ff1ef4830ef6c88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114659 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-27"with fail with..." => "will fail with..."Julien Nabet1-1/+1
Change-Id: I184224e91b204f0819c9a2d53fcd0f88d9248158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114663 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-04-27More aggressive Clang 13 trunk -Werror,-Wdeprecated-copy[-with-dtor]Stephan Bergmann6-0/+13
...since <https://github.com/llvm/llvm-project/commit/abf3ca61e3235681f26d0f527b8e2763dd4c0c62> "[Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)" Change-Id: I43ae8a620915ad211a1f21ecf89b6955b7d2faaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114674 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27tdf#141924: SwFormatAutoFormat::GetStyleHandle may return nullptrMike Kaganski1-3/+5
Change-Id: Id1b6fe687f5b328fa0743036a287bacfefe5e5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114685 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-27Correct some c/c++ licensesdante6-72/+12
The affected files where added from scratch in commit 565bbd2e46e57117eb401344689858c3d749dc5c. In consequence instead of the ASF license; the correct license is the pure MPLv2 found here: TEMPLATE.SOURCECODE.HEADER Change-Id: Ie2fa275a6a986fff026a5096a10f79ab3c6ea85c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114670 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-27SW merge layout shortcut into the full layout codeJan-Marek Glogowski1-31/+10
The shortcut codepath just skips a large part of the full layout code. To make this more obvious, this refactors the main layout loop by merging both paths, really skipping the code in the shortcut case and getting rid of all the duplicate code. Change-Id: I015202e86e75576f03901746e1a082e9f6811549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-27SW layout: convert XCHECKPAGE to lambdaJan-Marek Glogowski1-34/+23
Some refactoring, better to debug then preprocessor macro code. Change-Id: If2e8b126915b97dfa1d132713a57948993eace15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114678 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-26tdf#141914: Allow to unset modified anywayMike Kaganski1-5/+9
IsEnableSetModified returning true means kind of "treat this document as read-only". Marking object unmodified does not break this idea. Change-Id: I3efd5b3b25e2d9318702cdbf24ac5eb61aeda3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114666 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-26tdf#141887 SW don't crash on missing SwWrtShellJan-Marek Glogowski1-3/+3
The code assumes that SwEditWin::Command can just be called, while there is still an m_rView.GetWrtShell(), which is at least not true, if you have an IM in pre-selection and close the Writer window via Window decoration. Change-Id: I67d5f1f917e9b2180037babb8c70c72d75c4a7ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114624 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-26ScriptForge - (SFDatabases/SFDocuments) CommandType must be a LongJean-Pierre Ledure2-6/+5
cfr. https://gerrit.libreoffice.org/c/core/+/114659 Change-Id: I1638ee3f523e685b324201cc9916a743db0ecb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114662 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-04-26Use kahan sum for lcl_ named methods in abstract namespacedante4-533/+533
Change-Id: Ib2df6c1cbe3bc36df085f310db24810b33ec85e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-26AboutDialog: imgBrand: Fix alignmentPedro Pinto Silva1-1/+1
The imgBrand was "centered" aligned with the text bellow which was resulting in not only going against the dialog layout (2 sections) but was also appearing "false" centered aligned: - Left section: imgAbout - Right section: text left aligned - Right section: imgBrand was not left aligned and not centered aligned etheir (with the dialog) Fix: Left align imgBrand to be consistent with other elements in the same section. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I227f67863d5b6e951c498ee7acdfadc0fac75e6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114648 Tested-by: Jenkins
2021-04-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 766e173ed8c9b3401c07fa26716eefe1b2430be5 - tdf#141766 Update cell protection Help page Add new options available since LO 5.4 Change-Id: I1b283d5f4b6d43ed4167cbbbee969406935913bd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114668 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-04-26lok: calc: formula breaking to multiple lines partly shown in edit modeMarco Cecchetti1-0/+22
visible cells report wrong number because of the wrong grid size is retrieved that in turn is due to the fact that the size of the visible area in Online is used to set up only the active pane, So when we have windows splitting, even though there is no real split, the height can be computed using a non active pane whose size is not be synchronized with Online. Until we lack that synchronization, we use the implemented workaround for fixing the problem. Change-Id: I9df9e4b0ef77a2a8a5847ce77fe90d83ec75019d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114429 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-04-26Revert "ofz#27296 Out-of-memory and ofz#27384 Indirect-leak"Caolán McNamara5-18/+48
This reverts commit c80c8ac4eb58812c1b72aa0b0cef01ebb5337359. it seems blameless after all Change-Id: If0f95da5ee7f91fde0b679c9314e3da07f7779f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-26Simplify center calculationMike Kaganski1-7/+5
Change-Id: Iabe16cee8fe0b32d262be7066a036a305878cf39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114595 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-26drop mask from BitmapExNoel Grandin65-925/+344
So that we have fewer cases to deal with when we transition to 32-bit bitmaps. (*) rename maMask to maAlphaMask, since now it is only being used for alpha duties. (*) drop mbAlpha and mbTransparent to simplify state management, the only thing we need to check for alpha is if maAlphaMask is non-empty. Change-Id: I06252e38e950e846a94b4c2ba8ea763be17801fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111679 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-26Add a Kahan summation class.dante2-0/+137
Change-Id: I4021d07a2c011c2d5b2e79ecd878019d29cabd21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114567 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to fbc2bf25e85156c8c5d43e84d727bac1ec0288b9 - tdf#140518 Fix bad link in index Removed bookmarks values that points to a generic field update Help page. The page is for updating Fields, which includes captions for many objects, but is ambiguous if user looks on how to insert or manage captions Change-Id: Iae9d47766aa56910fcfb95b70e32f252d3bf6ef8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114633 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-26Breeze: tdf#141885 New Paste As Link iconsRizal Muttaqin12-0/+6
Change-Id: Ie1bee7066b2271e94acde45a7be0136db5eed0b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114642 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-26lok: add rendering and input for form controls in CalcTomaž Vajngerl4-5/+195
Until now the form controls were nto rendered to a tile when drawing tiles for LOKit usage (online). This change adds LokControlHandler that is responsible for rendering of the form controls on the tiles (currently implemented only for Calc) and handles mouse input events that come through LOKit. Change-Id: Ifcecc9a320a7836b76b0a10771b06c15339baed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114635 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-26sw: prefix members of SaveBox, SaveLine, SwDocStyleSheet and ...Miklos Vajna5-437/+440
... SwXTextTableRow See tdf#94879 for motivation. Change-Id: I1d27caebc8820f884114c4a8c0b3cbcdf35e86a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114639 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-26BitmapEx: always convert 1-bit mask to alphaNoel Grandin6-12/+104
which is a step towards dropping masks, and only using alpha. Change-Id: I6882c0e5b1c805b0cda5a2eaadcbdd078d8566c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-26Add unit conversion for Point, Size and RectangleTomaž Vajngerl1-72/+96
This makes it easier to convert between units when they are used in Point, Size and Rectangle classes, which we use a lot in the code where conversion of units is needed the most. constexpr some function on Rectangle as this is needed for the convert. Change-Id: I5c7e7c8637e4c9327dd55025be19b8f3f391f395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114634 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-26Sifr: tdf#141866 New Paste Transposed iconsRizal Muttaqin12-0/+6
Change-Id: I2c499e6deb7b34e0453a17fe4f274a8893380450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114623 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-26Breeze: tdf#141866 New Paste Transposed iconsRizal Muttaqin12-0/+6
Change-Id: Ia6c139c4de96cc8bd15deda816a19a3c57ab86ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114619 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-26elementary: tdf#141866 New Paste Transposed iconsRizal Muttaqin6-0/+3
Change-Id: I55b06384d3e0a015a97b231c2ea1c6aff9ba5a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114620 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-25Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 6d5b34965b64ed96fb560bdca85dc64088c7f970 - tdf#114240 Add note on extension security Added note on extension security. Expert configuration settings deliberately ommitted not to tempt end user. Change-Id: I28d9398c3b2abc8bea44c2956c16bb11d600fb9f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114585 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-25tdf#99991 - Don't resize toplevel widget containing the options expanderAndreas Heinisch1-1/+1
Change-Id: I930445e9047478b26142d049598fbe656d25d666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114628 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-25Use ROUNDSIG to do sensible value testingMike Kaganski1-293/+293
Without that, it doesn't make sense to compare values smaller than 10^-20, where ROUND(val;20) returns 0; ROUND does not accept count greater than 20. ROUNDSIG was implemented in tdf#105931 with unit testing in mind. Change-Id: I20cbe4d116373d1b783b781a1dfdb6c94fe13833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114625 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-25Colibre: tdf#141885 New Paste As Link iconsRizal Muttaqin6-0/+4
Change-Id: Ib3273a108fe4f5a9221f115ecb39ed0a2fcfa2ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114626 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-25Fix commentMike Kaganski1-1/+1
Change-Id: I6f2ec861571ed947ecbd267bc721fb9a3f5ceea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114594 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-25loplugin:unusedfieldsNoel Grandin4-18/+1
Change-Id: I52af3509afde02dae494747527ab800590682fa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114591 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-25loplugin:unusedmethodsNoel Grandin3-23/+0
Change-Id: I2d563f5f3e6e3a5f2a58080e13f4211253bdf30d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-25KJ: tdf#141866 New Paste Transposed iconsRizal Muttaqin6-0/+3
Change-Id: Ic3622b1092f7e6273211321397b3b8d87bb40dd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114621 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-25Sukapura: tdf#141866 New Paste Transposed iconsRizal Muttaqin6-0/+10
Change-Id: I5666596ebdc320181a0ad4c893538f133efb76ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114618 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-25Colibre: tdf#141866 New Paste Transposed iconsRizal Muttaqin6-0/+4
Change-Id: Ia9d0d9213604a8fcefc44404111160179a58137b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114617 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-25Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' to 2dfdb43a09ecc8d6082240bf6b9a59ae964633bc - All large icons are 24 × 24 pixel ever since Galaxy was removed See core commit bea44e5c1b982d05314b72452b94fe288071a496. Change-Id: Ie09f3220a2add3292e55cbab088131c89c5bed91
2021-04-24Update git submodulesStanislav Horacek1-0/+0
* Update helpcontent2 from branch 'master' to 3d03b85c641c287d42edf6703c6f780896c3010d - fix menu paths and remove redundant sentence in template manager page Change-Id: I3bffaeb463589ee3272605952877b0364bbc88f8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114580 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-24tdf#82211 - Show hidden info labelAndreas Heinisch1-1/+0
Change-Id: Ibd1b3d54ff94eb5a3e7ce92d9c790721bbe23c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114378 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-24elementary: tdf#141823 unify function iconsRizal Muttaqin4-2/+2
Change-Id: I01a3f6be32a02c8762d81d27c93b38760ebfc66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114575 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-24cid#1477317 Logically dead codeCaolán McNamara1-3/+3
bIsMultiRangeRowFilteredTranspose can only be true if bIncludeFiltered is false so nRowCountInRange is always set from nRowCountNonFiltered, and nRowCountAll is then unused Change-Id: I6b15a9d84b5db475a2ba2e230acc5d09d588dfce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114588 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-24typo: NavigatoeDlg->NavigatorDlgCaolán McNamara2-5/+5
Change-Id: Ied615268001b580a3f51726cd0e57189a00e3c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-24Related: tdf#130326: GetDrawNames doesn't do anything when !bisInNavigatoeDlgCaolán McNamara1-16/+15
so return early instead of looping to do nothing though that was introduced by commit b41332475783c31136673fb44cf4c411bb0148f8 Author: Steve Yin <steve_y@apache.org> Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 so maybe its existance is dubious Change-Id: Ibb8fe1409a8e66d37d51d9a1b99ce135f36b9522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114565 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-24backend tests for linecap and linejoin typesLuboš Luňák5-5/+314
Change-Id: Id481feb25ce938b4382f970f2e1082a3594c9eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114560 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-24Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 284b35052f341add5bf7545c806eb7ce43baa34d - tdf#141818 Fix page on animation in Impress Change-Id: I092eebff7cdedf8dc250615943062342c96ec17a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114587 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-24ScriptForge - (scriptforge.py) SF_Exception.PythonShell() methodJean-Pierre Ledure1-12/+37
The PythonShell() method invokes the console() method of the APSO extension. It accepts 1 argument, which is a dictionary of variables that the user wants transferred to the console to become part of the Python context there. Typical usage: exc.PythonShell( {**globals(), **locals()} ) Subsequent print() statements executed in the user script are displayed in the console. An (untranslated - english) error message is raised when the APSO extension is not installed. Change-Id: I1b620bc041e1293234ddfd789e0ce8892dc87169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114561 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-04-24Replace list by vector (m_aTransparentObjects in vcl/pdfwriter_impl)Julien Nabet1-1/+1
Change-Id: Ie6679df3426f50b2496b2478ae2ee852f1afff46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114578 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-24Sukapura: tdf#126689 revise Continue Previous Numbering iconsRizal Muttaqin12-6/+6
Change-Id: I537fb6e1850cc0b889d0b2385c7f9adb63ce9db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114576 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-24Removed executable permission on C++ fileAndrea Gelmini1-0/+0
Change-Id: Ifaff6a048b9d174a9aa3fc9dabf62c1f8c509eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114572 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins