summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-06-27cid#1464975: RESOURCE_LEAK (sd/sdpptwrp)Julien Nabet1-1/+1
Change-Id: Icb8a1add327e7b11b4095c1e3f60cddf2ea0f5c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97275 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27map has-frame to WB_BORDERCaolán McNamara1-1/+16
Change-Id: I3f0aeceb3015bb09d6b82a631f3b001f9061d090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97265 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27those properties should use - not _Caolán McNamara1-2/+2
Change-Id: Ifae279b7ffd50cd7f977e0b03a9207355a9304a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27drawinglayer: pragma once for fontattribute.hxxTomaž Vajngerl1-13/+3
Change-Id: I1d257a34b15a65d9b988a791e154ee64e781e0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97284 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-27Breeze: tdf#133538, tdf#126122, tdf#70102Rizal Muttaqin266-88/+294
- tdf#133538: Add Show White Space icons - tdf#126122: Differentiate icons for Promote and Indent - tdf#70102: Add RTL support for outline & numbering - Add Calc's Fill icons Change-Id: I16757a199852f544b4c32a011205dea483e7606f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97282 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27tdf#90978 add exit button to impress presenter consoleSrijan Bhatia10-0/+108
Change-Id: If8a5226d700eb7a4137218191b5abc85bbb36b4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97041 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-27do not use VCL scaling algorithm from SkiaLuboš Luňák2-42/+13
The only threaded one is "Super" (i.e. the default one), and Skia at a comparable quality seems to perform better. And the code is simpler too. Change-Id: I366197fe1a033c1f7a5f5c7f9fdcc00bff74dc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97278 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27properly copy pending scale quality in SkiaSalBitmapLuboš Luňák1-1/+2
EnsureBitmapData() was using Create() to make a copy of the bitmap to scale, but the quality was not copied, so it was usually at the default (and slowest) high quality. Change-Id: I7100304a935db420e2d55c2a9450016be1195965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97277 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27cache raster scaling also in Skia's drawAlphaBitmap()Luboš Luňák1-4/+16
Change-Id: I52849097267326cb362b113241179a766d286a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97273 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27use boost::make_shared_noinit()Luboš Luňák1-2/+2
The unnecessary initialization of all elements with plain boost::make_shared() actually shows up in the profiler. Change-Id: I054b13ac74362aca7f2dfa7dc746d3a80c7f1042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97267 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27Colibre: tdf#133538: icons for Show White SpaceRizal Muttaqin15-6/+11
Change-Id: I757696ece0b06cdd91358ea8944ba5cc49a644d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97274 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27AutoCorrect: fix redundant loadingLászló Németh1-9/+2
of new localized options added by commit da64ec8c8a91db6a6ec9657898f081d5ee67e739 (tdf#133589 AutoCorrect: transliterate to Old Hungarian) and commit 77b213890a96d144d9cfacdfd35ac0bba68b9f7a (tdf#133524 add option to angle quote AutoCorrect) Change-Id: I39f97cfc5a9deb7cbe92d175b2e59ba2ab8a2707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97266 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-27Karasa Jaga: tdf#133753, tdf#133582, tdf#106229Rizal Muttaqin66-28/+33
- tdf#133753: "Base point" image in "Position and Size" dialog - tdf#133582: checkbox and radio for gen env - tdf#106229: Infobar Success type Change-Id: I4253c6737af17273043cf6941f426b89b8b74ecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97270 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-26update some pchesCaolán McNamara6-51/+28
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#103734: sc: Add unittestXisco Fauli2-0/+14
Change-Id: Iffc31232e58e0beb6c24f09ef2406c72fa502c00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97261 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26drop unnecessary includeCaolán McNamara1-1/+0
Change-Id: I8d0dd93a2bcf8c4ea1bf1f6a5ed7a866e181127b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26weld FixedTextControlCaolán McNamara4-8/+71
Change-Id: I0a2983aa4d389aa0e65aa117d576295d02460b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#118624: sc: Add unittestXisco Fauli2-0/+15
Change-Id: I377d64258d1bd93af99284eb7b74e16d7924effd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97260 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 7a9ad91c49811550018363ddda12b5d2e5563c42 - tdf#131416 Enum Basic statement syntax diagram Change-Id: I7f0ad87f1b7bd678ca46caff518272e6ec5d7928 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97139 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-26tdf#127982: sc: Add unittestXisco Fauli2-0/+25
Change-Id: I6fc4299012db9094ceec3c8146bfef317c93e3cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26UITest_writer_tests7: wait until the child is available (blind fix)Xisco Fauli1-0/+4
it fails spuriously with Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf99711.py", line 43, in test_tdf99711 self.assertEqual(get_state_as_dict(xWriterEdit.getChild('selectwidth'))['Text'], '10.00 mm') uno.com.sun.star.uno.RuntimeException: Could not find child with id: selectwidth Change-Id: If80dac67880a1f4200331a7894ba2ecae4504bb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97184 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26tdf#134106: Get rid of XDesktopInternal againStephan Bergmann5-35/+19
For internal functionality that is not meant to be called by client code, I think it is appropriate to hide it either via XUnoTunnel (but which would have been a tad incovenient, as it would have meant to make framework::Desktop in framework/inc/services/desktop.hxx available to the code in desktop/source/app/app.cxx), or via reuse of some existing, sufficently fitting interface (as is done here with css.task.XJob). This nicely avoids the backwards compatibilty issue with remote Python scripts, as discussed in tdf#134106 "Binary URP bridge disposed during call to ServiceManager.createInstanceWithContext". Change-Id: Ic9db9401ddf0f6b696344dd1d5c6ad279ea5a832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97241 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-26tdf#129681: sc: Add unittestXisco Fauli2-0/+30
Change-Id: I160774b1b3d32fb5521d3f7a184f33922839bb1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97239 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26weld FixedImageControlCaolán McNamara5-24/+80
Change-Id: I13f3480794232a9c203ae047a4fcad372988b8b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26sd signature line: allow move / resize of shape before signingMiklos Vajna1-1/+8
Once the initial rectangle is drawn, a certificate is attached to this shape. Allow modifying this shape (and only this one) before the actual signing, in case the user wants to fine-tune the geometry. Change-Id: Icdf4ffa99eaf02f81d60884d45c26b3500ea73d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97240 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-26use Skia's SkShader for blending bitmapsLuboš Luňák2-106/+150
It turns out it's sometimes more efficient to use SkCanvas::drawPaint() with SkShader::Blend() used to blend bitmaps together, rather than manually creating temporary SkImage for the blending. This way it saves memory and it also performs faster e.g. for tdf#134237, where when zoomed it processes only relevant parts of the images instead of blending a whole enlarged image). Sadly in raster mode it is sometimes still faster to cache the image (e.g. with tdf#134160), so keep the caching there as well, for when useful. Change-Id: I887ae330907100c21a0d152783fcd7e8ef230355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97238 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-26Improve loplugin:elidestringvarStephan Bergmann3-1/+57
...by addressing the follow-up TODO mentioned in the commit message of 7a3736f908c0ae207567603c61ce0f617339bac0 "New loplugin:elidestringvar" (extending it not only to uses with a constant sal_Unicode, but also to uses with OUStringLiteral). (All necessary changes have been made in preceding "Upcoming improved loplugin:elidestringvar" commits.) Change-Id: Ib0000ef9c4a1dad52124dfd039dd936cf7e3ba3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26tdf#130583: sc: Add unittestXisco Fauli2-0/+22
Change-Id: I74f2d90f4f9eb17d1833ceedd1598c1439489354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97222 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26use underlying BitmapExCaolán McNamara9-40/+36
Change-Id: I1ddc5a50a54bb230af1c76a8098c68fdb0495df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#134039 Chart view: fix moving pie chart areaBalazs Varga3-2/+7
Do not allow to move data labels, when we create data series for the first time, in case of pie or donut chart, but allow to move when we recreate data series for pie or donut chart. Change-Id: If0d61116da1524d15553f8a80453ce2003484d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96534 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26There is no mysqlc moduleTor Lillqvist1-1/+0
Change-Id: I0106f5a86b86e40e97bbaf6918bc77601bd3a7fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97220 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-26QueueInfo must be VCL_DLLPUBLIC now also for --enable-mergelibsStephan Bergmann1-1/+1
...after 1a6b0f167d8ecba3b3d07fd48c43394e38b58702 "vcl: split off QueueInfo to own files" made its member functions non-inline; see e.g., <https://ci.libreoffice.org/job/lo_callgrind_linux/8949/>: > /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/sw/source/ui/dbui/mmresultdialogs.o: in function `SwMMResultPrintDialog::PrinterChangeHdl_Impl(weld::ComboBox&)': > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/source/ui/dbui/mmresultdialogs.cxx:754: undefined reference to `QueueInfo::GetPrinterName() const' > /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/source/ui/dbui/mmresultdialogs.cxx:755: undefined reference to `QueueInfo::GetDriver() const' > collect2: error: ld returned 1 exit status > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/Library_swui.mk:20: recipe for target '/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/libswuilo.so' failed Change-Id: I26b0591142c8936ed82488bdbcebb098208c705c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26improve tab traversal in addons with native widgetsCaolán McNamara4-0/+52
Change-Id: I55d0390522122cc4409ea14274e756881315df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97219 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26weld SpinfieldControlCaolán McNamara5-138/+146
Change-Id: I1696105ead648c86076f05f50f6286e9a3a932d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26extend FormattedSpinButton to allow custom input/outputCaolán McNamara3-0/+69
Change-Id: Ie84c1d46bc6fa3e29ed97147de486911dc6ecc0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: writerfilterStephan Bergmann1-3/+3
Change-Id: Ib06004b058c8079692adabd384dca72b63e8167a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: xmlsecurityStephan Bergmann1-1/+1
Change-Id: I1490e79489a98dd97ec31d6b52b4f05a1411de79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: xmloffStephan Bergmann1-1/+1
Change-Id: I7425d26955b6083df286fd8b417b2054d4298dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97211 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26SAL_DISABLE_GLYPH_CACHING is OpenGL-only againLuboš Luňák1-1/+1
Change-Id: Icafc5a7b7ea5bed67a0a44db6e4e92b3beba55c0
2020-06-26Upcoming improved loplugin:elidestringvar: vclStephan Bergmann1-2/+1
Change-Id: I4ffe3cfd0ed9a45607e978df88ae230ec04a152b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: swStephan Bergmann6-12/+7
Change-Id: I8cfc70f45a1fe8dff6c272ba617e73cf97480092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: scStephan Bergmann2-3/+2
Change-Id: Ic53ec0c5ffd661073742151c6c012a1dc1b88f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: reportdesignStephan Bergmann1-2/+1
Change-Id: I252db93acdf471062fe2a66bc49c732e2e7c5415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97201 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: lotuswordproStephan Bergmann1-4/+1
Change-Id: If39fbdf78bcac3394927c6a973cd5da36c1b35d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26optimize SvtBroadcaster::Normalize() even a bit more (tdf#132454)Luboš Luňák2-34/+46
Optimize also maDestructedListeners (often just one item). Optimize also small vectors if there's just one item unsorted. Keep the index of the first unsorted item in maListeners, so that it's cheap to find out where the unsorted part starts. This now improves tdf#132454 to 20s. Change-Id: I21a69b440c27a2e31e74fd13b9263f54af12e320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-26Upcoming improved loplugin:elidestringvar: basicStephan Bergmann2-4/+2
Change-Id: Ie5422ac19289693c44ce81548a74bd727bb0be36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97193 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26android: Add a CP x86-64 configuration.Jan Holesovsky1-0/+4
Change-Id: Icdfee0a6609487f5ac2423c74344cb605b7e4fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97130 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-06-26solenv: fix Android buildMiklos Vajna1-1/+0
Change-Id: I6938049072f458f45d47a1a5ae8901767d95e83b
2020-06-26tdf#134285 select the item before dragging itCaolán McNamara1-0/+1
so we don't get the previously selected item Change-Id: Ifd6e46d97f1de0de86403b9c237ee8d2cd3a6cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97187 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26Related: tdf#134280 set max limits for solver options that show max valuesCaolán McNamara2-0/+20
just simply clip to the claimed max Change-Id: Ie64da80204c9c817c85724abd1fee8c6594967b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>