summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-06-26Introduce a --disable-gpgmepp option instead of the ad-hoc build_for_iosTor Lillqvist1-5/+10
Change-Id: I70ac1fe2f3a91e2fea39fc1a5133ee082f8055e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97197 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-26Upcoming improved loplugin:elidestringvar: editengStephan Bergmann3-15/+9
Change-Id: I8181697f608f8472482905b21328744fe7909349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97196 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: connectivityStephan Bergmann1-2/+1
Change-Id: I50676f940abb36091e175d7469806e8ccc6ba7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97195 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: chart2Stephan Bergmann1-1/+1
Change-Id: If64cf392b3b77994c3f57660a7ddc6bf1db5b0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: basctlStephan Bergmann2-2/+2
Change-Id: I3b570313cd04c3af92e1e30ec4539de34398104f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97192 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Handle uno_threadpool_dispose in parallel with uno_threadpool_putJobStephan Bergmann2-3/+8
While tracking down the issue discussed in the commit message of 78dc7d982b65c1843a288b80da83f8766e85d0cf "Remove a potentially already enqueued response when a bridge is disposed", it occurred to me that there should be a race in those uno_threadpool_putJob( bridge_->getThreadPool(), ...); calls in binaryurp/source/reader.cxx, when the bridge gets disposed (through some other thread) between the time the bridge_->getThreadPool() call checks for the bridge being disposed (in which case it would throw a DisposedException) and the actual uno_threadpool_putJob call. I tried to catch that with a previous incarnation of this change (<https://gerrit.libreoffice.org/c/core/+/96120/1> "Jenkins Slides Through the Tiny Window"), but couldn't---presumably because this race would be very rare after all, and the issue I was chasing turned out to be caused by something different anyway. Nevertheless, I wanted to address this potential race now. We can only reliably check for disposed'ness after having locked ThreadPool's m_mutex in uno_threadpool_putJob -> ThreadPool::addJob, but at which time we can no longer indicate this condition to the caller---uno_threapool_putJob is part of the stable URE interface, has a void return type, and should not throw any exceptions as it is a C function. However, if the bridge gets disposed, any threads that would wait for this job (in cppu_threadpool::JobQueue::enter, either from cppu_threadpool::ORequestThread::run waiting to process new incoming calls, or from a bridge's call to uno_threadpool_enter waiting for a respose to an outgoing call) should already learn about the bridge being disposed by falling out of cppu_threadpool::JobQueue::enter with a null return value. So it should be OK if uno_threadpool_putJob silently discards the job in that case. Change-Id: I36fe996436f55a93d84d66cc0b164e2e45a37e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96120 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26vcl: split off QueueInfo to own filesChris Sherlock16-31/+106
Change-Id: Ib2904066edd371229c5daa09b81b210e99853895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96251 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-26Customize: Update description box on auto selectMuhammet Kara3-0/+7
When you open the dialog, select a category, or enter a search/filter term, the first entry on the functions list was selected automatically but the description box was not updated properly. Change-Id: I23737c540ab67af3e79694365b8c8c31c4f60ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97188 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-26LibreLogo: add command FONTTRANSPARENCYLászló Németh2-1/+12
similar to PENTRANSPARENCY, but for semi-transparent text. See commit 6fafae4d109f5768621a11deb394b1b0c4dc5606 (editeng: add UNO API for semi-transparent text) Change-Id: I5813c0954a1bb7740b3e164a39db7611753183a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97168 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26tdf#123786 AutoCorrect: fix apostrophe in RussianLászló Németh3-9/+62
and Ukrainian at "Single quotes" replacement outside of second level quotations. For example: „quote' -> „quote‘ but now apostrophe' -> apostrophe’ instead of the bad apostrophe' -> apostrophe“ Change-Id: Iad69b7f88ab9677f25ee0f806d035e16cdebe29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97096 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26tdf#133524 AutoCorrect angle quotes for fr-CH and gl-ESLászló Németh1-2/+7
Note: << and >> replaced with single angle quotation mark ‹ and › in Swiss French, according to the apostrophe related changes in tdf#116062, see commit b9910e87de4eea1cb3684bb7af8e58d681cbe809 (Resolves: tdf#116062 revert [fr-CH] to use previous single quote characters) Change-Id: I84c54b7c12d2b3a2a53e4daf876bfba11985fdea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97095 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26tdf#133524 add option to angle quote AutoCorrectLászló Németh10-9/+58
in Localized Options page of AutoCorrect Options dialog window: [x] Replace << and >> with angle quotes Note: this is optional part of Double Quotes replacement. Change-Id: Ib0c7e8837a89c3772c5db76720811d440e62183a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97094 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26xmloff: remove dead com.sun.star.comp.Impress.XMLMetaExporterMiklos Vajna3-15/+3
And test com.sun.star.comp.Impress.XMLOasisMetaExporter instead in JunitTest_xmloff_unoapi. Change-Id: Iec2da56b569c283686de1bd4aad5fb7ebebfbc2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97183 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-26tdf#130711: [tr] Extend Autocorrect list for Turkish language (Start with M)Ayhan Yalçınsoy1-0/+78
Change-Id: I5a607f2aaa7b623e7b634aa243062b75ebb7107f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97186 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-25tdf#133026: Tight integration of extensions - Additions Dialog first iterationYusuf Keten20-0/+917
- Add the uno command .uno:AdditionsDialog - Add the necessary commands to cui makefiles. - Add the dialog AdditionsDialog for only test - Implement the basic functionality to show up when clicked on the menu/toolbar item. Change-Id: I89dd74e49f5ff246ca355d2f8d1397621b26dea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95593 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-25update svx pchCaolán McNamara1-5/+10
Change-Id: I70b0ac22454aefc03d9cca04c576704f7abdb73c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25tdf#133326: sc: Add unittestXisco Fauli2-0/+57
Change-Id: I2436822fa289ae1bf10643cfc5232f4db6df2e29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97150 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25weld NavigatorTreeCaolán McNamara14-721/+708
Change-Id: I019021fa5a522b1238d74702c9222afdfd7540c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25nActiveTerm is -1 in an empty filter navigatorCaolán McNamara1-3/+1
Change-Id: Ia6eed6291375f136abbe8e50abae51e6f796911f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25loplugin:virtualdeadNoel Grandin7-52/+93
Change-Id: Idcaaecd5be080e43b731f8edcbbfb8aed5e2e28c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25handle nullptr pointers in Skia debugging functionsLuboš Luňák3-1/+8
Change-Id: I2c500444f97f66b03cc0e0a27581ced4d1cfbf22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97102 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-25log properly the compiler used to compile SkiaLuboš Luňák6-12/+41
Using #define's directly from VCL will report the compiler used to compile VCL, which may be different from the one used for Skia. Also truncate the log file on opening. Change-Id: Iddf613613df20505f1abe1dd5468dcc8c7041410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97090 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-25sd signature line: pass the model down to xmlsecurityMiklos Vajna9-34/+126
So it can avoid SfxObjectShell::Current(), which is only correct when a single document is open. Also add an sfx2::DigitalSignatures interface so this can be done without UNO API changes. Change-Id: Ie81996b8f1e8851975b27c43a53f9d23e316004e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97116 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-25UBSan needs SwSidebarItem RTTI outside of Library_swStephan Bergmann1-1/+1
e.g., <https://ci.libreoffice.org/job/lo_ubsan/1672/> > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so: undefined symbol: _ZTI13SwSidebarItem" after e619d685a4ac4e8a20f047be3fe00f5b492553b8 "sw: make postithelper.hxx self- contained" Change-Id: I42debde887b7cbd64c28efc4421cf076bc34ee38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97109 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-25-Werror=maybe-uninitialized: may be used uninitialized in this functionNoel Grandin1-3/+3
Change-Id: Iae4ca4fb760bd0fae8e26e6c77f20159cfb61388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25tdf#134234: sc: Add unittestXisco Fauli2-0/+15
Change-Id: Ie49cabb8ba10aaa8ec4453f6284b86617e98d490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97103 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 1057374f655ad0f05c517b888be837825a33b781 - Missing Math icons in ref pages replaces png-> svg Fix icon size refactor <tablecell>s refactor <literal> when no translation involved Change-Id: I3d6ee877d050eaa78c3916a627f4f97db25e1330 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97115 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-25Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to edd797863d4a748784ba72c5148c434e8c5977dd - tdf#132464 Enhance Help for sumation icon Change-Id: Iec55f78002beb2052e0d49089f1b3a09171fa43f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96784 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-25sd signature line: place shape on the correct pageMiklos Vajna7-7/+363
PDFDocument::Sign() had this hardcoded to always place the signature widget on the first page, add a way so that xmlsecurity/ can tell the pdf signing code to put it on an other page. This way in case the user created the signature line shape on the Nth page, it'll end up on the Nth page of the PDF result as well, as expected. Change-Id: I63decba98774151e9634ea924c2fed0f7814cb28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97045 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-25UITest_writer_tests7: Wait for async events (blind fix)Xisco Fauli1-0/+4
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62483/> failed spuriously with ERROR: test_tdf133348 (tdf133348.tdf133348) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf133348.py", line 44, in test_tdf133348 self.assertEqual(xEnum.nextElement().Author.strip(), 'Known Author') tdf133348.com.sun.star.container.NoSuchElementException: SwXFieldEnumeration::nextElement Change-Id: I5504f6febb20eb174b480f0d38176b1a70407716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97097 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25tdf#134291: make all hatch patterns translatableJulien Nabet3-24/+44
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=30a6e9e991fd1b62ead2d393331a0364372c52fb tdf#130928 Area Fill update hatcch section Change-Id: I75377f86bb8eafc24d739073e0341168637f7d62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97093 Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-06-25Rephrase commentStephan Bergmann1-3/+3
760980b0b510acac555f0c252fbaa10a4751bded "Fix typos" had, IMO incorrectly, removed one "that" from ..., so that that asynchronous request would... Lets rephrase the original comment in a less problematic way. Change-Id: Ic13ffaad43e2777eb36425363851b53f2f641865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97087 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-25tdf#130711: [tr] Extend Autocorrect list for Turkish language (Start with I-L)Ayhan Yalçınsoy1-4/+102
Change-Id: I52d6f91d1f216c0778881affa8d0ab1e2e753915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94360 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-25optimize SvtBroadcaster::Normalize() a bit more (tdf#132454)Luboš Luňák1-4/+11
A common case is just one unsorted item at the end, in that case it's even more efficient to simply insert it in the right place. This further improves the tdf#132454 undo operation 36s->27s. Change-Id: I29db80fb8292e827b655000cddc462cf87cb485d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97088 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-06-25Get the property dump of the text at the cursorShivam Kumar Singh4-13/+197
We need the property dump consisting of 1) Character Properties 2) Paragraph Properties 3) Character Style Properties 4) Paragraph Style Properties This patch gives all the properties related to 'Character Styles' at the cursor. This patch manages inheritance features, which means, it lists any property only at that level in which the property has been redefined for the last time. Change-Id: Ice2ae9ac92aec4af9d395885e06602753e636457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin44-302/+316
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25tdf#125893 DOCX import: fix "half" contextual paragraph spacingLászló Németh3-2/+20
Always ignore own top margin setting of the actual paragraph with contextual spacing, if the previous paragraph is identical. I.e. in that case, too, when the previous paragraph has no contextual spacing, like MSO does. Note: PARA_SPACE_MAX mode hasn't included this modification, yet, so only ODT documents converted from DOCX use it at the default setting. See also commit ba18832ceeda21f047a664b71a4333a54737e6c8 (tdf#75221: make margin collapsing implementation conform OASIS proposal) Change-Id: Ida9d12b2c511fcd5e38ade7eb5f4650387c65813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97081 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-25Revert "tdf#133858 opening spreadsheet with large array formula takes 10 ↵Noel Grandin1-9/+0
mins" (tdf#134234) This reverts commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c. Reason for revert: causes regression, see tdf#134234 Change-Id: I1cc3e6daa0e65231e8a4d7c1ae4a60cfdf106457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25sw: handle BackgroundParaOverDrawings when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 18b3feb8bef06bf7b126fd0bc743e19479cb8026 (n#778133 sw: add BackgroundParaOverDrawings compat flag, 2012-09-12), it's off by default and on for DOCX documents. Change-Id: If584f8eef2672d5d41c249e2b77b20f029587e23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-25loplugin:unusedfieldsNoel Grandin14-151/+138
Change-Id: I7d8cd41c6b4b97a6d33764a8580f08413e584a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25Fix typosAndrea Gelmini4-4/+4
Change-Id: I2bccc7beb2e9dfccd84b118a33a7aee9753a8be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-25LOK: duplicating multiple slidesPranam Lashkari2-1/+70
Change-Id: Ic2e870bf2ec3b236e2babf6c090bf3ec1978776e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94817 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-06-25LOK: Allow deleting multiple slides from slidesorterPranam Lashkari1-4/+21
Change-Id: Ie371e7eb5a96655fd281b4137243aa8628b6283b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94816 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-06-25LOK: slide sorter: update the model on selecting multiple slidesPranam Lashkari1-4/+25
Change-Id: I17bdd8e39c960a81d4bef2a8cffd42103adb5341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94715 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-06-25Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' to 4847445f1d2ba57767dfb3be236b112e7187a04d - tdf#133640 Replace problematic colors to make links discernible … and add back their default underlines, but dimmed. I still think this looks busy, but I shall get used to it. It’s more a11y-friendly this way. Also, the old, green footer line is gone, since it doesn’t really fit in since commit 4d6b5e5f74c50cc440a46fada8fa89ad2f946749. Change-Id: Ie9feb3cc232ec249dbe323c2ec4b761c12e91ad6
2020-06-24update creditsChristian Lohmaier1-1484/+1583
Change-Id: I0295600d528facb0411981a68c1c8a4224bf1dc5
2020-06-24fix JsonWriter::reallocBufferNoel Grandin1-0/+1
was not updating mSpaceAllocated Change-Id: Ie5404e58c6520d32b72c19ddfa58b2ab2b895199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24loplugin:unusedmethodsNoel Grandin21-411/+144
Change-Id: Ib724da1f07be9e8f4d0d505f7f2886990cab661f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24tdf#134280 set legal range for Epsilon levelCaolán McNamara2-0/+8
Change-Id: If544da13913ab6ce84e934e351e4e2d78b6e1466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 35a0244b536543f2f4a7bb0b1350e6b3caa295dd - Fix list formatting in QR code page Change-Id: Icf81d65d1d6ce5850112f76e10430459620a8b65 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96782 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-24 23:51:32 +0000