Age | Commit message (Collapse) | Author | Files | Lines |
|
Regression from commit 8512f4ca090c85477a6670438aeefe7fdfcf8a98 (build
nss using their new build system (gyp/ninja-based), 2020-02-19), the
problem was that for some reason nss was pre-loaded in the past in some
magic way, but after that commit we need to do this explicitly.
Additionally, if the core.git build is a debug one, we now get an nss
assert that checks if there was a fork between loading and using nss. I
don't think that was enabled before, so just patch that out to fix the
build breakage on the online.git side.
online.git's unit-password-protected now passes again with this.
Change-Id: I56c0019c446b4cabbb73141bbff80e8d8ffdb54c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91068
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ib4ad1a46a176b7043b1b87f430f442c13f3db8dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90941
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Change-Id: I82d37d0277e324e269674ed40592026e0097fa33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91027
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91031
Tested-by: Jenkins
|
|
Change-Id: I02fe3f93edf94829b4456df2e8a7740698cf5263
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91066
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
The bug is most likely caused by some code checking only the OpenGL
setting and doing something, even though the Skia setting takes
precedence. So make sure VCL OpenGL is considered disabled if Skia
is enabled.
Since isVCLOpenGLEnabled() is called right before setting up
the X11 visual, which is normally needed by isVCLSkiaEnabled()
to get Vulkan info to check blacklisting, this also requires using
a temporary Skia Vulkan context using the default X11 visual
to avoid the dependency loop.
Change-Id: I2d9d9e81ab4ed5021b5f42e3c272dcd10fd32cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91044
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
in wmfemfhelper when converting Metafile to
sequence of Prmitives. In the MetafileActions
MetaLineColorAction and MetaFillColorAction
usage of COL_TRANSPARENT must switch off line
draw/resp. fill
Change-Id: Id5754773c06b7f4aa8824dce9b8b9e7e526e6067
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91061
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: I62811de63906401194c85ac215d5fe74b50b5b56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91047
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
When constructing a shape object from property EmbeddedObject,
it may return null object. Check the returned value first.
Change-Id: I9d7a2d9c0c919007ae2a34a0af86dea5639b1bd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91024
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ie784468030bf612ba4209e0619d07032a488f700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91011
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Restores a condition which was removed in 8de98e61fbc96bf523b3dec7e1e52eb7e2d7693e
Change-Id: I68a9f8a362d2ded9975e7c73e2a0533aa5ad9e94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91053
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I8bb100478d88136d55a9b076464489f5d66c2ad7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91052
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ide2643349fbf5cdf79e68c2c504d1cd486c09d7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90996
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I9a127f5066405225d35dd0590e84168b3bd86790
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91049
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
At least on my Windows machine I had always had
C:\Program Files (x86)\Ninja 1.7.1
in Path, so that `which ninja` in configure.ac puts
export NINJA=/cygdrive/c/Program Files (x86)/Ninja 1.7.1/ninja
into config_host.mk, with spaces and parentheses that need to be quoted here.
Change-Id: I938f8914cbc9b7eff7a41009f12cd95abeb4421c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91042
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...at least in a Windows --enable-mergelibs `make screenshot` build
Change-Id: Id1168d5c0a4c417144a2d10a9ddc8ff1b33525f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91043
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
one of caolans test files, which appears to have a row layout which
references a non-existent parent.
Change-Id: I9322ed430aa9edd47db9967a19938b02e4af6bc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90475
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
identifier_typo: Using "Libreoffice" appears to be a typo:
"Libreoffice" is only known to be referenced here, or in copies of this code.
Identifier "LibreOffice" is referenced elsewhere at least 19 times.
Change-Id: I201bcc7e226dde52eed2c0281d2b9839a234af1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91033
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This dates back to the ancient times where no revision control history
dares, so no idea why this was so, but it doesn't make sense, as
at least Windows can disable AA for fonts too. And if some platform
really wants to hide the setting, it should be enough just to hide
the UI element, no reason for '#if defined( UNX )' all over the place.
Change-Id: I76fc9ad157358321904573079ace5a3fe556f86a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91041
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
- Update Curve & Freeform icons
- Add larger Cell Styles icons
- Update Navigation Data icons
- Update Numeric Field icons
- Update to Curve & to Polygon icons
- etc
Change-Id: Iffa13ee13fac13ba5b95f14496efa5419154b1a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91028
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change italic in Spanish from C to K
Change-Id: I5b1da84983827a17565143bda984d7ae3b5e0518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91040
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
immediately at least in the case when LOKit is active.
This is to allow prompt emission of .uno:ModifiedStatus=true statechange
message from lokit to the client. Without this, in online the chart
insert/modify related changes may not get saved on client exit.
Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f
(cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
|
|
The old test was always true (as -f/usr/share/java/flute-1.3.0.jar is not the
null string), so in a --with-system-jfreereport build that did not explicitly
configure --with-flute=..., FLUTE_JAR was always set to
/usr/share/java/libxml-1.0.0.jar, even if that file does not exist (as e.g. on
Fedora, where e.g. flute-1.3.0-22.OOo31.fc32.noarch includes
/usr/share/java/flute.jar instead).
The only use of FLUTE_JAR is in gb_Jar__use_flute in RepositoryExternal.mk, and
the only use of that is in reportbuilder/Jar_reportbuilder.mk, but which seems
to not mind if the given jar doesn't exist?
Change-Id: Iea94ed34b4df61d2abed67b54bd4caa24ede7e80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91039
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
For a PDF we create a BitmapPrimitive2D only, so it doesn't have
any metadata in the primitive sequence itself, but a call to the
getVectorGraphicData() method will render the PDF in order to
create the BitmapPrimitive2D. This is a problem when we have
multiple pages as we want them to be rendered on demand and not
right away on load.
This change short-circuits the gathering of metadata for PDF to
prevent unnecessary early rendering of PDF pages.
Change-Id: If5c286e88e72c4c0ba5083a98c7db707d207b6cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91034
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Idc88476213a01643f5ba6b8ea9fbee78673d7769
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91032
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I959a8bcc133d5f54ce991dff490ef339698be58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91025
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I22dad8c614e04da2234746834fffa8365c71d713
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90226
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I877364593025de65695995729a12294748c949ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91010
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
regression from LO 6.4
commit 2756ed9317e3474003c11ffe7d1e2f087c1412bf
Change-Id: Iaf32974c7282d11bcd9572ed75cf1233ad3f0008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90321
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Found by:
run-clang-tidy-10 -checks=-*,misc-unused-using-decls
Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I4897a6f2622e3e219f8b7b93d818d2edca03b117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91008
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
See CustomTarget_postprocess/check_dynamic_objects (in a
--with-package-format=... build) failing after
8512f4ca090c85477a6670438aeefe7fdfcf8a98 "build nss using their new build system
(gyp/ninja-based)" with
> instdir/program/libsmime3.so has no RPATH
> instdir/program/libnssutil3.so has no RPATH
> instdir/program/libnssdbm3.so has no RPATH
> instdir/program/libfreeblpriv3.so has no RPATH
> instdir/program/libsqlite3.so has no RPATH
> instdir/program/libfreebl3.so has no RPATH
> instdir/program/libnssckbi.so has no RPATH
> instdir/program/libnss3.so has no RPATH
> instdir/program/libsoftokn3.so has no RPATH
> instdir/program/libssl3.so has no RPATH
workdir/UnpackedTarball/gyp/pylib/gyp/generator/ninja.py already has logic to
add -Wl,-rpath=$ORIGIN/... to certain link command lines, presumably for
building certain executables, but of which we apparently include none in
ExternalPackage_nss, so it shouldn't hurt to keep them using that other
-Wl,-rpath=$ORIGIN/... I have no idea whether there would be a cleaner way than
this patch to pass an additional -Wl,-rpath=$ORIGIN to all link command lines
via the invocation of build.sh in ExternalProject_nss (even if those executables
mentioned in the previous sentence would then have two -Wl,-rpath=..., that
should not hurt in practice).
(Most, if not all of the rpath-related hunks of external/nss/nss.patch that were
needed for the make-based nss build on Linux et al prior to
8512f4ca090c85477a6670438aeefe7fdfcf8a98 can probably be removed in a follow-up
commit.)
Change-Id: I65eaf52efeb6feceb8540e0aedf340f9a9a18599
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91012
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Fixes suggested by SteenRønnow
Change-Id: I21e9ec2084baff3fb4cbbf9a3cadcf63662c1da6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91021
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
TOTD: Tip Of The Day
Fix suggested by vpanter on weblate instance
Change-Id: I545819bf7581b45776cdc07aa3731e2a69885082
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91015
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Reported by Tuomas Hietala on our weblate instance
Change-Id: I699fa4c231d4a4ad4f474fe72183f89104c1a532
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91014
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: Iea7866df74ad2ea68c8d797f1fa75f384e1e2ac4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90999
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Fix function name typo and actually prepend the footnote frame,
as the original code did. So much about "easy refactoring" :-(
Regression from commit 24caeee8236576abd92086974c1dbbf15b81a4c5
("Refactor a bit of the footnote handling code").
Change-Id: I227e30bc169fdfc237a5239d3ade6f035d85ca6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91004
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I7ef4acfd009c9e7fa0adf31a2f50f507b957bac9
|
|
Change-Id: If388ef4544001fb9064aed3ce979c2790ab0645f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90997
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
The problem is that at the end of WW8 import, a delete redline is
inserted that ends up calling DeleteAndJoin from inside
AppendRedline(). A fly is anchored AT_CHAR at (node 46, offset 0)
and the deletion goes from (node 46, offset 0) to
(node 48, offset 13) hence the special case check in
IsDestroyFrameAnchoredAtChar() for the IsInReading() prevents it
from being deleted, and then its anchor is still registered at the
node 46 when it gets deleted.
So try to restrict the WriterfilterHack to writerfilter, so it won't
affect WW8 import.
Unfortunately this is far less obvious than expected, because import can
happen for creating a new file, in which case it's all done via UNO in
writerfilter, or when inserting into an existing file, in which case
SwReader::Read() is used.
The SwDocShell's pMedium can't be used becuse in insert file case it
will be the loaded file, not the inserted file.
There isn't any obvious alternative to adding a silly UNO property for
the writerfilter to use.
Change-Id: Ia7fdc9bb1925202f6692ebee6e4b6b1fe50e5345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90384
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
warn: sal.osl:19830:19830:sal/osl/unx/module.cxx:162: dlopen(instdir/program/libvclplug_genlo.so, 257): instdir/program/libvclplug_genlo.so: undefined symbol: _ZTI20FreetypeFontInstance
This was originally done in commit
781c4402f1a8c64f87bc81e866bc444b9ed97948 (make some classes
module-private, 2019-11-02), but it did not cause problems till
recently.
I guess this started to be a problem when the gen vcl plug started to
interact with freetype directly in the skia case.
Change-Id: I05ef0ff4446de32deccff6d7ee1fde991e5a0256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90995
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Online just listens to .uno:FillFloatTransparence but the set-item
in core it corresponds to, does not represent the fill-transparency
types like 'None' and 'Solid'. This is represented by another item
called XFillTransparencyItem. As a result the mobile wizard does not
show the correct transparency fill type always.
To solve this, this patch encodes the constant transparency percentage
in case of Solid and None(always 0%) as an intensity and stores this
info in the statechange message of .uno:FillFloatTransparence whenever
there is no gradient type and corrects the 'style' attribute of the
message appropriately.
More detailed information is provided as comments at appropriate
places in the patch.
Change-Id: I443ef4ce349badf28f6c2c702b1014868d9c6ed5
(cherry picked from commit 34969e9c04f9305d19826c72a29e38e26794cbe3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90986
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to 81a863eb6fe5932e2161266dae6e7bfb4152a0c4
- README: Add Weblate badge for helpcontent2 l10n
Change-Id: Ieb89f42e51a04bfa73732a779a92b79a755bc644
|
|
Change-Id: I865ad6e7546b829306ee5c2a8648068ec4c151c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90980
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
According to the mailing list thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2020-March/084722.html>
"Reasonable boost baseline?", 1.66 should cover --with-system-boost at least for
contemporary Debian, RHEL, and SUSE based distros.
And at least our AX_BOOST_BASE from m4/ax_boost_base.m4 by itself only issues a
AC_MSG_NOTICE if no appropriate Boost is found, so add an explicit AC_MSG_ERROR
to make configure fail in that case.
Change-Id: Ifdf6566af785f613c62f9c5a4b85cf80cec672c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90985
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Also assert that correct data type is passed to SbiStringPool::Add.
Change-Id: I774d983be82d702b31de1054d13661e1d0e9c1dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90983
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This reverts commit 9bf40c635c41c6b3b072b7c61fea67a20ba4342b.
Reason for revert: This apparently causes builds to hang. Witness all the six failed Jenkins builds for <https://gerrit.libreoffice.org/c/core/+/90079> as well as <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/29218/> and following.
Change-Id: I441e04cba0f1234cdc200a9aa714b166bda4ab89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90950
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to cf6f0df5ad826b72513b2f1c465518bfe723c72e
- Fix to Property misleading snippet
Change-Id: Ie96f829d21384a9adab81e9b007d0773c035b97c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90948
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Makes expand and collapse all work from the outline context menu and
ctrl+* short cut for all vcl plugins
Change-Id: I6cec6f1b4dedfc62216028b24d09d7f402a387cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I0aca4af1bd79f28bf1c920a4d05e80948106aaac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90971
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
settings after file opening, if its value is true in the opened
ODF or OOXML document, instead of always showing disabled state.
Testing notes: double click on a data label during chart editing
to see the Data Labels for Data Series... window. On the page
"Data Labels...", click on the Number format... button to see
the checkbox "Source format".
Change-Id: Idb837d9492ad7e83b9020167c47ed52499c070a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90079
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|