summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-05-22Bin dead codeTor Lillqvist2-181/+0
OleServer::provideService() was not called anywhere. That means the ProviderOleWrapper class is unused, too. Which is good, as it seemed to largely be identical to OneInstanceOleWrapper anyway. Change-Id: If8782d56ed1ec1bb173cfc18be585be4c331f335 Reviewed-on: https://gerrit.libreoffice.org/54647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-22vbahelper, xmloff: Ask current datetime only onceTakeshi Abe2-9/+8
Change-Id: I930983fab11d30f0887965fe30b07c5ac6eef8ef Reviewed-on: https://gerrit.libreoffice.org/54651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22tdf#108523 Remove @author annotationsAbhyudaya Sharma10-181/+25
Change-Id: Icd9cd2c17657001058f09c4042804a91b4f1d1b1 Reviewed-on: https://gerrit.libreoffice.org/54539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Turn debug fprint in vcl/unx/generic/fontmanager/ into SAL_INFOStephan Bergmann3-45/+26
...mapping OSL_DEBUG_LEVEL > 1 ones to "vcl.fonts" and OSL_DEBUG_LEVEL > 2 ones to new "vcl.fonts.detail" Change-Id: I750b4915083c4a0f9d0310a667987ff33d7fcc2a Reviewed-on: https://gerrit.libreoffice.org/54526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-22Place help button on the left of signature dialogOlivier Hallot1-10/+14
Change-Id: Ic78646b7540d2eaf176b3b6c57b0225793b866bd Reviewed-on: https://gerrit.libreoffice.org/54597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Fix svg to base64 conversionSamuel Mehrbrodt2-20/+2
This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had a questionable fix by unconditionally removing the first 8 bytes of the svg which led to svgs starting with rsion="1.0" encoding="utf-8"?> instead of <?xml version="1.0" encoding="utf-8"?> Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03 Reviewed-on: https://gerrit.libreoffice.org/54550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Don't pass ODF version, just retrieve it directlySamuel Mehrbrodt3-9/+6
Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf Reviewed-on: https://gerrit.libreoffice.org/54483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Rename parameter bScriptingContent -> bSignScriptingContentSamuel Mehrbrodt2-3/+3
Change-Id: I227e59417719625a9752e727060f5e4f5094092d Reviewed-on: https://gerrit.libreoffice.org/54479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Simplify SignContents_Impl by moving readonly check to caller methodsSamuel Mehrbrodt3-127/+148
Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44 Reviewed-on: https://gerrit.libreoffice.org/54478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Reduce indentation by returning early on error conditionSamuel Mehrbrodt1-137/+139
Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c Reviewed-on: https://gerrit.libreoffice.org/54475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#97231: basic: do not use extra wrapping for string marshalingVasily Melenchuk1-5/+12
previous approach did wrap string reference once again, making practically "a pointer to pointer to string" so this code was not working correctly for RegQueryValueExA WinAPI call. String is already provided as a reference (see marshalString(), so no reason to wrap its reference. This approach was just copied from from dllmgr-x86.cxx plus some minor changes to make both versions similar. Change-Id: I85065112407de3f078265d2c76437814402eb1b3 Reviewed-on: https://gerrit.libreoffice.org/54645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-22Fix misleading comment: We do check HAVE_FEATURE_READONLY_INSTALLSET...Tor Lillqvist2-3/+4
...at least in a couple of places, and at least for a sandboxed macOS build that check does its job, it prevents write attempts into the app bundle. Change-Id: I6d243d3e8a4c77f03a8265125aefd75becbf0998
2018-05-21tdf#117189 Fix table InsertRow redoJim Raykowski1-1/+1
Change-Id: I92ce18105550d9514b18b81080cfd0c19dfe648b Reviewed-on: https://gerrit.libreoffice.org/53618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-21uitest - Calc standard filterZdeněk Crhonek2-0/+745
Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd Reviewed-on: https://gerrit.libreoffice.org/54636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-05-21weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFieldsCaolán McNamara24-526/+532
Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900 Reviewed-on: https://gerrit.libreoffice.org/54541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21weld SfxCheckinDialogCaolán McNamara4-53/+54
Change-Id: Iaa7954baf734229683acb81819daa332b02a7733 Reviewed-on: https://gerrit.libreoffice.org/54624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21loplugin:staticaccessTor Lillqvist1-1/+1
Change-Id: I9e8accc56fc1d3b095390944a5ae2fc80bcbc05d
2018-05-21Activated notebookbar in drawKshitij Pathania10-3/+173
Added tabbed and two groupedbars mode of notebookbar. Change-Id: I208a365139ca6c83510a73a8ffa0260b05787793 Reviewed-on: https://gerrit.libreoffice.org/54547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-21check-elf-dynamic-objects: Fedora 28 GTK+ depends on libfribidi.so.0Michael Stahl1-2/+2
... so add it to whitelists. Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf Reviewed-on: https://gerrit.libreoffice.org/54607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-21sw: Ask current datetime only onceTakeshi Abe2-4/+6
Change-Id: I99bed9a09ed1701ce441ddb0a19b5259ab37f135 Reviewed-on: https://gerrit.libreoffice.org/54621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21Updated coreOlivier Hallot1-0/+0
Project: help 4e45182924569adab9bc43ec174b3c4c828c7452 tdf#102259 formula groups at Statistics tab page Change-Id: I206139776c77e8855bd82fc5b5ffaa6c0ec60147 Reviewed-on: https://gerrit.libreoffice.org/54627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-21dont use SwClient/SwModify in unocore: RefMarkBjoern Michaelsen2-34/+30
Change-Id: I021f410793c9debfe5e984d591144636d6793fd6 Reviewed-on: https://gerrit.libreoffice.org/54610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-21weld ODateTimeDialogCaolán McNamara4-114/+88
Change-Id: Id93147f1d442e1e5f1cfba8ef2f9e476f4f6d728 Reviewed-on: https://gerrit.libreoffice.org/54623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21In fact it's simpler to not have m_guid fields in these two classes at allTor Lillqvist2-22/+16
We can just pass the GUID as parameter to the single member function registerClass() that needs it. This perhaps means the same class can be used in more cases, also for objects/classes that aren't going to be registered and don't need any GUID. Change-Id: I28703190c52b14236c6f613dd4acbe359c075f5c Reviewed-on: https://gerrit.libreoffice.org/54622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21weld SchAxisDlgCaolán McNamara7-76/+74
Change-Id: I18441b4fc06b69caf12dc73e5042ad2b609a7cc5 Reviewed-on: https://gerrit.libreoffice.org/54620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21Updated coreOlivier Hallot1-0/+0
Project: help 1d9b92c466b2b920ff46987d1668f4494b9f743a Fix media path for en-US Change-Id: If3a9667fa3dd8c1007132448a23e75d66279a192 Reviewed-on: https://gerrit.libreoffice.org/54640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-21weld SplinePropertiesDialogCaolán McNamara2-67/+49
Change-Id: I1df0f2bce86da698205c5b36217f935e0e971de5 Reviewed-on: https://gerrit.libreoffice.org/54619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-21Add sal/osl/unx/file.cxx for debugging convenienceTor Lillqvist1-0/+26
Change-Id: Ibfc8995c4d35c33fe203b9779b10a182cf5a4294
2018-05-21fix navigate by previous headings does not wrap when cursor positionJim Raykowski1-1/+2
...is before first heading unreported bug fix for a patch I made for tdf#115600 Change-Id: I7ccaad387c5ea344cda71d3cc1f185e590a1f586 Reviewed-on: https://gerrit.libreoffice.org/54059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21gla11y: Enable warnings for more widgets missing a labelSamuel Thibault15-4/+181
Namely GtkSpinButton GtkSpinner GtkProgressBar Change-Id: I00c1d03cde43d23cee5e8b502a03284ac81967a5 Reviewed-on: https://gerrit.libreoffice.org/54131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21Improve placement of tdf#117024/tdf#117283 patchesJim Raykowski1-2/+2
no need to repeatedly call so relocate the patches Change-Id: I87f8be3c1802924e76134d3221a72b04c1a03e54 Reviewed-on: https://gerrit.libreoffice.org/53919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#98544 Other Options remain expanded if any checkbox is checked.manujvashist2-2/+24
Change-Id: I2de79da0f0a6295d4d3c294d7cf6c123fca914bc Reviewed-on: https://gerrit.libreoffice.org/51190 Reviewed-by: Manuj Vashist <manujvashist@gmail.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#117581 impress: fix selection overlay after moving tableDaniel2-1/+12
Change-Id: Ie5afa4fbddf86c6692a7ed68af9ef990c2f9f487 Reviewed-on: https://gerrit.libreoffice.org/54493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#115600 Display messages in FindBar for Footnote navigationJim Raykowski1-0/+29
...and make Footnote navigation wrap Change-Id: Ie4ab6a5d34ba75119f900f46a983a031b84ab51a Reviewed-on: https://gerrit.libreoffice.org/54556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21tdf#97231: potential crash fixedVasily Melenchuk2-2/+2
blob2 pointer can be invalidated during marshalString() call, because it also adds new element in data vector and thus later access to blob2 can cause crash. Change-Id: I2de519c363193f34b249e7250a016397b7420882 Reviewed-on: https://gerrit.libreoffice.org/54613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21Partially revert "Fixup 23c5125148a8110d88385b29570bf0b7d4400458"Khaled Hosny1-2/+1
This reverts most of commit e8d48dd75a1bb31b5bc500bc79fb80384a09bcc6. Hopefully it will make the Win@42 tinderbox happy again. Change-Id: Ie5ef2c16a62e774dcd1f6005df3d86e1973dea2d Reviewed-on: https://gerrit.libreoffice.org/54567 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-21lokdialog: For the tunneled top-level popups, provide the position in twips.Jan Holesovsky2-8/+18
Change-Id: I7b1ca50b06c3bdf0958bb88946873c6ddf717b0e Reviewed-on: https://gerrit.libreoffice.org/51952 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/54628 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-05-21Updated coreOlivier Hallot1-0/+0
Project: help ffe3c4dc36948c44fc17b860c3b5020131cd391c tdf#117593 l10n of collateral file pivot.ods Change-Id: If487dcb74a7e8c61ee152365ba56ad0c6b010ba1 Reviewed-on: https://gerrit.libreoffice.org/54626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-21There is nothing called o2u_anyToVariantTor Lillqvist1-1/+1
Change-Id: I7118843fde87a2d587f0e4ec99d146c379da618e
2018-05-21These fields can be constTor Lillqvist1-2/+2
Change-Id: I103f06b9c7f14ac7eff9911ab5bebc4c98e7d41f Reviewed-on: https://gerrit.libreoffice.org/54614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21Updates by Xcode 9.3Tor Lillqvist1-5/+57
Change-Id: Ia9a87f3f9bdf357079c6d259d736504e0109bf57
2018-05-21tdf#96099 Remove unused typedef from shell/source/tools/lngconvexArkadiy Illarionov3-35/+2
Also remove empty defs.hxx Change-Id: I35f70cc13f0198623d99cfd1e294808ac90f5f02 Reviewed-on: https://gerrit.libreoffice.org/54600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21dont use SwClient/SwModify in unocore: StyleBjoern Michaelsen1-11/+12
Change-Id: I8b2b7378ea21ad1fcfa607aadb0f442838a6cc27 Reviewed-on: https://gerrit.libreoffice.org/54611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-21sc: Avoid looking up system clock twice to get current datetimeTakeshi Abe1-3/+2
Change-Id: I904067260c15263f8169f095809e642d0738f6bb Reviewed-on: https://gerrit.libreoffice.org/53957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21loplugin:unusedfields in scNoel Grandin49-151/+74
Change-Id: I04aee9574b97d6120fe20be97b2c0fb8187fb260 Reviewed-on: https://gerrit.libreoffice.org/54453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-21dont use SwClient/SwModify in unocore: BookmarkBjoern Michaelsen1-32/+30
Change-Id: Iea03642c6b1de1160b98e3b61e831588bb6207b7 Reviewed-on: https://gerrit.libreoffice.org/54609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-21Updated coreOlivier Hallot1-0/+0
Project: help a9cecd08312f8115c657a640a05bb91f21248f0a Add support for localized collateral files Fix src Change-Id: I4997884f087b625c8ac8dbf923363d97f88f7922 Reviewed-on: https://gerrit.libreoffice.org/54599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-05-20dont use SwClient/SwModify in unocore: TextRangeBjoern Michaelsen2-39/+38
Change-Id: Ib87647671776e9c6ef5a9c5a7b75a638452b4555 Reviewed-on: https://gerrit.libreoffice.org/54605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-05-20coverity#1435682 Unchecked return valueCaolán McNamara3-4/+4
and coverity#1435683 Unchecked return value coverity#1435685 Unchecked return value Change-Id: I089d6bdfc80f18c38402b61177d85505fc4c4b36 Reviewed-on: https://gerrit.libreoffice.org/54589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-20coverity#1435678 Resource leakCaolán McNamara1-5/+8
Change-Id: I994508d0d88fa6727c49d568956887ca1d22ce7e Reviewed-on: https://gerrit.libreoffice.org/54588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-12-02 14:28:30 +0000