summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-17tdf#125691: use _exit() instead of exit()...Dennis Francis1-1/+1
for ExitTimer which is used exclusively for the case when OOO_EXIT_POST_STARTUP is set, so that there is no waiting around for ThreadPool's threads to get joined. Setting OOO_EXIT_POST_STARTUP already evades any proper destruction of objects in the heap, so using _exit() instead of exit() here does not make things any worse w.r.t the purpose of this env var. Change-Id: Ib4a253d6e1a3fd8593e4a2115a51cf4c10344b3c Reviewed-on: https://gerrit.libreoffice.org/74016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit d39846bfd16ad9873795149c370a95f42363bfd9) Reviewed-on: https://gerrit.libreoffice.org/74153 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-17tdf#105799 Fix vector use bugJim Raykowski1-1/+1
Change-Id: Ibf2b5314584725a10e11fe83e9fef5c710e421c4 Reviewed-on: https://gerrit.libreoffice.org/73937 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit adcb7bacb452dccde70b20a902f5c1f23f37913f) Reviewed-on: https://gerrit.libreoffice.org/74151 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-3' - tdf#124582 Change Outline to Chapter in Help page Change-Id: Ica5e33aa11da21b1194710a46b60663421222bf8 Reviewed-on: https://gerrit.libreoffice.org/73445 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-16tdf#121486: Correct scale of broken fonts on WindowsKhaled Hosny1-1/+1
Some fonts have negative tmAveCharWidth which makes no sense (fonts can't have negative glyph width, so the average can't be negative) and it would cause our code to apply negative scale to the glyphs of these fonts making them drawn on the flipped horizontally. Fix this by using the absolute value so it is always positive. Change-Id: I731e7aad80dae734847679a1b08c6ac78111e16c Reviewed-on: https://gerrit.libreoffice.org/74109 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit 8fffb56940c6eb81674000cdb718edc79603a6c5) Reviewed-on: https://gerrit.libreoffice.org/74122 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-15tdf#125934 Qt5 set the desktop file nameJan-Marek Glogowski2-0/+7
This is a preliminary fix, so LO on Wayland has an application icon at all. As the result, the start center icon will appear as the application icon on Wayland for all windows. For the proper, per QWindow fix, we need some QtCore and QtWayland changes, to allow setting the appId per QWindow and eventually a Waylnad XDG shell spec update, to officially allow a top level window to change its appId. Change-Id: Icefcfc992836e0c657237984d7d88561b26b06a2 Reviewed-on: https://gerrit.libreoffice.org/74097 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 045de7a51f402062f23a3deeb15a199fd039a6f2) Reviewed-on: https://gerrit.libreoffice.org/74103
2019-06-15Qt5 move and init static m_ActiveDragSourceJan-Marek Glogowski2-2/+1
Change-Id: Iab82151b8d1a8281c9999983b9de5f35dfb0442e Reviewed-on: https://gerrit.libreoffice.org/74013 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 5195c5bcd8be5f3b183659ead272cd86b8774cc1) Reviewed-on: https://gerrit.libreoffice.org/74091
2019-06-15remove some unused includesCaolán McNamara19-71/+18
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-15check-elf-dynamic-objects: Update 'qt5whitelist'Michael Weghorn1-4/+4
This needs 'libgobject-2.0.so.0' and 'libxcb.so.1' as well now, since a6201725d760cbce832d4de029b418bb7334df6a ("Don't link avmediagst with gtk3 and qt5") and 77a3c443d35c7d966217f02ea9189cb1819c7828 ("tdf#125921 Qt5 set WM_CLASS for top level windows"). Change-Id: I453cede879eda8470a45c48f789a0419866fcb79 Reviewed-on: https://gerrit.libreoffice.org/74085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 365df1880a5bfacf25beddefc9206a783e6a4877) Reviewed-on: https://gerrit.libreoffice.org/74089
2019-06-15tdf#125921 Qt5 set WM_CLASS for top level windowsJan-Marek Glogowski2-3/+27
Uses the same naming then the gtk3 backend, i.e. "libreoffice" for the instance name and different class names for the module windows, like "libreoffice-writer". These names are referenced in the desktop files a StartupWMClass and for example used to pin an app to the task bar. Change-Id: Ic9b8890536f6413ab59d2e0da866e2280ab3181a Reviewed-on: https://gerrit.libreoffice.org/74014 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 77a3c443d35c7d966217f02ea9189cb1819c7828) Reviewed-on: https://gerrit.libreoffice.org/74082 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-15KDE5 move screensafer inhibiting code into Qt5Jan-Marek Glogowski6-32/+54
There will presumably be more X11 specific code later to implement some "fix" for tdf#119202. Moving the screensafer inhibitor is rather uncontroversial in comparion, so start with it and use it to carry the matching configure.ac changes. A little "nightmare" are all the clashing X11 / Qt type undefs, but I couldn't find a better solution while the inhibitor continues to include the X11 headers in it's header. Reviewed-on: https://gerrit.libreoffice.org/74015 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b5323c72ff7e5bcde34089e49fe98e589dcc5acb) Change-Id: I55c89c76726d30a890178488484e954207267e89 Reviewed-on: https://gerrit.libreoffice.org/74081 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-15Have all VCL plugin related defines in config_vclplug.hMichael Weghorn5-37/+5
Add the 'ENABLE_GTK3' and 'ENABLE_QT5' there to allow using sth like #include <config_vclplug.h> #if ENABLE_GTK3 // your code here #endif for these as well. Remove 'config_gtk3_kde5.h{,.in}', 'config_kde5.h{,.in}' and 'config_qt5.h{,.in}'; they aren't included anywhere. ('QT5_HAVE_GLIB' is only used in Makefiles, so there's no need to have it in a config header and 'KDE5_HAVE_GLIB' is not used anywhere at all.) Change-Id: Iea7906880f57dde782c50f2520e8d9b358f6bc82 Reviewed-on: https://gerrit.libreoffice.org/73204 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 593e8c671361ba5a1229001ce9d1da92f4aae842) Reviewed-on: https://gerrit.libreoffice.org/74080 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-15tdf#125774 Remove double call SvTreeListBox::Select for non-gtk backendsGülşah Köse1-12/+1
Change-Id: Ic8238d91f1cddb8fe627fafb0587751de308f6ac Reviewed-on: https://gerrit.libreoffice.org/73747 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 8c0e209ddb40f4fd5419dd2190a40d1670c16a3d) Reviewed-on: https://gerrit.libreoffice.org/74084 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-14Resolves: tdf#124251 do not treat internal "URI" as real path URIEike Rathke1-1/+8
Change-Id: I754704b0a979e8449b7ec799cbda58b14ab17098 Reviewed-on: https://gerrit.libreoffice.org/74067 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit ca08ec9292410c28713fd2d92920a7af09883e97) Reviewed-on: https://gerrit.libreoffice.org/74069
2019-06-14weld ExtMgrDialog and UpdateRequiredDialogCaolán McNamara18-783/+721
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f Reviewed-on: https://gerrit.libreoffice.org/74051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'libreoffice-6-3' - Remove superfluous string in impress/Draw contents Keep same Contents structure as other apps Change-Id: I1afc21e3581c3200ce6821ee3594686a1f8a70dc Reviewed-on: https://gerrit.libreoffice.org/73572 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-14Resolves: tdf#125875 allow keyboard traversal into icon controlCaolán McNamara1-1/+1
Change-Id: I001a5ec63aa998917f30b47f37e7db995bf55f0f Reviewed-on: https://gerrit.libreoffice.org/74040 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-14disable 'Quit' when toggling a dialog hierarchy to 'busy'Caolán McNamara1-0/+4
Change-Id: I28773e983014596f6c6b98ab9846bae0a4b3b9ad Reviewed-on: https://gerrit.libreoffice.org/74029 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 213521b339cd39b650564ce8a695da29225012b5) Reviewed-on: https://gerrit.libreoffice.org/74038
2019-06-14broadcast up/down of welded native modal dialogs like vcl onesCaolán McNamara3-19/+29
Change-Id: I61519f0ff92b912501f82e31d6cc3cae244208e6 Reviewed-on: https://gerrit.libreoffice.org/74028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7db198677d7907a1e146f0287ab742ee536f397f) Reviewed-on: https://gerrit.libreoffice.org/74037
2019-06-14tdf#115212 DOCX export: fix ToC with tracked deletionLászló Németh3-0/+9
Removing part of Table of Contents with tracked deletion resulted broken DOCX export, ie. unrecoverable and uneditable document in MSO. Change-Id: If5972b2c9fb967819b7be889e0a3efb3714e670b Reviewed-on: https://gerrit.libreoffice.org/73550 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f9fd82ffa2ccb0e506f44586289ac8b3e1001b38) Reviewed-on: https://gerrit.libreoffice.org/73877 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-14tdf#125881 DOCX import: handle list level after tracked deletionLászló Németh3-4/+23
to avoid bad numbering (for example import "II.1" instead of "I.3"). Commit cbd894925e6b9869baedcd6476484c14d3a3df87 "tdf#125319 DOCX track changes: don't change numbering" fixed losing numbering after tracked deletion (for example, during switching off the Show Changes mode or by DOCX export of the attached test document), but not handling list levels still changed the numbering. Change-Id: I67cd9459bc44e9bb470bfed6834be2e88edfe0d0 Reviewed-on: https://gerrit.libreoffice.org/73978 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit be9379d0a955bd06a8d22c4dc8d99a87ed062ac4) Reviewed-on: https://gerrit.libreoffice.org/74027 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-14disable 'quit' menu entry when modal dialog waiting responseCaolán McNamara6-21/+35
Traditionally when a modal dialog is active, the quit menu entry of all LibreOffice toplevel frames, not just those which are themselves modal, is get disabled. This has come unstuck because its implemented by dialogs emitting MouseNotifyEvent::[END]EXECUTEDIALOG on its parent, and SfxFrameWindow_Impl listening for that event. But if the dialog parent is the toplevel parent of SfxFrameWindow_Impl then it doesn't get seen by the SfxFrameWindow_Impl child. Change-Id: I0c4a5472d16d9169e68f6b0c230d039f1119489a Reviewed-on: https://gerrit.libreoffice.org/74030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14tdf#125904 Bullets and Numbering popupmenu sd modulesandreas kainz2-0/+2
Change-Id: Ibefefded800e7440398005fd02cc0aa2c724ad64 Reviewed-on: https://gerrit.libreoffice.org/74017 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit af37bb23f63b209af1193e20177c3aacbd777543) Reviewed-on: https://gerrit.libreoffice.org/74021 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-06-14tdf#92079 vcl: fix missing image background on dialog from basicMiklos Vajna1-0/+3
Regression from commit e5bb5c52aeaeb60c8592b004efd88c30242e03a1 (add RenderContext to Window::PushPaintHelper, use Erase correctly, 2015-05-18), the problem was the unconditional ApplySettings() call in the direct painting case. It's not clear what was the intent of that addition, since vcl::Window::ApplySettings() is virtual, and the default implementation is empty. But at least the Dialog subclass sets the background there, leading to the loss of the original bitmap background. Fix the problem by explicitly restoring the old background after ApplySettings() at least in the bitmap case. (Wallpaper is copy-on-write, so no problem to make a copy before ApplySettings() unconditionally.) (cherry picked from commit f4e0cc1ff145287f80738f070a8c46a64b2f76d1) Change-Id: I89768a1331f9dc1ea4508336723484d112156338 Reviewed-on: https://gerrit.libreoffice.org/74023 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-14tdf#125563 Adapt adjustment values to binary shape geometryRegina Henschel2-19/+58
All presetTextWarp shapes are mapped to MS binary WordArt geometry in current implementation. But they use different reference systems for coordinates and different unit for angles. So _all_ adjustment values have to be adapted. Error was, that only angles were treated. Correct test file to actually contain the claimed 213.25 degree. Other bugs than adjustment values will be addressed in separate issues. Change-Id: I719b364af23887e50f003cf9878665755b8989ae Reviewed-on: https://gerrit.libreoffice.org/73624 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 95b61f7da41acaabeb0a4bf74749b8fa95ae9966) Reviewed-on: https://gerrit.libreoffice.org/73875 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-14tdf#70234: This change didn't get cherry-pickedXisco Fauli1-2/+0
master commit: 222f6a1c43b7ae7bf8e2f1fbc1dbe6457e611ab7 libreoffice-6-3 commit: 7dc4f5d686f7834702ff133b4e75f29ffa6b5ec3 Change-Id: I403aedf5adc79dd927a4787bf522246467137987 Reviewed-on: https://gerrit.libreoffice.org/73878 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-14Drop '-Wno-shadow' previously set for qt5/kde5Michael Weghorn1-12/+0
The flag has been introduced with commit 9335945c7cb215f387ed1444e28533fac437c6e8 ("KF5 initial VCL plugin") and was presumably just copy-pasted in commit 4d78cf97d7b1629556df68fc461922fda930d9ec. The flag should no longer be necessary now; the only issue showing up after removing the flag was fixed. Change-Id: I65fe4d12bdf7d5888b75f8a5743bab6979a63295 Reviewed-on: https://gerrit.libreoffice.org/73892 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 41a644dae966ecb958d1fe56cb14f3c091b0eceb) Reviewed-on: https://gerrit.libreoffice.org/73996
2019-06-14tdf#125146 Disable the reply command in UIMaxim Monastirsky1-1/+5
... when the focus isn't inside a comment. That's likely a regression of 6e463381b43d888a632e652a873f2b5abe7e5458 ("lok: Allow to reply to comments using postit id"), which enabled the command also in the text context. The current solution is to only enable the command when lok is active, which is where it's used. This is similar to what is done in the code nearby for FN_REDLINE_COMMENT. If that turns out to not be enough (e.g. executing the command useful outside lok), another possible solution might be to add FastCall = TRUE; to FN_REPLY in _textsh.sdi. That will allow executing the command via api even when disabled in ui. Change-Id: Ibf2248a82599801af63a169fc2d34b27d080c048 Reviewed-on: https://gerrit.libreoffice.org/73972 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 4d11c44673e46b134231ea825c1be36c15f8b263) Reviewed-on: https://gerrit.libreoffice.org/73994 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-14tdf#125146 Use correct id for reply command itemMaxim Monastirsky1-3/+3
This was overlooked in commit a10b4fd2bc08651d47bdb19bb8ab9c1f8f3d4851 ("convert annotation menu to .ui"). Change-Id: Ia9e44460394e60f9c2ae767fbb2a07414fa07cf7 Reviewed-on: https://gerrit.libreoffice.org/73971 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 1b39bae5debe3bf952449bd7d2910defcea92b9e) Reviewed-on: https://gerrit.libreoffice.org/73992 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-14Related: tdf#113541 use reference syntax of the document being editedEike Rathke1-11/+12
When creating a formula referencing an external document by travelling (clicking in) to that document, the reference was created using the reference syntax of the referenced document, which may be different if the syntax was changed for only one of the documents after being opened. Use the reference syntax of the document being edited instead so the created reference is correct and can be compiled. Change-Id: I07d0ce9cd911ac8e62576b4cdabdfd2569336fbf Reviewed-on: https://gerrit.libreoffice.org/73983 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2d36e43d3d3ac69f4cacd532308cfc8c81982864) Reviewed-on: https://gerrit.libreoffice.org/73995
2019-06-14Resolves: tdf#113541 handle external reference in Excel syntaxEike Rathke1-3/+6
... not only OOXML. This wasn't only a problem when creating a reference by clicking or travelling to a cell in the external document, but also when editing an external reference in Excel_A1 or Excel_R1C1 reference syntax. Change-Id: Iee3d529ff9834e5013a61c2056238277f33356fe Reviewed-on: https://gerrit.libreoffice.org/73979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 69903b5c5f9b9015c88931c0eb8a47b52ea3de12) Reviewed-on: https://gerrit.libreoffice.org/73987
2019-06-14VCL make horizontal scrolling depend on RTLJan-Marek Glogowski1-4/+3
This is easiest to test in calc. We have two test cases, because the document and the GUI can either have different or equal RTL settings. This fixes the horizontal border scrolling for me on Linux with gen, gtk / gtk3 and qt5 /kde5. It looks a bit strange that this inverts the delta, if the RTL settings are equal, but it seems not all toolkits invert the delta in RTL mode, like Qt does. I also tried to implement this inside ScrollBar::ImplScroll, but the Scrollbar has no idea of the wheel event origin, the only one which must be inverted. Change-Id: I239cf6528de95ad581834ec77a13f582aeff5a91 Reviewed-on: https://gerrit.libreoffice.org/73923 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit dc326926b0adc35b6ebefa7705ee5a3f133f5c88) Reviewed-on: https://gerrit.libreoffice.org/73993
2019-06-14Make .uno:Objects3DToolbox item work in menusMaxim Monastirsky2-13/+15
Similar to the other insert shape group commands. Change-Id: I67524c1d521246b76d953ed9a8aff506535bf550 Reviewed-on: https://gerrit.libreoffice.org/73970 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 7fb6f10c92d21681e9b0fa722ac9329cf3b8e5a2) Reviewed-on: https://gerrit.libreoffice.org/73990
2019-06-13no need for awt::Toolkit::create in UpdateDialogCaolán McNamara1-11/+0
since... commit bb3daa7351f0b07e6f4331c19837081e6c3e30b8 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Thu Oct 7 13:54:14 2010 +0200 dba34b: #i112779# no need to use a UNO control/peer for the throbber - it exists as VCL control now Change-Id: I561642d78d76ab970ee12b6b2b2fbdd0be2850e5 Reviewed-on: https://gerrit.libreoffice.org/73955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13drop intermediate IExtensionListBox classCaolán McNamara3-31/+16
Change-Id: I415645fd61113577deef404cceb02d72d541291d Reviewed-on: https://gerrit.libreoffice.org/73974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13add link to hsqldb->firebird migration dialogCaolán McNamara3-7/+26
1. keep presenting the migration dialog 2. but, default to 'later' 3. add a link to a URL that someone will have to fill in Change-Id: I4c67fe0b65fd78e942ca0760c0f9e128e5ac7be6 Reviewed-on: https://gerrit.libreoffice.org/73966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13unopkg gui crashes on shutdownCaolán McNamara3-6/+7
since... commit e655dc8bbf010e5ef89c32c2ebde56281b323925 Date: Thu May 9 18:24:18 2019 +0100 unipoll: let InitVCL tolerate double init. which changed InitVCL to return true if it was already initialized, tricking toolkit into thinking it was the first one to call InitVCL Change-Id: I33552a5e2caca909f8d63fbf5f23b9fbc4c2dfbd Reviewed-on: https://gerrit.libreoffice.org/73957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13elementary: tdf#125794, fix Show Draw function iconsrizmut69-1046/+49
Change-Id: I3ee4afb5cd7cbbaded59c61adabe77c526ca0bdc Reviewed-on: https://gerrit.libreoffice.org/73959 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 9045f982a75d6a0e3cc92c03a218a0a0cf214891) Reviewed-on: https://gerrit.libreoffice.org/73967 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-13remove some unneeded includesCaolán McNamara8-12/+28
Change-Id: I4722cc32e79cb9bd3708a66be127e097fdb84aed Reviewed-on: https://gerrit.libreoffice.org/73838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit acf941677f92debe62900232231b81c3c03ccf51) Reviewed-on: https://gerrit.libreoffice.org/73939 Tested-by: Jenkins
2019-06-13move IExtensionListBox to where its usedCaolán McNamara5-67/+27
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2 Reviewed-on: https://gerrit.libreoffice.org/73897 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d18f31c4c9d6169f48f34bc53615a5a93a822aa7) Reviewed-on: https://gerrit.libreoffice.org/73938 Tested-by: Jenkins
2019-06-13tdf#125879 Change Wrap Through Icon in Breezeandreas kainz45-52/+279
Change-Id: Ib7a39b69fc55461b68fa416a48399f5e0a16c63a Reviewed-on: https://gerrit.libreoffice.org/73932 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 896e8b0914b6e5dee562ddaa09d4169eb8f325f5) Reviewed-on: https://gerrit.libreoffice.org/73940
2019-06-13tdf#95173 vcl: fix not drawn progressbar widget from UNOMiklos Vajna1-0/+12
Commit e6c2951f1957224aa0e7dc97b33b0450c41f92f7 (delegate RenderContext, invalidate - prgsbar, scrbar, 2015-04-29) switched ProgressBar::SetValue() from direct partial paint to invalidate + paint later, which means setting a progressbar value, then using an external sleep (such as Python's time.sleep()) no longer results in an updated progressbar. Solve the problem by explicitly processing all events with at least TaskPriority::REPAINT priority after the invalidate in ProgressBar::SetValue(), which is similar to what the Wait implementation in the basic runtime does. (cherry picked from commit f7157f04fab298423e2c4f6a7e5f8e361164b15f) Change-Id: I86475fb899f16b72ebefe9d3056c92cedeff4439 Reviewed-on: https://gerrit.libreoffice.org/73952 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-13Intel OpenCL also has broken nan() that ignores the argumentLuboš Luňák1-4/+2
And since whether this works correctly is tested by cl-test.ods, without this OpenCL gets disabled on Intel machines. Change-Id: I8d5c9b1298a08f2e2cb6dfdf183f542315372889 Reviewed-on: https://gerrit.libreoffice.org/73887 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 5b6128699dbe94590629c43cc8f78d95f68330bb) Reviewed-on: https://gerrit.libreoffice.org/73944 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-13Resolves: tdf#125878 correct calculation of H:M:S from timestampEike Rathke1-2/+3
This apparently has been wrong since the beginning in 2009. It's a somewhat odd algorithm anyway, first calculating the time in seconds, minutes and hours, but maybe there's a reason regarding rounding, so not changing that. Change-Id: I855d2c96094b4edb1095d20bcdfebdea6d6d943a Reviewed-on: https://gerrit.libreoffice.org/73893 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 1436d2307d90f5ddbdcb0f129e59544306530342) Reviewed-on: https://gerrit.libreoffice.org/73914
2019-06-13Resolves: tdf#125866 null-derefCaolán McNamara1-0/+3
Change-Id: I0bd597498d10130928de5d7865219fe6f4bc8bcd Reviewed-on: https://gerrit.libreoffice.org/73882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13tdf#95173 vcl: fix partially drawn progressbar widgetMiklos Vajna2-8/+4
Commit e6c2951f1957224aa0e7dc97b33b0450c41f92f7 (delegate RenderContext, invalidate - prgsbar, scrbar, 2015-04-29) switched ProgressBar::SetValue() from direct partial paint to invalidate + full paint. This means that ProgressBar::ImplDrawProgress() has to paint the whole progressbar, not only just the delta between the old and the new value. Remove the not needed mnPreviousPercent member and just paint from 0 to the percent value, like we did before the above commit, that does the needed full paint. (cherry picked from commit 6fd3eb533998c8f63430a43767b2a52aa5e71e3f) Change-Id: Id45ee918248b5fa6647bd766a49b707da1e5846f Reviewed-on: https://gerrit.libreoffice.org/73933 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-13setting cursor needs widget to be realizedCaolán McNamara1-0/+2
Change-Id: I56b1bb83dc221c87ec7aac72b406d67c85f74f43 Reviewed-on: https://gerrit.libreoffice.org/73881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13weld OrganizeDialogCaolán McNamara28-1236/+1152
Change-Id: I976edb0b49c8439d1723be4544b10a5375b8e1d3 Reviewed-on: https://gerrit.libreoffice.org/73900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13menu_item...with_label -> menu_item...with_mnemonicCaolán McNamara1-4/+4
Change-Id: I9d5165a486e8806f41122e72803000ab3e7b3b46 Reviewed-on: https://gerrit.libreoffice.org/73913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13tdf#125791 sc autofilter popup: make sure menu item text uses the label fontMiklos Vajna1-0/+5
It happened that the first and subsequent paints used a different font size, standardize on the label font. E.g. the linux gen backend used either 11 or 12 pt font height, now it always uses 12pt, matching the gtk3 behavior. (No cutoff of text with Windows gdi 125% text size this way, either.) (cherry picked from commit 47dbbe214641b9a28871d0c82f71b2afb9c5943c) Change-Id: Ia3f7b69c5a76e1c15fe04743870e92cffdc351d7 Reviewed-on: https://gerrit.libreoffice.org/73888 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-13Move isIVSSelector, isCJKIVSCharacter to i18nutil/unicode.hxxStephan Bergmann4-34/+31
6a7db071c75609093fc3a9cbc297b8069726a33e "tdf#125497 allow backspace to remove CJK IVS" had moved these functions from sw/source/uibase/wrtsh/delete.cxx to rtl/character.hxx, but the latter appears to be a less than ideal home for them: For one, it is part of the stable URE interface, which makes it harder to maintain (e.g., later versions of Unicode have added CJK Extension C--F code blocks, which the current implementation of isCJKIVSCharacter does not reflect). And for another, besides details of legacy/ubiquitous ASCII, it only deals with the "hard" structure of Unicode (isUnicodeCodePoint, isSurrogate, etc.), not with any specific code blocks or character classifications (which can change over time). Internal i18nutil/unicode.hxx appears to be better suited. Reviewed-on: https://gerrit.libreoffice.org/73873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c1399e497191f295b9c3db95d126ff6a4fa5891d) Conflicts: include/rtl/character.hxx Change-Id: I88b3e4e2488411f988c1a20f79b8a58626d93dce Reviewed-on: https://gerrit.libreoffice.org/73889 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 23:20:27 +0000