AgeCommit message (Collapse)AuthorFilesLines
2016-03-14Bin ifdeffed-out and commented-out codeprivate/tml/fixwintextTor Lillqvist1-254/+0
Change-Id: I38e3aee413587e61d133c4773ea3c3021399435a
2016-03-14Make AddChunkOfGlyphs() bail when CJK text is requestedTim Eves1-0/+16
Change-Id: I4374c809014ac618d5b701752e6bb6b9a196fe8d
2016-03-14Fix what seems to have been off-by-one errors in glyph bounds calculationTor Lillqvist1-2/+2
For some reason the error had a visible impact (as far as I an see, anyway) only for Graphite fonts. The bottommost pixels were cut off. (Also leftmost, but that was not so easily visible.) <tools/gen.hxx> Rectangle type, I love you. Change-Id: I6f7438ec21d2bc1b9bef31cd70e649856f7ec7d5
2016-03-14Rename OpenGLGlyphChunk::mnAscent to mnBaselineOffset to reflect curr useTim Eves1-9/+9
Changed at Tor's stuggestion to better describe to it's use as it's value would be per chunk and based on the maximum ink box bounds of the glyphs in the chunk, rather than having anything to do with the font's real ascent value. Change-Id: Iba15b26ff105731603b56f736cb9bca841f2cdd9
2016-03-14Fix horizontal occsional alingment issues in OpenGL cached glyphsTim Eves1-26/+27
The left edge of the src location rectangle for the first glyph in a cache chunk would set to extraspace and not zero, but all other rectangles in the chunk would be set from the aEnds array. This produced a bug where only certain letters would be mispositioned, proportional to the fonts point size. Change-Id: Id53b4a13d6d1534fc189fcd05ade77f1b7f90578
2016-03-14Fix vertical alignment problems.Tim Eves1-20/+8
Inkboxes are returned with all co-ordinates relative to the glyphs not the fonts ascent. Therefor bounds.Top() is not the vertical overhang but the -ve height of the inkbox above the baseline. This fixes the calulation of the per Chunk ascent. Change-Id: I8f0135cfd84e7081ce154343085225ced25a56e0
2016-03-11Further tweak, getting much closer to correctTor Lillqvist1-1/+1
Change-Id: I57ada8873b24a911b9f24ca268f876193ebe25ed
2016-03-11Fix several miscalulations in positioning glyph to be rendered into that AtlasTim Eves1-10/+4
Change-Id: Ife4c6f9057389c0f96801a99ccc14eb14d75bdfe
2016-03-11Temporary tweak of glyph vertical positioningTor Lillqvist1-1/+2
Change-Id: I2a6afca473e36e240f8d2b3f7da3447be20e2294
2016-03-11Mark the mnAscent in the chunk bitmap debug outputTor Lillqvist1-3/+7
Change-Id: Ibf8077b9ffe34443858990eb699c0ed2129bd39e
2016-03-11Passing a string to a std::ostringstream ctor is trickyTor Lillqvist1-1/+1
Change-Id: If520c98cbd4d3913b644c2137623c2b7e9c5c708
2016-03-11Try calculating a chunks ascent & height from the inkboxesTim Eves1-4/+10
Rather than using the font metrics which might not alway be correct when glyphs inkboxes are tall than the ascent or lower than the descent. Change-Id: I9811acafd9619c2223f3ead934d5a06aed6a7baf
2016-03-11Handle the non-real glyph case for AddChunkOfGlyphsTim Eves1-0/+13
Convert UTF16 to UTF32 and turn codepoints into glyph indices with DWrite. Change-Id: I79c6e534e8e99416fc2c5a75c49e7c0a983954bb
2016-03-11Use better baselineTor Lillqvist1-1/+1
Now glyphs show up at the right position. Not the correct glyphs, but that is a different problem. Change-Id: I21370d18189e761b223a4a4e78d849fb0180b1e3
2016-03-11I assume we want to initialise the rectangle with zero left/right/top/bottomTor Lillqvist1-1/+1
... and not using the default constructor, which sets the right and bottom coordinates to the magic value -32767. That made the 'bound' rectangle end up with rather amusing boundaries, like left=-32766, top=-16, right=-32576, bottom=6. Change-Id: I46b99b757b6a4f8129f3b2ca43b193e99a54c532
2016-03-11Don't treat success as an errorTor Lillqvist1-0/+2
Change-Id: I9e24d6118dad8fa3dceb0a6f80cf76af668064bd
2016-03-11Refactor D2DWriteTextOutRenderer and apply to rendering GlyphAtlasTim Eves1-131/+464
Refactor some previously private methods into public ones and reimplement parts of D2DWriteTextOutRenderer to user them. Also apply them to rendering the OpenGL glyph atlas, in an effort to workaround some bugs in legacy Windows text rendering APIs. Change-Id: I99b2a18537014c81a54575573ea5468223c0829f
2016-03-11Starting to render horizontal text apparently correctly ...Michael Meeks1-55/+83
Change-Id: I6bf049bf56bc971824c9591ccd23e437b9b268b3
2016-03-11framework: Kill BmkMenuMaxim Monastirsky7-316/+34
Change-Id: I182e752f5602d946f27206a1bb744c5d2248bdf8
2016-03-10wrap vcl::window* pointer members in VclPtr, tdf#97344 follow-upEike Rathke2-4/+13
Trying to satisfy loplugin:vclwidgets sc/source/ui/inc/checklistmenu.hxx:199:28: error: OutputDevice subclass 'ScCheckListMenuWindow *' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets] ScCheckListMenuWindow* mpMenuWindow; ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ sc/source/ui/inc/checklistmenu.hxx:200:21: error: OutputDevice subclass 'ControlToPosMap' (aka 'unordered_map<vcl::Window *, size_t>') declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets] ControlToPosMap maControlToPos; ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ sc/source/ui/inc/checklistmenu.hxx:201:31: error: OutputDevice subclass 'std::vector<vcl::Window *>' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets] std::vector<vcl::Window*> maControls; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ Change-Id: I47ba432fd76899681ec0afd852c71b584629eeb9
2016-03-10coverity#1355504 Dereference before null checkCaolán McNamara2-2/+2
Change-Id: I1f19fa2b55054bff7bb7e34d8a07dcf29fd229be
2016-03-10coverity#1355499 Unchecked return valueCaolán McNamara1-2/+4
Change-Id: I0b9329d00bfcebb6e29db6786715b19a7697d087
2016-03-10coverity#1355501 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I84001559ed2bafee16a176eb11ea991397b733bc
2016-03-10coverity#1355507 uninitialized scalar fieldCaolán McNamara8-21/+25
I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10Fix memory leaksStephan Bergmann3-32/+32
Change-Id: If9f7dc4a28d5e005959f0d4a0a2ed317b699f292
2016-03-10No more need for jfw_freeJavaInfoStephan Bergmann7-42/+26
Change-Id: I2426a76936b4099a243ce8c102da867e7868aac3
2016-03-10Turn JavaInfo sal_Sequence* member into rtl::ByteSequenceStephan Bergmann4-20/+10
Change-Id: Iecd476970b0b7a46afe223f71e95b0010048d7b1
2016-03-10Turn JavaInfo rtl_uString* members into OUStringStephan Bergmann5-38/+19
Change-Id: Ieb23b0c36ef56a4793a56cdb450df34e4d9bce1d
2016-03-10Manage JavaInfo instances via new/deleteStephan Bergmann4-21/+11
Change-Id: I10a113718e525b646c51aa8a19f9f2b75a36714a
2016-03-10No need for SAL_CALL hereStephan Bergmann1-19/+19
Change-Id: Iefa38d62235eb54ed5f1ff78b49127bd7bea1f5e
2016-03-10No need to repeat SAL_CALL in definitionsStephan Bergmann1-20/+18
Change-Id: Ief75af9d08d9b7e31d821773db2363fa201f3038
2016-03-10No need for extern "C" hereStephan Bergmann3-16/+12
...and fix resulting loplugin:salbool fallout Change-Id: I5ae1497608d31c20b0d10676450a7673dee1c651
2016-03-10-Werror=shadowStephan Bergmann1-2/+2
Change-Id: I82d2d44fd43ff2a641df74b9e05aea01991d001c
2016-03-10sc lok: Don't interact with the user during .uno:SortAscending or Descending.Jan Holesovsky5-2/+259
Change-Id: Ib3679413ba59e86438dac83abfa9b624e291e5a9
2016-03-10Improve error message when URL cannot be opened externallyStephan Bergmann2-2/+7
It need not be due to no browser, but might also be e.g. a misspelled URL like <htp://...>, see mail thread starting at <> "[libreoffice-users] LO 5.1 Presentation can't find system browser on OSX 10.11." Change-Id: I74ce7abb4e78d72ce9bf92424f66608c6780d2d3
2016-03-10Avoid reserved identifiersStephan Bergmann1-10/+10
Change-Id: Ic2c7cc2a78e8e58c3ca28acd9b6a35ddaceeab60
2016-03-10Avoid reserved identifierStephan Bergmann1-1/+1
Change-Id: I4d0dc49e44b9e9f7504008ea1d10876cd80e76f8
2016-03-10Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I6c60905541de56229bc26e9dc6e589d4099e9266
2016-03-10Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I75158ff7588452f38306b0bed351a6532b9c8d1f
2016-03-10Avoid reserved identifierStephan Bergmann1-5/+5
Change-Id: Ifc4929a5ef43194af33b0aa2816aaf21bc61cd0e
2016-03-10Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I33b9966c0d57b4f9b2028352dfbb68359653f976
2016-03-10Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: Iba05a29b75666a595e58dfe753bba0825d09f61f
2016-03-10Avoid reserved identifiersStephan Bergmann4-14/+14
Change-Id: I0e353e3d892e1d01155dd7e48f8d24597604d3c4
2016-03-10Avoid reserved identifier, remove unnecessary typedefStephan Bergmann2-4/+2
Change-Id: I1172bff37539d1ffb8da7b53c0e5f1913f7b7ec7
2016-03-10Avoid reserved identifierStephan Bergmann2-3/+3
Change-Id: I69e8a6b2d449aff92e7bd8d0d4c39b0d1c71c97c
2016-03-10Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I4e846dcfa3325a1b700da0ec16a380b97a9fb2ed
2016-03-10Avoid reserved identifierStephan Bergmann1-4/+4
Change-Id: I47c9613771bb99c43c12dfe43e2d3c2417403b56
2016-03-10Avoid reserved identifiersStephan Bergmann1-39/+39
Change-Id: I0b9e187be888cb1f89b52dcc60edadf6399802d6
2016-03-10Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: Ie27122c31703b1a09874d21a686cd0bc54ebbccb
2016-03-10Avoid reserved identifiersStephan Bergmann1-8/+8
Change-Id: Id82db66f932c033491c6014eecdff4cc48f5c083